@finos/legend-graph 32.5.1 → 32.5.2

package/src/graph-manager/protocol/pure/v1/engine/analytics/V1_MappingModelCoverageAnalysis.ts

@@ -103,6 +103,13 @@ const V1_deserializeMappedProperty = (
     case V1_MappedPropertyType.ENUM:
       return deserialize(V1_EnumMappedProperty.serialization.schema, json);
     default: {
+      // fix: data product artifacts omit type
+      if (json.entityPath !== undefined) {
+        return deserialize(V1_EntityMappedProperty.serialization.schema, json);
+      }
+      if (json.enumPath !== undefined) {
+        return deserialize(V1_EnumMappedProperty.serialization.schema, json);
+      }
       return deserialize(V1_MappedProperty.serialization.schema, json);
     }
   }

package/src/graph-manager/protocol/pure/v1/transformation/pureGraph/to/helpers/V1_DataProductBuilder.ts

@@ -85,6 +85,7 @@ export const V1_buildDataProductLink = (
 export const V1_buildAccessPoint = (
   ap: V1_AccessPoint,
   context: V1_GraphBuilderContext,
+  owner: AccessPointGroup,
 ): AccessPoint => {
   if (ap instanceof V1_LakehouseAccessPoint) {
     const lakeAccessPoint = new LakehouseAccessPoint(
@@ -95,6 +96,7 @@ export const V1_buildAccessPoint = (
         ap.func.body,
         context,
       ),
+      owner,
     );
     lakeAccessPoint.reproducible = ap.reproducible;
     lakeAccessPoint.classification = ap.classification;
@@ -112,6 +114,7 @@ export const V1_buildAccessPoint = (
         ap.query.body,
         context,
       ),
+      owner,
     );
     functionAccessPoint.description = ap.description;
     functionAccessPoint.title = ap.title;
@@ -120,7 +123,7 @@ export const V1_buildAccessPoint = (
       .filter(isNonNullable);
     return functionAccessPoint;
   } else if (ap instanceof V1_UnknownAccessPoint) {
-    const unknown = new UnknownAccessPoint(ap.id);
+    const unknown = new UnknownAccessPoint(ap.id, owner);
     unknown.description = ap.description;
     unknown.title = ap.title;
     unknown.content = ap.content;
@@ -178,7 +181,7 @@ export const V1_buildAccessPointGroup = (
     group.title = elementGroup.title;
     group.description = elementGroup.description;
     group.accessPoints = elementGroup.accessPoints.map((ep) =>
-      V1_buildAccessPoint(ep, context),
+      V1_buildAccessPoint(ep, context, group),
     );
     group.stereotypes = elementGroup.stereotypes
       .map((stereotype) => context.resolveStereotype(stereotype))
@@ -225,7 +228,7 @@ export const V1_buildAccessPointGroup = (
     group.title = elementGroup.title;
     group.description = elementGroup.description;
     group.accessPoints = elementGroup.accessPoints.map((ep) =>
-      V1_buildAccessPoint(ep, context),
+      V1_buildAccessPoint(ep, context, group),
     );
     group.stereotypes = elementGroup.stereotypes
       .map((stereotype) => context.resolveStereotype(stereotype))

package/src/graph-manager/protocol/pure/v1/transformation/pureProtocol/V1_PureProtocolSerialization.ts

@@ -30,6 +30,7 @@ import {
   UnsupportedOperationError,
   assertErrorThrown,
   usingModelSchema,
+  guaranteeNonNullable,
 } from '@finos/legend-shared';
 import { V1_PureModelContextData } from '../../model/context/V1_PureModelContextData.js';
 import { V1_PureModelContextPointer } from '../../model/context/V1_PureModelContextPointer.js';
@@ -101,29 +102,26 @@ export const V1_entitiesToPureModelContextData = async (
         TEMPORARY__entityPathIndex?.set(element.path, entity.path);
         return element;
       };
-      graph.elements = await Promise.all<V1_PackageableElement>(
-        entities.map(
-          (e) =>
-            new Promise((resolve, reject) =>
-              setTimeout(() => {
-                try {
-                  resolve(
-                    // NOTE: here we skip the check for classifier path, so there could be cases
-                    // where the classifier path is different from the actua element protocol path
-                    // we might need to do validation here. This can happen when the classifier
-                    // path is changed in the backend. If we are to check for this, we might consider
-                    // not throwing error but quitely print out warnings about elements that would not
-                    // be built.
-                    entityToElement(e),
-                  );
-                } catch (error) {
-                  assertErrorThrown(error);
-                  reject(error);
-                }
-              }, 0),
-            ),
-        ),
-      );
+      // Process entities in batches to avoid per-element setTimeout overhead.
+      // Each batch yields to the event loop to keep the UI responsive.
+      const DESERIALIZATION_BATCH_SIZE = 100;
+      const results: V1_PackageableElement[] = [];
+      for (let i = 0; i < entities.length; i += DESERIALIZATION_BATCH_SIZE) {
+        if (i > 0) {
+          await new Promise<void>((resolve) => setTimeout(resolve, 0));
+        }
+        const end = Math.min(i + DESERIALIZATION_BATCH_SIZE, entities.length);
+        for (let j = i; j < end; j++) {
+          // NOTE: here we skip the check for classifier path, so there could be cases
+          // where the classifier path is different from the actua element protocol path
+          // we might need to do validation here. This can happen when the classifier
+          // path is changed in the backend. If we are to check for this, we might consider
+          // not throwing error but quitely print out warnings about elements that would not
+          // be built.
+          results.push(entityToElement(guaranteeNonNullable(entities[j])));
+        }
+      }
+      graph.elements = results;
     }
   } catch (error) {
     assertErrorThrown(error);