@finos/legend-graph 3.0.0 → 4.0.0

package/src/graphManager/action/changeDetection/ValueSpecificationObserver.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { action, computed, makeObservable, observable } from 'mobx';
+import { computed, makeObservable, observable } from 'mobx';
 import type { AlloySerializationConfigInstanceValue } from '../../../models/metamodels/pure/valueSpecification/AlloySerializationConfig';
 import {
   type RootGraphFetchTreeInstanceValue,
@@ -95,9 +95,6 @@ export const observe_PrimitiveInstanceValue = skipObserved(
     makeObservable<PrimitiveInstanceValue>(metamodel, {
       genericType: observable,
       values: observable,
-      deleteValue: action,
-      addValue: action,
-      changeValue: action,
     });
 
     observe_GenericTypeReference(metamodel.genericType);
@@ -113,9 +110,6 @@ export const observe_EnumValueInstanceValue = skipObserved(
     makeObservable<EnumValueInstanceValue>(metamodel, {
       genericType: observable,
       values: observable,
-      deleteValue: action,
-      addValue: action,
-      changeValue: action,
     });
 
     metamodel.values.forEach(observe_EnumValueReference);
@@ -296,7 +290,6 @@ function _observe_CollectionInstanceValue(
   makeObservable<CollectionInstanceValue>(metamodel, {
     genericType: observable,
     values: observable,
-    changeValues: action,
   });
 
   metamodel.values.forEach((value) =>
@@ -331,8 +324,6 @@ function observe_Abstract_GraphFetchTree(
 ): GraphFetchTree {
   makeObservable(metamodel, {
     subTrees: observable,
-    addSubTree: action,
-    removeSubTree: action,
     isEmpty: computed,
   });
 
@@ -359,7 +350,6 @@ function _observe_PropertyGraphFetchTree(
     alias: observable,
     parameters: observable,
     subType: observable,
-    withSubType: action,
   });
 
   observe_PropertyReference(metamodel.property);

package/src/models/metamodels/pure/packageableElements/PackageableElement.ts

@@ -66,9 +66,7 @@ export interface PackageableElementVisitor<T> {
   visit_GenerationSpecification(element: GenerationSpecification): T;
 }
 
-export abstract class /*toCHECK*/ PackageableElement
-  implements Hashable, Stubable
-{
+export abstract class PackageableElement implements Hashable, Stubable {
   readonly uuid = uuid();
 
   protected _isDeleted = false;

package/src/models/metamodels/pure/valueSpecification/GraphFetchTree.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { addUniqueEntry, deleteEntry } from '@finos/legend-shared';
 import type { Class } from '../packageableElements/domain/Class';
 import type { PropertyReference } from '../packageableElements/domain/PropertyReference';
 import {
@@ -28,21 +27,15 @@ import type {
 } from './ValueSpecification';
 import { InstanceValue } from './InstanceValue';
 
-export abstract class /*toCHECK*/ GraphFetchTree {
+export abstract class GraphFetchTree {
   subTrees: GraphFetchTree[] = [];
 
   get isEmpty(): boolean {
     return !this.subTrees.length;
   }
-  addSubTree(val: GraphFetchTree): void {
-    addUniqueEntry(this.subTrees, val);
-  }
-  removeSubTree(val: GraphFetchTree): void {
-    deleteEntry(this.subTrees, val);
-  }
 }
 
-export class /*toCHECK*/ RootGraphFetchTree extends GraphFetchTree {
+export class RootGraphFetchTree extends GraphFetchTree {
   class: PackageableElementReference<Class>;
 
   constructor(_class: PackageableElementReference<Class>) {
@@ -51,7 +44,7 @@ export class /*toCHECK*/ RootGraphFetchTree extends GraphFetchTree {
   }
 }
 
-export class /*toCHECK*/ PropertyGraphFetchTree extends GraphFetchTree {
+export class PropertyGraphFetchTree extends GraphFetchTree {
   property: PropertyReference;
   alias?: string | undefined;
   parameters: ValueSpecification[] = []; //TODO
@@ -67,20 +60,13 @@ export class /*toCHECK*/ PropertyGraphFetchTree extends GraphFetchTree {
       val ??
       OptionalPackageableElementExplicitReference.create<Class>(undefined);
   }
-
-  withSubType(
-    val: OptionalPackageableElementReference<Class>,
-  ): PropertyGraphFetchTree {
-    this.subType = val;
-    return this;
-  }
 }
 
-export abstract class /*toCHECK*/ GraphFetchTreeInstanceValue extends InstanceValue {
+export abstract class GraphFetchTreeInstanceValue extends InstanceValue {
   override values: GraphFetchTree[] = [];
 }
 
-export class /*toCHECK*/ PropertyGraphFetchTreeInstanceValue extends GraphFetchTreeInstanceValue {
+export class PropertyGraphFetchTreeInstanceValue extends GraphFetchTreeInstanceValue {
   override values: PropertyGraphFetchTree[] = [];
 
   override accept_ValueSpecificationVisitor<T>(
@@ -90,7 +76,7 @@ export class /*toCHECK*/ PropertyGraphFetchTreeInstanceValue extends GraphFetchT
   }
 }
 
-export class /*toCHECK*/ RootGraphFetchTreeInstanceValue extends GraphFetchTreeInstanceValue {
+export class RootGraphFetchTreeInstanceValue extends GraphFetchTreeInstanceValue {
   override values: RootGraphFetchTree[] = [];
 
   override accept_ValueSpecificationVisitor<T>(

package/src/models/metamodels/pure/valueSpecification/InstanceValue.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { deleteEntry, addUniqueEntry, type Pair } from '@finos/legend-shared';
+import type { Pair } from '@finos/legend-shared';
 import {
   type ValueSpecificationVisitor,
   ValueSpecification,
@@ -32,25 +32,9 @@ import type { Mapping } from '../packageableElements/mapping/Mapping';
  * Also, right now, we haven't done the full build/transform flow for value specification
  * we use the subtypes to make it easier to transform metamodel back into protocol.
  */
-export class /*toCHECK*/ InstanceValue extends ValueSpecification {
+export class InstanceValue extends ValueSpecification {
   values: unknown[] = [];
 
-  deleteValue(val: unknown): void {
-    deleteEntry(this.values, val);
-  }
-
-  addValue(val: unknown): void {
-    addUniqueEntry(this.values, val);
-  }
-
-  changeValue(val: unknown, idx: number): void {
-    this.values[idx] = val;
-  }
-
-  changeValues(val: unknown[]): void {
-    this.values = val;
-  }
-
   accept_ValueSpecificationVisitor<T>(
     visitor: ValueSpecificationVisitor<T>,
   ): T {
@@ -58,7 +42,7 @@ export class /*toCHECK*/ InstanceValue extends ValueSpecification {
   }
 }
 
-export class /*toCHECK*/ PrimitiveInstanceValue extends InstanceValue {
+export class PrimitiveInstanceValue extends InstanceValue {
   override genericType: GenericTypeReference;
 
   constructor(genericType: GenericTypeReference, multiplicity: Multiplicity) {
@@ -73,7 +57,7 @@ export class /*toCHECK*/ PrimitiveInstanceValue extends InstanceValue {
   }
 }
 
-export class /*toCHECK*/ EnumValueInstanceValue extends InstanceValue {
+export class EnumValueInstanceValue extends InstanceValue {
   override values: EnumValueReference[] = [];
 
   constructor(genericType: GenericTypeReference, multiplicity: Multiplicity) {
@@ -87,7 +71,7 @@ export class /*toCHECK*/ EnumValueInstanceValue extends InstanceValue {
   }
 }
 
-export class /*toCHECK*/ RuntimeInstanceValue extends InstanceValue {
+export class RuntimeInstanceValue extends InstanceValue {
   override values: EngineRuntime[] = [];
 
   override accept_ValueSpecificationVisitor<T>(
@@ -97,7 +81,7 @@ export class /*toCHECK*/ RuntimeInstanceValue extends InstanceValue {
   }
 }
 
-export class /*toCHECK*/ PairInstanceValue extends InstanceValue {
+export class PairInstanceValue extends InstanceValue {
   override values: Pair<unknown, unknown>[] = [];
 
   override accept_ValueSpecificationVisitor<T>(
@@ -107,7 +91,7 @@ export class /*toCHECK*/ PairInstanceValue extends InstanceValue {
   }
 }
 
-export class /*toCHECK*/ MappingInstanceValue extends InstanceValue {
+export class MappingInstanceValue extends InstanceValue {
   override values: PackageableElementReference<Mapping>[] = [];
 
   override accept_ValueSpecificationVisitor<T>(
@@ -117,7 +101,7 @@ export class /*toCHECK*/ MappingInstanceValue extends InstanceValue {
   }
 }
 
-export class /*toCHECK*/ PureListInstanceValue extends InstanceValue {
+export class PureListInstanceValue extends InstanceValue {
   override values: ValueSpecification[] = [];
 
   override accept_ValueSpecificationVisitor<T>(
@@ -127,7 +111,7 @@ export class /*toCHECK*/ PureListInstanceValue extends InstanceValue {
   }
 }
 
-export class /*toCHECK*/ CollectionInstanceValue extends InstanceValue {
+export class CollectionInstanceValue extends InstanceValue {
   override values: ValueSpecification[] = [];
 
   override accept_ValueSpecificationVisitor<T>(

package/src/models/protocols/pure/v1/V1_PureGraphManager.ts

@@ -552,7 +552,7 @@ export class V1_PureGraphManager extends AbstractPureGraphManager {
       systemModel,
       this.pluginManager.getPureGraphPlugins(),
     );
-    graph.setDependencyManager(dependencyManager);
+    graph.dependencyManager = dependencyManager;
 
     try {
       dependencyManager.initialize(dependencyEntitiesMap);