@finos/legend-graph 2.1.2 → 4.0.0

package/src/models/metamodels/pure/packageableElements/mapping/EnumerationMapping.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
 import { hashArray, type Hashable } from '@finos/legend-shared';
 import { fromElementPathToMappingElementId } from '../../../../../MetaModelUtils';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
@@ -47,47 +46,12 @@ export class EnumerationMapping implements Hashable, Stubable {
     parent: Mapping,
     sourceType: OptionalPackageableElementReference<Type>,
   ) {
-    makeObservable(this, {
-      sourceType: observable,
-      enumValueMappings: observable,
-      setId: action,
-      setSourceType: action,
-      setEnumValueMappings: action,
-      updateSourceType: action,
-      label: computed,
-      isStub: computed,
-      hashCode: computed,
-    });
-
     this.id = id;
     this.enumeration = enumeration;
     this.parent = parent;
     this.sourceType = sourceType;
   }
 
-  setId(value: string): void {
-    this.id.setValue(value);
-  }
-  setSourceType(value: Type | undefined): void {
-    this.sourceType.setValue(value);
-  }
-  setEnumValueMappings(value: EnumValueMapping[]): void {
-    this.enumValueMappings = value;
-  }
-
-  updateSourceType(type: Type | undefined): void {
-    if (this.sourceType.value !== type) {
-      this.setSourceType(type);
-      this.enumValueMappings = this.enumValueMappings.map(
-        (enumValueMapping) => {
-          enumValueMapping.sourceValues = [];
-          enumValueMapping.addSourceValue();
-          return enumValueMapping;
-        },
-      );
-    }
-  }
-
   get label(): MappingElementLabel {
     return {
       value: `${

package/src/models/metamodels/pure/packageableElements/mapping/ExpectedOutputMappingTestAssert.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, computed, makeObservable, action } from 'mobx';
 import {
   type Hashable,
   hashArray,
@@ -37,22 +36,10 @@ export class ExpectedOutputMappingTestAssert
 
   constructor(expectedOutput: string) {
     super();
-
-    makeObservable(this, {
-      expectedOutput: observable,
-      setExpectedOutput: action,
-      validationResult: computed,
-      hashCode: computed,
-    });
-
     /* @MARKER: Workaround for https://github.com/finos/legend-studio/issues/68 */
     this.expectedOutput = tryToMinifyLosslessJSONString(expectedOutput);
   }
 
-  setExpectedOutput(val: string): void {
-    this.expectedOutput = val;
-  }
-
   get validationResult(): ValidationIssue | undefined {
     return !isValidJSONString(fromGrammarString(this.expectedOutput))
       ? createValidationError([

package/src/models/metamodels/pure/packageableElements/mapping/InferableMappingElementId.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { computed, makeObservable } from 'mobx';
 import { fromElementPathToMappingElementId } from '../../../../../MetaModelUtils';
 import { InferableValue } from '../../InferableValue';
 
@@ -26,11 +25,6 @@ export abstract class InferableMappingElementIdValue extends InferableValue<
 
   constructor(value: string, defaultValue: string) {
     super(value);
-
-    makeObservable(this, {
-      isDefault: computed,
-    });
-
     this.defaultValue = defaultValue;
   }
 
@@ -40,14 +34,6 @@ export abstract class InferableMappingElementIdValue extends InferableValue<
 }
 
 export class InferableMappingElementIdExplicitValue extends InferableMappingElementIdValue {
-  constructor(value: string, defaultValue: string) {
-    super(value, defaultValue);
-
-    makeObservable(this, {
-      valueForSerialization: computed,
-    });
-  }
-
   static create(
     value: string,
     targetPath: string,
@@ -73,11 +59,6 @@ export class InferableMappingElementIdImplicitValue extends InferableMappingElem
 
   constructor(value: string, defaultValue: string, input: string | undefined) {
     super(value, defaultValue);
-
-    makeObservable(this, {
-      valueForSerialization: computed,
-    });
-
     this.input = input;
   }
 

package/src/models/metamodels/pure/packageableElements/mapping/InferableMappingElementRoot.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { computed, makeObservable } from 'mobx';
 import { InferableValue } from '../../InferableValue';
 
 export abstract class InferableMappingElementRoot extends InferableValue<
@@ -25,10 +24,6 @@ export abstract class InferableMappingElementRoot extends InferableValue<
 export class InferableMappingElementRootExplicitValue extends InferableMappingElementRoot {
   private constructor(value: boolean) {
     super(value);
-
-    makeObservable(this, {
-      valueForSerialization: computed,
-    });
   }
 
   static create(value: boolean): InferableMappingElementRootExplicitValue {
@@ -45,11 +40,6 @@ export class InferableMappingElementRootImplicitValue extends InferableMappingEl
 
   private constructor(value: boolean, input: boolean) {
     super(value);
-
-    makeObservable(this, {
-      valueForSerialization: computed,
-    });
-
     this.input = input;
   }
 

package/src/models/metamodels/pure/packageableElements/mapping/InstanceSetImplementation.ts

@@ -14,17 +14,11 @@
  * limitations under the License.
  */
 
-import { observable, makeObservable } from 'mobx';
 import type { Hashable } from '@finos/legend-shared';
 import type { MappingClass } from './MappingClass';
 import { SetImplementation } from './SetImplementation';
 import type { PropertyMappingsImplementation } from './PropertyMappingsImplementation';
 import type { PropertyMapping } from './PropertyMapping';
-import type { InferableMappingElementIdValue } from './InferableMappingElementId';
-import type { Mapping } from './Mapping';
-import type { PackageableElementReference } from '../PackageableElementReference';
-import type { Class } from '../domain/Class';
-import type { InferableMappingElementRoot } from './InferableMappingElementRoot';
 
 export abstract class InstanceSetImplementation
   extends SetImplementation
@@ -34,20 +28,6 @@ export abstract class InstanceSetImplementation
   propertyMappings: PropertyMapping[] = [];
   // aggregateSpecification: AggregateSpecification[0..1];
 
-  constructor(
-    id: InferableMappingElementIdValue,
-    parent: Mapping,
-    _class: PackageableElementReference<Class>,
-    root: InferableMappingElementRoot,
-  ) {
-    super(id, parent, _class, root);
-
-    makeObservable(this, {
-      mappingClass: observable,
-      propertyMappings: observable,
-    });
-  }
-
   abstract getEmbeddedSetImplmentations(): InstanceSetImplementation[];
   abstract findPropertyMapping(
     propertyName: string,

package/src/models/metamodels/pure/packageableElements/mapping/LocalMappingPropertyInfo.ts

@@ -21,6 +21,7 @@ import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 
 export class LocalMappingPropertyInfo implements Hashable {
   localMappingProperty!: boolean;
+  // TODO: refactor this to use `PackageableElementReference`
   localMappingPropertyType!: Type;
   localMappingPropertyMultiplicity!: Multiplicity;
 

package/src/models/metamodels/pure/packageableElements/mapping/Mapping.ts

@@ -14,14 +14,8 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable, override } from 'mobx';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
-import {
-  hashArray,
-  deleteEntry,
-  addUniqueEntry,
-  type Hashable,
-} from '@finos/legend-shared';
+import { hashArray, type Hashable } from '@finos/legend-shared';
 import type { EnumerationMapping } from './EnumerationMapping';
 import type { SetImplementation } from './SetImplementation';
 import type { AssociationImplementation } from './AssociationImplementation';
@@ -40,63 +34,6 @@ export class Mapping extends PackageableElement implements Hashable, Stubable {
   associationMappings: AssociationImplementation[] = [];
   tests: MappingTest[] = [];
 
-  constructor(name: string) {
-    super(name);
-
-    makeObservable<Mapping, '_elementHashCode'>(this, {
-      includes: observable,
-      classMappings: observable,
-      enumerationMappings: observable,
-      associationMappings: observable,
-      tests: observable,
-      addClassMapping: action,
-      deleteClassMapping: action,
-      addEnumerationMapping: action,
-      deleteEnumerationMapping: action,
-      addAssociationMapping: action,
-      deleteAssociationMapping: action,
-      deleteTest: action,
-      addTest: action,
-      allOwnClassMappings: computed,
-      allOwnEnumerationMappings: computed,
-      allIncludedMappings: computed,
-      isStub: computed,
-      _elementHashCode: override,
-    });
-  }
-
-  addClassMapping(val: SetImplementation): void {
-    addUniqueEntry(this.classMappings, val);
-  }
-
-  deleteClassMapping(val: SetImplementation): void {
-    deleteEntry(this.classMappings, val);
-  }
-
-  addEnumerationMapping(val: EnumerationMapping): void {
-    addUniqueEntry(this.enumerationMappings, val);
-  }
-
-  deleteEnumerationMapping(val: EnumerationMapping): void {
-    deleteEntry(this.enumerationMappings, val);
-  }
-
-  addAssociationMapping(val: AssociationImplementation): void {
-    addUniqueEntry(this.associationMappings, val);
-  }
-
-  deleteAssociationMapping(val: AssociationImplementation): void {
-    deleteEntry(this.associationMappings, val);
-  }
-
-  deleteTest(val: MappingTest): void {
-    deleteEntry(this.tests, val);
-  }
-
-  addTest(val: MappingTest): void {
-    addUniqueEntry(this.tests, val);
-  }
-
   get allOwnClassMappings(): SetImplementation[] {
     return this.classMappings;
   }
@@ -140,7 +77,6 @@ export class Mapping extends PackageableElement implements Hashable, Stubable {
     return hashArray([
       CORE_HASH_STRUCTURE.MAPPING,
       this.path,
-      // TODO mapping include
       hashArray(this.classMappings),
       hashArray(this.enumerationMappings),
       hashArray(this.associationMappings),

package/src/models/metamodels/pure/packageableElements/mapping/MappingClass.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, makeObservable } from 'mobx';
 import type { SetImplementation } from './SetImplementation';
 import { Class } from '../domain/Class';
 import type { Property } from '../domain/Property';
@@ -23,12 +22,4 @@ export class MappingClass extends Class {
   setImplementation?: SetImplementation | undefined;
   class?: Class | undefined;
   localProperties: Property[] = [];
-
-  constructor(name: string) {
-    super(name);
-    makeObservable(this, {
-      setImplementation: observable,
-      class: observable,
-    });
-  }
 }

package/src/models/metamodels/pure/packageableElements/mapping/MappingInclude.ts

@@ -14,12 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, makeObservable } from 'mobx';
-import {
-  hashArray,
-  getNullableFirstElement,
-  addUniqueEntry,
-} from '@finos/legend-shared';
+import { hashArray, getNullableFirstElement } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import type { PackageableElementReference } from '../PackageableElementReference';
 import type { Mapping } from './Mapping';
@@ -31,20 +26,10 @@ export class MappingInclude {
   storeSubstitutions: SubstituteStore[] = [];
 
   constructor(owner: Mapping, included: PackageableElementReference<Mapping>) {
-    makeObservable(this, {
-      included: observable,
-      storeSubstitutions: observable,
-      addStoreSubstitution: action,
-    });
-
     this.owner = owner;
     this.included = included;
   }
 
-  addStoreSubstitution(value: SubstituteStore): void {
-    addUniqueEntry(this.storeSubstitutions, value);
-  }
-
   get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.MAPPING_INCLUDE,

package/src/models/metamodels/pure/packageableElements/mapping/MappingTest.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
 import { uuid, hashArray, type Hashable } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import type { MappingTestAssert } from './MappingTestAssert';
@@ -26,7 +25,8 @@ import {
 } from '../../../../../helpers/ValidationHelper';
 
 export class MappingTest implements Hashable {
-  uuid = uuid();
+  readonly uuid = uuid();
+
   name: string;
   query: RawLambda; // @MARKER GENERATED MODEL DISCREPANCY --- Studio does not process lambda
   inputData: InputData[] = [];
@@ -38,41 +38,12 @@ export class MappingTest implements Hashable {
     inputData: InputData[],
     assert: MappingTestAssert,
   ) {
-    makeObservable(this, {
-      name: observable,
-      query: observable,
-      inputData: observable,
-      assert: observable,
-      setName: action,
-      setInputData: action,
-      setQuery: action,
-      setAssert: action,
-      validationResult: computed,
-      hashCode: computed,
-    });
-
     this.name = name;
     this.query = query;
     this.inputData = inputData;
     this.assert = assert;
   }
 
-  setName(value: string): void {
-    this.name = value;
-  }
-
-  setInputData(value: InputData[]): void {
-    this.inputData = value;
-  }
-
-  setQuery(value: RawLambda): void {
-    this.query = value;
-  }
-
-  setAssert(value: MappingTestAssert): void {
-    this.assert = value;
-  }
-
   get validationResult(): ValidationIssue[] | undefined {
     let problems: ValidationIssue[] = [];
     // query

package/src/models/metamodels/pure/packageableElements/mapping/MergeOperationSetImplementation.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, action, makeObservable } from 'mobx';
 import { type Hashable, hashArray } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import type { PackageableElementReference } from '../PackageableElementReference';
@@ -46,19 +45,9 @@ export class MergeOperationSetImplementation
     validationFunction: RawLambda,
   ) {
     super(id, parent, pureClass, root, operation);
-
-    makeObservable(this, {
-      validationFunction: observable,
-      setValidationFunction: action,
-    });
-
     this.validationFunction = validationFunction;
   }
 
-  setValidationFunction(value: RawLambda): void {
-    this.validationFunction = value;
-  }
-
   override get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.OPERATION_SET_IMPLEMENTATION,

package/src/models/metamodels/pure/packageableElements/mapping/OperationSetImplementation.ts

@@ -14,14 +14,10 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
 import {
   type Hashable,
   hashArray,
   guaranteeNonNullable,
-  addUniqueEntry,
-  deleteEntry,
-  changeEntry,
 } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import type { PackageableElementReference } from '../PackageableElementReference';
@@ -64,41 +60,9 @@ export class OperationSetImplementation
     operation: OperationType,
   ) {
     super(id, parent, pureClass, root);
-
-    makeObservable(this, {
-      parameters: observable,
-      operation: observable,
-      setOperation: action,
-      setParameters: action,
-      addParameter: action,
-      changeParameter: action,
-      deleteParameter: action,
-      isStub: computed,
-      hashCode: computed,
-    });
-
     this.operation = operation;
   }
 
-  setOperation(value: OperationType): void {
-    this.operation = value;
-  }
-  setParameters(value: SetImplementationContainer[]): void {
-    this.parameters = value;
-  }
-  addParameter(value: SetImplementationContainer): void {
-    addUniqueEntry(this.parameters, value);
-  }
-  changeParameter(
-    oldValue: SetImplementationContainer,
-    newValue: SetImplementationContainer,
-  ): void {
-    changeEntry(this.parameters, oldValue, newValue);
-  }
-  deleteParameter(value: SetImplementationContainer): void {
-    deleteEntry(this.parameters, value);
-  }
-
   /**
    * Get all leaf impls of an operation Set Implementation. Accounts for loops and duplication (which should be caught by compiler).
    */

package/src/models/metamodels/pure/packageableElements/mapping/PropertyMapping.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, makeObservable } from 'mobx';
 import {
   UnsupportedOperationError,
   hashArray,
@@ -62,7 +61,7 @@ export interface PropertyMappingVisitor<T> {
 }
 
 export abstract class PropertyMapping implements Hashable, Stubable {
-  isEmbedded = false;
+  readonly isEmbedded: boolean = false;
   property: PropertyReference;
   owner: PropertyMappingsImplementation; // the immediate parent instance set implementation that holds the property mappings
   // NOTE: in case the holder of this property mapping is an embedded property mapping, that embedded property mapping is considered the source
@@ -82,11 +81,6 @@ export abstract class PropertyMapping implements Hashable, Stubable {
     source: SetImplementation,
     target?: SetImplementation,
   ) {
-    makeObservable(this, {
-      sourceSetImplementation: observable,
-      targetSetImplementation: observable,
-    });
-
     this.owner = owner;
     this.sourceSetImplementation = source;
     this.targetSetImplementation = target;

package/src/models/metamodels/pure/packageableElements/mapping/SetImplementation.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
 import { hashArray, type Hashable } from '@finos/legend-shared';
 import { fromElementPathToMappingElementId } from '../../../../../MetaModelUtils';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
@@ -79,7 +78,7 @@ export interface SetImplementationVisitor<T> {
 export abstract class SetImplementation
   implements PropertyOwnerImplementation, Hashable, Stubable
 {
-  isEmbedded = false;
+  readonly isEmbedded: boolean = false;
   id: InferableMappingElementIdValue;
   class: PackageableElementReference<Class>;
   root: InferableMappingElementRoot;
@@ -91,21 +90,11 @@ export abstract class SetImplementation
     _class: PackageableElementReference<Class>,
     root: InferableMappingElementRoot,
   ) {
-    makeObservable(this, {
-      root: observable,
-      parent: observable,
-      setRoot: action,
-      label: computed,
-    });
-
     this.id = id;
     this.parent = parent;
     this.class = _class;
     this.root = root;
   }
-  setRoot(value: boolean): void {
-    this.root.setValue(value);
-  }
 
   get label(): MappingElementLabel {
     return {
@@ -156,7 +145,7 @@ export enum SET_IMPLEMENTATION_TYPE {
   AGGREGATION_AWARE = 'aggregationAware',
 }
 
-/* @MARKER: RELAXED GRAPH CHECK - See https://github.com/finos/legend-studio/issues/880 */
+/* @MARKER: RELAXED GRAPH CHECK - See https://github.com/finos/legend-studio/issues/941 */
 /**
  * When set implementation cannot be resolved by ID,
  * we try to avoid failing graph building for now
@@ -165,6 +154,7 @@ export enum SET_IMPLEMENTATION_TYPE {
  * NOTE: this is just a temporary solutions until we make this a hard-fail post migration.
  *
  * See https://github.com/finos/legend-studio/issues/880
+ * See https://github.com/finos/legend-studio/issues/941
  */
 export class TEMPORARY__UnresolvedSetImplementation extends SetImplementation {
   constructor(id: string, parent: Mapping) {

package/src/models/metamodels/pure/packageableElements/mapping/SetImplementationContainer.ts

@@ -14,29 +14,19 @@
  * limitations under the License.
  */
 
-import { computed, action, makeObservable } from 'mobx';
 import { uuid } from '@finos/legend-shared';
 import type { SetImplementationReference } from './SetImplementationReference';
 import type { Stubable } from '../../../../../helpers/Stubable';
-import type { SetImplementation } from './SetImplementation';
 
 export class SetImplementationContainer implements Stubable {
-  uuid = uuid();
+  readonly uuid = uuid();
+
   setImplementation: SetImplementationReference;
 
   constructor(setImplementation: SetImplementationReference) {
-    makeObservable(this, {
-      setSetImplementation: action,
-      isStub: computed,
-    });
-
     this.setImplementation = setImplementation;
   }
 
-  setSetImplementation(value: SetImplementation): void {
-    this.setImplementation.setValue(value);
-  }
-
   get isStub(): boolean {
     return !this.setImplementation.value.id;
   }

package/src/models/metamodels/pure/packageableElements/mapping/SetImplementationReference.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, action, makeObservable } from 'mobx';
 import {
   PackageableElementExplicitReference,
   type PackageableElementReference,
@@ -33,20 +32,9 @@ export abstract class SetImplementationReference extends ReferenceWithOwner {
     value: SetImplementation,
   ) {
     super(ownerReference);
-
-    makeObservable(this, {
-      value: observable,
-      setValue: action,
-    });
-
     this.ownerReference = ownerReference;
     this.value = value;
   }
-
-  setValue(value: SetImplementation): void {
-    this.value = value;
-    this.ownerReference.value = value.parent;
-  }
 }
 
 export class SetImplementationExplicitReference extends SetImplementationReference {

package/src/models/metamodels/pure/packageableElements/mapping/SubstituteStore.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, makeObservable } from 'mobx';
 import type { Store } from '../store/Store';
 import type { PackageableElementReference } from '../PackageableElementReference';
 import type { MappingInclude } from './MappingInclude';
@@ -29,11 +28,6 @@ export class SubstituteStore {
     original: PackageableElementReference<Store>,
     substitue: PackageableElementReference<Store>,
   ) {
-    makeObservable(this, {
-      original: observable,
-      substitute: observable,
-    });
-
     this.owner = owner;
     this.original = original;
     this.substitute = substitue;