@finos/legend-graph 2.1.2 → 2.1.3

package/src/models/metamodels/pure/packageableElements/store/relational/connection/DatasourceSpecification.ts

@@ -16,7 +16,7 @@
 
 import { type Hashable, hashArray } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../../../MetaModelConst';
-import { observable, computed, makeObservable, action } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 
 export abstract class DatasourceSpecification implements Hashable {
   private readonly _$nominalTypeBrand!: 'DatasourceSpecification';
@@ -40,9 +40,6 @@ export class StaticDatasourceSpecification
       port: observable,
       databaseName: observable,
       hashCode: computed,
-      setHost: action,
-      setPort: action,
-      setDatabaseName: action,
     });
     this.host = host;
     this.port = port;
@@ -57,18 +54,6 @@ export class StaticDatasourceSpecification
       this.databaseName,
     ]);
   }
-
-  setHost(val: string): void {
-    this.host = val;
-  }
-
-  setPort(val: number): void {
-    this.port = val;
-  }
-
-  setDatabaseName(val: string): void {
-    this.databaseName = val;
-  }
 }
 
 export class DatabricksDatasourceSpecification
@@ -110,22 +95,6 @@ export class DatabricksDatasourceSpecification
       this.httpPath,
     ]);
   }
-
-  setHostName(val: string): void {
-    this.hostname = val;
-  }
-
-  setPort(val: string): void {
-    this.port = val;
-  }
-
-  setProtocol(val: string): void {
-    this.protocol = val;
-  }
-
-  setHttpPath(val: string): void {
-    this.httpPath = val;
-  }
 }
 
 export class EmbeddedH2DatasourceSpecification
@@ -148,27 +117,12 @@ export class EmbeddedH2DatasourceSpecification
       directory: observable,
       autoServerMode: observable,
       hashCode: computed,
-      setDatabaseName: action,
-      setDirectory: action,
-      setAutoServerMode: action,
     });
     this.databaseName = databaseName;
     this.directory = directory;
     this.autoServerMode = autoServerMode;
   }
 
-  setDatabaseName(val: string): void {
-    this.databaseName = val;
-  }
-
-  setDirectory(val: string): void {
-    this.directory = val;
-  }
-
-  setAutoServerMode(val: boolean): void {
-    this.autoServerMode = val;
-  }
-
   get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.EMBEDDED_H2_DATASOURCE_SPECIFICATION,
@@ -192,20 +146,10 @@ export class LocalH2DatasourceSpecification
     makeObservable(this, {
       testDataSetupCsv: observable,
       testDataSetupSqls: observable,
-      setTestDataSetupCsv: action,
-      setTestDataSetupSqls: action,
       hashCode: computed,
     });
   }
 
-  setTestDataSetupCsv(val: string | undefined): void {
-    this.testDataSetupCsv = val;
-  }
-
-  setTestDataSetupSqls(val: string[]): void {
-    this.testDataSetupSqls = val;
-  }
-
   get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.LOCAL_H2_DATASOURCE_SPECIFICATION,
@@ -254,18 +198,6 @@ export class SnowflakeDatasourceSpecification
       accountType: observable,
       role: observable,
       hashCode: computed,
-      setAccountName: action,
-      setRegion: action,
-      setWarehouseName: action,
-      setDatabaseName: action,
-      setCloudType: action,
-      setProxyHost: action,
-      setProxyPort: action,
-      setNonProxyHosts: action,
-      setOrganization: action,
-      setAccountType: action,
-      setRole: action,
-      setQuotedIdentifiersIgnoreCase: action,
     });
 
     this.region = region;
@@ -274,54 +206,6 @@ export class SnowflakeDatasourceSpecification
     this.accountName = accountName;
   }
 
-  setAccountName(val: string): void {
-    this.accountName = val;
-  }
-
-  setRegion(val: string): void {
-    this.region = val;
-  }
-
-  setWarehouseName(val: string): void {
-    this.warehouseName = val;
-  }
-
-  setDatabaseName(val: string): void {
-    this.databaseName = val;
-  }
-
-  setCloudType(val: string | undefined): void {
-    this.cloudType = val;
-  }
-
-  setQuotedIdentifiersIgnoreCase(val: boolean | undefined): void {
-    this.quotedIdentifiersIgnoreCase = val;
-  }
-
-  setProxyHost(val: string | undefined): void {
-    this.proxyHost = val;
-  }
-
-  setProxyPort(val: string | undefined): void {
-    this.proxyPort = val;
-  }
-
-  setNonProxyHosts(val: string | undefined): void {
-    this.nonProxyHosts = val;
-  }
-
-  setOrganization(val: string | undefined): void {
-    this.organization = val;
-  }
-
-  setAccountType(val: string | undefined): void {
-    this.accountType = val;
-  }
-
-  setRole(val: string | undefined): void {
-    this.role = val;
-  }
-
   get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.SNOWFLAKE_DATASOURCE_SPECIFICATION,
@@ -370,12 +254,6 @@ export class RedshiftDatasourceSpecification
       clusterID: observable,
       host: observable,
       hashCode: computed,
-      setDatabaseName: action,
-      setEndpointURL: action,
-      setPort: action,
-      setRegion: action,
-      setClusterID: action,
-      setHost: action,
     });
     this.clusterID = clusterID;
     this.region = region;
@@ -384,29 +262,6 @@ export class RedshiftDatasourceSpecification
     this.endpointURL = endpointURL;
     this.port = port;
   }
-
-  setDatabaseName(val: string): void {
-    this.databaseName = val;
-  }
-
-  setEndpointURL(val: string): void {
-    this.endpointURL = val;
-  }
-
-  setPort(val: number): void {
-    this.port = val;
-  }
-  setRegion(val: string): void {
-    this.region = val;
-  }
-
-  setHost(val: string): void {
-    this.host = val;
-  }
-
-  setClusterID(val: string): void {
-    this.clusterID = val;
-  }
   get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.REDSHIFT_DATASOURCE_SPECIFICATION,
@@ -434,20 +289,11 @@ export class BigQueryDatasourceSpecification
       projectId: observable,
       defaultDataset: observable,
       hashCode: computed,
-      setProjectId: action,
-      setDefaultDataset: action,
     });
     this.projectId = projectId;
     this.defaultDataset = defaultDataset;
   }
 
-  setProjectId(val: string): void {
-    this.projectId = val;
-  }
-  setDefaultDataset(val: string): void {
-    this.defaultDataset = val;
-  }
-
   get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.BIGQUERY_DATASOURCE_SPECIFICATION,

package/src/models/metamodels/pure/packageableElements/store/relational/connection/RelationalDatabaseConnection.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, computed, makeObservable, action } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import { CORE_HASH_STRUCTURE } from '../../../../../../../MetaModelConst';
 import { hashArray, guaranteeType } from '@finos/legend-shared';
 import {
@@ -61,20 +61,10 @@ export abstract class DatabaseConnection extends Connection {
       type: observable,
       timeZone: observable,
       quoteIdentifiers: observable,
-      setType: action,
-      setQuoteIdentifiers: action,
     });
 
     this.type = type;
   }
-
-  setType(val: DatabaseType): void {
-    this.type = val;
-  }
-
-  setQuoteIdentifiers(val: boolean): void {
-    this.quoteIdentifiers = val;
-  }
 }
 
 export class RelationalDatabaseConnection extends DatabaseConnection {
@@ -103,8 +93,6 @@ export class RelationalDatabaseConnection extends DatabaseConnection {
       authenticationStrategy: observable,
       database: computed,
       hashCode: computed,
-      setDatasourceSpecification: action,
-      setAuthenticationStrategy: action,
     });
 
     this.datasourceSpecification = datasourceSpecification;
@@ -123,14 +111,6 @@ export class RelationalDatabaseConnection extends DatabaseConnection {
     ]);
   }
 
-  setDatasourceSpecification(val: DatasourceSpecification): void {
-    this.datasourceSpecification = val;
-  }
-
-  setAuthenticationStrategy(val: AuthenticationStrategy): void {
-    this.authenticationStrategy = val;
-  }
-
   accept_ConnectionVisitor<T>(visitor: ConnectionVisitor<T>): T {
     return visitor.visit_RelationalDatabaseConnection(this);
   }

package/src/models/metamodels/pure/packageableElements/store/relational/mapping/RelationalInputData.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import {
   hashArray,
   UnsupportedOperationError,
@@ -62,8 +62,6 @@ export class RelationalInputData extends InputData implements Hashable {
     makeObservable(this, {
       data: observable,
       inputType: observable,
-      setData: action,
-      setInputType: action,
       validationResult: computed,
       hashCode: computed,
     });
@@ -73,14 +71,6 @@ export class RelationalInputData extends InputData implements Hashable {
     this.inputType = inputType;
   }
 
-  setData(value: string): void {
-    this.data = value;
-  }
-
-  setInputType(value: string): void {
-    this.inputType = getRelationalInputType(value);
-  }
-
   get validationResult(): ValidationIssue | undefined {
     if (this.database.value.isStub) {
       return createValidationError([

package/src/models/metamodels/pure/packageableElements/store/relational/mapping/RelationalPropertyMapping.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, computed, makeObservable, action } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import { CORE_HASH_STRUCTURE } from '../../../../../../../MetaModelConst';
 import { hashArray, type Hashable } from '@finos/legend-shared';
 import type { EnumerationMapping } from '../../../mapping/EnumerationMapping';
@@ -52,20 +52,10 @@ export class RelationalPropertyMapping
       transformer: observable,
       relationalOperation: observable.ref,
       bindingTransformer: observable,
-      setBindingTransformer: action,
-      setTransformer: action,
       hashCode: computed,
     });
   }
 
-  setTransformer(value: EnumerationMapping | undefined): void {
-    this.transformer = value;
-  }
-
-  setBindingTransformer(value: BindingTransformer | undefined): void {
-    this.bindingTransformer = value;
-  }
-
   accept_PropertyMappingVisitor<T>(visitor: PropertyMappingVisitor<T>): T {
     return visitor.visit_RelationalPropertyMapping(this);
   }

package/src/models/metamodels/pure/packageableElements/store/relational/mapping/RootRelationalInstanceSetImplementation.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, computed, makeObservable, action } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import { type Hashable, hashArray } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../../../MetaModelConst';
 import type { SetImplementationVisitor } from '../../../mapping/SetImplementation';
@@ -31,7 +31,6 @@ import type { Mapping } from '../../../mapping/Mapping';
 import type { PackageableElementReference } from '../../../PackageableElementReference';
 import type { Class } from '../../../domain/Class';
 import type { InferableMappingElementRoot } from '../../../mapping/InferableMappingElementRoot';
-import type { PropertyMapping } from '../../../mapping/PropertyMapping';
 
 export class RootRelationalInstanceSetImplementation
   extends RelationalInstanceSetImplementation
@@ -59,15 +58,10 @@ export class RootRelationalInstanceSetImplementation
       groupBy: observable,
       mainTableAlias: observable,
       superSetImplementationId: observable,
-      setPropertyMappings: action,
       hashCode: computed,
     });
   }
 
-  setPropertyMappings(value: PropertyMapping[]): void {
-    this.propertyMappings = value;
-  }
-
   override accept_SetImplementationVisitor<T>(
     visitor: SetImplementationVisitor<T>,
   ): T {

package/src/models/metamodels/pure/packageableElements/store/relational/model/ColumnReference.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, makeObservable } from 'mobx';
+import { observable, makeObservable } from 'mobx';
 import {
   PackageableElementExplicitReference,
   type PackageableElementReference,
@@ -37,17 +37,11 @@ export abstract class ColumnReference extends ReferenceWithOwner {
 
     makeObservable(this, {
       value: observable,
-      setValue: action,
     });
 
     this.ownerReference = ownerReference;
     this.value = value;
   }
-
-  setValue(value: Column): void {
-    this.value = value;
-    this.ownerReference.value = getSchemaFromRelation(value.owner).owner;
-  }
 }
 
 export class ColumnExplicitReference extends ColumnReference {

package/src/models/metamodels/pure/packageableElements/store/relational/model/FilterReference.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, makeObservable } from 'mobx';
+import { observable, makeObservable } from 'mobx';
 import {
   PackageableElementExplicitReference,
   type PackageableElementReference,
@@ -36,17 +36,11 @@ export abstract class FilterReference extends ReferenceWithOwner {
 
     makeObservable(this, {
       value: observable,
-      setValue: action,
     });
 
     this.ownerReference = ownerReference;
     this.value = value;
   }
-
-  setValue(value: Filter): void {
-    this.value = value;
-    this.ownerReference.value = value.owner;
-  }
 }
 
 export class FilterExplicitReference extends FilterReference {

package/src/models/metamodels/pure/packageableElements/store/relational/model/JoinReference.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, makeObservable } from 'mobx';
+import { observable, makeObservable } from 'mobx';
 import {
   PackageableElementExplicitReference,
   type PackageableElementReference,
@@ -36,17 +36,11 @@ export abstract class JoinReference extends ReferenceWithOwner {
 
     makeObservable(this, {
       value: observable,
-      setValue: action,
     });
 
     this.ownerReference = ownerReference;
     this.value = value;
   }
-
-  setValue(value: Join): void {
-    this.value = value;
-    this.ownerReference.value = value.owner;
-  }
 }
 
 export class JoinExplicitReference extends JoinReference {

package/src/models/metamodels/pure/packageableElements/store/relational/model/TableReference.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import { CORE_HASH_STRUCTURE } from '../../../../../../../MetaModelConst';
 import { hashString } from '@finos/legend-shared';
 import {
@@ -47,7 +47,6 @@ export abstract class TableReference extends NamedRelationalReference {
 
     makeObservable(this, {
       value: observable,
-      setValue: action,
       pointerHashCode: computed,
       selfJoinPointerHashCode: computed,
     });
@@ -55,11 +54,6 @@ export abstract class TableReference extends NamedRelationalReference {
     this.value = value;
   }
 
-  setValue(value: Table): void {
-    this.value = value;
-    this.ownerReference.value = value.schema.owner;
-  }
-
   get pointerHashCode(): string {
     return [
       CORE_HASH_STRUCTURE.RELATIONAL_OPERATION_TABLE_POINTER,

package/src/models/metamodels/pure/packageableElements/store/relational/model/ViewReference.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import { CORE_HASH_STRUCTURE } from '../../../../../../../MetaModelConst';
 import { hashString } from '@finos/legend-shared';
 import {
@@ -38,7 +38,6 @@ export abstract class ViewReference extends NamedRelationalReference {
 
     makeObservable(this, {
       value: observable,
-      setValue: action,
       pointerHashCode: computed,
       selfJoinPointerHashCode: computed,
     });
@@ -46,11 +45,6 @@ export abstract class ViewReference extends NamedRelationalReference {
     this.value = value;
   }
 
-  setValue(value: View): void {
-    this.value = value;
-    this.ownerReference.value = value.schema.owner;
-  }
-
   get pointerHashCode(): string {
     return [
       CORE_HASH_STRUCTURE.RELATIONAL_OPERATION_TABLE_POINTER,

package/src/models/protocols/pure/v1/transformation/pureGraph/to/helpers/V1_MappingBuilderHelper.ts

@@ -21,6 +21,7 @@ import {
   assertTrue,
   assertType,
   UnsupportedOperationError,
+  addUniqueEntry,
 } from '@finos/legend-shared';
 import { PRIMITIVE_TYPE } from '../../../../../../../../MetaModelConst';
 import { fromElementPathToMappingElementId } from '../../../../../../../../MetaModelUtils';
@@ -189,7 +190,8 @@ export const V1_buildMappingInclude = (
     context.resolveMapping(mappingInclude.includedMappingPath),
   );
   if (mappingInclude.sourceDatabasePath && mappingInclude.targetDatabasePath) {
-    includedMapping.addStoreSubstitution(
+    addUniqueEntry(
+      includedMapping.storeSubstitutions,
       new SubstituteStore(
         includedMapping,
         context.resolveStore(mappingInclude.sourceDatabasePath),