@finos/legend-graph 2.1.1 → 3.0.0

package/src/models/metamodels/pure/packageableElements/service/ServiceExecution.ts

@@ -14,13 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, computed, action, makeObservable } from 'mobx';
-import {
-  hashArray,
-  uuid,
-  addUniqueEntry,
-  type Hashable,
-} from '@finos/legend-shared';
+import { hashArray, uuid, type Hashable } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import type { Mapping } from '../mapping/Mapping';
 import type { RawLambda } from '../../rawValueSpecification/RawLambda';
@@ -31,7 +25,6 @@ import {
   createValidationError,
 } from '../../../../../helpers/ValidationHelper';
 import type { PackageableElementReference } from '../PackageableElementReference';
-import { setPackageableElementReferenceValue } from '../../../../DomainModifierHelper';
 
 export abstract class ServiceExecution implements Hashable {
   private readonly _$nominalTypeBrand!: 'ServiceExecution';
@@ -45,13 +38,6 @@ export class PureExecution extends ServiceExecution implements Hashable {
 
   constructor(func: RawLambda, owner: Service) {
     super();
-
-    makeObservable(this, {
-      func: observable,
-      queryValidationResult: computed,
-      setFunction: action,
-    });
-
     this.func = func;
     this.owner = owner;
   }
@@ -69,10 +55,6 @@ export class PureExecution extends ServiceExecution implements Hashable {
     return undefined;
   }
 
-  setFunction(value: RawLambda): void {
-    this.func = value;
-  }
-
   get hashCode(): string {
     return hashArray([CORE_HASH_STRUCTURE.SERVICE_PURE_EXECUTION, this.func]);
   }
@@ -89,26 +71,10 @@ export class PureSingleExecution extends PureExecution implements Hashable {
     runtime: Runtime,
   ) {
     super(func, owner);
-
-    makeObservable(this, {
-      runtime: observable,
-      setMapping: action,
-      setRuntime: action,
-      mappingValidationResult: computed,
-      hashCode: computed,
-    });
-
     this.mapping = mapping;
     this.runtime = runtime;
   }
 
-  setMapping(value: Mapping): void {
-    setPackageableElementReferenceValue(this.mapping, value);
-  }
-  setRuntime(value: Runtime): void {
-    this.runtime = value;
-  }
-
   get mappingValidationResult(): ValidationIssue | undefined {
     return this.mapping.value.isStub
       ? createValidationError(['Service execution mapping cannot be empty'])
@@ -126,7 +92,8 @@ export class PureSingleExecution extends PureExecution implements Hashable {
 }
 
 export class KeyedExecutionParameter implements Hashable {
-  uuid = uuid();
+  readonly uuid = uuid();
+
   key: string;
   mapping: PackageableElementReference<Mapping>;
   runtime: Runtime;
@@ -136,16 +103,6 @@ export class KeyedExecutionParameter implements Hashable {
     mapping: PackageableElementReference<Mapping>,
     runtime: Runtime,
   ) {
-    makeObservable(this, {
-      key: observable,
-      runtime: observable,
-      mappingValidationResult: computed,
-      setKey: action,
-      setMapping: action,
-      setRuntime: action,
-      hashCode: computed,
-    });
-
     this.key = key;
     this.mapping = mapping;
     this.runtime = runtime;
@@ -157,16 +114,6 @@ export class KeyedExecutionParameter implements Hashable {
       : undefined;
   }
 
-  setKey(value: string): void {
-    this.key = value;
-  }
-  setMapping(value: Mapping): void {
-    setPackageableElementReferenceValue(this.mapping, value);
-  }
-  setRuntime(value: Runtime): void {
-    this.runtime = value;
-  }
-
   get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.SERVICE_KEYED_EXECUTION_PARAMETER,
@@ -183,25 +130,9 @@ export class PureMultiExecution extends PureExecution implements Hashable {
 
   constructor(executionKey: string, func: RawLambda, parentService: Service) {
     super(func, parentService);
-
-    makeObservable(this, {
-      executionKey: observable,
-      executionParameters: observable,
-      setExecutionKey: action,
-      addExecutionParameter: action,
-      hashCode: computed,
-    });
-
     this.executionKey = executionKey;
   }
 
-  setExecutionKey(value: string): void {
-    this.executionKey = value;
-  }
-  addExecutionParameter(value: KeyedExecutionParameter): void {
-    addUniqueEntry(this.executionParameters, value);
-  }
-
   override get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.SERVICE_PURE_MULTI_EXECUTION,

package/src/models/metamodels/pure/packageableElements/service/ServiceTest.ts

@@ -14,14 +14,7 @@
  * limitations under the License.
  */
 
-import {
-  type Hashable,
-  uuid,
-  hashArray,
-  addUniqueEntry,
-  deleteEntry,
-} from '@finos/legend-shared';
-import { observable, computed, action, makeObservable } from 'mobx';
+import { type Hashable, uuid, hashArray } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import type { RawLambda } from '../../rawValueSpecification/RawLambda';
 import type { Service } from './Service';
@@ -37,19 +30,13 @@ export abstract class ServiceTest implements Hashable {
 }
 
 export class TestContainer implements Hashable {
-  uuid = uuid();
+  readonly uuid = uuid();
+
   parametersValues: unknown[] = []; // Any[*]; // ValueSpecification?
   assert: RawLambda; // @MARKER GENERATED MODEL DISCREPANCY --- Studio does not process lambda
   singleExecutionTestParent: SingleExecutionTest;
 
   constructor(assert: RawLambda, parent: SingleExecutionTest) {
-    makeObservable(this, {
-      parametersValues: observable,
-      assert: observable,
-      singleExecutionTestParent: observable,
-      hashCode: computed,
-    });
-
     this.assert = assert;
     this.singleExecutionTestParent = parent;
   }
@@ -69,29 +56,9 @@ export class SingleExecutionTest extends ServiceTest implements Hashable {
 
   constructor(owner: Service, data: string) {
     super(owner);
-
-    makeObservable(this, {
-      data: observable,
-      asserts: observable,
-      setData: action,
-      addAssert: action,
-      deleteAssert: action,
-      hashCode: computed,
-    });
-
     this.data = data;
   }
 
-  setData(value: string): void {
-    this.data = value;
-  }
-  addAssert(value: TestContainer): void {
-    addUniqueEntry(this.asserts, value);
-  }
-  deleteAssert(value: TestContainer): void {
-    deleteEntry(this.asserts, value);
-  }
-
   get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.SERVICE_SINGLE_EXECUTION_TEST,
@@ -109,19 +76,9 @@ export class KeyedSingleExecutionTest
 
   constructor(key: string, parentService: Service, data: string) {
     super(parentService, data);
-
-    makeObservable(this, {
-      key: observable,
-      setKey: action,
-    });
-
     this.key = key;
   }
 
-  setKey(value: string): void {
-    this.key = value;
-  }
-
   override get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.SERVICE_KEYED_SINGLE_EXECUTION_TEST,
@@ -135,24 +92,6 @@ export class KeyedSingleExecutionTest
 export class MultiExecutionTest extends ServiceTest implements Hashable {
   tests: KeyedSingleExecutionTest[] = [];
 
-  constructor(owner: Service) {
-    super(owner);
-
-    makeObservable(this, {
-      tests: observable,
-      addTest: action,
-      deleteTest: action,
-      hashCode: computed,
-    });
-  }
-
-  addTest(value: KeyedSingleExecutionTest): void {
-    addUniqueEntry(this.tests, value);
-  }
-  deleteTest(value: KeyedSingleExecutionTest): void {
-    deleteEntry(this.tests, value);
-  }
-
   get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.SERVICE_MULTI_EXECUTION_TEST,

package/src/models/metamodels/pure/packageableElements/store/Store.ts

@@ -14,19 +14,10 @@
  * limitations under the License.
  */
 
-import { observable, makeObservable } from 'mobx';
 import type { Hashable } from '@finos/legend-shared';
 import { PackageableElement } from '../PackageableElement';
 import type { PackageableElementReference } from '../PackageableElementReference';
 
 export abstract class Store extends PackageableElement implements Hashable {
   includes: PackageableElementReference<Store>[] = [];
-
-  constructor(name: string) {
-    super(name);
-
-    makeObservable(this, {
-      includes: observable,
-    });
-  }
 }

package/src/models/metamodels/pure/packageableElements/store/flatData/connection/FlatDataConnection.ts

@@ -14,52 +14,29 @@
  * limitations under the License.
  */
 
-import { observable, computed, action, makeObservable } from 'mobx';
 import {
   type Hashable,
   hashArray,
   ContentType,
-  guaranteeType,
   createUrlStringFromData,
 } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../../../MetaModelConst';
-import { FlatData } from '../model/FlatData';
 import {
   type ConnectionVisitor,
   Connection,
 } from '../../../connection/Connection';
 import type { PackageableElementReference } from '../../../PackageableElementReference';
+import type { FlatData } from '../model/FlatData';
 
 export class FlatDataConnection extends Connection implements Hashable {
-  static readonly CONTENT_TYPE = ContentType.TEXT_PLAIN;
-
+  declare store: PackageableElementReference<FlatData>;
   url: string;
 
   constructor(
-    flatData: PackageableElementReference<FlatData>,
-    url = createUrlStringFromData('', FlatDataConnection.CONTENT_TYPE, false),
+    store: PackageableElementReference<FlatData>,
+    url = createUrlStringFromData('', ContentType.TEXT_PLAIN, false),
   ) {
-    super(flatData);
-
-    makeObservable(this, {
-      url: observable,
-      flatDataStore: computed,
-      setUrl: action,
-      hashCode: computed,
-    });
-
-    this.url = url;
-  }
-
-  get flatDataStore(): FlatData {
-    return guaranteeType(
-      this.store.value,
-      FlatData,
-      'Flat-data connection must have a flat-data store',
-    );
-  }
-
-  setUrl(url: string): void {
+    super(store);
     this.url = url;
   }
 

package/src/models/metamodels/pure/packageableElements/store/flatData/mapping/EmbeddedFlatDataPropertyMapping.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, computed, action, makeObservable } from 'mobx';
 import {
   hashArray,
   UnsupportedOperationError,
@@ -55,7 +54,7 @@ export class EmbeddedFlatDataPropertyMapping
   implements InstanceSetImplementation, Hashable
 {
   root = InferableMappingElementRootExplicitValue.create(false);
-  override isEmbedded = true;
+  override readonly isEmbedded = true;
   class: PackageableElementReference<Class>;
   id: InferableMappingElementIdValue;
   propertyMappings: PropertyMapping[] = [];
@@ -72,27 +71,12 @@ export class EmbeddedFlatDataPropertyMapping
     target?: SetImplementation,
   ) {
     super(owner, property, source, target);
-
-    makeObservable(this, {
-      id: observable,
-      propertyMappings: observable,
-      rootInstanceSetImplementation: observable,
-      parent: observable,
-      label: computed,
-      setPropertyMappings: action,
-      isStub: computed,
-      hashCode: computed,
-    });
-
     this.class = _class;
     this.id = id;
     this.rootInstanceSetImplementation = rootInstanceSetImplementation;
     this.parent = rootInstanceSetImplementation.parent;
   }
 
-  setId(value: string): void {
-    throw new UnsupportedOperationError();
-  }
   setRoot(value: boolean): void {
     throw new UnsupportedOperationError();
   }
@@ -105,12 +89,6 @@ export class EmbeddedFlatDataPropertyMapping
     };
   }
 
-  setPropertyMappings(
-    propertyMappings: AbstractFlatDataPropertyMapping[],
-  ): void {
-    this.propertyMappings = propertyMappings;
-  }
-
   // As of now, there is no stub cases of Embedded Flat Property Mapping since they are created with an existing property mapping
   override get isStub(): boolean {
     return false;

package/src/models/metamodels/pure/packageableElements/store/flatData/mapping/FlatDataInputData.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
 import { hashArray, type Hashable } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../../../MetaModelConst';
 import { InputData } from '../../../mapping/InputData';
@@ -38,22 +37,10 @@ export class FlatDataInputData extends InputData implements Hashable {
     data: string,
   ) {
     super();
-
-    makeObservable(this, {
-      data: observable,
-      setData: action,
-      validationResult: computed,
-      hashCode: computed,
-    });
-
     this.sourceFlatData = sourceFlatData;
     this.data = data;
   }
 
-  setData(value: string): void {
-    this.data = value;
-  }
-
   get validationResult(): ValidationIssue | undefined {
     if (this.sourceFlatData.value.isStub) {
       return createValidationError([

package/src/models/metamodels/pure/packageableElements/store/flatData/mapping/FlatDataInstanceSetImplementation.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
 import { hashArray, type Hashable } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../../../MetaModelConst';
 import { InstanceSetImplementation } from '../../../mapping/InstanceSetImplementation';
@@ -23,7 +22,6 @@ import type { Class } from '../../../domain/Class';
 import type { Mapping } from '../../../mapping/Mapping';
 import type { SetImplementationVisitor } from '../../../mapping/SetImplementation';
 import { EmbeddedFlatDataPropertyMapping } from './EmbeddedFlatDataPropertyMapping';
-import type { RootFlatDataRecordType } from '../model/FlatDataDataType';
 import type { InferableMappingElementIdValue } from '../../../mapping/InferableMappingElementId';
 import type { RawLambda } from '../../../../rawValueSpecification/RawLambda';
 import type { PackageableElementReference } from '../../../PackageableElementReference';
@@ -46,24 +44,9 @@ export class FlatDataInstanceSetImplementation
     sourceRootRecordType: RootFlatDataRecordTypeReference,
   ) {
     super(id, parent, _class, root);
-
-    makeObservable(this, {
-      filter: observable,
-      setSourceRootRecordType: action,
-      setPropertyMappings: action,
-      hashCode: computed,
-    });
-
     this.sourceRootRecordType = sourceRootRecordType;
   }
 
-  setSourceRootRecordType(value: RootFlatDataRecordType): void {
-    this.sourceRootRecordType.setValue(value);
-  }
-  setPropertyMappings(value: AbstractFlatDataPropertyMapping[]): void {
-    this.propertyMappings = value;
-  }
-
   findPropertyMapping(
     propertyName: string,
     targetId: string | undefined,

package/src/models/metamodels/pure/packageableElements/store/flatData/mapping/FlatDataPropertyMapping.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
 import { CORE_HASH_STRUCTURE } from '../../../../../../../MetaModelConst';
 import { hashArray, type Hashable } from '@finos/legend-shared';
 import type { EnumerationMapping } from '../../../mapping/EnumerationMapping';
@@ -29,6 +28,7 @@ export class FlatDataPropertyMapping
   extends AbstractFlatDataPropertyMapping
   implements Hashable
 {
+  // TODO: convert to reference
   transformer?: EnumerationMapping | undefined;
   transform: RawLambda; // @MARKER GENERATED MODEL DISCREPANCY --- Studio does not process lambda
 
@@ -40,22 +40,9 @@ export class FlatDataPropertyMapping
     target?: SetImplementation,
   ) {
     super(owner, property, source, target);
-
-    makeObservable(this, {
-      transformer: observable,
-      transform: observable,
-      setTransformer: action,
-      isStub: computed,
-      hashCode: computed,
-    });
-
     this.transform = transform;
   }
 
-  setTransformer(value: EnumerationMapping | undefined): void {
-    this.transformer = value;
-  }
-
   override get isStub(): boolean {
     return this.transform.isStub;
   }

package/src/models/metamodels/pure/packageableElements/store/flatData/model/FlatData.ts

@@ -14,14 +14,10 @@
  * limitations under the License.
  */
 
-import { observable, computed, action, makeObservable, override } from 'mobx';
 import {
   type Hashable,
   guaranteeNonNullable,
   hashArray,
-  addUniqueEntry,
-  deleteEntry,
-  changeEntry,
 } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../../../MetaModelConst';
 import type { FlatDataSection } from './FlatDataSection';
@@ -32,33 +28,11 @@ import type { RootFlatDataRecordType } from './FlatDataDataType';
 export class FlatData extends Store implements Hashable {
   sections: FlatDataSection[] = [];
 
-  constructor(name: string) {
-    super(name);
-
-    makeObservable<FlatData, '_elementHashCode'>(this, {
-      sections: observable,
-      deleteSection: action,
-      changeSection: action,
-      addSection: action,
-      recordTypes: computed,
-      _elementHashCode: override,
-    });
-  }
-
   findSection = (sectionName: string): FlatDataSection =>
     guaranteeNonNullable(
       this.sections.find((section) => section.name === sectionName),
       `Can't find section '${sectionName}' in flat-data store '${this.path}'`,
     );
-  deleteSection(value: FlatDataSection): void {
-    deleteEntry(this.sections, value);
-  }
-  changeSection(value: FlatDataSection, newVal: FlatDataSection): void {
-    changeEntry(this.sections, value, newVal);
-  }
-  addSection(value: FlatDataSection): void {
-    addUniqueEntry(this.sections, value);
-  }
 
   get recordTypes(): RootFlatDataRecordType[] {
     return this.sections.flatMap((section) =>

package/src/models/metamodels/pure/packageableElements/store/flatData/model/FlatDataDataType.ts

@@ -14,14 +14,13 @@
  * limitations under the License.
  */
 
-import { observable, computed, action, makeObservable } from 'mobx';
 import { hashArray, type Hashable } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../../../MetaModelConst';
 import type { FlatDataSection } from './FlatDataSection';
 import type { PrimitiveType } from '../../../domain/PrimitiveType';
 
 export abstract class FlatDataDataType {
-  correspondingPrimitiveType?: PrimitiveType | undefined;
+  readonly correspondingPrimitiveType?: PrimitiveType | undefined;
 
   constructor(correspondingPrimitiveType?: PrimitiveType) {
     this.correspondingPrimitiveType = correspondingPrimitiveType;
@@ -34,16 +33,6 @@ export class FlatDataBoolean extends FlatDataDataType implements Hashable {
   trueString?: string | undefined;
   falseString?: string | undefined;
 
-  constructor(correspondingPrimitiveType?: PrimitiveType) {
-    super(correspondingPrimitiveType);
-
-    makeObservable(this, {
-      trueString: observable,
-      falseString: observable,
-      hashCode: computed,
-    });
-  }
-
   get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.FLAT_DATA_BOOLEAN,
@@ -54,28 +43,12 @@ export class FlatDataBoolean extends FlatDataDataType implements Hashable {
 }
 
 export class FlatDataString extends FlatDataDataType implements Hashable {
-  constructor(correspondingPrimitiveType?: PrimitiveType) {
-    super(correspondingPrimitiveType);
-
-    makeObservable(this, {
-      hashCode: computed,
-    });
-  }
-
   get hashCode(): string {
     return hashArray([CORE_HASH_STRUCTURE.FLAT_DATA_STRING]);
   }
 }
 
 export class FlatDataNumber extends FlatDataDataType implements Hashable {
-  constructor(correspondingPrimitiveType?: PrimitiveType) {
-    super(correspondingPrimitiveType);
-
-    makeObservable(this, {
-      hashCode: computed,
-    });
-  }
-
   get hashCode(): string {
     return hashArray([CORE_HASH_STRUCTURE.FLAT_DATA_NUMBER]);
   }
@@ -103,25 +76,6 @@ export class FlatDataDate extends FlatDataDataType implements Hashable {
   dateFormat?: string | undefined;
   timeZone?: string | undefined;
 
-  constructor(correspondingPrimitiveType?: PrimitiveType) {
-    super(correspondingPrimitiveType);
-
-    makeObservable(this, {
-      dateFormat: observable,
-      timeZone: observable,
-      setDateFormat: action,
-      setTimeZone: action,
-      hashCode: computed,
-    });
-  }
-
-  setDateFormat(value: string | undefined): void {
-    this.dateFormat = value;
-  }
-  setTimeZone(value: string | undefined): void {
-    this.timeZone = value;
-  }
-
   get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.FLAT_DATA_DATE,
@@ -162,24 +116,11 @@ export class FlatDataRecordField implements Hashable {
     flatDataDataType: FlatDataDataType,
     optional: boolean,
   ) {
-    makeObservable(this, {
-      label: observable,
-      flatDataDataType: observable,
-      optional: observable,
-      address: observable,
-      setAddress: action,
-      hashCode: computed,
-    });
-
     this.label = label;
     this.flatDataDataType = flatDataDataType;
     this.optional = optional;
   }
 
-  setAddress(value: string | undefined): void {
-    this.address = value;
-  }
-
   get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.FLAT_DATA_RECORD_FIELD,
@@ -203,15 +144,6 @@ export class FlatDataRecordField implements Hashable {
 export class FlatDataRecordType extends FlatDataDataType implements Hashable {
   fields: FlatDataRecordField[] = [];
 
-  constructor(correspondingPrimitiveType?: PrimitiveType) {
-    super(correspondingPrimitiveType);
-
-    makeObservable(this, {
-      fields: observable,
-      hashCode: computed,
-    });
-  }
-
   get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.FLAT_DATA_RECORD_TYPE,

package/src/models/metamodels/pure/packageableElements/store/flatData/model/FlatDataProperty.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, computed, makeObservable } from 'mobx';
 import { CORE_HASH_STRUCTURE } from '../../../../../../../MetaModelConst';
 import { type Hashable, hashArray } from '@finos/legend-shared';
 
@@ -25,12 +24,6 @@ export class FlatDataProperty implements Hashable {
   value: FlatDataPropertyValue;
 
   constructor(name: string, value: FlatDataPropertyValue) {
-    makeObservable(this, {
-      name: observable,
-      value: observable,
-      hashCode: computed,
-    });
-
     this.name = name;
     this.value = value;
   }