@finos/legend-graph 2.0.2 → 2.1.0

package/src/models/metamodels/pure/packageableElements/domain/Constraint.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import { hashArray, uuid, type Hashable } from '@finos/legend-shared';
 import { RawLambda } from '../../rawValueSpecification/RawLambda';
@@ -37,8 +37,6 @@ export class Constraint implements Hashable, Stubable {
       externalId: observable,
       enforcementLevel: observable,
       messageFunction: observable,
-      setName: action,
-      setFunctionDefinition: action,
       isStub: computed,
       hashCode: computed,
     });
@@ -48,13 +46,6 @@ export class Constraint implements Hashable, Stubable {
     this.functionDefinition = functionDefinition;
   }
 
-  setName(name: string): void {
-    this.name = name;
-  }
-  setFunctionDefinition(lambda: RawLambda): void {
-    this.functionDefinition = lambda;
-  }
-
   static createStub = (_class: Class): Constraint =>
     new Constraint('', _class, RawLambda.createStub());
   // the constraint is considered stub if it doesn't have a body in the function definition lambda because

package/src/models/metamodels/pure/packageableElements/domain/DerivedProperty.ts

@@ -14,15 +14,8 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
-import {
-  type Hashable,
-  hashArray,
-  uuid,
-  deleteEntry,
-  addUniqueEntry,
-  changeEntry,
-} from '@finos/legend-shared';
+import { observable, computed, makeObservable } from 'mobx';
+import { type Hashable, hashArray, uuid } from '@finos/legend-shared';
 import { hashLambda } from '../../../../../MetaModelUtils';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import { Multiplicity } from './Multiplicity';
@@ -65,16 +58,6 @@ export class DerivedProperty
       taggedValues: observable,
       body: observable.ref,
       parameters: observable.ref,
-      setName: action,
-      setGenericType: action,
-      setMultiplicity: action,
-      deleteTaggedValue: action,
-      addTaggedValue: action,
-      deleteStereotype: action,
-      changeStereotype: action,
-      addStereotype: action,
-      setBody: action,
-      setParameters: action,
       isStub: computed,
       hashCode: computed,
     });
@@ -84,41 +67,6 @@ export class DerivedProperty
     this.genericType = genericType;
     this.owner = owner;
   }
-
-  setName(value: string): void {
-    this.name = value;
-  }
-  setGenericType(value: GenericType): void {
-    this.genericType.setValue(value);
-  }
-  setMultiplicity(value: Multiplicity): void {
-    this.multiplicity = value;
-  }
-  deleteTaggedValue(value: TaggedValue): void {
-    deleteEntry(this.taggedValues, value);
-  }
-  addTaggedValue(value: TaggedValue): void {
-    addUniqueEntry(this.taggedValues, value);
-  }
-  deleteStereotype(value: StereotypeReference): void {
-    deleteEntry(this.stereotypes, value);
-  }
-  changeStereotype(
-    oldValue: StereotypeReference,
-    newValue: StereotypeReference,
-  ): void {
-    changeEntry(this.stereotypes, oldValue, newValue);
-  }
-  addStereotype(value: StereotypeReference): void {
-    addUniqueEntry(this.stereotypes, value);
-  }
-  setBody(value: object | undefined): void {
-    this.body = value;
-  }
-  setParameters(value: object | undefined): void {
-    this.parameters = value;
-  }
-
   static createStub = (type: Type, _class: Class): DerivedProperty =>
     new DerivedProperty(
       '',

package/src/models/metamodels/pure/packageableElements/domain/Enum.ts

@@ -14,15 +14,8 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
-import {
-  type Hashable,
-  uuid,
-  hashArray,
-  deleteEntry,
-  addUniqueEntry,
-  changeEntry,
-} from '@finos/legend-shared';
+import { observable, computed, makeObservable } from 'mobx';
+import { type Hashable, uuid, hashArray } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import type { Enumeration } from './Enumeration';
 import type { TaggedValue } from './TaggedValue';
@@ -42,12 +35,6 @@ export class Enum implements AnnotatedElement, Hashable, Stubable {
       name: observable,
       stereotypes: observable,
       taggedValues: observable,
-      setName: action,
-      deleteTaggedValue: action,
-      addTaggedValue: action,
-      deleteStereotype: action,
-      changeStereotype: action,
-      addStereotype: action,
       isStub: computed,
       hashCode: computed,
     });
@@ -56,28 +43,6 @@ export class Enum implements AnnotatedElement, Hashable, Stubable {
     this.owner = owner;
   }
 
-  setName(value: string): void {
-    this.name = value;
-  }
-  deleteTaggedValue(value: TaggedValue): void {
-    deleteEntry(this.taggedValues, value);
-  }
-  addTaggedValue(value: TaggedValue): void {
-    addUniqueEntry(this.taggedValues, value);
-  }
-  deleteStereotype(value: StereotypeReference): void {
-    deleteEntry(this.stereotypes, value);
-  }
-  changeStereotype(
-    oldValue: StereotypeReference,
-    newValue: StereotypeReference,
-  ): void {
-    changeEntry(this.stereotypes, oldValue, newValue);
-  }
-  addStereotype(value: StereotypeReference): void {
-    addUniqueEntry(this.stereotypes, value);
-  }
-
   static createStub = (parentEnumeration: Enumeration): Enum =>
     new Enum('', parentEnumeration);
   get isStub(): boolean {

package/src/models/metamodels/pure/packageableElements/domain/EnumValueReference.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import {
   PackageableElementExplicitReference,
   type PackageableElementReference,
@@ -40,7 +40,6 @@ export abstract class EnumValueReference
 
     makeObservable(this, {
       value: observable,
-      setValue: action,
       isStub: computed,
     });
 
@@ -48,11 +47,6 @@ export abstract class EnumValueReference
     this.value = value;
   }
 
-  setValue(value: Enum): void {
-    this.value = value;
-    this.ownerReference.setValue(value.owner);
-  }
-
   get isStub(): boolean {
     return !this.value.isStub;
   }

package/src/models/metamodels/pure/packageableElements/domain/Enumeration.ts

@@ -14,14 +14,11 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable, override } from 'mobx';
+import { observable, computed, makeObservable, override } from 'mobx';
 import {
   type Hashable,
   hashArray,
   guaranteeNonNullable,
-  addUniqueEntry,
-  deleteEntry,
-  changeEntry,
 } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import { DataType } from './DataType';
@@ -44,13 +41,6 @@ export class Enumeration extends DataType implements Hashable, Stubable {
       values: observable,
       stereotypes: observable,
       taggedValues: observable,
-      addValue: action,
-      deleteValue: action,
-      deleteTaggedValue: action,
-      addTaggedValue: action,
-      deleteStereotype: action,
-      changeStereotype: action,
-      addStereotype: action,
       isStub: computed,
       _elementHashCode: override,
     });
@@ -63,32 +53,6 @@ export class Enumeration extends DataType implements Hashable, Stubable {
       this.values.find((value) => value.name === name),
       `Can't find enum value '${name}' in enumeration '${this.path}'`,
     );
-
-  addValue(value: Enum): void {
-    addUniqueEntry(this.values, value);
-  }
-  deleteValue(value: Enum): void {
-    deleteEntry(this.values, value);
-  }
-  deleteTaggedValue(value: TaggedValue): void {
-    deleteEntry(this.taggedValues, value);
-  }
-  addTaggedValue(value: TaggedValue): void {
-    addUniqueEntry(this.taggedValues, value);
-  }
-  deleteStereotype(value: StereotypeReference): void {
-    deleteEntry(this.stereotypes, value);
-  }
-  changeStereotype(
-    oldValue: StereotypeReference,
-    newValue: StereotypeReference,
-  ): void {
-    changeEntry(this.stereotypes, oldValue, newValue);
-  }
-  addStereotype(value: StereotypeReference): void {
-    addUniqueEntry(this.stereotypes, value);
-  }
-
   static createStub = (): Enumeration => new Enumeration('');
 
   override get isStub(): boolean {

package/src/models/metamodels/pure/packageableElements/domain/GenericType.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import { type Clazz, guaranteeType, uuid } from '@finos/legend-shared';
 import type { Type } from './Type';
 import type { Stubable } from '../../../../../helpers/Stubable';
@@ -26,7 +26,6 @@ export class GenericType implements Stubable {
   constructor(rawType: Type) {
     makeObservable(this, {
       rawType: observable,
-      setRawType: action,
       isStub: computed,
     });
 
@@ -35,9 +34,6 @@ export class GenericType implements Stubable {
 
   getRawType = <T extends Type>(clazz: Clazz<T>): T =>
     guaranteeType<T>(this.rawType, clazz);
-  setRawType(type: Type): void {
-    this.rawType = type;
-  }
 
   // NOTE: we don't have a `createStub` for GenericType because it all depends on the type passed in
   // so might as well use constructor

package/src/models/metamodels/pure/packageableElements/domain/GenericTypeReference.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import {
   PackageableElementExplicitReference,
   type PackageableElementReference,
@@ -40,7 +40,6 @@ export abstract class GenericTypeReference
 
     makeObservable(this, {
       value: observable,
-      setValue: action,
       isStub: computed,
     });
 
@@ -48,11 +47,6 @@ export abstract class GenericTypeReference
     this.value = value;
   }
 
-  setValue(value: GenericType): void {
-    this.value = value;
-    this.ownerReference.setValue(value.rawType);
-  }
-
   get isStub(): boolean {
     return !this.value.isStub;
   }

package/src/models/metamodels/pure/packageableElements/domain/Measure.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, makeObservable, override } from 'mobx';
+import { observable, makeObservable, override } from 'mobx';
 import {
   hashArray,
   UnsupportedOperationError,
@@ -40,7 +40,6 @@ export class Unit extends DataType implements Hashable {
     makeObservable(this, {
       measure: observable,
       conversionFunction: observable,
-      setConversionFunction: action,
       hashCode: override,
     });
 
@@ -55,10 +54,6 @@ export class Unit extends DataType implements Hashable {
     return this.measure === type;
   }
 
-  setConversionFunction(lambda: RawLambda): void {
-    this.conversionFunction = lambda;
-  }
-
   override get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.UNIT,
@@ -84,15 +79,10 @@ export class Measure extends Type implements Hashable {
     makeObservable<Measure, '_elementHashCode'>(this, {
       canonicalUnit: observable,
       nonCanonicalUnits: observable,
-      setCanonicalUnit: action,
       _elementHashCode: override,
     });
   }
 
-  setCanonicalUnit(unit: Unit): void {
-    this.canonicalUnit = unit;
-  }
-
   isSubType(type: Type): boolean {
     return false;
   }

package/src/models/metamodels/pure/packageableElements/domain/Multiplicity.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, computed, makeObservable, action } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import {
   CORE_HASH_STRUCTURE,
   MULTIPLICITY_INFINITE,
@@ -31,22 +31,12 @@ export class Multiplicity implements Hashable {
       upperBound: observable,
       str: computed,
       hashCode: computed,
-      setLowerBound: action,
-      setUpperBound: action,
     });
 
     this.lowerBound = lowerBound;
     this.upperBound = upperBound;
   }
 
-  setLowerBound(val: number): void {
-    this.lowerBound = val;
-  }
-
-  setUpperBound(val: number | undefined): void {
-    this.upperBound = val;
-  }
-
   get str(): string {
     if (this.lowerBound === this.upperBound) {
       return this.lowerBound.toString();

package/src/models/metamodels/pure/packageableElements/domain/Package.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, makeObservable, override } from 'mobx';
+import { observable, makeObservable, override } from 'mobx';
 import {
   CORE_HASH_STRUCTURE,
   ELEMENT_PATH_DELIMITER,
@@ -29,6 +29,7 @@ import {
   type PackageableElementVisitor,
   PackageableElement,
 } from '../PackageableElement';
+import { addPackageChild } from '../../../../DomainModifierHelper';
 
 export const RESERVERD_PACKAGE_NAMES = ['$implicit'];
 
@@ -40,8 +41,6 @@ export class Package extends PackageableElement implements Hashable {
 
     makeObservable(this, {
       children: observable,
-      addChild: action,
-      addElement: action,
       hashCode: override,
     });
   }
@@ -56,17 +55,6 @@ export class Package extends PackageableElement implements Hashable {
     return newPackage;
   }
 
-  addChild(value: PackageableElement): void {
-    // NOTE: here we directly push the element to the children array without any checks rather than use `addUniqueEntry` to improve performance.
-    // Duplication checks should be handled separately
-    this.children.push(value);
-  }
-
-  addElement(element: PackageableElement): void {
-    this.addChild(element);
-    element.setPackage(this);
-  }
-
   get fullPath(): string {
     if (!this.package) {
       return '';
@@ -77,12 +65,6 @@ export class Package extends PackageableElement implements Hashable {
       : `${parentPackageName}${ELEMENT_PATH_DELIMITER}${this.name}`;
   }
 
-  deleteElement(packageableElement: PackageableElement): void {
-    this.children = this.children.filter(
-      (child) => child !== packageableElement,
-    );
-  }
-
   /**
    * If package name is a path, continue to recursively traverse the package chain to find the leaf package
    * NOTE: if we do not allow insertion, error could be thrown if a package in the path is not found
@@ -107,7 +89,7 @@ export class Package extends PackageableElement implements Hashable {
       }
       // create the node if it is not in parent package
       node = Package.createPackageFromParent(str, parent);
-      parent.addChild(node);
+      addPackageChild(parent, node);
     }
     if (index !== -1) {
       return Package.getOrCreatePackage(

package/src/models/metamodels/pure/packageableElements/domain/Profile.ts

@@ -14,13 +14,11 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable, override } from 'mobx';
+import { observable, computed, makeObservable, override } from 'mobx';
 import {
   type Hashable,
   guaranteeNonNullable,
   hashArray,
-  deleteEntry,
-  addUniqueEntry,
 } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import {
@@ -41,31 +39,11 @@ export class Profile extends PackageableElement implements Hashable, Stubable {
     makeObservable<Profile, '_elementHashCode'>(this, {
       stereotypes: observable,
       tags: observable,
-      addTag: action,
-      deleteTag: action,
-      addStereotype: action,
-      deleteStereotype: action,
       isStub: computed,
       _elementHashCode: override,
     });
   }
 
-  addTag(value: Tag): void {
-    addUniqueEntry(this.tags, value);
-  }
-
-  deleteTag(value: Tag): void {
-    deleteEntry(this.tags, value);
-  }
-
-  addStereotype(value: Stereotype): void {
-    addUniqueEntry(this.stereotypes, value);
-  }
-
-  deleteStereotype(value: Stereotype): void {
-    deleteEntry(this.stereotypes, value);
-  }
-
   getTag = (value: string): Tag =>
     guaranteeNonNullable(
       this.tags.find((tag) => tag.value === value),

package/src/models/metamodels/pure/packageableElements/domain/Property.ts

@@ -14,15 +14,8 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
-import {
-  type Hashable,
-  hashArray,
-  uuid,
-  deleteEntry,
-  addUniqueEntry,
-  changeEntry,
-} from '@finos/legend-shared';
+import { observable, computed, makeObservable } from 'mobx';
+import { type Hashable, hashArray, uuid } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import {
   type GenericTypeReference,
@@ -60,14 +53,6 @@ export class Property
       multiplicity: observable,
       stereotypes: observable,
       taggedValues: observable,
-      setName: action,
-      setGenericType: action,
-      setMultiplicity: action,
-      addTaggedValue: action,
-      deleteTaggedValue: action,
-      addStereotype: action,
-      changeStereotype: action,
-      deleteStereotype: action,
       isStub: computed,
       hashCode: computed,
     });
@@ -78,34 +63,6 @@ export class Property
     this.owner = owner;
   }
 
-  setName(value: string): void {
-    this.name = value;
-  }
-  setGenericType(value: GenericType): void {
-    this.genericType.setValue(value);
-  }
-  setMultiplicity(value: Multiplicity): void {
-    this.multiplicity = value;
-  }
-  addTaggedValue(value: TaggedValue): void {
-    addUniqueEntry(this.taggedValues, value);
-  }
-  deleteTaggedValue(value: TaggedValue): void {
-    deleteEntry(this.taggedValues, value);
-  }
-  addStereotype(value: StereotypeReference): void {
-    addUniqueEntry(this.stereotypes, value);
-  }
-  changeStereotype(
-    oldValue: StereotypeReference,
-    newValue: StereotypeReference,
-  ): void {
-    changeEntry(this.stereotypes, oldValue, newValue);
-  }
-  deleteStereotype(value: StereotypeReference): void {
-    deleteEntry(this.stereotypes, value);
-  }
-
   static createStub = (type: Type, _class: Class): Property =>
     new Property(
       '',

package/src/models/metamodels/pure/packageableElements/domain/PropertyReference.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import { hashString } from '@finos/legend-shared';
 import {
@@ -45,7 +45,6 @@ export abstract class PropertyReference
 
     makeObservable(this, {
       value: observable,
-      setValue: action,
       isStub: computed,
       pointerHashCode: computed,
     });
@@ -54,15 +53,6 @@ export abstract class PropertyReference
     this.value = value;
   }
 
-  setValue(value: AbstractProperty): void {
-    this.value = value;
-    this.ownerReference.setValue(
-      value.owner instanceof Association
-        ? value.owner.getPropertyAssociatedClass(this.value)
-        : value.owner,
-    );
-  }
-
   get isStub(): boolean {
     return !this.value.isStub;
   }

package/src/models/metamodels/pure/packageableElements/domain/Stereotype.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import { uuid } from '@finos/legend-shared';
 import type { Profile } from './Profile';
 import type { Stubable } from '../../../../../helpers/Stubable';
@@ -27,7 +27,6 @@ export class Stereotype implements Stubable {
   constructor(owner: Profile, value: string) {
     makeObservable(this, {
       value: observable,
-      setValue: action,
       isStub: computed,
     });
 
@@ -35,10 +34,6 @@ export class Stereotype implements Stubable {
     this.value = value;
   }
 
-  setValue(value: string): void {
-    this.value = value;
-  }
-
   static createStub = (profile: Profile): Stereotype =>
     new Stereotype(profile, '');
   get isStub(): boolean {

package/src/models/metamodels/pure/packageableElements/domain/StereotypeReference.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import { hashString } from '@finos/legend-shared';
 import {
@@ -42,7 +42,6 @@ export abstract class StereotypeReference
 
     makeObservable(this, {
       value: observable,
-      setValue: action,
       isStub: computed,
       pointerHashCode: computed,
     });
@@ -51,11 +50,6 @@ export abstract class StereotypeReference
     this.value = value;
   }
 
-  setValue(value: Stereotype): void {
-    this.value = value;
-    this.ownerReference.setValue(value.owner);
-  }
-
   get isStub(): boolean {
     return !this.value.isStub;
   }

package/src/models/metamodels/pure/packageableElements/domain/Tag.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import { uuid } from '@finos/legend-shared';
 import type { Profile } from './Profile';
 import type { Stubable } from '../../../../../helpers/Stubable';
@@ -27,7 +27,6 @@ export class Tag implements Stubable {
   constructor(owner: Profile, value: string) {
     makeObservable(this, {
       value: observable,
-      setValue: action,
       isStub: computed,
     });
 
@@ -35,10 +34,6 @@ export class Tag implements Stubable {
     this.value = value;
   }
 
-  setValue(value: string): void {
-    this.value = value;
-  }
-
   static createStub = (profile: Profile): Tag => new Tag(profile, '');
   get isStub(): boolean {
     return !this.value;