@finos/legend-graph 19.1.0 → 19.2.0

package/src/graphManager/protocol/pure/v1/transformation/pureGraph/to/V1_ElementThirdPassBuilder.ts

@@ -118,18 +118,17 @@ export class V1_ElementThirdPassBuilder
     const uniqueProperties = new Set<string>();
     element.properties.forEach((property) => {
       if (uniqueProperties.has(property.name)) {
+        const message = `Found duplicated property '${property.name}' in class '${_class.path}'`;
         /**
-         * This test is skipped because we want to temporarily relax graph building algorithm
-         * to ease Pure -> Legend migration push.
-         * See https://github.com/finos/legend-studio/issues/660
+         * In strict-mode, graph builder will consider this as an error
+         * See https://github.com/finos/legend-studio/issues/941
          *
          * @discrepancy graph-building
          */
-        this.context.log.warn(
-          LogEvent.create(
-            `Found duplicated property '${property.name}' in class '${_class.path}'`,
-          ),
-        );
+        if (this.context.options?.strict) {
+          throw new GraphBuilderError(message);
+        }
+        this.context.log.warn(LogEvent.create(message));
       }
       _class.properties.push(V1_buildProperty(property, this.context, _class));
       uniqueProperties.add(property.name);
@@ -148,18 +147,17 @@ export class V1_ElementThirdPassBuilder
     const first = guaranteeNonNullable(element.properties[0]);
     const second = guaranteeNonNullable(element.properties[1]);
     if (first.name === second.name) {
+      const message = `Found duplicated property '${element.properties[0]?.name}' in association '${element.path}'`;
       /**
-       * This test is skipped because we want to temporarily relax graph building algorithm
-       * to ease Pure -> Legend migration push.
-       * See https://github.com/finos/legend-studio/issues/660
+       * In strict-mode, graph builder will consider this as an error
+       * See https://github.com/finos/legend-studio/issues/941
        *
        * @discrepancy graph-building
        */
-      this.context.log.warn(
-        LogEvent.create(
-          `Found duplicated property '${element.properties[0]?.name}' in association '${element.name}'`,
-        ),
-      );
+      if (this.context.options?.strict) {
+        throw new GraphBuilderError(message);
+      }
+      this.context.log.warn(LogEvent.create(message));
     }
     association.properties = [
       V1_buildAssociationProperty(first, second, this.context, association),

package/src/graphManager/protocol/pure/v1/transformation/pureGraph/to/V1_PropertyMappingBuilder.ts

@@ -102,30 +102,46 @@ import { EnumerationMappingExplicitReference } from '../../../../../../../graph/
 import type { V1_FlatDataAssociationPropertyMapping } from '../../../model/packageableElements/store/flatData/mapping/V1_FlatDataAssociationPropertyMapping.js';
 import { FlatDataAssociationPropertyMapping } from '../../../../../../../graph/metamodel/pure/packageableElements/store/flatData/mapping/FlatDataAssociationPropertyMapping.js';
 
-/**
- * This test is skipped because we want to temporarily relax graph building algorithm
- * to ease Pure -> Legend migration push.
- * See https://github.com/finos/legend-studio/issues/880
- *
- * @discrepancy graph-building
- */
 const TEMPORARY__getClassMappingByIdOrReturnUnresolved = (
   mapping: Mapping,
   id: string,
-): SetImplementation =>
-  returnUndefOnError(() => getClassMappingById(mapping, id)) ??
-  new TEMPORARY__UnresolvedSetImplementation(id, mapping);
+  context: V1_GraphBuilderContext,
+): SetImplementation => {
+  const classMapping = returnUndefOnError(() =>
+    getClassMappingById(mapping, id),
+  );
+
+  if (!classMapping) {
+    const message = `Can't find class mapping with ID '${id}' in mapping '${mapping.path}'`;
+    /**
+     * In strict-mode, graph builder will consider this as an error
+     * See https://github.com/finos/legend-studio/issues/880
+     * See https://github.com/finos/legend-studio/issues/941
+     *
+     * @discrepancy graph-building
+     */
+    if (context.options?.strict) {
+      throw new GraphBuilderError(message);
+    }
+    context.log.warn(LogEvent.create(message));
+    return new TEMPORARY__UnresolvedSetImplementation(id, mapping);
+  }
+
+  return classMapping;
+};
 
 const resolvePropertyMappingSource = (
   immediateParent: PropertyMappingsImplementation,
   value: V1_PropertyMapping,
   topParent: InstanceSetImplementation | undefined,
+  context: V1_GraphBuilderContext,
 ): SetImplementation | undefined => {
   if (immediateParent instanceof AssociationImplementation) {
     if (value.source) {
       return TEMPORARY__getClassMappingByIdOrReturnUnresolved(
         immediateParent._PARENT,
         value.source,
+        context,
       );
     }
     const property = getOwnProperty(
@@ -256,6 +272,7 @@ export class V1_PropertyMappingBuilder
           TEMPORARY__getClassMappingByIdOrReturnUnresolved(
             topParent._PARENT,
             protocol.target,
+            this.context,
           );
       } else {
         // NOTE: if no there is one non-root class mapping, auto-nominate that as the target set implementation
@@ -273,6 +290,7 @@ export class V1_PropertyMappingBuilder
       ? TEMPORARY__getClassMappingByIdOrReturnUnresolved(
           topParent._PARENT,
           protocol.source,
+          this.context,
         )
       : undefined;
     const purePropertyMapping = new PurePropertyMapping(
@@ -364,6 +382,7 @@ export class V1_PropertyMappingBuilder
         ? TEMPORARY__getClassMappingByIdOrReturnUnresolved(
             this.topParent._PARENT,
             protocol.target,
+            this.context,
           )
         : undefined;
     }
@@ -587,6 +606,7 @@ export class V1_PropertyMappingBuilder
           ? TEMPORARY__getClassMappingByIdOrReturnUnresolved(
               parentMapping,
               protocol.target,
+              this.context,
             )
           : undefined;
       } else {
@@ -603,6 +623,7 @@ export class V1_PropertyMappingBuilder
         this.immediateParent,
         protocol,
         this.topParent,
+        this.context,
       ),
     );
     const relationalPropertyMapping = new RelationalPropertyMapping(
@@ -728,6 +749,7 @@ export class V1_PropertyMappingBuilder
           TEMPORARY__getClassMappingByIdOrReturnUnresolved(
             parentMapping,
             protocol.target,
+            this.context,
           );
       } else {
         targetSetImplementation = getClassMappingsByClass(
@@ -741,6 +763,7 @@ export class V1_PropertyMappingBuilder
         this.immediateParent,
         protocol,
         this.topParent,
+        this.context,
       ),
     );
     const flatDataAssociationPropertyMapping =
@@ -838,6 +861,7 @@ export class V1_PropertyMappingBuilder
       TEMPORARY__getClassMappingByIdOrReturnUnresolved(
         topParent._PARENT,
         protocol.setImplementationId,
+        this.context,
       );
     return inline;
   }

package/src/graphManager/protocol/pure/v1/transformation/pureGraph/to/helpers/V1_ValueSpecificationBuilderHelper.ts

@@ -106,8 +106,8 @@ import type { V1_RuntimeInstance } from '../../../../model/valueSpecification/ra
 import type { V1_SerializationConfig } from '../../../../model/valueSpecification/raw/V1_SerializationConfig.js';
 import type { V1_TDSAggregateValue } from '../../../../model/valueSpecification/raw/V1_TDSAggregateValue.js';
 import type { V1_TDSColumnInformation } from '../../../../model/valueSpecification/raw/V1_TDSColumnInformation.js';
-import type { V1_TdsOlapAggregation } from '../../../../model/valueSpecification/raw/V1_TdsOlapAggregation.js';
-import type { V1_TdsOlapRank } from '../../../../model/valueSpecification/raw/V1_TdsOlapRank.js';
+import type { V1_TDSOlapAggregation } from '../../../../model/valueSpecification/raw/V1_TDSOlapAggregation_.js';
+import type { V1_TDSOlapRank } from '../../../../model/valueSpecification/raw/V1_TDSOlapRank_.js';
 import type { V1_TDSSortInformation } from '../../../../model/valueSpecification/raw/V1_TDSSortInformation.js';
 import type { V1_UnitInstance } from '../../../../model/valueSpecification/raw/V1_UnitInstance.js';
 import type { V1_UnitType } from '../../../../model/valueSpecification/raw/V1_UnitType.js';
@@ -584,12 +584,12 @@ export class V1_ValueSpecificationBuilder
     throw new UnsupportedOperationError();
   }
 
-  visit_TdsOlapRank(valueSpecification: V1_TdsOlapRank): ValueSpecification {
+  visit_TDSOlapRank(valueSpecification: V1_TDSOlapRank): ValueSpecification {
     throw new UnsupportedOperationError();
   }
 
-  visit_TdsOlapAggregation(
-    valueSpecification: V1_TdsOlapAggregation,
+  visit_TDSOlapAggregation(
+    valueSpecification: V1_TDSOlapAggregation,
   ): ValueSpecification {
     throw new UnsupportedOperationError();
   }

package/src/graphManager/protocol/pure/v1/transformation/pureGraph/to/helpers/V1_ValueSpecificationPathResolver.ts

@@ -55,8 +55,8 @@ import type { V1_RuntimeInstance } from '../../../../model/valueSpecification/ra
 import type { V1_SerializationConfig } from '../../../../model/valueSpecification/raw/V1_SerializationConfig.js';
 import type { V1_TDSAggregateValue } from '../../../../model/valueSpecification/raw/V1_TDSAggregateValue.js';
 import type { V1_TDSColumnInformation } from '../../../../model/valueSpecification/raw/V1_TDSColumnInformation.js';
-import type { V1_TdsOlapAggregation } from '../../../../model/valueSpecification/raw/V1_TdsOlapAggregation.js';
-import type { V1_TdsOlapRank } from '../../../../model/valueSpecification/raw/V1_TdsOlapRank.js';
+import type { V1_TDSOlapAggregation } from '../../../../model/valueSpecification/raw/V1_TDSOlapAggregation_.js';
+import type { V1_TDSOlapRank } from '../../../../model/valueSpecification/raw/V1_TDSOlapRank_.js';
 import type { V1_TDSSortInformation } from '../../../../model/valueSpecification/raw/V1_TDSSortInformation.js';
 import type { V1_UnitInstance } from '../../../../model/valueSpecification/raw/V1_UnitInstance.js';
 import type { V1_UnitType } from '../../../../model/valueSpecification/raw/V1_UnitType.js';
@@ -310,11 +310,11 @@ class V1_ValueSpecificationPathResolver
   visit_TDSSortInformation(spec: V1_TDSSortInformation): V1_ValueSpecification {
     return spec;
   }
-  visit_TdsOlapRank(spec: V1_TdsOlapRank): V1_ValueSpecification {
+  visit_TDSOlapRank(spec: V1_TDSOlapRank): V1_ValueSpecification {
     spec.function.accept_ValueSpecificationVisitor(this);
     return spec;
   }
-  visit_TdsOlapAggregation(spec: V1_TdsOlapAggregation): V1_ValueSpecification {
+  visit_TDSOlapAggregation(spec: V1_TDSOlapAggregation): V1_ValueSpecification {
     spec.function.accept_ValueSpecificationVisitor(this);
     return spec;
   }

package/src/graphManager/protocol/pure/v1/transformation/pureProtocol/serializationHelpers/V1_ValueSpecificationSerializer.ts

@@ -60,8 +60,8 @@ import { V1_PureList } from '../../../model/valueSpecification/raw/V1_PureList.j
 import { V1_TDSAggregateValue } from '../../../model/valueSpecification/raw/V1_TDSAggregateValue.js';
 import { V1_TDSColumnInformation } from '../../../model/valueSpecification/raw/V1_TDSColumnInformation.js';
 import { V1_TDSSortInformation } from '../../../model/valueSpecification/raw/V1_TDSSortInformation.js';
-import { V1_TdsOlapRank } from '../../../model/valueSpecification/raw/V1_TdsOlapRank.js';
-import { V1_TdsOlapAggregation } from '../../../model/valueSpecification/raw/V1_TdsOlapAggregation.js';
+import { V1_TDSOlapRank } from '../../../model/valueSpecification/raw/V1_TDSOlapRank_.js';
+import { V1_TDSOlapAggregation } from '../../../model/valueSpecification/raw/V1_TDSOlapAggregation_.js';
 import { V1_multiplicitySchema } from './V1_CoreSerializationHelper.js';
 import type {
   V1_ValueSpecification,
@@ -479,12 +479,12 @@ const tdsSortInformationModelSchema = createModelSchema(V1_TDSSortInformation, {
   direction: primitive(),
 });
 
-const tdsOlapRankModelSchema = createModelSchema(V1_TdsOlapRank, {
+const tdsOlapRankModelSchema = createModelSchema(V1_TDSOlapRank, {
   _type: usingConstantValueSchema(V1_ValueSpecificationType.TDS_OLAP_RANK),
   function: usingModelSchema(lambdaModelSchema),
 });
 
-const tdsOlapAggregationModelSchema = createModelSchema(V1_TdsOlapAggregation, {
+const tdsOlapAggregationModelSchema = createModelSchema(V1_TDSOlapAggregation, {
   _type: usingConstantValueSchema(
     V1_ValueSpecificationType.TDS_OLAP_AGGREGATION,
   ),
@@ -666,13 +666,13 @@ class V1_ValueSpecificationSerializer
   ): PlainObject<V1_ValueSpecification> {
     return serialize(tdsSortInformationModelSchema, valueSpecification);
   }
-  visit_TdsOlapRank(
-    valueSpecification: V1_TdsOlapRank,
+  visit_TDSOlapRank(
+    valueSpecification: V1_TDSOlapRank,
   ): PlainObject<V1_ValueSpecification> {
     return serialize(tdsOlapRankModelSchema, valueSpecification);
   }
-  visit_TdsOlapAggregation(
-    valueSpecification: V1_TdsOlapAggregation,
+  visit_TDSOlapAggregation(
+    valueSpecification: V1_TDSOlapAggregation,
   ): PlainObject<V1_ValueSpecification> {
     return serialize(tdsOlapAggregationModelSchema, valueSpecification);
   }

package/src/index.ts

@@ -219,7 +219,7 @@ export * from './graphManager/DSL_Generation_PureGraphManagerPlugin_Extension.js
 export * from './graphManager/Testable_PureGraphManagerPlugin_Extension.js';
 export {
   ExecutionResult,
-  TdsExecutionResult,
+  TDSExecutionResult as TDSExecutionResult,
   RawExecutionResult,
   EXECUTION_SERIALIZATION_FORMAT,
 } from './graphManager/action/execution/ExecutionResult.js';
@@ -229,6 +229,9 @@ export * from './graphManager/PureGraphManagerPlugin.js';
 export * from './graphManager/action/query/Query.js';
 export * from './graphManager/action/query/QuerySearchSpecification.js';
 export * from './graphManager/action/EngineError.js';
+export * from './graphManager/action/compilation/CompilationWarning.js';
+export * from './graphManager/action/compilation/CompilationResult.js';
+
 export * from './graphManager/action/SourceInformationHelper.js';
 export * from './graphManager/action/generation/DatabaseBuilderInput.js';
 export * from './graphManager/action/generation/GenerationConfigurationDescription.js';

package/tsconfig.json

@@ -294,6 +294,8 @@
     "./src/graphManager/action/changeDetection/STO_Relational_ObserverHelper.ts",
     "./src/graphManager/action/changeDetection/Testable_ObserverHelper.ts",
     "./src/graphManager/action/changeDetection/ValueSpecificationObserver.ts",
+    "./src/graphManager/action/compilation/CompilationResult.ts",
+    "./src/graphManager/action/compilation/CompilationWarning.ts",
     "./src/graphManager/action/execution/ExecutionResult.ts",
     "./src/graphManager/action/execution/ExecutionResultHelper.ts",
     "./src/graphManager/action/externalFormat/ExternalFormatDescription.ts",
@@ -327,6 +329,8 @@
     "./src/graphManager/protocol/pure/v1/engine/V1_EngineServerClient.ts",
     "./src/graphManager/protocol/pure/v1/engine/analytics/V1_MappingModelCoverageAnalysis.ts",
     "./src/graphManager/protocol/pure/v1/engine/compilation/V1_CompilationError.ts",
+    "./src/graphManager/protocol/pure/v1/engine/compilation/V1_CompilationResult.ts",
+    "./src/graphManager/protocol/pure/v1/engine/compilation/V1_CompilationWarning.ts",
     "./src/graphManager/protocol/pure/v1/engine/compilation/V1_CompileResult.ts",
     "./src/graphManager/protocol/pure/v1/engine/compilation/V1_LambdaReturnTypeResult.ts",
     "./src/graphManager/protocol/pure/v1/engine/execution/V1_ExecuteInput.ts",
@@ -546,9 +550,9 @@
     "./src/graphManager/protocol/pure/v1/model/valueSpecification/raw/V1_SerializationConfig.ts",
     "./src/graphManager/protocol/pure/v1/model/valueSpecification/raw/V1_TDSAggregateValue.ts",
     "./src/graphManager/protocol/pure/v1/model/valueSpecification/raw/V1_TDSColumnInformation.ts",
+    "./src/graphManager/protocol/pure/v1/model/valueSpecification/raw/V1_TDSOlapAggregation_.ts",
+    "./src/graphManager/protocol/pure/v1/model/valueSpecification/raw/V1_TDSOlapRank_.ts",
     "./src/graphManager/protocol/pure/v1/model/valueSpecification/raw/V1_TDSSortInformation.ts",
-    "./src/graphManager/protocol/pure/v1/model/valueSpecification/raw/V1_TdsOlapAggregation.ts",
-    "./src/graphManager/protocol/pure/v1/model/valueSpecification/raw/V1_TdsOlapRank.ts",
     "./src/graphManager/protocol/pure/v1/model/valueSpecification/raw/V1_UnitInstance.ts",
     "./src/graphManager/protocol/pure/v1/model/valueSpecification/raw/V1_UnitType.ts",
     "./src/graphManager/protocol/pure/v1/model/valueSpecification/raw/executionContext/V1_AnalyticsExecutionContext.ts",

package/lib/graphManager/protocol/pure/v1/model/valueSpecification/raw/V1_TdsOlapAggregation.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"V1_TdsOlapAggregation.d.ts","sourceRoot":"","sources":["../../../../../../../../src/graphManager/protocol/pure/v1/model/valueSpecification/raw/V1_TdsOlapAggregation.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;GAcG;AAEH,OAAO,EACL,KAAK,4BAA4B,EACjC,qBAAqB,EACtB,MAAM,4DAA4D,CAAC;AACpE,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,gBAAgB,CAAC;AAEhD,qBAAa,qBAAsB,SAAQ,qBAAqB;IAC9D,QAAQ,EAAG,SAAS,CAAC;IACrB,UAAU,EAAG,MAAM,CAAC;IAEpB,gCAAgC,CAAC,CAAC,EAChC,OAAO,EAAE,4BAA4B,CAAC,CAAC,CAAC,GACvC,CAAC;CAGL"}

package/lib/graphManager/protocol/pure/v1/model/valueSpecification/raw/V1_TdsOlapAggregation.js.map

@@ -1 +0,0 @@
-{"version":3,"file":"V1_TdsOlapAggregation.js","sourceRoot":"","sources":["../../../../../../../../src/graphManager/protocol/pure/v1/model/valueSpecification/raw/V1_TdsOlapAggregation.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;GAcG;AAEH,OAAO,EAEL,qBAAqB,GACtB,MAAM,4DAA4D,CAAC;AAGpE,MAAM,OAAO,qBAAsB,SAAQ,qBAAqB;IAC9D,QAAQ,CAAa;IACrB,UAAU,CAAU;IAEpB,gCAAgC,CAC9B,OAAwC;QAExC,OAAO,OAAO,CAAC,wBAAwB,CAAC,IAAI,CAAC,CAAC;IAChD,CAAC;CACF"}

package/lib/graphManager/protocol/pure/v1/model/valueSpecification/raw/V1_TdsOlapRank.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"V1_TdsOlapRank.d.ts","sourceRoot":"","sources":["../../../../../../../../src/graphManager/protocol/pure/v1/model/valueSpecification/raw/V1_TdsOlapRank.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;GAcG;AAEH,OAAO,EACL,KAAK,4BAA4B,EACjC,qBAAqB,EACtB,MAAM,4DAA4D,CAAC;AACpE,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,gBAAgB,CAAC;AAEhD,qBAAa,cAAe,SAAQ,qBAAqB;IACvD,QAAQ,EAAG,SAAS,CAAC;IAErB,gCAAgC,CAAC,CAAC,EAChC,OAAO,EAAE,4BAA4B,CAAC,CAAC,CAAC,GACvC,CAAC;CAGL"}

package/lib/graphManager/protocol/pure/v1/model/valueSpecification/raw/V1_TdsOlapRank.js.map

@@ -1 +0,0 @@
-{"version":3,"file":"V1_TdsOlapRank.js","sourceRoot":"","sources":["../../../../../../../../src/graphManager/protocol/pure/v1/model/valueSpecification/raw/V1_TdsOlapRank.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;GAcG;AAEH,OAAO,EAEL,qBAAqB,GACtB,MAAM,4DAA4D,CAAC;AAGpE,MAAM,OAAO,cAAe,SAAQ,qBAAqB;IACvD,QAAQ,CAAa;IAErB,gCAAgC,CAC9B,OAAwC;QAExC,OAAO,OAAO,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAC;IACzC,CAAC;CACF"}