@finos/legend-graph 19.0.0 → 19.2.0

package/src/graphManager/protocol/pure/v1/engine/V1_Engine.ts

@@ -92,6 +92,11 @@ import {
   V1_MappingModelCoverageAnalysisResult,
 } from './analytics/V1_MappingModelCoverageAnalysis.js';
 import type { ServiceExecutionMode } from '../../../../action/service/ServiceExecutionMode.js';
+import type {
+  V1_CompilationResult,
+  V1_TextCompilationResult,
+} from './compilation/V1_CompilationResult.js';
+import { V1_CompilationWarning } from './compilation/V1_CompilationWarning.js';
 
 class V1_EngineConfig extends TEMPORARY__AbstractEngineConfig {
   private engine: V1_Engine;
@@ -365,11 +370,20 @@ export class V1_Engine {
   async compilePureModelContextData(
     model: V1_PureModelContextData,
     options?: { onError?: (() => void) | undefined } | undefined,
-  ): Promise<void> {
+  ): Promise<V1_CompilationResult> {
     try {
-      await this.engineServerClient.compile(
+      const compilationResult = await this.engineServerClient.compile(
         this.serializePureModelContextData(model),
       );
+      return {
+        warnings: (
+          compilationResult.warnings as
+            | PlainObject<V1_CompilationWarning>[]
+            | undefined
+        )?.map((warning) =>
+          V1_CompilationWarning.serialization.fromJson(warning),
+        ),
+      };
     } catch (error) {
       assertErrorThrown(error);
       options?.onError?.();
@@ -390,8 +404,8 @@ export class V1_Engine {
   async compileText(
     graphText: string,
     compileContext?: V1_PureModelContextData,
-    options?: { onError?: () => void },
-  ): Promise<V1_PureModelContextData> {
+    options?: { onError?: () => void; getCompilationWarnings?: boolean },
+  ): Promise<V1_TextCompilationResult> {
     const mainGraph = await this.pureCodeToPureModelContextDataJSON(graphText, {
       ...options,
       // NOTE: we need to return source information here so we can locate the compilation
@@ -407,7 +421,20 @@ export class V1_Engine {
       : mainGraph;
     try {
       await this.engineServerClient.compile(pureModelContextDataJson);
-      return V1_deserializePureModelContextData(mainGraph);
+      const model = V1_deserializePureModelContextData(mainGraph);
+      const compilationResult = await this.engineServerClient.compile(
+        pureModelContextDataJson,
+      );
+      return {
+        model,
+        warnings: (
+          compilationResult.warnings as
+            | PlainObject<V1_CompilationWarning>[]
+            | undefined
+        )?.map((warning) =>
+          V1_CompilationWarning.serialization.fromJson(warning),
+        ),
+      };
     } catch (error) {
       assertErrorThrown(error);
       options?.onError?.();

package/src/graphManager/protocol/pure/v1/engine/compilation/V1_CompilationResult.ts

@@ -0,0 +1,26 @@
+/**
+ * Copyright (c) 2020-present, Goldman Sachs
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import type { V1_PureModelContextData } from '../../model/context/V1_PureModelContextData.js';
+import type { V1_CompilationWarning } from './V1_CompilationWarning.js';
+
+export interface V1_CompilationResult {
+  warnings: V1_CompilationWarning[] | undefined;
+}
+
+export interface V1_TextCompilationResult extends V1_CompilationResult {
+  model: V1_PureModelContextData;
+}

package/src/graphManager/protocol/pure/v1/engine/compilation/V1_CompilationWarning.ts

@@ -0,0 +1,34 @@
+/**
+ * Copyright (c) 2020-present, Goldman Sachs
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { createModelSchema, primitive } from 'serializr';
+import { SerializationFactory, usingModelSchema } from '@finos/legend-shared';
+import { V1_sourceInformationSerialization } from '../../transformation/pureProtocol/serializationHelpers/V1_CoreSerializationHelper.js';
+import type { V1_SourceInformation } from '../../model/V1_SourceInformation.js';
+
+export class V1_CompilationWarning {
+  message = '';
+  sourceInformation?: V1_SourceInformation | undefined;
+
+  static readonly serialization = new SerializationFactory(
+    createModelSchema(V1_CompilationWarning, {
+      message: primitive(),
+      sourceInformation: usingModelSchema(
+        V1_sourceInformationSerialization.schema,
+      ),
+    }),
+  );
+}

package/src/graphManager/protocol/pure/v1/engine/compilation/V1_CompileResult.ts

@@ -14,6 +14,8 @@
  * limitations under the License.
  */
 
+import type { V1_CompilationWarning } from './V1_CompilationWarning.js';
+
 /**
  * NOTE: technically, this endpoint should be returning 204 (No Content), and 400 (Bad Request) when there are
  * compilation errors but for backward compatibility, we have to resort to return something, i.e. 200 (OK) with
@@ -22,4 +24,7 @@
  * On the other hand, we might want to keep this around since compilation API might change in the future to return
  * some state or meaningful results.
  */
-export type V1_CompileResult = { message: string };
+export type V1_CompileResult = {
+  message: string;
+  warnings?: V1_CompilationWarning[] | undefined;
+};

package/src/graphManager/protocol/pure/v1/engine/execution/V1_ExecutionHelper.ts

@@ -20,22 +20,22 @@ import {
 } from '@finos/legend-shared';
 import {
   type ExecutionResult,
-  TdsRow,
+  TDSRow,
   INTERNAL__UnknownExecutionResult,
   ClassExecutionResult,
   JsonExecutionResult,
-  TdsExecutionResult,
-  TdsBuilder,
+  TDSExecutionResult,
+  TDSBuilder,
   TDSColumn,
   RawExecutionResult,
 } from '../../../../../../graphManager/action/execution/ExecutionResult.js';
 import {
   type V1_ExecutionResult,
-  type V1_TdsBuilder,
+  type V1_TDSBuilder,
   V1_ClassExecutionResult,
   V1_JsonExecutionResult,
   V1_INTERNAL__UnknownExecutionResult,
-  V1_TdsExecutionResult,
+  V1_TDSExecutionResult,
   V1_RawExecutionResult,
 } from './V1_ExecutionResult.js';
 
@@ -50,8 +50,8 @@ const buildJSONExecutionResult = (
   return metamodel;
 };
 
-const buildTDSBuilder = (protocol: V1_TdsBuilder): TdsBuilder => {
-  const builder = new TdsBuilder();
+const buildTDSBuilder = (protocol: V1_TDSBuilder): TDSBuilder => {
+  const builder = new TDSBuilder();
   builder.columns = protocol.columns.map((_column) => {
     const column = new TDSColumn();
     column.name = guaranteeNonNullable(
@@ -67,9 +67,9 @@ const buildTDSBuilder = (protocol: V1_TdsBuilder): TdsBuilder => {
 };
 
 const buildTDSExecutionResult = (
-  protocol: V1_TdsExecutionResult,
-): TdsExecutionResult => {
-  const metamodel = new TdsExecutionResult();
+  protocol: V1_TDSExecutionResult,
+): TDSExecutionResult => {
+  const metamodel = new TDSExecutionResult();
   metamodel.builder = buildTDSBuilder(
     guaranteeNonNullable(
       protocol.builder,
@@ -87,7 +87,7 @@ const buildTDSExecutionResult = (
       rows: { values: (string | number)[] }[];
     }
   ).rows.map((_row) => {
-    const row = new TdsRow();
+    const row = new TDSRow();
     row.values = _row.values;
     return row;
   });
@@ -111,7 +111,7 @@ export const V1_buildExecutionResult = (
 ): ExecutionResult => {
   if (protocol instanceof V1_ClassExecutionResult) {
     return buildClassExecutionResult(protocol);
-  } else if (protocol instanceof V1_TdsExecutionResult) {
+  } else if (protocol instanceof V1_TDSExecutionResult) {
     return buildTDSExecutionResult(protocol);
   } else if (protocol instanceof V1_JsonExecutionResult) {
     return buildJSONExecutionResult(protocol);

package/src/graphManager/protocol/pure/v1/engine/execution/V1_ExecutionResult.ts

@@ -64,25 +64,25 @@ export class V1_TDSColumn {
   );
 }
 
-export class V1_TdsBuilder extends V1_ResultBuilder {
+export class V1_TDSBuilder extends V1_ResultBuilder {
   columns: V1_TDSColumn[] = [];
 
   static readonly serialization = new SerializationFactory(
-    createModelSchema(V1_TdsBuilder, {
+    createModelSchema(V1_TDSBuilder, {
       _type: primitive(),
       columns: list(usingModelSchema(V1_TDSColumn.serialization.schema)),
     }),
   );
 }
 
-export class V1_TdsExecutionResult extends V1_ExecutionResult {
-  declare builder: V1_TdsBuilder;
+export class V1_TDSExecutionResult extends V1_ExecutionResult {
+  declare builder: V1_TDSBuilder;
   result!: object;
 
   static readonly serialization = new SerializationFactory(
-    createModelSchema(V1_TdsExecutionResult, {
+    createModelSchema(V1_TDSExecutionResult, {
       _type: primitive(),
-      builder: usingModelSchema(V1_TdsBuilder.serialization.schema),
+      builder: usingModelSchema(V1_TDSBuilder.serialization.schema),
       activities: raw(),
       result: raw(),
     }),
@@ -130,7 +130,7 @@ export const V1_serializeExecutionResult = (
     case BuilderType.CLASS_BUILDER:
       return V1_ClassExecutionResult.serialization.fromJson(value);
     case BuilderType.TDS_BUILDER:
-      return V1_TdsExecutionResult.serialization.fromJson(value);
+      return V1_TDSExecutionResult.serialization.fromJson(value);
     case BuilderType.JSON_BUILDER:
       return V1_JsonExecutionResult.serialization.fromJson(value);
     default:

package/src/graphManager/protocol/pure/v1/helpers/V1_DomainHelper.ts

@@ -22,7 +22,9 @@ import type { V1_Multiplicity } from '../model/packageableElements/domain/V1_Mul
 import type { V1_ConcreteFunctionDefinition } from '../model/packageableElements/function/V1_ConcreteFunctionDefinition.js';
 import type { V1_RawVariable } from '../model/rawValueSpecification/V1_RawVariable.js';
 
-const V1_getMultiplicitySuffix = (multiplicity: V1_Multiplicity): string => {
+const V1_buildFunctionMultiplicitySignature = (
+  multiplicity: V1_Multiplicity,
+): string => {
   if (multiplicity.lowerBound === multiplicity.upperBound) {
     return multiplicity.lowerBound.toString();
   } else if (
@@ -36,16 +38,20 @@ const V1_getMultiplicitySuffix = (multiplicity: V1_Multiplicity): string => {
   }$`;
 };
 
-const V1_getVariableSuffix = (variable: V1_RawVariable): string =>
+const V1_buildFunctionParameterSignature = (variable: V1_RawVariable): string =>
   `${variable.class
     .split(ELEMENT_PATH_DELIMITER)
-    .pop()}_${V1_getMultiplicitySuffix(variable.multiplicity)}_`;
+    .pop()}_${V1_buildFunctionMultiplicitySignature(variable.multiplicity)}_`;
 
-export const V1_getFunctionSuffix = (
-  fn: V1_ConcreteFunctionDefinition,
-): string =>
-  `${fn.parameters
-    .map((p) => V1_getVariableSuffix(p))
-    .join('_')}_${fn.returnType
+export const V1_buildFunctionSignature = (
+  func: V1_ConcreteFunctionDefinition,
+): string => {
+  const functionSignature = `_${func.parameters
+    .map((p) => V1_buildFunctionParameterSignature(p))
+    .join('_')}_${func.returnType
     .split(ELEMENT_PATH_DELIMITER)
-    .pop()}_${V1_getMultiplicitySuffix(fn.returnMultiplicity)}_`;
+    .pop()}_${V1_buildFunctionMultiplicitySignature(func.returnMultiplicity)}_`;
+  return func.name.endsWith(functionSignature)
+    ? func.name
+    : func.name + functionSignature;
+};

package/src/graphManager/protocol/pure/v1/model/valueSpecification/V1_ValueSpecification.ts

@@ -44,8 +44,8 @@ import type { V1_PureList } from '../../model/valueSpecification/raw/V1_PureList
 import type { V1_TDSAggregateValue } from '../../model/valueSpecification/raw/V1_TDSAggregateValue.js';
 import type { V1_TDSColumnInformation } from '../../model/valueSpecification/raw/V1_TDSColumnInformation.js';
 import type { V1_TDSSortInformation } from '../../model/valueSpecification/raw/V1_TDSSortInformation.js';
-import type { V1_TdsOlapRank } from '../../model/valueSpecification/raw/V1_TdsOlapRank.js';
-import type { V1_TdsOlapAggregation } from '../../model/valueSpecification/raw/V1_TdsOlapAggregation.js';
+import type { V1_TDSOlapRank } from './raw/V1_TDSOlapRank_.js';
+import type { V1_TDSOlapAggregation } from './raw/V1_TDSOlapAggregation_.js';
 import type { V1_AppliedProperty } from './application/V1_AppliedProperty.js';
 import type { V1_PackageableElementPtr } from './raw/V1_PackageableElementPtr.js';
 import type { V1_HackedClass } from './raw/V1_HackedClass.js';
@@ -95,8 +95,8 @@ export interface V1_ValueSpecificationVisitor<T> {
   visit_TDSAggregateValue(valueSpecification: V1_TDSAggregateValue): T;
   visit_TDSColumnInformation(valueSpecification: V1_TDSColumnInformation): T;
   visit_TDSSortInformation(valueSpecification: V1_TDSSortInformation): T;
-  visit_TdsOlapRank(valueSpecification: V1_TdsOlapRank): T;
-  visit_TdsOlapAggregation(valueSpecification: V1_TdsOlapAggregation): T;
+  visit_TDSOlapRank(valueSpecification: V1_TDSOlapRank): T;
+  visit_TDSOlapAggregation(valueSpecification: V1_TDSOlapAggregation): T;
 
   visit_INTERNAL__UnknownValueSpecfication(
     valueSpecification: V1_INTERNAL__UnknownValueSpecification,

package/src/graphManager/protocol/pure/v1/model/valueSpecification/raw/{V1_TdsOlapAggregation.ts → V1_TDSOlapAggregation_.ts}

@@ -17,16 +17,16 @@
 import {
   type V1_ValueSpecificationVisitor,
   V1_ValueSpecification,
-} from '../../../model/valueSpecification/V1_ValueSpecification.js';
+} from '../V1_ValueSpecification.js';
 import type { V1_Lambda } from './V1_Lambda.js';
 
-export class V1_TdsOlapAggregation extends V1_ValueSpecification {
+export class V1_TDSOlapAggregation extends V1_ValueSpecification {
   function!: V1_Lambda;
   columnName!: string;
 
   accept_ValueSpecificationVisitor<T>(
     visitor: V1_ValueSpecificationVisitor<T>,
   ): T {
-    return visitor.visit_TdsOlapAggregation(this);
+    return visitor.visit_TDSOlapAggregation(this);
   }
 }

package/src/graphManager/protocol/pure/v1/model/valueSpecification/raw/{V1_TdsOlapRank.ts → V1_TDSOlapRank_.ts}

@@ -17,15 +17,15 @@
 import {
   type V1_ValueSpecificationVisitor,
   V1_ValueSpecification,
-} from '../../../model/valueSpecification/V1_ValueSpecification.js';
+} from '../V1_ValueSpecification.js';
 import type { V1_Lambda } from './V1_Lambda.js';
 
-export class V1_TdsOlapRank extends V1_ValueSpecification {
+export class V1_TDSOlapRank extends V1_ValueSpecification {
   function!: V1_Lambda;
 
   accept_ValueSpecificationVisitor<T>(
     visitor: V1_ValueSpecificationVisitor<T>,
   ): T {
-    return visitor.visit_TdsOlapRank(this);
+    return visitor.visit_TDSOlapRank(this);
   }
 }

package/src/graphManager/protocol/pure/v1/transformation/pureGraph/to/V1_ElementFirstPassBuilder.ts

@@ -67,6 +67,7 @@ import { V1_checkDuplicatedElement } from './V1_ElementBuilder.js';
 import type { Package } from '../../../../../../../graph/metamodel/pure/packageableElements/domain/Package.js';
 import type { V1_DataElement } from '../../../model/packageableElements/data/V1_DataElement.js';
 import { DataElement } from '../../../../../../../graph/metamodel/pure/packageableElements/data/DataElement.js';
+import { V1_buildFunctionSignature } from '../../../helpers/V1_DomainHelper.js';
 
 export class V1_ElementFirstPassBuilder
   implements V1_PackageableElementVisitor<PackageableElement>
@@ -243,8 +244,9 @@ export class V1_ElementFirstPassBuilder
       element.name,
       `Function 'name' field is missing or empty`,
     );
+    const name = V1_buildFunctionSignature(element);
     const func = new ConcreteFunctionDefinition(
-      element.name,
+      name,
       // This is just a stub to fill in when we first create the function
       PackageableElementImplicitReference.create(
         this.context.graph.getPrimitiveType(PRIMITIVE_TYPE.STRING),
@@ -254,7 +256,7 @@ export class V1_ElementFirstPassBuilder
         TYPICAL_MULTIPLICITY_TYPE.ZEROMANY,
       ),
     );
-    const path = V1_buildFullPath(element.package, element.name);
+    const path = V1_buildFullPath(element.package, name);
     V1_checkDuplicatedElement(path, this.context, this.elementPathCache);
     addElementToPackage(
       getOrCreateGraphPackage(

package/src/graphManager/protocol/pure/v1/transformation/pureGraph/to/V1_ElementSecondPassBuilder.ts

@@ -83,6 +83,9 @@ import { V1_buildTestSuite } from './helpers/V1_TestBuilderHelper.js';
 import { ServiceTestSuite } from '../../../../../../../graph/metamodel/pure/packageableElements/service/ServiceTestSuite.js';
 import { V1_getIncludedMappingPath } from '../../../helpers/V1_DSL_Mapping_Helper.js';
 import { V1_DataElementReference } from '../../../model/data/V1_EmbeddedData.js';
+import { V1_buildFunctionSignature } from '../../../helpers/V1_DomainHelper.js';
+import { getFunctionName } from '../../../../../../../graph/helpers/DomainHelper.js';
+import { GraphBuilderError } from '../../../../../../GraphManagerUtils.js';
 
 export class V1_ElementSecondPassBuilder
   implements V1_PackageableElementVisitor<void>
@@ -106,18 +109,17 @@ export class V1_ElementSecondPassBuilder
     const uniqueStereotypes = new Set<string>();
     profile.p_stereotypes = element.stereotypes.map((stereotype) => {
       if (uniqueStereotypes.has(stereotype)) {
+        const message = `Found duplicated stereotype '${stereotype}' in profile '${element.path}'`;
         /**
-         * This test is skipped because we want to temporarily relax graph building algorithm
-         * to ease Pure -> Legend migration push.
-         * See https://github.com/finos/legend-studio/issues/660
+         * In strict-mode, graph builder will consider this as an error
+         * See https://github.com/finos/legend-studio/issues/941
          *
          * @discrepancy graph-building
          */
-        this.context.log.warn(
-          LogEvent.create(
-            `Found duplicated stereotype '${stereotype}' in profile '${element.path}'`,
-          ),
-        );
+        if (this.context.options?.strict) {
+          throw new GraphBuilderError(message);
+        }
+        this.context.log.warn(LogEvent.create(message));
       }
       uniqueStereotypes.add(stereotype);
       return new Stereotype(profile, stereotype);
@@ -125,18 +127,17 @@ export class V1_ElementSecondPassBuilder
     const uniqueTags = new Set<string>();
     profile.p_tags = element.tags.map((tag) => {
       if (uniqueTags.has(tag)) {
+        const message = `Found duplicated tag '${tag}' in profile '${element.path}'`;
         /**
-         * This test is skipped because we want to temporarily relax graph building algorithm
-         * to ease Pure -> Legend migration push.
-         * See https://github.com/finos/legend-studio/issues/660
+         * In strict-mode, graph builder will consider this as an error
+         * See https://github.com/finos/legend-studio/issues/941
          *
          * @discrepancy graph-building
          */
-        this.context.log.warn(
-          LogEvent.create(
-            `Found duplicated tag '${tag}' in profile '${element.path}'`,
-          ),
-        );
+        if (this.context.options?.strict) {
+          throw new GraphBuilderError(message);
+        }
+        this.context.log.warn(LogEvent.create(message));
       }
       uniqueTags.add(tag);
       return new Tag(profile, tag);
@@ -160,18 +161,17 @@ export class V1_ElementSecondPassBuilder
         `Enum value 'value' field is missing or empty`,
       );
       if (uniqueEnumValues.has(enumValue.value)) {
+        const message = `Found duplicated value '${enumValue.value}' in enumeration '${enumeration.path}'`;
         /**
-         * This test is skipped because we want to temporarily relax graph building algorithm
-         * to ease Pure -> Legend migration push.
-         * See https://github.com/finos/legend-studio/issues/660
+         * In strict-mode, graph builder will consider this as an error
+         * See https://github.com/finos/legend-studio/issues/941
          *
          * @discrepancy graph-building
          */
-        this.context.log.warn(
-          LogEvent.create(
-            `Found duplicated value '${enumValue.value}' in enumeration '${enumeration.path}'`,
-          ),
-        );
+        if (this.context.options?.strict) {
+          throw new GraphBuilderError(message);
+        }
+        this.context.log.warn(LogEvent.create(message));
       }
       const _enum = new Enum(enumValue.value, enumeration);
       _enum.stereotypes = enumValue.stereotypes
@@ -234,7 +234,7 @@ export class V1_ElementSecondPassBuilder
       `Function 'returnMultiplicity' field is missing`,
     );
     const func = this.context.currentSubGraph.getOwnFunction(
-      V1_buildFullPath(protocol.package, protocol.name),
+      V1_buildFullPath(protocol.package, V1_buildFunctionSignature(protocol)),
     );
     func.returnType = this.context.resolveType(protocol.returnType);
     func.returnMultiplicity = this.context.graph.getMultiplicity(
@@ -251,6 +251,7 @@ export class V1_ElementSecondPassBuilder
       V1_buildVariable(param, this.context),
     );
     func.expressionSequence = protocol.body;
+    func.functionName = getFunctionName(func, func.name);
   }
 
   visit_FlatData(element: V1_FlatData): void {

package/src/graphManager/protocol/pure/v1/transformation/pureGraph/to/V1_ElementThirdPassBuilder.ts

@@ -118,18 +118,17 @@ export class V1_ElementThirdPassBuilder
     const uniqueProperties = new Set<string>();
     element.properties.forEach((property) => {
       if (uniqueProperties.has(property.name)) {
+        const message = `Found duplicated property '${property.name}' in class '${_class.path}'`;
         /**
-         * This test is skipped because we want to temporarily relax graph building algorithm
-         * to ease Pure -> Legend migration push.
-         * See https://github.com/finos/legend-studio/issues/660
+         * In strict-mode, graph builder will consider this as an error
+         * See https://github.com/finos/legend-studio/issues/941
          *
          * @discrepancy graph-building
          */
-        this.context.log.warn(
-          LogEvent.create(
-            `Found duplicated property '${property.name}' in class '${_class.path}'`,
-          ),
-        );
+        if (this.context.options?.strict) {
+          throw new GraphBuilderError(message);
+        }
+        this.context.log.warn(LogEvent.create(message));
       }
       _class.properties.push(V1_buildProperty(property, this.context, _class));
       uniqueProperties.add(property.name);
@@ -148,18 +147,17 @@ export class V1_ElementThirdPassBuilder
     const first = guaranteeNonNullable(element.properties[0]);
     const second = guaranteeNonNullable(element.properties[1]);
     if (first.name === second.name) {
+      const message = `Found duplicated property '${element.properties[0]?.name}' in association '${element.path}'`;
       /**
-       * This test is skipped because we want to temporarily relax graph building algorithm
-       * to ease Pure -> Legend migration push.
-       * See https://github.com/finos/legend-studio/issues/660
+       * In strict-mode, graph builder will consider this as an error
+       * See https://github.com/finos/legend-studio/issues/941
        *
        * @discrepancy graph-building
        */
-      this.context.log.warn(
-        LogEvent.create(
-          `Found duplicated property '${element.properties[0]?.name}' in association '${element.name}'`,
-        ),
-      );
+      if (this.context.options?.strict) {
+        throw new GraphBuilderError(message);
+      }
+      this.context.log.warn(LogEvent.create(message));
     }
     association.properties = [
       V1_buildAssociationProperty(first, second, this.context, association),