@finos/legend-graph 13.0.1 → 14.0.1

package/lib/graphManager/protocol/pure/v1/engine/execution/V1_ExecuteInput.d.ts

@@ -34,7 +34,7 @@ export declare class V1_ExecuteInput {
 }
 export declare class V1_TestDataGenerationExecutionInput extends V1_ExecuteInput {
     parameters: (string | number | boolean)[];
-    hashStrings: boolean;
+    hashValues: boolean;
     static readonly serialization: SerializationFactory<V1_TestDataGenerationExecutionInput>;
 }
 //# sourceMappingURL=V1_ExecuteInput.d.ts.map

package/lib/graphManager/protocol/pure/v1/engine/execution/V1_ExecuteInput.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"V1_ExecuteInput.d.ts","sourceRoot":"","sources":["../../../../../../../src/graphManager/protocol/pure/v1/engine/execution/V1_ExecuteInput.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;GAcG;AAWH,OAAO,EAAE,oBAAoB,EAAoB,MAAM,sBAAsB,CAAC;AAC9E,OAAO,EAAE,uBAAuB,EAAE,MAAM,gDAAgD,CAAC;AACzF,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,uDAAuD,CAAC;AACxF,OAAO,KAAK,EAAE,sBAAsB,EAAE,MAAM,6DAA6D,CAAC;AAC1G,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,mDAAmD,CAAC;AAOtF,qBAAa,eAAe;IAC1B,aAAa,EAAG,MAAM,CAAC;IACvB;;;;OAIG;IACH,QAAQ,EAAG,YAAY,CAAC;IACxB,OAAO,EAAG,MAAM,CAAC;IACjB,KAAK,EAAG,uBAAuB,CAAC;IAChC,OAAO,EAAG,UAAU,CAAC;IACrB,OAAO,EAAG,sBAAsB,CAAC;IAEjC,MAAM,CAAC,QAAQ,CAAC,aAAa,wCAY3B;CACH;AAED,qBAAa,mCAAoC,SAAQ,eAAe;IACtE,UAAU,EAAE,CAAC,MAAM,GAAG,MAAM,GAAG,OAAO,CAAC,EAAE,CAAM;IAC/C,WAAW,UAAS;IAEpB,gBAAyB,aAAa,4DAcpC;CACH"}
+{"version":3,"file":"V1_ExecuteInput.d.ts","sourceRoot":"","sources":["../../../../../../../src/graphManager/protocol/pure/v1/engine/execution/V1_ExecuteInput.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;GAcG;AAWH,OAAO,EAAE,oBAAoB,EAAoB,MAAM,sBAAsB,CAAC;AAC9E,OAAO,EAAE,uBAAuB,EAAE,MAAM,gDAAgD,CAAC;AACzF,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,uDAAuD,CAAC;AACxF,OAAO,KAAK,EAAE,sBAAsB,EAAE,MAAM,6DAA6D,CAAC;AAC1G,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,mDAAmD,CAAC;AAOtF,qBAAa,eAAe;IAC1B,aAAa,EAAG,MAAM,CAAC;IACvB;;;;OAIG;IACH,QAAQ,EAAG,YAAY,CAAC;IACxB,OAAO,EAAG,MAAM,CAAC;IACjB,KAAK,EAAG,uBAAuB,CAAC;IAChC,OAAO,EAAG,UAAU,CAAC;IACrB,OAAO,EAAG,sBAAsB,CAAC;IAEjC,MAAM,CAAC,QAAQ,CAAC,aAAa,wCAY3B;CACH;AAED,qBAAa,mCAAoC,SAAQ,eAAe;IACtE,UAAU,EAAE,CAAC,MAAM,GAAG,MAAM,GAAG,OAAO,CAAC,EAAE,CAAM;IAC/C,UAAU,UAAS;IAEnB,gBAAyB,aAAa,4DAcpC;CACH"}

package/lib/graphManager/protocol/pure/v1/engine/execution/V1_ExecuteInput.js

@@ -41,7 +41,7 @@ export class V1_ExecuteInput {
 }
 export class V1_TestDataGenerationExecutionInput extends V1_ExecuteInput {
     parameters = [];
-    hashStrings = false;
+    hashValues = false;
     static serialization = new SerializationFactory(createModelSchema(V1_TestDataGenerationExecutionInput, {
         clientVersion: optional(primitive()),
         function: usingModelSchema(V1_rawLambdaModelSchema),
@@ -49,7 +49,7 @@ export class V1_TestDataGenerationExecutionInput extends V1_ExecuteInput {
         model: object(V1_PureModelContextData),
         runtime: custom((val) => V1_serializeRuntime(val), () => SKIP),
         context: usingModelSchema(V1_rawBaseExecutionContextModelSchema),
-        hashStrings: primitive(),
+        hashValues: primitive(),
         parameters: list(primitive()),
     }));
 }

package/lib/graphManager/protocol/pure/v1/engine/execution/V1_ExecuteInput.js.map

@@ -1 +1 @@
-{"version":3,"file":"V1_ExecuteInput.js","sourceRoot":"","sources":["../../../../../../../src/graphManager/protocol/pure/v1/engine/execution/V1_ExecuteInput.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;GAcG;AAEH,OAAO,EACL,iBAAiB,EACjB,MAAM,EACN,IAAI,EACJ,MAAM,EACN,QAAQ,EACR,SAAS,EACT,IAAI,GACL,MAAM,WAAW,CAAC;AACnB,OAAO,EAAE,oBAAoB,EAAE,gBAAgB,EAAE,MAAM,sBAAsB,CAAC;AAC9E,OAAO,EAAE,uBAAuB,EAAE,MAAM,gDAAgD,CAAC;AAIzF,OAAO,EAAE,mBAAmB,EAAE,MAAM,yFAAyF,CAAC;AAC9H,OAAO,EACL,qCAAqC,EACrC,uBAAuB,GACxB,MAAM,uGAAuG,CAAC;AAE/G,MAAM,OAAO,eAAe;IAC1B,aAAa,CAAU;IACvB;;;;OAIG;IACH,QAAQ,CAAgB;IACxB,OAAO,CAAU;IACjB,KAAK,CAA2B;IAChC,OAAO,CAAc;IACrB,OAAO,CAA0B;IAEjC,MAAM,CAAU,aAAa,GAAG,IAAI,oBAAoB,CACtD,iBAAiB,CAAC,eAAe,EAAE;QACjC,aAAa,EAAE,QAAQ,CAAC,SAAS,EAAE,CAAC;QACpC,QAAQ,EAAE,gBAAgB,CAAC,uBAAuB,CAAC;QACnD,OAAO,EAAE,SAAS,EAAE;QACpB,KAAK,EAAE,MAAM,CAAC,uBAAuB,CAAC;QACtC,OAAO,EAAE,MAAM,CACb,CAAC,GAAG,EAAE,EAAE,CAAC,mBAAmB,CAAC,GAAG,CAAC,EACjC,GAAG,EAAE,CAAC,IAAI,CACX;QACD,OAAO,EAAE,gBAAgB,CAAC,qCAAqC,CAAC;KACjE,CAAC,CACH,CAAC;;AAGJ,MAAM,OAAO,mCAAoC,SAAQ,eAAe;IACtE,UAAU,GAAkC,EAAE,CAAC;IAC/C,WAAW,GAAG,KAAK,CAAC;IAEpB,MAAM,CAAmB,aAAa,GAAG,IAAI,oBAAoB,CAC/D,iBAAiB,CAAC,mCAAmC,EAAE;QACrD,aAAa,EAAE,QAAQ,CAAC,SAAS,EAAE,CAAC;QACpC,QAAQ,EAAE,gBAAgB,CAAC,uBAAuB,CAAC;QACnD,OAAO,EAAE,SAAS,EAAE;QACpB,KAAK,EAAE,MAAM,CAAC,uBAAuB,CAAC;QACtC,OAAO,EAAE,MAAM,CACb,CAAC,GAAG,EAAE,EAAE,CAAC,mBAAmB,CAAC,GAAG,CAAC,EACjC,GAAG,EAAE,CAAC,IAAI,CACX;QACD,OAAO,EAAE,gBAAgB,CAAC,qCAAqC,CAAC;QAChE,WAAW,EAAE,SAAS,EAAE;QACxB,UAAU,EAAE,IAAI,CAAC,SAAS,EAAE,CAAC;KAC9B,CAAC,CACH,CAAC"}
+{"version":3,"file":"V1_ExecuteInput.js","sourceRoot":"","sources":["../../../../../../../src/graphManager/protocol/pure/v1/engine/execution/V1_ExecuteInput.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;GAcG;AAEH,OAAO,EACL,iBAAiB,EACjB,MAAM,EACN,IAAI,EACJ,MAAM,EACN,QAAQ,EACR,SAAS,EACT,IAAI,GACL,MAAM,WAAW,CAAC;AACnB,OAAO,EAAE,oBAAoB,EAAE,gBAAgB,EAAE,MAAM,sBAAsB,CAAC;AAC9E,OAAO,EAAE,uBAAuB,EAAE,MAAM,gDAAgD,CAAC;AAIzF,OAAO,EAAE,mBAAmB,EAAE,MAAM,yFAAyF,CAAC;AAC9H,OAAO,EACL,qCAAqC,EACrC,uBAAuB,GACxB,MAAM,uGAAuG,CAAC;AAE/G,MAAM,OAAO,eAAe;IAC1B,aAAa,CAAU;IACvB;;;;OAIG;IACH,QAAQ,CAAgB;IACxB,OAAO,CAAU;IACjB,KAAK,CAA2B;IAChC,OAAO,CAAc;IACrB,OAAO,CAA0B;IAEjC,MAAM,CAAU,aAAa,GAAG,IAAI,oBAAoB,CACtD,iBAAiB,CAAC,eAAe,EAAE;QACjC,aAAa,EAAE,QAAQ,CAAC,SAAS,EAAE,CAAC;QACpC,QAAQ,EAAE,gBAAgB,CAAC,uBAAuB,CAAC;QACnD,OAAO,EAAE,SAAS,EAAE;QACpB,KAAK,EAAE,MAAM,CAAC,uBAAuB,CAAC;QACtC,OAAO,EAAE,MAAM,CACb,CAAC,GAAG,EAAE,EAAE,CAAC,mBAAmB,CAAC,GAAG,CAAC,EACjC,GAAG,EAAE,CAAC,IAAI,CACX;QACD,OAAO,EAAE,gBAAgB,CAAC,qCAAqC,CAAC;KACjE,CAAC,CACH,CAAC;;AAGJ,MAAM,OAAO,mCAAoC,SAAQ,eAAe;IACtE,UAAU,GAAkC,EAAE,CAAC;IAC/C,UAAU,GAAG,KAAK,CAAC;IAEnB,MAAM,CAAmB,aAAa,GAAG,IAAI,oBAAoB,CAC/D,iBAAiB,CAAC,mCAAmC,EAAE;QACrD,aAAa,EAAE,QAAQ,CAAC,SAAS,EAAE,CAAC;QACpC,QAAQ,EAAE,gBAAgB,CAAC,uBAAuB,CAAC;QACnD,OAAO,EAAE,SAAS,EAAE;QACpB,KAAK,EAAE,MAAM,CAAC,uBAAuB,CAAC;QACtC,OAAO,EAAE,MAAM,CACb,CAAC,GAAG,EAAE,EAAE,CAAC,mBAAmB,CAAC,GAAG,CAAC,EACjC,GAAG,EAAE,CAAC,IAAI,CACX;QACD,OAAO,EAAE,gBAAgB,CAAC,qCAAqC,CAAC;QAChE,UAAU,EAAE,SAAS,EAAE;QACvB,UAAU,EAAE,IAAI,CAAC,SAAS,EAAE,CAAC;KAC9B,CAAC,CACH,CAAC"}

package/lib/graphManager/protocol/pure/v1/model/packageableElements/store/flatData/model/V1_FlatDataProperty.d.ts

@@ -14,9 +14,11 @@
  * limitations under the License.
  */
 import { type Hashable } from '@finos/legend-shared';
+declare type V1_FlatDataPropertyValue = boolean | string | number;
 export declare class V1_FlatDataProperty implements Hashable {
     name: string;
-    value: (boolean | string | number)[];
+    value: V1_FlatDataPropertyValue[];
     get hashCode(): string;
 }
+export {};
 //# sourceMappingURL=V1_FlatDataProperty.d.ts.map

package/lib/graphManager/protocol/pure/v1/model/packageableElements/store/flatData/model/V1_FlatDataProperty.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"V1_FlatDataProperty.d.ts","sourceRoot":"","sources":["../../../../../../../../../../src/graphManager/protocol/pure/v1/model/packageableElements/store/flatData/model/V1_FlatDataProperty.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;GAcG;AAGH,OAAO,EAAE,KAAK,QAAQ,EAAa,MAAM,sBAAsB,CAAC;AAEhE,qBAAa,mBAAoB,YAAW,QAAQ;IAClD,IAAI,EAAG,MAAM,CAAC;IACd,KAAK,EAAG,CAAC,OAAO,GAAG,MAAM,GAAG,MAAM,CAAC,EAAE,CAAC;IAEtC,IAAI,QAAQ,IAAI,MAAM,CAMrB;CACF"}
+{"version":3,"file":"V1_FlatDataProperty.d.ts","sourceRoot":"","sources":["../../../../../../../../../../src/graphManager/protocol/pure/v1/model/packageableElements/store/flatData/model/V1_FlatDataProperty.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;GAcG;AAGH,OAAO,EAAE,KAAK,QAAQ,EAAa,MAAM,sBAAsB,CAAC;AAEhE,aAAK,wBAAwB,GAAG,OAAO,GAAG,MAAM,GAAG,MAAM,CAAC;AAE1D,qBAAa,mBAAoB,YAAW,QAAQ;IAClD,IAAI,EAAG,MAAM,CAAC;IACd,KAAK,EAAG,wBAAwB,EAAE,CAAC;IAEnC,IAAI,QAAQ,IAAI,MAAM,CAMrB;CACF"}

package/lib/graphManager/protocol/pure/v1/model/packageableElements/store/flatData/model/V1_FlatDataProperty.js.map

@@ -1 +1 @@
-{"version":3,"file":"V1_FlatDataProperty.js","sourceRoot":"","sources":["../../../../../../../../../../src/graphManager/protocol/pure/v1/model/packageableElements/store/flatData/model/V1_FlatDataProperty.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;GAcG;AAEH,OAAO,EAAE,mBAAmB,EAAE,MAAM,oDAAoD,CAAC;AACzF,OAAO,EAAiB,SAAS,EAAE,MAAM,sBAAsB,CAAC;AAEhE,MAAM,OAAO,mBAAmB;IAC9B,IAAI,CAAU;IACd,KAAK,CAAiC;IAEtC,IAAI,QAAQ;QACV,OAAO,SAAS,CAAC;YACf,mBAAmB,CAAC,kBAAkB;YACtC,IAAI,CAAC,IAAI;YACT,SAAS,CAAC,IAAI,CAAC,KAAK,CAAC;SACtB,CAAC,CAAC;IACL,CAAC;CACF"}
+{"version":3,"file":"V1_FlatDataProperty.js","sourceRoot":"","sources":["../../../../../../../../../../src/graphManager/protocol/pure/v1/model/packageableElements/store/flatData/model/V1_FlatDataProperty.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;GAcG;AAEH,OAAO,EAAE,mBAAmB,EAAE,MAAM,oDAAoD,CAAC;AACzF,OAAO,EAAiB,SAAS,EAAE,MAAM,sBAAsB,CAAC;AAIhE,MAAM,OAAO,mBAAmB;IAC9B,IAAI,CAAU;IACd,KAAK,CAA8B;IAEnC,IAAI,QAAQ;QACV,OAAO,SAAS,CAAC;YACf,mBAAmB,CAAC,kBAAkB;YACtC,IAAI,CAAC,IAAI;YACT,SAAS,CAAC,IAAI,CAAC,KAAK,CAAC;SACtB,CAAC,CAAC;IACL,CAAC;CACF"}

package/lib/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@finos/legend-graph",
-    "version": "13.0.1",
+    "version": "14.0.1",
     "description": "Legend graph and graph manager",
     "keywords": [
         "legend",
@@ -51,7 +51,7 @@
         "@finos/legend-dev-utils": "workspace:*",
         "@jest/globals": "28.1.3",
         "cross-env": "7.0.3",
-        "eslint": "8.21.0",
+        "eslint": "8.22.0",
         "jest": "28.1.3",
         "npm-run-all": "4.1.5",
         "rimraf": "3.0.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@finos/legend-graph",
-  "version": "13.0.1",
+  "version": "14.0.1",
   "description": "Legend graph and graph manager",
   "keywords": [
     "legend",
@@ -39,8 +39,8 @@
     "test:watch": "jest --watch"
   },
   "dependencies": {
-    "@finos/legend-shared": "5.0.2",
-    "@finos/legend-storage": "3.0.2",
+    "@finos/legend-shared": "6.0.1",
+    "@finos/legend-storage": "3.0.5",
     "date-fns": "2.29.1",
     "mobx": "6.6.1",
     "mobx-react-lite": "3.4.0",
@@ -48,10 +48,10 @@
     "serializr": "2.0.5"
   },
   "devDependencies": {
-    "@finos/legend-dev-utils": "2.0.8",
+    "@finos/legend-dev-utils": "2.0.11",
     "@jest/globals": "28.1.3",
     "cross-env": "7.0.3",
-    "eslint": "8.21.0",
+    "eslint": "8.22.0",
     "jest": "28.1.3",
     "npm-run-all": "4.1.5",
     "rimraf": "3.0.2",

package/src/graph/Core_HashUtils.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { hashArray, hashObject, hashString } from '@finos/legend-shared';
+import { hashArray, hashObject, hashValue } from '@finos/legend-shared';
 import { SOURCE_INFORMATION_PROPERTY_KEY_SUFFIX } from './MetaModelConst.js';
 
 /**
@@ -261,5 +261,5 @@ export const hashRawLambda = (
 
 export const hashElementPointer = (pointerType: string, path: string): string =>
   [CORE_HASH_STRUCTURE.PACKAGEABLE_ELEMENT_POINTER, pointerType, path]
-    .map(hashString)
+    .map(hashValue)
     .join(',');

package/src/graph/helpers/DomainHelper.ts

@@ -24,6 +24,7 @@ import {
   PRIMITIVE_TYPE,
   MULTIPLICITY_INFINITE,
   PURE_DEPRECATED_STEREOTYPE,
+  ROOT_PACKAGE_NAME,
 } from '../MetaModelConst.js';
 import { Package } from '../metamodel/pure/packageableElements/domain/Package.js';
 import type { PackageableElement } from '../metamodel/pure/packageableElements/PackageableElement.js';
@@ -36,6 +37,7 @@ import {
   guaranteeType,
   uniqBy,
   UnsupportedOperationError,
+  returnUndefOnError,
 } from '@finos/legend-shared';
 import { createPath } from '../MetaModelUtils.js';
 import type { BasicModel } from '../BasicModel.js';
@@ -215,6 +217,35 @@ export const getRawGenericType = <T extends Type>(
   clazz: Clazz<T>,
 ): T => guaranteeType<T>(genericType.rawType, clazz);
 
+export const isElementReadOnly = (element: PackageableElement): boolean =>
+  returnUndefOnError(() => getElementRootPackage(element))?.name !==
+  ROOT_PACKAGE_NAME.MAIN;
+
+export const isDependencyElement = (
+  element: PackageableElement,
+): element is PackageableElement =>
+  returnUndefOnError(() => getElementRootPackage(element))?.name ===
+  ROOT_PACKAGE_NAME.PROJECT_DEPENDENCY_ROOT;
+
+export const isGeneratedElement = (
+  element: PackageableElement,
+): element is PackageableElement =>
+  returnUndefOnError(() => getElementRootPackage(element))?.name ===
+  ROOT_PACKAGE_NAME.MODEL_GENERATION;
+
+export const isSystemElement = (
+  element: PackageableElement,
+): element is PackageableElement => {
+  const elementRootPackageName = returnUndefOnError(() =>
+    getElementRootPackage(element),
+  )?.name;
+  return (
+    element instanceof PrimitiveType ||
+    elementRootPackageName === ROOT_PACKAGE_NAME.SYSTEM ||
+    elementRootPackageName === ROOT_PACKAGE_NAME.CORE
+  );
+};
+
 /**
  * Extract the type of temporal milestone the class is associated with (using stereotype).
  *

package/src/graph/metamodel/pure/Reference.ts

@@ -14,6 +14,8 @@
  * limitations under the License.
  */
 
+import { uuid } from '@finos/legend-shared';
+
 /**
  * Reference implies pointer-based relationship in the protocol. This means that during graph-building,
  * we figure out/infer the reference using pointer of some form. Take the following example:
@@ -53,6 +55,8 @@
  *    but for simplicity sake, we will just swap out to use new a new reference
  */
 export abstract class Reference {
+  readonly _UUID = uuid();
+
   abstract value: unknown;
 }
 

package/src/graph/metamodel/pure/packageableElements/domain/PropertyReference.ts

@@ -15,7 +15,7 @@
  */
 
 import { CORE_HASH_STRUCTURE } from '../../../../../graph/Core_HashUtils.js';
-import { hashString } from '@finos/legend-shared';
+import { hashValue } from '@finos/legend-shared';
 import {
   PackageableElementExplicitReference,
   type PackageableElementReference,
@@ -48,7 +48,7 @@ export abstract class PropertyReference extends ReferenceWithOwner {
       this.value.name,
       this.ownerReference.valueForSerialization ?? '',
     ]
-      .map(hashString)
+      .map(hashValue)
       .join(',');
   }
 }

package/src/graph/metamodel/pure/packageableElements/domain/StereotypeReference.ts

@@ -15,7 +15,7 @@
  */
 
 import { CORE_HASH_STRUCTURE } from '../../../../../graph/Core_HashUtils.js';
-import { hashString } from '@finos/legend-shared';
+import { hashValue } from '@finos/legend-shared';
 import {
   PackageableElementExplicitReference,
   type PackageableElementReference,
@@ -44,7 +44,7 @@ export abstract class StereotypeReference extends ReferenceWithOwner {
       this.value.value,
       this.ownerReference.valueForSerialization ?? '',
     ]
-      .map(hashString)
+      .map(hashValue)
       .join(',');
   }
 }

package/src/graph/metamodel/pure/packageableElements/domain/TagReference.ts

@@ -15,7 +15,7 @@
  */
 
 import { CORE_HASH_STRUCTURE } from '../../../../../graph/Core_HashUtils.js';
-import { hashString } from '@finos/legend-shared';
+import { hashValue } from '@finos/legend-shared';
 import {
   PackageableElementExplicitReference,
   type PackageableElementReference,
@@ -44,7 +44,7 @@ export abstract class TagReference extends ReferenceWithOwner {
       this.value.value,
       this.ownerReference.valueForSerialization ?? '',
     ]
-      .map(hashString)
+      .map(hashValue)
       .join(',');
   }
 }

package/src/graph/metamodel/pure/packageableElements/mapping/PropertyMapping.ts

@@ -102,7 +102,7 @@ export abstract class PropertyMapping implements Hashable {
     return hashArray([
       CORE_HASH_STRUCTURE.PROPERTY_MAPPING,
       this.property.pointerHashCode,
-      this.targetSetImplementation?.value.id.value ?? '',
+      this.targetSetImplementation?.valueForSerialization ?? '',
       this.localMappingProperty ?? '',
     ]);
   }

package/src/graph/metamodel/pure/packageableElements/store/flatData/model/FlatDataSectionReference.ts

@@ -15,7 +15,7 @@
  */
 
 import { CORE_HASH_STRUCTURE } from '../../../../../../../graph/Core_HashUtils.js';
-import { hashString } from '@finos/legend-shared';
+import { hashValue } from '@finos/legend-shared';
 import {
   PackageableElementExplicitReference,
   type PackageableElementReference,
@@ -44,7 +44,7 @@ export abstract class FlatDataSectionReference extends ReferenceWithOwner {
       this.ownerReference.valueForSerialization ?? '',
       this.value.name,
     ]
-      .map(hashString)
+      .map(hashValue)
       .join(',');
   }
 }

package/src/graph/metamodel/pure/packageableElements/store/relational/model/TableReference.ts

@@ -15,7 +15,7 @@
  */
 
 import { CORE_HASH_STRUCTURE } from '../../../../../../../graph/Core_HashUtils.js';
-import { hashString } from '@finos/legend-shared';
+import { hashValue } from '@finos/legend-shared';
 import {
   PackageableElementExplicitReference,
   type PackageableElementReference,
@@ -53,7 +53,7 @@ export abstract class TableReference extends NamedRelationalReference {
       this.value.schema.name,
       this.value.name,
     ]
-      .map(hashString)
+      .map(hashValue)
       .join(',');
   }
 
@@ -64,7 +64,7 @@ export abstract class TableReference extends NamedRelationalReference {
       SELF_JOIN_SCHEMA_NAME,
       SELF_JOIN_TABLE_NAME,
     ]
-      .map(hashString)
+      .map(hashValue)
       .join(',');
   }
 }

package/src/graph/metamodel/pure/packageableElements/store/relational/model/ViewReference.ts

@@ -15,7 +15,7 @@
  */
 
 import { CORE_HASH_STRUCTURE } from '../../../../../../../graph/Core_HashUtils.js';
-import { hashString } from '@finos/legend-shared';
+import { hashValue } from '@finos/legend-shared';
 import {
   PackageableElementExplicitReference,
   type PackageableElementReference,
@@ -44,7 +44,7 @@ export abstract class ViewReference extends NamedRelationalReference {
       this.value.schema.name,
       this.value.name,
     ]
-      .map(hashString)
+      .map(hashValue)
       .join(',');
   }
 
@@ -55,7 +55,7 @@ export abstract class ViewReference extends NamedRelationalReference {
       SELF_JOIN_SCHEMA_NAME,
       SELF_JOIN_TABLE_NAME,
     ]
-      .map(hashString)
+      .map(hashValue)
       .join(',');
   }
 }

package/src/graphManager/AbstractPureGraphManager.ts

@@ -279,6 +279,16 @@ export abstract class AbstractPureGraphManager {
     rawValueSpecification: RawValueSpecification,
   ): Record<PropertyKey, unknown>;
 
+  // These methods are utilities that we could use to quickly construct compilable
+  // raw lambdas.
+  // NOTE: As of now, to simplify the code, these methods are implemented in quite a hacky way, as we create
+  // the lambdas from a templated JSON object. Formally, we could remove these method by building them
+  // in metamodel form and convert to raw form as these are relatively simple lambda to construct
+  abstract createGetAllRawLambda(_class: Class): RawLambda;
+  abstract createDefaultBasicRawLambda(options?: {
+    addDummyParameter?: boolean;
+  }): RawLambda;
+
   // ------------------------------------------- Generation -------------------------------------------
 
   abstract getAvailableGenerationConfigurationDescriptions(): Promise<
@@ -420,6 +430,10 @@ export abstract class AbstractPureGraphManager {
     input: RawMappingModelCoverageAnalysisResult,
   ): MappingModelCoverageAnalysisResult;
 
+  // ------------------------------------------- Change detection -------------------------------------------
+
+  abstract buildHashesIndex(entities: Entity[]): Promise<Map<string, string>>;
+
   // ------------------------------------------- Utilities -------------------------------------------
 
   abstract elementToEntity(
@@ -448,24 +462,4 @@ export abstract class AbstractPureGraphManager {
     );
     return graph;
   }
-
-  // ------------------------------------------- Change detection -------------------------------------------
-
-  abstract buildHashesIndex(entities: Entity[]): Promise<Map<string, string>>;
-
-  // --------------------------------------------- HACKY ---------------------------------------------
-  // As the name suggested, these methods are temporary hacks since we don't handle value-specification
-  // structurally in Studio
-
-  // Eventually, we could remove these method by building them in metamodel form and convert to raw form
-  // as these are relatively simple lambda to construct
-  abstract HACKY__createGetAllLambda(_class: Class): RawLambda;
-  abstract HACKY__createDefaultBlankLambda(): RawLambda;
-
-  // NOTE: after we refactor service, we probably can remove these methods
-  // See https://github.com/finos/legend-studio/issues/1077
-  abstract HACKY__createServiceTestAssertLambda(assertData: string): RawLambda;
-  abstract HACKY__extractServiceTestAssertionData(
-    query: RawLambda,
-  ): string | undefined;
 }

package/src/graphManager/GraphManagerState.ts

@@ -14,12 +14,7 @@
  * limitations under the License.
  */
 
-import {
-  type Log,
-  uniq,
-  ActionState,
-  assertErrorThrown,
-} from '@finos/legend-shared';
+import { type Log, ActionState, assertErrorThrown } from '@finos/legend-shared';
 import { action, makeObservable, observable } from 'mobx';
 import { DependencyManager } from '../graph/DependencyManager.js';
 import {
@@ -33,21 +28,14 @@ import type {
   GraphBuilderOptions,
 } from '../graphManager/AbstractPureGraphManager.js';
 import type { GraphManagerPluginManager } from './GraphManagerPluginManager.js';
-import { getElementRootPackage } from '../graph/helpers/DomainHelper.js';
-import { getLeafSetImplementations } from '../graph/helpers/DSLMapping_Helper.js';
-import { ROOT_PACKAGE_NAME } from '../graph/MetaModelConst.js';
-import { AssociationImplementation } from '../graph/metamodel/pure/packageableElements/mapping/AssociationImplementation.js';
 import type { EnumerationMapping } from '../graph/metamodel/pure/packageableElements/mapping/EnumerationMapping.js';
 import { InstanceSetImplementation } from '../graph/metamodel/pure/packageableElements/mapping/InstanceSetImplementation.js';
-import { OperationSetImplementation } from '../graph/metamodel/pure/packageableElements/mapping/OperationSetImplementation.js';
-import type { PropertyMapping } from '../graph/metamodel/pure/packageableElements/mapping/PropertyMapping.js';
 import type { SetImplementation } from '../graph/metamodel/pure/packageableElements/mapping/SetImplementation.js';
 import type { PackageableElement } from '../graph/metamodel/pure/packageableElements/PackageableElement.js';
 import { EmbeddedFlatDataPropertyMapping } from '../graph/metamodel/pure/packageableElements/store/flatData/mapping/EmbeddedFlatDataPropertyMapping.js';
 import { EmbeddedRelationalInstanceSetImplementation } from '../graph/metamodel/pure/packageableElements/store/relational/mapping/EmbeddedRelationalInstanceSetImplementation.js';
-import { InlineEmbeddedRelationalInstanceSetImplementation } from '../graph/metamodel/pure/packageableElements/store/relational/mapping/InlineEmbeddedRelationalInstanceSetImplementation.js';
-import { OtherwiseEmbeddedRelationalInstanceSetImplementation } from '../graph/metamodel/pure/packageableElements/store/relational/mapping/OtherwiseEmbeddedRelationalInstanceSetImplementation.js';
 import { buildPureGraphManager } from '../graphManager/protocol/pure/PureGraphManagerBuilder.js';
+import type { AssociationImplementation } from '../graph/metamodel/pure/packageableElements/mapping/AssociationImplementation.js';
 
 export class BasicGraphManagerState {
   pluginManager: GraphManagerPluginManager;
@@ -62,18 +50,17 @@ export class BasicGraphManagerState {
   }
 
   // -------------------------------------------------- UTILITIES -----------------------------------------------------
+
   /**
-   * NOTE: Notice how this utility draws resources from all of metamodels and uses `instanceof` to classify behavior/response.
-   * As such, methods in this utility cannot be placed in place they should belong to.
+   * Check if a mapping element is an instance set implementation
    *
-   * For example: `getSetImplemetnationType` cannot be placed in `SetImplementation` because of circular module dependency
-   * So this utility is born for such purpose, to avoid circular module dependency, and it should just be used for only that
-   * Other utilities that really should reside in the domain-specific meta model should be placed in the meta model module.
+   * NOTE: This would account for embedded property mappings as well
+   * these are technically instance of `InstanceSetImplementation`
+   * but since unlike Pure, Typescript cannot do multiple inheritance
+   * we only can make embedded property mapping extends `PropertyMapping`
    *
-   * NOTE: We expect the need for these methods will eventually go away as we complete modularization. But we need these
-   * methods here so that we can load plugins.
+   * Potentially, we might need to apply an extension mechanism on this
    */
-
   isInstanceSetImplementation(
     setImplementation:
       | EnumerationMapping
@@ -87,67 +74,13 @@ export class BasicGraphManagerState {
     );
   }
 
-  getInstanceSetImplementationPropertyMappings(
-    instanceSetImpl: InstanceSetImplementation,
-  ): PropertyMapping[] {
-    if (
-      instanceSetImpl instanceof
-      InlineEmbeddedRelationalInstanceSetImplementation
-    ) {
-      return this.getMappingElementPropertyMappings(
-        instanceSetImpl.inlineSetImplementation,
-      );
-    } else if (
-      instanceSetImpl instanceof
-      OtherwiseEmbeddedRelationalInstanceSetImplementation
-    ) {
-      // NOTE: for now we will grab all property mappings from the main otherwise embedded mapping and the otherwise property mapping.
-      // In the future we may want to incorporate some smartness as to when the otherwise set implementation isinvoked.
-      const otherwisePropertyMappings = instanceSetImpl.otherwisePropertyMapping
-        .targetSetImplementation?.value
-        ? this.getMappingElementPropertyMappings(
-            instanceSetImpl.otherwisePropertyMapping.targetSetImplementation
-              .value,
-          )
-        : [];
-      return [
-        ...instanceSetImpl.propertyMappings,
-        ...otherwisePropertyMappings,
-      ];
-    }
-    return instanceSetImpl.propertyMappings;
-  }
-
-  getMappingElementPropertyMappings(
-    mappingElement:
-      | EnumerationMapping
-      | SetImplementation
-      | AssociationImplementation,
-  ): PropertyMapping[] {
-    let mappedProperties: PropertyMapping[] = [];
-    if (this.isInstanceSetImplementation(mappingElement)) {
-      mappedProperties =
-        this.getInstanceSetImplementationPropertyMappings(mappingElement);
-    } else if (mappingElement instanceof AssociationImplementation) {
-      mappedProperties = mappingElement.propertyMappings;
-    } else if (mappingElement instanceof OperationSetImplementation) {
-      mappedProperties = getLeafSetImplementations(mappingElement)
-        .filter((me): me is InstanceSetImplementation =>
-          this.isInstanceSetImplementation(me),
-        )
-        .map((si) => si.propertyMappings)
-        .flat();
-    }
-    return uniq(mappedProperties);
-  }
-
   /**
    * Filter the list of system elements that will be shown in selection options
    * to users. This is helpful to avoid overwhelming and confusing users in form
    * mode since many system elements are needed to build the graph, but should
    * not present at all as selection options in form mode.
    */
-  filterSystemElementOptions<T extends PackageableElement>(
+  collectExposedSystemElements<T extends PackageableElement>(
     systemElements: T[],
   ): T[] {
     const allowedSystemElements = this.pluginManager
@@ -157,10 +90,6 @@ export class BasicGraphManagerState {
       allowedSystemElements.includes(element.path),
     );
   }
-
-  isElementReadOnly(element: PackageableElement): boolean {
-    return getElementRootPackage(element).name !== ROOT_PACKAGE_NAME.MAIN;
-  }
 }
 
 export class GraphManagerState extends BasicGraphManagerState {