@finos/legend-graph 10.1.2 → 11.0.0

package/src/models/metamodels/pure/packageableElements/store/flatData/mapping/EmbeddedFlatDataPropertyMapping.ts

@@ -22,10 +22,7 @@ import type {
   PropertyMapping,
   PropertyMappingVisitor,
 } from '../../../mapping/PropertyMapping.js';
-import type {
-  SetImplementationVisitor,
-  SetImplementation,
-} from '../../../mapping/SetImplementation.js';
+import type { SetImplementationVisitor } from '../../../mapping/SetImplementation.js';
 import type { Class } from '../../../domain/Class.js';
 import type { InstanceSetImplementation } from '../../../mapping/InstanceSetImplementation.js';
 import type { PropertyMappingsImplementation } from '../../../mapping/PropertyMappingsImplementation.js';
@@ -35,6 +32,7 @@ import type { PackageableElementReference } from '../../../PackageableElementRef
 import { InferableMappingElementRootExplicitValue } from '../../../mapping/InferableMappingElementRoot.js';
 import type { MappingClass } from '../../../mapping/MappingClass.js';
 import { FlatDataPropertyMapping } from './FlatDataPropertyMapping.js';
+import type { SetImplementationReference } from '../../../mapping/SetImplementationReference.js';
 
 /**
  * We can think of embedded property mappings as a 'gateway' from one set of property mappings to another. They are in a sense
@@ -45,7 +43,7 @@ import { FlatDataPropertyMapping } from './FlatDataPropertyMapping.js';
  * 1. Javascript only support single inheritance unlike Pure
  * 2. In the general mental model, it is more sensible to think of embedded property mapping as a property mapping rather than a class mapping because
  * despite the fact that it has the shape similar to a class mapping and it can contain multiple property mappings, it itselt is not a class mapping, it must
- * exsit "embedded" within a property mapping.
+ * exist "embedded" within a property mapping.
  */
 export class EmbeddedFlatDataPropertyMapping
   extends AbstractFlatDataPropertyMapping
@@ -65,10 +63,10 @@ export class EmbeddedFlatDataPropertyMapping
     owner: PropertyMappingsImplementation,
     property: PropertyReference,
     rootInstanceSetImplementation: InstanceSetImplementation,
-    source: SetImplementation,
+    source: SetImplementationReference,
     _class: PackageableElementReference<Class>,
     id: InferableMappingElementIdValue,
-    target?: SetImplementation,
+    target: SetImplementationReference | undefined,
   ) {
     super(owner, property, source, target);
     this.class = _class;

package/src/models/metamodels/pure/packageableElements/store/flatData/mapping/FlatDataPropertyMapping.ts

@@ -18,17 +18,17 @@ import { CORE_HASH_STRUCTURE } from '../../../../../../../MetaModelConst.js';
 import { hashArray, type Hashable } from '@finos/legend-shared';
 import type { RawLambda } from '../../../../rawValueSpecification/RawLambda.js';
 import { AbstractFlatDataPropertyMapping } from './AbstractFlatDataPropertyMapping.js';
-import type { SetImplementation } from '../../../mapping/SetImplementation.js';
 import type { PropertyMappingsImplementation } from '../../../mapping/PropertyMappingsImplementation.js';
 import type { PropertyReference } from '../../../domain/PropertyReference.js';
 import type { PropertyMappingVisitor } from '../../../mapping/PropertyMapping.js';
-import { OptionalEnumerationMappingExplicitReference } from '../../../mapping/EnumerationMappingReference.js';
+import type { EnumerationMappingReference } from '../../../mapping/EnumerationMappingReference.js';
+import type { SetImplementationReference } from '../../../mapping/SetImplementationReference.js';
 
 export class FlatDataPropertyMapping
   extends AbstractFlatDataPropertyMapping
   implements Hashable
 {
-  transformer = OptionalEnumerationMappingExplicitReference.create(undefined);
+  transformer?: EnumerationMappingReference | undefined;
   /**
    * Studio does not process value specification, they are left in raw JSON form
    *
@@ -40,8 +40,8 @@ export class FlatDataPropertyMapping
     owner: PropertyMappingsImplementation,
     property: PropertyReference,
     transform: RawLambda,
-    source: SetImplementation,
-    target?: SetImplementation,
+    source: SetImplementationReference,
+    target: SetImplementationReference | undefined,
   ) {
     super(owner, property, source, target);
     this.transform = transform;
@@ -51,7 +51,7 @@ export class FlatDataPropertyMapping
     return hashArray([
       CORE_HASH_STRUCTURE.FLAT_DATA_PROPERTY_MAPPING,
       super.hashCode,
-      this.transformer.valueForSerialization ?? '',
+      this.transformer?.valueForSerialization ?? '',
       this.transform,
     ]);
   }

package/src/models/metamodels/pure/packageableElements/store/modelToModel/mapping/PureInstanceSetImplementation.ts

@@ -21,10 +21,7 @@ import { InstanceSetImplementation } from '../../../mapping/InstanceSetImplement
 import type { PurePropertyMapping } from './PurePropertyMapping.js';
 import type { SetImplementationVisitor } from '../../../mapping/SetImplementation.js';
 import type { RawLambda } from '../../../../rawValueSpecification/RawLambda.js';
-import type {
-  PackageableElementReference,
-  OptionalPackageableElementReference,
-} from '../../../PackageableElementReference.js';
+import type { PackageableElementReference } from '../../../PackageableElementReference.js';
 import type { InferableMappingElementIdValue } from '../../../mapping/InferableMappingElementId.js';
 import type { Mapping } from '../../../mapping/Mapping.js';
 import type { InferableMappingElementRoot } from '../../../mapping/InferableMappingElementRoot.js';
@@ -34,7 +31,7 @@ export class PureInstanceSetImplementation
   implements Hashable
 {
   declare propertyMappings: PurePropertyMapping[];
-  srcClass: OptionalPackageableElementReference<Class>;
+  srcClass?: PackageableElementReference<Class> | undefined;
   /**
    * Studio does not process value specification, they are left in raw JSON form
    *
@@ -47,7 +44,7 @@ export class PureInstanceSetImplementation
     parent: Mapping,
     _class: PackageableElementReference<Class>,
     root: InferableMappingElementRoot,
-    srcClass: OptionalPackageableElementReference<Class>,
+    srcClass: PackageableElementReference<Class> | undefined,
   ) {
     super(id, parent, _class, root);
     this.srcClass = srcClass;
@@ -57,7 +54,7 @@ export class PureInstanceSetImplementation
     return hashArray([
       CORE_HASH_STRUCTURE.PURE_INSTANCE_SET_IMPLEMENTATION,
       super.hashCode,
-      this.srcClass.valueForSerialization ?? '',
+      this.srcClass?.valueForSerialization ?? '',
       this.filter ?? '',
       hashArray(
         this.propertyMappings.filter(

package/src/models/metamodels/pure/packageableElements/store/modelToModel/mapping/PurePropertyMapping.ts

@@ -21,13 +21,13 @@ import {
   PropertyMapping,
 } from '../../../mapping/PropertyMapping.js';
 import type { PropertyReference } from '../../../domain/PropertyReference.js';
-import type { SetImplementation } from '../../../mapping/SetImplementation.js';
 import type { PropertyMappingsImplementation } from '../../../mapping/PropertyMappingsImplementation.js';
 import type { RawLambda } from '../../../../rawValueSpecification/RawLambda.js';
-import { OptionalEnumerationMappingExplicitReference } from '../../../mapping/EnumerationMappingReference.js';
+import type { EnumerationMappingReference } from '../../../mapping/EnumerationMappingReference.js';
+import type { SetImplementationReference } from '../../../mapping/SetImplementationReference.js';
 
 export class PurePropertyMapping extends PropertyMapping implements Hashable {
-  transformer = OptionalEnumerationMappingExplicitReference.create(undefined);
+  transformer?: EnumerationMappingReference | undefined;
   /**
    * Studio does not process value specification, they are left in raw JSON form
    *
@@ -40,8 +40,8 @@ export class PurePropertyMapping extends PropertyMapping implements Hashable {
     owner: PropertyMappingsImplementation,
     property: PropertyReference,
     transform: RawLambda,
-    source: SetImplementation,
-    target?: SetImplementation,
+    source: SetImplementationReference,
+    target: SetImplementationReference | undefined,
     explodeProperty?: boolean,
   ) {
     super(owner, property, source, target);
@@ -53,7 +53,7 @@ export class PurePropertyMapping extends PropertyMapping implements Hashable {
     return hashArray([
       CORE_HASH_STRUCTURE.PURE_PROPERTY_MAPPING,
       super.hashCode,
-      this.transformer.valueForSerialization ?? '',
+      this.transformer?.valueForSerialization ?? '',
       this.transform,
       Boolean(this.explodeProperty).toString(),
     ]);

package/src/models/metamodels/pure/packageableElements/store/relational/mapping/EmbeddedRelationalInstanceSetImplementation.ts

@@ -25,10 +25,7 @@ import type { RelationalOperationElement } from '../model/RelationalOperationEle
 import type { EmbeddedSetImplementation } from '../../../mapping/EmbeddedSetImplementation.js';
 import type { Class } from '../../../domain/Class.js';
 import type { Mapping } from '../../../mapping/Mapping.js';
-import type {
-  SetImplementationVisitor,
-  SetImplementation,
-} from '../../../mapping/SetImplementation.js';
+import type { SetImplementationVisitor } from '../../../mapping/SetImplementation.js';
 import type { PropertyMappingsImplementation } from '../../../mapping/PropertyMappingsImplementation.js';
 import {
   type PropertyMappingVisitor,
@@ -42,6 +39,7 @@ import type { RelationalInstanceSetImplementation } from './RelationalInstanceSe
 import { InferableMappingElementRootExplicitValue } from '../../../mapping/InferableMappingElementRoot.js';
 import type { MappingClass } from '../../../mapping/MappingClass.js';
 import { RelationalPropertyMapping } from './RelationalPropertyMapping.js';
+import type { SetImplementationReference } from '../../../mapping/SetImplementationReference.js';
 
 export class EmbeddedRelationalInstanceSetImplementation
   extends PropertyMapping
@@ -65,10 +63,10 @@ export class EmbeddedRelationalInstanceSetImplementation
     owner: PropertyMappingsImplementation,
     property: PropertyReference,
     rootInstanceSetImplementation: RootRelationalInstanceSetImplementation,
-    source: SetImplementation,
+    source: SetImplementationReference,
     _class: PackageableElementReference<Class>,
     id: InferableMappingElementIdValue,
-    target?: SetImplementation,
+    target: SetImplementationReference | undefined,
   ) {
     super(owner, property, source, target);
     this.class = _class;

package/src/models/metamodels/pure/packageableElements/store/relational/mapping/RelationalPropertyMapping.ts

@@ -23,13 +23,13 @@ import {
 import { hashObjectWithoutSourceInformation } from '../../../../../../../MetaModelUtils.js';
 import type { RawRelationalOperationElement } from '../model/RawRelationalOperationElement.js';
 import type { BindingTransformer } from '../../../externalFormat/store/DSLExternalFormat_BindingTransformer.js';
-import { OptionalEnumerationMappingExplicitReference } from '../../../mapping/EnumerationMappingReference.js';
+import type { EnumerationMappingReference } from '../../../mapping/EnumerationMappingReference.js';
 
 export class RelationalPropertyMapping
   extends PropertyMapping
   implements Hashable
 {
-  transformer = OptionalEnumerationMappingExplicitReference.create(undefined);
+  transformer?: EnumerationMappingReference | undefined;
   /**
    * Studio does not process value specification, they are left in raw JSON form
    *
@@ -46,7 +46,7 @@ export class RelationalPropertyMapping
     return hashArray([
       CORE_HASH_STRUCTURE.REALTIONAL_PROPERTY_MAPPING,
       super.hashCode,
-      this.transformer.valueForSerialization ?? '',
+      this.transformer?.valueForSerialization ?? '',
       this.bindingTransformer ?? '',
       hashObjectWithoutSourceInformation(this.relationalOperation),
     ]);

package/src/models/metamodels/pure/valueSpecification/GraphFetchTree.ts

@@ -16,11 +16,7 @@
 
 import type { Class } from '../packageableElements/domain/Class.js';
 import type { PropertyReference } from '../packageableElements/domain/PropertyReference.js';
-import {
-  OptionalPackageableElementExplicitReference,
-  type OptionalPackageableElementReference,
-  type PackageableElementReference,
-} from '../packageableElements/PackageableElementReference.js';
+import type { PackageableElementReference } from '../packageableElements/PackageableElementReference.js';
 import type {
   ValueSpecification,
   ValueSpecificationVisitor,
@@ -48,17 +44,15 @@ export class PropertyGraphFetchTree extends GraphFetchTree {
   property: PropertyReference;
   alias?: string | undefined;
   parameters: ValueSpecification[] = []; //TODO
-  subType: OptionalPackageableElementReference<Class>;
+  subType?: PackageableElementReference<Class> | undefined;
 
   constructor(
     property: PropertyReference,
-    val?: OptionalPackageableElementReference<Class>,
+    subType: PackageableElementReference<Class> | undefined,
   ) {
     super();
     this.property = property;
-    this.subType =
-      val ??
-      OptionalPackageableElementExplicitReference.create<Class>(undefined);
+    this.subType = subType;
   }
 }
 

package/src/models/protocols/pure/DSLExternalFormat_PureProtocolProcessorPlugin.ts

@@ -31,10 +31,7 @@ import {
 import type { Connection } from '../../metamodels/pure/packageableElements/connection/Connection.js';
 import type { Mapping } from '../../metamodels/pure/packageableElements/mapping/Mapping.js';
 import type { PackageableElement } from '../../metamodels/pure/packageableElements/PackageableElement.js';
-import {
-  PackageableElementReference,
-  optionalizePackageableElementReference,
-} from '../../metamodels/pure/packageableElements/PackageableElementReference.js';
+import { PackageableElementReference } from '../../metamodels/pure/packageableElements/PackageableElementReference.js';
 import type { Runtime } from '../../metamodels/pure/packageableElements/runtime/Runtime.js';
 import { ExternalFormatConnection } from '../../metamodels/pure/packageableElements/externalFormat/connection/DSLExternalFormat_ExternalFormatConnection.js';
 import { UrlStream } from '../../metamodels/pure/packageableElements/externalFormat/connection/DSLExternalFormat_UrlStream.js';
@@ -133,11 +130,9 @@ export class DSLExternalFormat_PureProtocolProcessorPlugin
           );
           const element = getOwnBinding(path, context.currentSubGraph);
           element.schemaId = elementProtocol.schemaId;
-          element.schemaSet = optionalizePackageableElementReference(
-            elementProtocol.schemaSet
-              ? V1_resolveSchemaSet(elementProtocol.schemaSet, context)
-              : undefined,
-          );
+          element.schemaSet = elementProtocol.schemaSet
+            ? V1_resolveSchemaSet(elementProtocol.schemaSet, context)
+            : undefined;
 
           element.contentType = guaranteeNonEmptyString(
             elementProtocol.contentType,
@@ -262,7 +257,7 @@ export class DSLExternalFormat_PureProtocolProcessorPlugin
           protocol.name = metamodel.name;
           protocol.package = metamodel.package?.path ?? '';
           protocol.schemaId = metamodel.schemaId;
-          protocol.schemaSet = metamodel.schemaSet.valueForSerialization;
+          protocol.schemaSet = metamodel.schemaSet?.valueForSerialization;
           protocol.contentType = metamodel.contentType;
           const modelUnit = new V1_ModelUnit();
           modelUnit.packageableElementExcludes =

package/src/models/protocols/pure/PureProtocolProcessorPlugin.ts

@@ -70,6 +70,11 @@ export type V1_MappingModelCoverageAnalysisInputCollector = (
   protocolGraph: V1_PureModelContextData,
 ) => V1_PackageableElement[];
 
+export type V1_MappingModelRuntimeCompatibilityAnalysisInputCollector = (
+  graph: PureModel,
+  protocolGraph: V1_PureModelContextData,
+) => V1_PackageableElement[];
+
 export type V1_PropertyExpressionTypeInferrer = (
   variable: ValueSpecification | undefined,
 ) => Type | undefined;
@@ -141,19 +146,14 @@ export abstract class PureProtocolProcessorPlugin extends AbstractPlugin {
   /**
    * Get the list of collectors of graph elements to build execution input.
    *
-   * In particular, such collector is used to specify any additional packageable elements
-   * added to the graph that is used when executing a query against the engine server.
-   * We prune the graph to avoid sending the server additional elements not needed for execution.
-   * This would provide a mechanism to add more elements in this reduced graph.
+   * In particular, these collectors are used to produce the minimal graph that is needed for such execution.
    */
   V1_getExtraExecutionInputCollectors?(): V1_ExecutionInputCollector[];
 
   /**
-   * Get the list of collectors of graph elements to build mapping-model-coverage-analysis input.
+   * Get the list of collectors of graph elements to build the input for mapping model-coverage analysis.
    *
-   * In particular, such collector is used to specify any additional packageable elements
-   * added to the graph that is used when analyzing mapped properties in the mapping.
-   * This would provide a mechanism to add more elements in this reduced graph.
+   * In particular, these collectors are used to produce the minimal graph that is needed for such analysis.
    */
   V1_getExtraMappingModelCoverageAnalysisInputCollectors?(): V1_MappingModelCoverageAnalysisInputCollector[];