@finos/legend-extension-dsl-data-quality 2.1.34 → 2.1.36

package/src/graph-manager/protocol/pure/v1/V1_DataQualityValidationConfiguration.ts

@@ -165,3 +165,52 @@ export class V1_DataQualityRelationValidationsConfiguration
     return visitor.visit_PackageableElement(this);
   }
 }
+
+export abstract class V1_ReconStrategy implements Hashable {
+  abstract get hashCode(): string;
+}
+
+export class V1_MD5HashStrategy extends V1_ReconStrategy {
+  sourceHashColumn?: string | undefined;
+  targetHashColumn?: string | undefined;
+  aggregatedHash?: boolean | undefined;
+
+  override get hashCode(): string {
+    return hashArray([
+      DATA_QUALITY_HASH_STRUCTURE.DATA_QUALITY_MD5_HASH_STRATEGY,
+      this.sourceHashColumn ?? '',
+      this.targetHashColumn ?? '',
+      this.aggregatedHash ?? false,
+    ]);
+  }
+}
+
+export class V1_DataQualityRelationComparisonConfiguration
+  extends V1_DataQualityValidationsConfiguration
+  implements Hashable
+{
+  source!: V1_DataQualityRelationQueryLambda;
+  target!: V1_DataQualityRelationQueryLambda;
+  keys: string[] = [];
+  columnsToCompare: string[] = [];
+  strategy!: V1_ReconStrategy;
+  expectedMatch?: number | undefined;
+
+  override get hashCode(): string {
+    return hashArray([
+      DATA_QUALITY_HASH_STRUCTURE.DATA_QUALITY_RELATION_COMPARISON_HASH_STRUCTURE,
+      this.source,
+      this.target,
+      hashArray(this.keys),
+      hashArray(this.columnsToCompare),
+      String(this.expectedMatch ?? ''),
+      this.strategy,
+    ]);
+  }
+
+  accept_PackageableElementVisitor<T>(
+    visitor: V1_PackageableElementVisitor<T>,
+  ): T {
+    return visitor.visit_PackageableElement(this);
+  }
+}

package/src/graph-manager/protocol/pure/v1/transformation/V1_DSL_DataQuality_ValueSpecificationBuilderHelper.ts

@@ -31,8 +31,10 @@ import {
   type V1_DataQualityRelationValidation,
   type V1_DataQualityRelationValidationsConfiguration,
   type V1_DataQualityServiceValidationsConfiguration,
+  type V1_DataQualityRelationComparisonConfiguration,
   V1_DataSpaceDataQualityExecutionContext,
   V1_MappingAndRuntimeDataQualityExecutionContext,
+  V1_MD5HashStrategy,
 } from '../V1_DataQualityValidationConfiguration.js';
 import {
   type DataQualityExecutionContext,
@@ -40,6 +42,7 @@ import {
   DataQualityRelationValidation,
   DataSpaceDataQualityExecutionContext,
   MappingAndRuntimeDataQualityExecutionContext,
+  MD5HashStrategy,
 } from '../../../../../graph/metamodel/pure/packageableElements/data-quality/DataQualityValidationConfiguration.js';
 import {
   type V1_GraphBuilderContext,
@@ -65,6 +68,7 @@ import {
   getOwnDataQualityClassValidationsConfiguration,
   getOwnDataQualityServiceValidationsConfiguration,
   getOwnDataQualityRelationValidationsConfiguration,
+  getOwnDataQualityRelationComparisonConfiguration,
 } from '../../../../DSL_DataQuality_GraphManagerHelper.js';
 
 export function V1_buildDataQualityExecutionContext(
@@ -355,3 +359,38 @@ export function V1_buildDataQualityServiceValidationConfiguration(
         ) as DataQualityRootGraphFetchTree)
       : undefined;
 }
+
+export function V1_buildDataQualityRelationComparisonConfiguration(
+  elementProtocol: V1_DataQualityRelationComparisonConfiguration,
+  context: V1_GraphBuilderContext,
+): void {
+  const path = V1_buildFullPath(elementProtocol.package, elementProtocol.name);
+  const element = getOwnDataQualityRelationComparisonConfiguration(
+    path,
+    context.currentSubGraph,
+  );
+  element.source = new DataQualityRelationQueryLambda();
+  element.source.body = elementProtocol.source.body;
+  element.source.parameters = elementProtocol.source.parameters.map((param) =>
+    V1_buildVariable(param, context),
+  );
+  element.target = new DataQualityRelationQueryLambda();
+  element.target.body = elementProtocol.target.body;
+  element.target.parameters = elementProtocol.target.parameters.map((param) =>
+    V1_buildVariable(param, context),
+  );
+  element.keys = elementProtocol.keys;
+  element.columnsToCompare = elementProtocol.columnsToCompare;
+  if (elementProtocol.strategy instanceof V1_MD5HashStrategy) {
+    const strategy = new MD5HashStrategy();
+    strategy.sourceHashColumn = elementProtocol.strategy.sourceHashColumn;
+    strategy.targetHashColumn = elementProtocol.strategy.targetHashColumn;
+    strategy.aggregatedHash = elementProtocol.strategy.aggregatedHash;
+    element.strategy = strategy;
+  } else {
+    throw new UnsupportedOperationError(
+      `Can't build recon strategy: unsupported type`,
+    );
+  }
+  element.expectedMatch = elementProtocol.expectedMatch;
+}

package/src/graph-manager/protocol/pure/v1/transformation/V1_DSL_DataQuality_ValueSpecificationTransformer.ts

@@ -45,17 +45,23 @@ import {
   type DataQualityRelationValidation,
   type DataQualityRelationValidationConfiguration,
   type DataQualityClassValidationsConfiguration,
+  type DataQualityRelationComparisonConfiguration,
+  type ReconStrategy,
+  MD5HashStrategy,
   DataSpaceDataQualityExecutionContext,
   MappingAndRuntimeDataQualityExecutionContext,
 } from '../../../../../graph/metamodel/pure/packageableElements/data-quality/DataQualityValidationConfiguration.js';
 import {
   type V1_DataQualityExecutionContext,
+  type V1_ReconStrategy,
   V1_DataQualityClassValidationsConfiguration,
   V1_DataQualityRelationValidation,
   V1_DataQualityRelationValidationsConfiguration,
   V1_DataSpaceDataQualityExecutionContext,
   V1_MappingAndRuntimeDataQualityExecutionContext,
   V1_DataQualityRelationQueryLambda,
+  V1_DataQualityRelationComparisonConfiguration,
+  V1_MD5HashStrategy,
 } from '../V1_DataQualityValidationConfiguration.js';
 import { DATA_SPACE_ELEMENT_POINTER } from '@finos/legend-extension-dsl-data-space/graph';
 
@@ -224,3 +230,47 @@ export function V1_transformDataQualityRelationValidationConfiguration(
   );
   return protocol;
 }
+
+function V1_transformReconStrategy(value: ReconStrategy): V1_ReconStrategy {
+  if (value instanceof MD5HashStrategy) {
+    const protocol = new V1_MD5HashStrategy();
+    protocol.sourceHashColumn = value.sourceHashColumn;
+    protocol.targetHashColumn = value.targetHashColumn;
+    protocol.aggregatedHash = value.aggregatedHash;
+    return protocol;
+  }
+  throw new UnsupportedOperationError(
+    `Can't transform recon strategy: unsupported type`,
+  );
+}
+
+export function V1_transformDataQualityRelationComparisonConfiguration(
+  metamodel: DataQualityRelationComparisonConfiguration,
+  context: V1_GraphTransformerContext,
+): V1_DataQualityRelationComparisonConfiguration {
+  const protocol = new V1_DataQualityRelationComparisonConfiguration();
+  V1_initPackageableElement(protocol, metamodel);
+  protocol.name = metamodel.name;
+  protocol.package = metamodel.package?.path ?? '';
+  protocol.source = new V1_DataQualityRelationQueryLambda();
+  protocol.source.body = metamodel.source.body;
+  protocol.source.parameters = metamodel.source.parameters.map(
+    (v) =>
+      v.accept_RawValueSpecificationVisitor(
+        new V1_RawValueSpecificationTransformer(context),
+      ) as V1_RawVariable,
+  );
+  protocol.target = new V1_DataQualityRelationQueryLambda();
+  protocol.target.body = metamodel.target.body;
+  protocol.target.parameters = metamodel.target.parameters.map(
+    (v) =>
+      v.accept_RawValueSpecificationVisitor(
+        new V1_RawValueSpecificationTransformer(context),
+      ) as V1_RawVariable,
+  );
+  protocol.keys = metamodel.keys;
+  protocol.columnsToCompare = metamodel.columnsToCompare;
+  protocol.strategy = V1_transformReconStrategy(metamodel.strategy);
+  protocol.expectedMatch = metamodel.expectedMatch;
+  return protocol;
+}

package/src/graph-manager/protocol/pure/v1/transformation/pureProtocol/V1_DSL_DataQuality_ProtocolHelper.ts

@@ -24,9 +24,11 @@ import {
   list,
   optional,
   raw,
+  SKIP,
 } from 'serializr';
 import {
   type V1_DataQualityExecutionContext,
+  type V1_ReconStrategy,
   V1_DataQualityClassValidationsConfiguration,
   V1_DataQualityServiceValidationsConfiguration,
   V1_DataSpaceDataQualityExecutionContext,
@@ -34,6 +36,8 @@ import {
   V1_DataQualityRelationValidationsConfiguration,
   V1_DataQualityRelationValidation,
   V1_DataQualityRelationQueryLambda,
+  V1_DataQualityRelationComparisonConfiguration,
+  V1_MD5HashStrategy,
 } from '../../V1_DataQualityValidationConfiguration.js';
 import {
   type PlainObject,
@@ -60,6 +64,8 @@ export const V1_DATA_QUALITY_RELATION_PROTOCOL_TYPE =
   'dataqualityRelationValidation';
 export const V1_DATA_QUALITY_SERVICE_PROTOCOL_TYPE =
   'dataQualityServiceValidations';
+export const V1_DATA_QUALITY_RELATION_COMPARISON_PROTOCOL_TYPE =
+  'dataQualityRelationComparison';
 const V1_DATA_QUALITY_DATASPACE_EXECUTION_CONTEXT =
   'dataSpaceDataQualityExecutionContext';
 const V1_DATA_QUALITY_MAPPING_AND_RUNTIME_EXECUTION_CONTEXT =
@@ -251,3 +257,68 @@ export const V1_deserializeDataQualityRelationValidation = (
   plugins: PureProtocolProcessorPlugin[],
 ): V1_DataQualityRelationValidationsConfiguration =>
   deserialize(V1_dataQualityRelationValidationModelSchema(plugins), json);
+
+const V1_MD5_HASH_STRATEGY_TYPE = 'md5Hash';
+
+const V1_md5HashStrategyModelSchema = createModelSchema(V1_MD5HashStrategy, {
+  _type: usingConstantValueSchema(V1_MD5_HASH_STRATEGY_TYPE),
+  sourceHashColumn: optional(primitive()),
+  targetHashColumn: optional(primitive()),
+  aggregatedHash: optional(primitive()),
+});
+
+function V1_serializeReconStrategy(
+  value: V1_ReconStrategy,
+): PlainObject<V1_ReconStrategy> {
+  if (value instanceof V1_MD5HashStrategy) {
+    return serialize(V1_md5HashStrategyModelSchema, value);
+  }
+  throw new UnsupportedOperationError(
+    `Can't serialize recon strategy: unsupported type`,
+  );
+}
+
+function V1_deserializeReconStrategy(
+  json: PlainObject<V1_ReconStrategy>,
+): V1_ReconStrategy {
+  switch (json._type) {
+    case V1_MD5_HASH_STRATEGY_TYPE:
+      return deserialize(V1_md5HashStrategyModelSchema, json);
+    default:
+      throw new UnsupportedOperationError(
+        `Can't deserialize recon strategy of type '${json._type}'`,
+      );
+  }
+}
+
+const V1_dataQualityRelationComparisonModelSchema = (
+  plugins: PureProtocolProcessorPlugin[],
+): ModelSchema<V1_DataQualityRelationComparisonConfiguration> =>
+  createModelSchema(V1_DataQualityRelationComparisonConfiguration, {
+    _type: usingConstantValueSchema(
+      V1_DATA_QUALITY_RELATION_COMPARISON_PROTOCOL_TYPE,
+    ),
+    name: primitive(),
+    package: primitive(),
+    source: usingModelSchema(V1_rawLambdaModelSchemaParameters),
+    target: usingModelSchema(V1_rawLambdaModelSchemaParameters),
+    keys: list(primitive()),
+    columnsToCompare: list(primitive()),
+    strategy: optionalCustom(
+      (val) => (val ? V1_serializeReconStrategy(val) : SKIP),
+      (val) => (val ? V1_deserializeReconStrategy(val) : SKIP),
+    ),
+    expectedMatch: optional(primitive()),
+  });
+
+export const V1_serializeDataQualityRelationComparison = (
+  protocol: V1_DataQualityRelationComparisonConfiguration,
+  plugins: PureProtocolProcessorPlugin[],
+): PlainObject<V1_DataQualityRelationComparisonConfiguration> =>
+  serialize(V1_dataQualityRelationComparisonModelSchema(plugins), protocol);
+
+export const V1_deserializeDataQualityRelationComparison = (
+  json: PlainObject<V1_DataQualityRelationComparisonConfiguration>,
+  plugins: PureProtocolProcessorPlugin[],
+): V1_DataQualityRelationComparisonConfiguration =>
+  deserialize(V1_dataQualityRelationComparisonModelSchema(plugins), json);

package/style/_data-quality-relation-comparison-editor.scss

@@ -0,0 +1,361 @@
+/**
+ * Copyright (c) 2026-present, Goldman Sachs
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+@use 'mixins' as *;
+
+.data-quality-relation-comparison-editor {
+  height: 100%;
+  width: 100%;
+  background: var(--color-dark-grey-50);
+
+  .panel {
+    height: 100%;
+    width: 100%;
+
+    &__header__title__label {
+      background: var(--color-dark-grey-250);
+    }
+
+    &__content {
+      background: var(--color-dark-grey-50);
+    }
+
+    &__header {
+      padding-left: 0.5rem;
+      color: var(--color-light-grey-300);
+      font-weight: bold;
+      background: var(--color-dark-grey-50);
+      border-bottom: 0.1rem solid var(--color-dark-grey-200);
+    }
+  }
+
+  &__panel__content__form {
+    padding-left: 1rem;
+    padding-top: 1rem;
+    max-width: 160rem;
+    width: 100%;
+  }
+
+  &__actions-bar {
+    display: flex;
+    align-items: center;
+    justify-content: end;
+    gap: 1rem;
+    background: var(--color-dark-grey-50);
+    margin-top: 2rem;
+    height: 4rem;
+    padding-top: 0.5rem;
+
+    &__limit {
+      @include flexVCenter;
+
+      flex-shrink: 0;
+      height: 2.8rem;
+    }
+
+    &__limit__label {
+      @include flexVCenter;
+
+      height: 100%;
+      padding: 0 1rem;
+      background: var(--color-dark-grey-280);
+      border-radius: 0.2rem 0 0 0.2rem;
+      color: var(--color-light-grey-300);
+      font-size: 1.2rem;
+      text-transform: lowercase;
+      white-space: nowrap;
+    }
+
+    &__limit__input {
+      width: 7rem;
+      height: 2.8rem;
+      padding: 0 0.8rem;
+      color: var(--color-light-grey-150);
+      background: var(--color-dark-grey-100);
+      border: 0.1rem solid var(--color-dark-grey-300);
+      border-radius: 0.2rem;
+    }
+
+    &__cancel-btn {
+      padding-right: 2.8rem;
+    }
+
+    &__cancel-label {
+      height: 2.8rem;
+    }
+
+    &__run-group {
+      display: flex;
+      gap: 0.02rem;
+      padding-right: 2.8rem;
+    }
+
+    &__run-btn {
+      height: 2.8rem;
+      width: 14rem;
+      white-space: nowrap;
+    }
+
+    &__dropdown-btn {
+      height: 2.8rem;
+    }
+  }
+
+  &__column-fetch-error {
+    @include flexVCenter;
+
+    gap: 0.8rem;
+    padding: 0.8rem 1rem;
+    margin: 0 1rem 1rem;
+    border-radius: 0.2rem;
+    background: var(--color-dark-grey-200);
+    border: 0.1rem solid var(--color-red-200);
+
+    &__icon {
+      flex-shrink: 0;
+      color: var(--color-red-200);
+      font-size: 1.6rem;
+    }
+
+    &__message {
+      flex: 1;
+      color: var(--color-red-100);
+      font-size: 1.2rem;
+    }
+
+    &__retry-btn {
+      @include flexVCenter;
+
+      flex-shrink: 0;
+      gap: 0.4rem;
+      height: 2.4rem;
+      min-width: 7rem;
+      padding: 0 0.8rem;
+      border: none;
+      border-radius: 0.2rem;
+      cursor: pointer;
+      font-size: 1.2rem;
+      white-space: nowrap;
+      color: var(--color-light-grey-200);
+      background: var(--color-dark-grey-300);
+
+      &:hover:not(:disabled) {
+        background: var(--color-dark-grey-350);
+      }
+
+      &:disabled {
+        opacity: 0.5;
+        cursor: not-allowed;
+      }
+
+      svg {
+        font-size: 1.3rem;
+      }
+    }
+  }
+
+  &__column-overlap-warning {
+    @include flexVCenter;
+
+    gap: 0.8rem;
+    padding: 0.8rem 1rem;
+    margin: 0 1rem 1rem;
+    border-radius: 0.2rem;
+    background: var(--color-dark-grey-200);
+    border: 0.1rem solid var(--color-yellow-200);
+
+    &__icon {
+      flex-shrink: 0;
+      color: var(--color-yellow-200);
+      font-size: 1.6rem;
+    }
+
+    &__message {
+      flex: 1;
+      color: var(--color-yellow-100);
+      font-size: 1.2rem;
+    }
+  }
+
+  &__queries {
+    height: 25rem;
+    min-height: 15rem;
+  }
+
+  &__query-panel {
+    display: flex;
+    flex-direction: column;
+    height: 100%;
+
+    &__header {
+      @include flexVCenter;
+
+      height: 2.8rem;
+      padding-left: 2rem;
+      font-weight: 500;
+      color: var(--color-light-grey-300);
+    }
+
+    &__content {
+      flex: 1;
+      min-height: 0;
+      margin-left: 2rem;
+      margin-right: 2rem;
+      padding-top: 0.5rem;
+      overflow: hidden;
+      border-bottom: 0.1rem solid var(--color-dark-grey-200);
+    }
+
+    &__title {
+      height: 2.8rem;
+
+      @include flexVCenter;
+
+      background: var(--color-dark-grey-200);
+      color: var(--color-light-grey-100);
+      padding: 0 1rem;
+      border-radius: 0.2rem;
+      margin: 0;
+      font-weight: 500;
+    }
+  }
+
+  &__lambda-editor {
+    height: 28rem !important;
+  }
+
+  &__result {
+    padding-top: 1rem;
+    padding-left: 2rem;
+    padding-right: 1rem;
+
+    &__header {
+      padding-right: 1rem;
+
+      @include flexVCenter;
+      @include flexHSpaceBetween;
+    }
+
+    &__header-group {
+      display: flex;
+      flex-direction: row;
+      color: var(--color-light-grey-300);
+
+      @include flexVCenter;
+    }
+
+    &__title {
+      height: 2.8rem;
+
+      @include flexVCenter;
+
+      background: var(--color-dark-grey-200);
+      color: var(--color-light-grey-100);
+      padding: 0 1rem;
+      border-radius: 0.2rem;
+      margin: 0;
+      font-weight: 500;
+    }
+
+    &__status {
+      @include flexVCenter;
+
+      margin-left: 1rem;
+      color: var(--color-yellow-200);
+      font-size: 1.2rem;
+    }
+
+    &__analytics {
+      @include flexVCenter;
+
+      margin-left: 1rem;
+      color: var(--color-light-grey-400);
+      font-size: 1.2rem;
+    }
+
+    &__content {
+      width: 100%;
+      padding-top: 0.5rem;
+    }
+
+    &__viewer {
+      height: 35rem !important;
+      border: 0.1rem solid var(--color-dark-grey-280);
+    }
+  }
+
+  &__parameters-modal {
+    width: 96rem;
+    max-width: calc(100vw - 4rem);
+
+    &__body {
+      display: flex;
+      flex-direction: column;
+      gap: 1.6rem;
+      max-height: 70vh;
+    }
+
+    &__description {
+      color: var(--color-light-grey-300);
+      font-size: 1.2rem;
+      line-height: 1.8rem;
+    }
+
+    &__sections {
+      display: grid;
+      grid-template-columns: repeat(2, minmax(0, 1fr));
+      gap: 1.6rem;
+      align-items: start;
+    }
+
+    &__section {
+      display: flex;
+      flex-direction: column;
+      gap: 1.2rem;
+      padding: 1.2rem;
+      border: 0.1rem solid var(--color-dark-grey-200);
+      border-radius: 0.2rem;
+      background: var(--color-dark-grey-50);
+    }
+
+    &__section__title {
+      color: var(--color-light-grey-100);
+      font-size: 1.2rem;
+      font-weight: 700;
+      letter-spacing: 0.04rem;
+      text-transform: uppercase;
+    }
+
+    &__section__body {
+      display: flex;
+      flex-direction: column;
+      gap: 1.2rem;
+    }
+
+    .value-spec-editor__reset-btn,
+    .value-spec-editor__variable__reset-btn {
+      display: none;
+    }
+
+    @media (width <= 1000px) {
+      width: calc(100vw - 4rem);
+
+      &__sections {
+        grid-template-columns: minmax(0, 1fr);
+      }
+    }
+  }
+}

package/style/data-quality-custom-selector.scss

@@ -19,6 +19,7 @@
 .data-quality-custom-selector {
   @include flexVCenter;
 
+  width: 100%;
   height: 2.8rem;
   border: 0.1rem solid var(--color-dark-grey-280);
   border-radius: 0.2rem;
@@ -50,6 +51,28 @@
     user-select: none;
   }
 
+  &__clear {
+    @include flexCenter;
+
+    flex-shrink: 0;
+    width: 2rem;
+    min-width: 2rem;
+    height: 100%;
+    padding: 0;
+    border: none;
+    background: transparent;
+    cursor: pointer;
+    color: var(--color-light-grey-400);
+
+    &:hover {
+      color: var(--color-light-grey-100);
+    }
+
+    svg {
+      font-size: 1.1rem;
+    }
+  }
+
   &__dropdown__trigger {
     @include flexCenter;