@finos/legend-extension-dsl-data-quality 1.0.38 → 1.0.39

package/src/components/states/DataQualityState.ts

@@ -16,24 +16,31 @@
 
 import { action, computed, flow, makeObservable, observable } from 'mobx';
 import {
+  type Class,
+  type GraphFetchTree,
   type GraphManagerState,
-  type Runtime,
+  type PackageableElement,
   type RawLambda,
   type RootGraphFetchTree,
-  type PackageableElement,
-  type Class,
-  type GraphFetchTree,
-  buildRawLambdaFromLambdaFunction,
+  type Runtime,
   CORE_PURE_PATH,
   FunctionType,
   GenericType,
   GenericTypeExplicitReference,
+  getMilestoneTemporalStereotype,
   LambdaFunction,
   LambdaFunctionInstanceValue,
+  MILESTONING_STEREOTYPE,
   Multiplicity,
   observe_ValueSpecification,
   PackageableElementExplicitReference,
+  ParameterValue,
+  PRIMITIVE_TYPE,
+  buildRawLambdaFromLambdaFunction,
   VariableExpression,
+  PROCESSING_DATE_MILESTONING_PROPERTY_NAME,
+  BUSINESS_DATE_MILESTONING_PROPERTY_NAME,
+  V1_RawValueSpecificationType,
 } from '@finos/legend-graph';
 import {
   type EditorExtensionState,
@@ -64,6 +71,7 @@ import { DataQualityResultState } from './DataQualityResultState.js';
 import { DATA_QUALITY_HASH_STRUCTURE } from '../../graph/metamodel/DSL_DataQuality_HashUtils.js';
 import {
   buildFilterConditionExpression,
+  generateDefaultValueForPrimitiveType,
   processFilterLambda,
   QueryBuilderAdvancedWorkflowState,
 } from '@finos/legend-query-builder';
@@ -119,6 +127,13 @@ export abstract class DataQualityState extends ElementEditorState {
   dataQualityQueryBuilderState: DataQualityQueryBuilderState;
   resultState: DataQualityResultState;
   showStructuralValidations = false;
+  showDateSelection = false;
+  processingDate = generateDefaultValueForPrimitiveType(
+    PRIMITIVE_TYPE.STRICTDATE,
+  ) as string;
+  businessDate = generateDefaultValueForPrimitiveType(
+    PRIMITIVE_TYPE.STRICTDATE,
+  ) as string;
 
   constructor(editorStore: EditorStore, element: PackageableElement) {
     super(editorStore, element);
@@ -129,6 +144,9 @@ export abstract class DataQualityState extends ElementEditorState {
       structuralValidationsGraphFetchTreeState: observable,
       dataQualityQueryBuilderState: observable,
       showStructuralValidations: observable,
+      showDateSelection: observable,
+      processingDate: observable,
+      businessDate: observable,
       constraintsConfigurationElement: computed,
       setSelectedTab: action,
       setExecutionContext: action,
@@ -136,9 +154,12 @@ export abstract class DataQualityState extends ElementEditorState {
       initializeGraphFetchTreeState: action,
       initializeStructuralValidationsGraphFetchTreeState: action,
       setShowStructuralValidations: action,
+      setShowDateSelection: action,
       updateElementOnClassChange: action,
       checkConstraintsSelectedAtNode: action,
       changeClass: action,
+      setProcessingDate: action,
+      setBusinessDate: action,
       fetchStructuralValidations: flow,
       tabsToShow: computed,
       areNestedConstraintsSelected: computed,
@@ -169,6 +190,18 @@ export abstract class DataQualityState extends ElementEditorState {
     this.showStructuralValidations = val;
   }
 
+  setShowDateSelection(val: boolean): void {
+    this.showDateSelection = val;
+  }
+
+  setProcessingDate(val: string): void {
+    this.processingDate = val;
+  }
+
+  setBusinessDate(val: string): void {
+    this.businessDate = val;
+  }
+
   get tabsToShow(): string[] {
     const tabs: string[] = Object.values(DATA_QUALITY_TAB);
     const extensionTabGetters = this.editorStore.pluginManager
@@ -185,6 +218,54 @@ export abstract class DataQualityState extends ElementEditorState {
     return tabs;
   }
 
+  get currentClassMilestoningStrategy(): MILESTONING_STEREOTYPE | undefined {
+    const currentclass = this.dataQualityQueryBuilderState.class;
+    if (currentclass !== undefined) {
+      return getMilestoneTemporalStereotype(
+        currentclass,
+        this.graphManagerState.graph,
+      );
+    }
+    return undefined;
+  }
+
+  get isCurrentClassMilestoned(): boolean {
+    return this.currentClassMilestoningStrategy !== undefined;
+  }
+
+  get lambdaParameterValues(): ParameterValue[] {
+    const parameters: ParameterValue[] = [];
+    const currentClassMilestoningStrategy =
+      this.currentClassMilestoningStrategy;
+    if (
+      currentClassMilestoningStrategy ===
+        MILESTONING_STEREOTYPE.PROCESSING_TEMPORAL ||
+      currentClassMilestoningStrategy === MILESTONING_STEREOTYPE.BITEMPORAL
+    ) {
+      const parameterValue = new ParameterValue();
+      parameterValue.name = PROCESSING_DATE_MILESTONING_PROPERTY_NAME;
+      parameterValue.value = {
+        _type: V1_RawValueSpecificationType.CSTRICTDATE,
+        value: this.processingDate,
+      };
+      parameters.push(parameterValue);
+    }
+    if (
+      currentClassMilestoningStrategy ===
+        MILESTONING_STEREOTYPE.BUSINESS_TEMPORAL ||
+      currentClassMilestoningStrategy === MILESTONING_STEREOTYPE.BITEMPORAL
+    ) {
+      const parameterValue = new ParameterValue();
+      parameterValue.name = BUSINESS_DATE_MILESTONING_PROPERTY_NAME;
+      parameterValue.value = {
+        _type: V1_RawValueSpecificationType.CSTRICTDATE,
+        value: this.businessDate,
+      };
+      parameters.push(parameterValue);
+    }
+    return parameters;
+  }
+
   *fetchStructuralValidations(): GeneratorFn<void> {
     const packagePath = this.constraintsConfigurationElement.path;
     const model = this.graphManagerState.graph;

package/src/graph-manager/protocol/pure/DSL_DataQuality_PureGraphManagerExtension.ts

@@ -20,6 +20,7 @@ import {
   type ExecutionResult,
   type PureModel,
   type RootGraphFetchTree,
+  type ParameterValue,
   AbstractPureGraphManagerExtension,
 } from '@finos/legend-graph';
 import { guaranteeNonNullable } from '@finos/legend-shared';
@@ -32,6 +33,7 @@ export abstract class DSL_DataQuality_PureGraphManagerExtension extends Abstract
 
   abstract execute(
     graph: PureModel,
+    lambdaParameterValues: ParameterValue[],
     packagePath: string,
     previewLimit: number,
   ): Promise<ExecutionResult>;

package/src/graph-manager/protocol/pure/v1/V1_DSL_Data_Quality_PureGraphManagerExtension.ts

@@ -24,6 +24,8 @@ import {
   type V1_ExecutionResult,
   type V1_PureModelContext,
   type V1_RootGraphFetchTree,
+  type ParameterValue,
+  type V1_ParameterValue,
   LegendSDLC,
   PureClientVersion,
   V1_buildExecutionError,
@@ -37,6 +39,8 @@ import {
   V1_PureModelContextPointer,
   V1_pureModelContextPropSchema,
   V1_serializeExecutionResult,
+  V1_parameterValueModelSchema,
+  V1_transformParameterValue,
 } from '@finos/legend-graph';
 import { createModelSchema, optional, primitive } from 'serializr';
 import {
@@ -47,6 +51,7 @@ import {
   returnUndefOnError,
   SerializationFactory,
   UnsupportedOperationError,
+  customListWithSchema,
 } from '@finos/legend-shared';
 import { DSL_DataQuality_PureGraphManagerExtension } from '../DSL_DataQuality_PureGraphManagerExtension.js';
 import {
@@ -63,6 +68,7 @@ const DQ_FETCH_PROPERTY_PATH_TREE = 'dq fetch property path tree';
 export class V1_DQExecuteInput {
   clientVersion: string | undefined;
   model!: V1_PureModelContext;
+  lambdaParameterValues: V1_ParameterValue[] = [];
   packagePath!: string;
   queryLimit: number | undefined;
 
@@ -70,6 +76,7 @@ export class V1_DQExecuteInput {
     createModelSchema(V1_DQExecuteInput, {
       clientVersion: optional(primitive()),
       model: V1_pureModelContextPropSchema,
+      lambdaParameterValues: customListWithSchema(V1_parameterValueModelSchema),
       packagePath: primitive(),
       queryLimit: optional(primitive()),
     }),
@@ -143,6 +150,7 @@ export class V1_DSL_Data_Quality_PureGraphManagerExtension extends DSL_DataQuali
 
   createExecutionInput(
     graph: PureModel,
+    lambdaParameterValues: ParameterValue[],
     packagePath: string,
     clientVersion: string | undefined,
     previewLimit: number | undefined,
@@ -152,6 +160,9 @@ export class V1_DSL_Data_Quality_PureGraphManagerExtension extends DSL_DataQuali
     dqExecuteInput.model = graph.origin
       ? this.buildPureModelSDLCPointer(graph.origin, undefined)
       : this.graphManager.getFullGraphModelData(graph);
+    dqExecuteInput.lambdaParameterValues = lambdaParameterValues.map(
+      V1_transformParameterValue,
+    );
     dqExecuteInput.packagePath = packagePath;
     dqExecuteInput.queryLimit = previewLimit;
     return dqExecuteInput;
@@ -163,6 +174,7 @@ export class V1_DSL_Data_Quality_PureGraphManagerExtension extends DSL_DataQuali
   ): Promise<RawExecutionPlan> => {
     const input = this.createExecutionInput(
       graph,
+      [],
       packagePath,
       V1_DSL_Data_Quality_PureGraphManagerExtension.DEV_PROTOCOL_VERSION,
       undefined,
@@ -186,11 +198,13 @@ export class V1_DSL_Data_Quality_PureGraphManagerExtension extends DSL_DataQuali
 
   execute = async (
     graph: PureModel,
+    lambdaParameterValues: ParameterValue[],
     packagePath: string,
     previewLimit: number,
   ): Promise<ExecutionResult> => {
     const input = this.createExecutionInput(
       graph,
+      lambdaParameterValues,
       packagePath,
       V1_DSL_Data_Quality_PureGraphManagerExtension.DEV_PROTOCOL_VERSION,
       previewLimit,
@@ -229,6 +243,7 @@ export class V1_DSL_Data_Quality_PureGraphManagerExtension extends DSL_DataQuali
   ): Promise<{ plan: RawExecutionPlan; debug: string }> => {
     const input = this.createExecutionInput(
       graph,
+      [],
       packagePath,
       V1_DSL_Data_Quality_PureGraphManagerExtension.DEV_PROTOCOL_VERSION,
       undefined,
@@ -261,6 +276,7 @@ export class V1_DSL_Data_Quality_PureGraphManagerExtension extends DSL_DataQuali
     const engineServerClient = this.graphManager.engine.getEngineServerClient();
     const input = this.createExecutionInput(
       graph,
+      [],
       packagePath,
       V1_DSL_Data_Quality_PureGraphManagerExtension.DEV_PROTOCOL_VERSION,
       undefined,

package/style/index.scss

@@ -66,3 +66,105 @@
   width: 15rem;
   font-size: 1.2rem;
 }
+
+.validation-date-selection-modal {
+  padding: 0;
+  width: 25vw;
+  overflow: hidden;
+
+  &__root-container {
+    margin-top: 0 !important;
+  }
+
+  &__container {
+    align-items: center !important;
+  }
+
+  &__content {
+    max-width: 100vw !important;
+  }
+
+  &__content--scrollable {
+    max-width: 100vw !important;
+  }
+
+  .modal__body {
+    height: calc(100% - 8.6rem);
+    padding: 1rem;
+  }
+
+  .modal__body.modal__body--footless {
+    height: calc(100% - 3.6rem);
+  }
+
+  &__absolute-date {
+    padding-bottom: 1rem;
+    border-top: 0.1rem solid var(--color-dark-grey-50);
+
+    &__input {
+      height: 2.8rem;
+      border: 0.1rem solid var(--color-dark-grey-300);
+      color-scheme: dark;
+      font-size: 1.2rem;
+    }
+  }
+}
+
+.trial-runs-result-modifier-prompt {
+  @include flexVCenter;
+
+  overflow-x: auto;
+  overflow-y: hidden;
+
+  &__header {
+    @include flexVCenter;
+
+    height: 2.2rem;
+
+    &__label {
+      @include flexVCenter;
+
+      height: 2.2rem;
+      padding: 1rem;
+      text-underline-position: under;
+    }
+
+    &__label__icon {
+      font-size: 1.3rem;
+      margin-right: 0.7rem;
+    }
+
+    &__label__title {
+      white-space: nowrap;
+      font-size: 1.3rem;
+      font-weight: 500;
+    }
+  }
+
+  &__divider {
+    color: var(--color-light-grey-200);
+    margin-right: 1rem;
+  }
+
+  &__divider--light {
+    margin-left: 1rem;
+  }
+
+  &__group {
+    @include flexVCenter;
+
+    &__label {
+      display: flex;
+      align-items: center;
+      justify-content: center;
+      padding: 0.7rem;
+      height: 2.2rem;
+      background: var(--color-dark-grey-280);
+      color: var(--color-light-grey-200);
+      white-space: nowrap;
+      line-height: 1.8rem;
+      border-radius: 0.1rem;
+      font-size: 1.1rem;
+    }
+  }
+}

package/tsconfig.json

@@ -116,6 +116,7 @@
     "./src/components/DataQualityClassValidationEditor.tsx",
     "./src/components/DataQualityConstraintsSelection.tsx",
     "./src/components/DataQualityDataSpaceBuilder.tsx",
+    "./src/components/DataQualityDateSelectionPanel.tsx",
     "./src/components/DataQualityExplorerPanel.tsx",
     "./src/components/DataQualityFilterPanel.tsx",
     "./src/components/DataQualityMappingAndRuntimeBuilder.tsx",