@finos/legend-data-cube 0.3.118 → 0.3.119

package/src/stores/core/filter/DataCubeQueryFilterOperation__GreaterThan.tsx

@@ -23,6 +23,7 @@ import {
   isPrimitiveType,
   ofDataType,
   _defaultPrimitiveTypeValue,
+  isCurrentMomentValue,
   type DataCubeOperationValue,
 } from '../DataCubeQueryEngine.js';
 import {
@@ -60,6 +61,12 @@ export class DataCubeQueryFilterOperation__GreaterThan extends DataCubeQueryFilt
   }
 
   isCompatibleWithValue(value: DataCubeOperationValue) {
+    // current-moment values (`today()`/`now()`) are date values resolved at
+    // execution time; the column they apply to is checked in
+    // `_finalizeConditionSnapshot()`
+    if (isCurrentMomentValue(value)) {
+      return true;
+    }
     return (
       value.value !== undefined &&
       isPrimitiveType(value.type) &&

package/src/stores/core/filter/DataCubeQueryFilterOperation__GreaterThanOrEqual.tsx

@@ -23,6 +23,7 @@ import {
   isPrimitiveType,
   ofDataType,
   _defaultPrimitiveTypeValue,
+  isCurrentMomentValue,
   type DataCubeOperationValue,
 } from '../DataCubeQueryEngine.js';
 import {
@@ -60,6 +61,12 @@ export class DataCubeQueryFilterOperation__GreaterThanOrEqual extends DataCubeQu
   }
 
   isCompatibleWithValue(value: DataCubeOperationValue) {
+    // current-moment values (`today()`/`now()`) are date values resolved at
+    // execution time; the column they apply to is checked in
+    // `_finalizeConditionSnapshot()`
+    if (isCurrentMomentValue(value)) {
+      return true;
+    }
     return (
       value.value !== undefined &&
       isPrimitiveType(value.type) &&

package/src/stores/core/filter/DataCubeQueryFilterOperation__LessThan.tsx

@@ -24,6 +24,7 @@ import {
   isPrimitiveType,
   ofDataType,
   _defaultPrimitiveTypeValue,
+  isCurrentMomentValue,
   type DataCubeOperationValue,
 } from '../DataCubeQueryEngine.js';
 import {
@@ -61,6 +62,12 @@ export class DataCubeQueryFilterOperation__LessThan extends DataCubeQueryFilterO
   }
 
   isCompatibleWithValue(value: DataCubeOperationValue) {
+    // current-moment values (`today()`/`now()`) are date values resolved at
+    // execution time; the column they apply to is checked in
+    // `_finalizeConditionSnapshot()`
+    if (isCurrentMomentValue(value)) {
+      return true;
+    }
     return (
       value.value !== undefined &&
       isPrimitiveType(value.type) &&

package/src/stores/core/filter/DataCubeQueryFilterOperation__LessThanOrEqual.tsx

@@ -23,6 +23,7 @@ import {
   isPrimitiveType,
   ofDataType,
   _defaultPrimitiveTypeValue,
+  isCurrentMomentValue,
   type DataCubeOperationValue,
 } from '../DataCubeQueryEngine.js';
 import {
@@ -60,6 +61,12 @@ export class DataCubeQueryFilterOperation__LessThanOrEqual extends DataCubeQuery
   }
 
   isCompatibleWithValue(value: DataCubeOperationValue) {
+    // current-moment values (`today()`/`now()`) are date values resolved at
+    // execution time; the column they apply to is checked in
+    // `_finalizeConditionSnapshot()`
+    if (isCurrentMomentValue(value)) {
+      return true;
+    }
     return (
       value.value !== undefined &&
       isPrimitiveType(value.type) &&

package/src/stores/core/filter/DataCubeQueryFilterOperation__NotEqual.tsx

@@ -23,6 +23,7 @@ import {
   isPrimitiveType,
   ofDataType,
   _defaultPrimitiveTypeValue,
+  isCurrentMomentValue,
   type DataCubeOperationValue,
 } from '../DataCubeQueryEngine.js';
 import {
@@ -67,6 +68,12 @@ export class DataCubeQueryFilterOperation__NotEqual extends DataCubeQueryFilterO
   }
 
   isCompatibleWithValue(value: DataCubeOperationValue) {
+    // current-moment values (`today()`/`now()`) are date values resolved at
+    // execution time; the column they apply to is checked in
+    // `_finalizeConditionSnapshot()`
+    if (isCurrentMomentValue(value)) {
+      return true;
+    }
     return (
       value.value !== undefined &&
       isPrimitiveType(value.type) &&

package/src/stores/view/filter/DataCubeFilterEditorState.tsx

@@ -79,7 +79,9 @@ export class DataCubeFilterEditorState extends DataCubeSnapshotController {
       {
         x: -50,
         y: 50,
-        width: 600,
+        // NOTE: wide enough to fit a condition on a date-time column, whose
+        // value is specified down to the second
+        width: 750,
         height: 400,
         minWidth: 300,
         minHeight: 200,

package/tsconfig.json

@@ -55,6 +55,7 @@
     "./src/__lib__/DataCubeEvent.ts",
     "./src/__lib__/DataCubeSetting.ts",
     "./src/__lib__/DataCubeTesting.ts",
+    "./src/components/view/filter/DataCubeFilterEditorUtils.ts",
     "./src/stores/DataCubeAPI.ts",
     "./src/stores/DataCubeOptions.ts",
     "./src/stores/core/DataCubeConfigurationBuilder.ts",