@finos/legend-data-cube 0.0.43 → 0.0.44

package/src/stores/core/aggregation/DataCubeQueryAggregateOperation.ts

@@ -14,24 +14,11 @@
  * limitations under the License.
  */
 
-import { guaranteeNonNullable } from '@finos/legend-shared';
 import type { DataCubeColumn } from '../model/DataCubeColumn.js';
 import { type V1_ColSpec } from '@finos/legend-graph';
 import type { DataCubeColumnConfiguration } from '../model/DataCubeConfiguration.js';
-
-// --------------------------------- UTILITIES ---------------------------------
-
-export function getAggregateOperation(
-  operator: string,
-  aggregateOperations: DataCubeQueryAggregateOperation[],
-) {
-  return guaranteeNonNullable(
-    aggregateOperations.find((op) => op.operator === operator),
-    `Can't find aggregate operation '${operator}'`,
-  );
-}
-
-// --------------------------------- CONTRACT ---------------------------------
+import type { DataCubeOperationValue } from '../DataCubeQueryEngine.js';
+import type { DataCubeQuerySnapshotAggregateColumn } from '../DataCubeQuerySnapshot.js';
 
 export abstract class DataCubeQueryAggregateOperation {
   abstract get label(): React.ReactNode;
@@ -40,8 +27,44 @@ export abstract class DataCubeQueryAggregateOperation {
   abstract get operator(): string;
 
   abstract isCompatibleWithColumn(column: DataCubeColumn): boolean;
+  abstract isCompatibleWithParameterValues(
+    values: DataCubeOperationValue[],
+  ): boolean;
+  abstract generateDefaultParameterValues(
+    column: DataCubeColumn,
+  ): DataCubeOperationValue[];
+
+  abstract buildAggregateColumnSnapshot(
+    colSpec: V1_ColSpec,
+    columnGetter: (name: string) => DataCubeColumn,
+  ): DataCubeQuerySnapshotAggregateColumn | undefined;
+
+  protected _finalizeAggregateColumnSnapshot(
+    data:
+      | {
+          column: DataCubeColumn;
+          paramterValues: DataCubeOperationValue[];
+        }
+      | undefined,
+  ): DataCubeQuerySnapshotAggregateColumn | undefined {
+    if (!data) {
+      return undefined;
+    }
+    const { column, paramterValues } = data;
+    if (
+      !this.isCompatibleWithColumn(column) ||
+      !this.isCompatibleWithParameterValues(paramterValues)
+    ) {
+      return undefined;
+    }
+    return {
+      ...column,
+      operator: this.operator,
+      parameterValues: paramterValues,
+    };
+  }
 
-  abstract buildAggregateColumn(
+  abstract buildAggregateColumnExpression(
     column: DataCubeColumnConfiguration,
   ): V1_ColSpec | undefined;
 }

package/src/stores/core/aggregation/DataCubeQueryAggregateOperation__Average.tsx

@@ -21,9 +21,12 @@ import {
   DataCubeColumnDataType,
   DataCubeFunction,
   ofDataType,
+  type DataCubeOperationValue,
 } from '../DataCubeQueryEngine.js';
-import { _aggCol_basic } from '../DataCubeQueryBuilderUtils.js';
+import { _aggCol_base } from '../DataCubeQueryBuilderUtils.js';
 import type { DataCubeColumnConfiguration } from '../model/DataCubeConfiguration.js';
+import type { V1_ColSpec } from '@finos/legend-graph';
+import { _agg_base } from '../DataCubeQuerySnapshotBuilderUtils.js';
 
 export class DataCubeQueryAggregateOperation__Average extends DataCubeQueryAggregateOperation {
   override get label() {
@@ -42,11 +45,30 @@ export class DataCubeQueryAggregateOperation__Average extends DataCubeQueryAggre
     return DataCubeQueryAggregateOperator.AVERAGE;
   }
 
-  isCompatibleWithColumn(column: DataCubeColumn) {
+  override isCompatibleWithColumn(column: DataCubeColumn) {
     return ofDataType(column.type, [DataCubeColumnDataType.NUMBER]);
   }
 
-  buildAggregateColumn(column: DataCubeColumnConfiguration) {
-    return _aggCol_basic(column, DataCubeFunction.AVERAGE);
+  override isCompatibleWithParameterValues(values: DataCubeOperationValue[]) {
+    return !values.length;
+  }
+
+  override generateDefaultParameterValues(
+    column: DataCubeColumn,
+  ): DataCubeOperationValue[] {
+    return [];
+  }
+
+  override buildAggregateColumnSnapshot(
+    colSpec: V1_ColSpec,
+    columnGetter: (name: string) => DataCubeColumn,
+  ) {
+    return this._finalizeAggregateColumnSnapshot(
+      _agg_base(colSpec, DataCubeFunction.AVERAGE, columnGetter),
+    );
+  }
+
+  override buildAggregateColumnExpression(column: DataCubeColumnConfiguration) {
+    return _aggCol_base(column, DataCubeFunction.AVERAGE);
   }
 }

package/src/stores/core/aggregation/DataCubeQueryAggregateOperation__Count.tsx

@@ -21,9 +21,12 @@ import {
   DataCubeColumnDataType,
   DataCubeFunction,
   ofDataType,
+  type DataCubeOperationValue,
 } from '../DataCubeQueryEngine.js';
-import { _aggCol_basic } from '../DataCubeQueryBuilderUtils.js';
+import { _aggCol_base } from '../DataCubeQueryBuilderUtils.js';
 import type { DataCubeColumnConfiguration } from '../model/DataCubeConfiguration.js';
+import type { V1_ColSpec } from '@finos/legend-graph';
+import { _agg_base } from '../DataCubeQuerySnapshotBuilderUtils.js';
 
 export class DataCubeQueryAggregateOperation__Count extends DataCubeQueryAggregateOperation {
   override get label() {
@@ -42,7 +45,7 @@ export class DataCubeQueryAggregateOperation__Count extends DataCubeQueryAggrega
     return DataCubeQueryAggregateOperator.COUNT;
   }
 
-  isCompatibleWithColumn(column: DataCubeColumn) {
+  override isCompatibleWithColumn(column: DataCubeColumn) {
     return ofDataType(column.type, [
       // NOTE: technically all data types are suported,
       // but we can't because we must preserve the type
@@ -55,7 +58,26 @@ export class DataCubeQueryAggregateOperation__Count extends DataCubeQueryAggrega
     ]);
   }
 
-  buildAggregateColumn(column: DataCubeColumnConfiguration) {
-    return _aggCol_basic(column, DataCubeFunction.COUNT);
+  override isCompatibleWithParameterValues(values: DataCubeOperationValue[]) {
+    return !values.length;
+  }
+
+  override generateDefaultParameterValues(
+    column: DataCubeColumn,
+  ): DataCubeOperationValue[] {
+    return [];
+  }
+
+  override buildAggregateColumnSnapshot(
+    colSpec: V1_ColSpec,
+    columnGetter: (name: string) => DataCubeColumn,
+  ) {
+    return this._finalizeAggregateColumnSnapshot(
+      _agg_base(colSpec, DataCubeFunction.COUNT, columnGetter),
+    );
+  }
+
+  override buildAggregateColumnExpression(column: DataCubeColumnConfiguration) {
+    return _aggCol_base(column, DataCubeFunction.COUNT);
   }
 }

package/src/stores/core/aggregation/DataCubeQueryAggregateOperation__First.tsx

@@ -21,9 +21,12 @@ import {
   DataCubeColumnDataType,
   DataCubeFunction,
   ofDataType,
+  type DataCubeOperationValue,
 } from '../DataCubeQueryEngine.js';
-import { _aggCol_basic } from '../DataCubeQueryBuilderUtils.js';
+import { _aggCol_base } from '../DataCubeQueryBuilderUtils.js';
 import type { DataCubeColumnConfiguration } from '../model/DataCubeConfiguration.js';
+import type { V1_ColSpec } from '@finos/legend-graph';
+import { _agg_base } from '../DataCubeQuerySnapshotBuilderUtils.js';
 
 export class DataCubeQueryAggregateOperation__First extends DataCubeQueryAggregateOperation {
   override get label() {
@@ -42,7 +45,7 @@ export class DataCubeQueryAggregateOperation__First extends DataCubeQueryAggrega
     return DataCubeQueryAggregateOperator.FIRST;
   }
 
-  isCompatibleWithColumn(column: DataCubeColumn) {
+  override isCompatibleWithColumn(column: DataCubeColumn) {
     return ofDataType(column.type, [
       DataCubeColumnDataType.TEXT,
       DataCubeColumnDataType.NUMBER,
@@ -51,7 +54,26 @@ export class DataCubeQueryAggregateOperation__First extends DataCubeQueryAggrega
     ]);
   }
 
-  buildAggregateColumn(column: DataCubeColumnConfiguration) {
-    return _aggCol_basic(column, DataCubeFunction.FIRST);
+  override isCompatibleWithParameterValues(values: DataCubeOperationValue[]) {
+    return !values.length;
+  }
+
+  override generateDefaultParameterValues(
+    column: DataCubeColumn,
+  ): DataCubeOperationValue[] {
+    return [];
+  }
+
+  override buildAggregateColumnSnapshot(
+    colSpec: V1_ColSpec,
+    columnGetter: (name: string) => DataCubeColumn,
+  ) {
+    return this._finalizeAggregateColumnSnapshot(
+      _agg_base(colSpec, DataCubeFunction.FIRST, columnGetter),
+    );
+  }
+
+  override buildAggregateColumnExpression(column: DataCubeColumnConfiguration) {
+    return _aggCol_base(column, DataCubeFunction.FIRST);
   }
 }

package/src/stores/core/aggregation/DataCubeQueryAggregateOperation__JoinStrings.tsx

@@ -15,24 +15,19 @@
  */
 
 import type { DataCubeColumn } from '../model/DataCubeColumn.js';
-import { PRIMITIVE_TYPE } from '@finos/legend-graph';
+import { PRIMITIVE_TYPE, type V1_ColSpec } from '@finos/legend-graph';
 import { DataCubeQueryAggregateOperation } from './DataCubeQueryAggregateOperation.js';
 import {
   DataCubeQueryAggregateOperator,
   DataCubeColumnDataType,
   DataCubeFunction,
   ofDataType,
+  type DataCubeOperationValue,
 } from '../DataCubeQueryEngine.js';
-import {
-  _colSpec,
-  _function,
-  _functionName,
-  _lambda,
-  _primitiveValue,
-  _property,
-  _var,
-} from '../DataCubeQueryBuilderUtils.js';
 import type { DataCubeColumnConfiguration } from '../model/DataCubeConfiguration.js';
+import { _aggCol_base } from '../DataCubeQueryBuilderUtils.js';
+import { _agg_base } from '../DataCubeQuerySnapshotBuilderUtils.js';
+import { isString } from '@finos/legend-shared';
 
 export class DataCubeQueryAggregateOperation__JoinStrings extends DataCubeQueryAggregateOperation {
   override get label() {
@@ -51,7 +46,7 @@ export class DataCubeQueryAggregateOperation__JoinStrings extends DataCubeQueryA
     return DataCubeQueryAggregateOperator.JOIN_STRINGS;
   }
 
-  isCompatibleWithColumn(column: DataCubeColumn) {
+  override isCompatibleWithColumn(column: DataCubeColumn) {
     return ofDataType(column.type, [
       // NOTE: technically all data types should be suported,
       // i.e. we can use meta::pure::functions::string::makeString
@@ -61,21 +56,41 @@ export class DataCubeQueryAggregateOperation__JoinStrings extends DataCubeQueryA
     ]);
   }
 
-  buildAggregateColumn(column: DataCubeColumnConfiguration) {
-    const variable = _var();
-    return _colSpec(
-      column.name,
-      _lambda([variable], [_property(column.name, variable)]),
-      _lambda(
-        [variable],
-        [
-          _function(_functionName(DataCubeFunction.JOIN_STRINGS), [
-            variable,
-            // TODO: we might want to support customizing the delimiter in this case
-            _primitiveValue(PRIMITIVE_TYPE.STRING, ','),
-          ]),
-        ],
-      ),
+  override isCompatibleWithParameterValues(values: DataCubeOperationValue[]) {
+    return (
+      values.length === 1 &&
+      values[0] !== undefined &&
+      ofDataType(values[0].type, [DataCubeColumnDataType.TEXT]) &&
+      !Array.isArray(values[0].value) &&
+      isString(values[0].value)
+    );
+  }
+
+  override generateDefaultParameterValues(
+    column: DataCubeColumn,
+  ): DataCubeOperationValue[] {
+    return [
+      {
+        type: PRIMITIVE_TYPE.STRING,
+        value: '',
+      },
+    ];
+  }
+
+  override buildAggregateColumnSnapshot(
+    colSpec: V1_ColSpec,
+    columnGetter: (name: string) => DataCubeColumn,
+  ) {
+    return this._finalizeAggregateColumnSnapshot(
+      _agg_base(colSpec, DataCubeFunction.JOIN_STRINGS, columnGetter),
+    );
+  }
+
+  override buildAggregateColumnExpression(column: DataCubeColumnConfiguration) {
+    return _aggCol_base(
+      column,
+      DataCubeFunction.JOIN_STRINGS,
+      column.aggregationParameters,
     );
   }
 }

package/src/stores/core/aggregation/DataCubeQueryAggregateOperation__Last.tsx

@@ -21,9 +21,12 @@ import {
   DataCubeColumnDataType,
   DataCubeFunction,
   ofDataType,
+  type DataCubeOperationValue,
 } from '../DataCubeQueryEngine.js';
-import { _aggCol_basic } from '../DataCubeQueryBuilderUtils.js';
+import { _aggCol_base } from '../DataCubeQueryBuilderUtils.js';
 import type { DataCubeColumnConfiguration } from '../model/DataCubeConfiguration.js';
+import type { V1_ColSpec } from '@finos/legend-graph';
+import { _agg_base } from '../DataCubeQuerySnapshotBuilderUtils.js';
 
 export class DataCubeQueryAggregateOperation__Last extends DataCubeQueryAggregateOperation {
   override get label() {
@@ -42,7 +45,7 @@ export class DataCubeQueryAggregateOperation__Last extends DataCubeQueryAggregat
     return DataCubeQueryAggregateOperator.LAST;
   }
 
-  isCompatibleWithColumn(column: DataCubeColumn) {
+  override isCompatibleWithColumn(column: DataCubeColumn) {
     return ofDataType(column.type, [
       DataCubeColumnDataType.TEXT,
       DataCubeColumnDataType.NUMBER,
@@ -51,7 +54,26 @@ export class DataCubeQueryAggregateOperation__Last extends DataCubeQueryAggregat
     ]);
   }
 
-  buildAggregateColumn(column: DataCubeColumnConfiguration) {
-    return _aggCol_basic(column, DataCubeFunction.LAST);
+  override isCompatibleWithParameterValues(values: DataCubeOperationValue[]) {
+    return !values.length;
+  }
+
+  override generateDefaultParameterValues(
+    column: DataCubeColumn,
+  ): DataCubeOperationValue[] {
+    return [];
+  }
+
+  override buildAggregateColumnSnapshot(
+    colSpec: V1_ColSpec,
+    columnGetter: (name: string) => DataCubeColumn,
+  ) {
+    return this._finalizeAggregateColumnSnapshot(
+      _agg_base(colSpec, DataCubeFunction.LAST, columnGetter),
+    );
+  }
+
+  override buildAggregateColumnExpression(column: DataCubeColumnConfiguration) {
+    return _aggCol_base(column, DataCubeFunction.LAST);
   }
 }

package/src/stores/core/aggregation/DataCubeQueryAggregateOperation__Max.tsx

@@ -21,9 +21,12 @@ import {
   DataCubeColumnDataType,
   DataCubeFunction,
   ofDataType,
+  type DataCubeOperationValue,
 } from '../DataCubeQueryEngine.js';
-import { _aggCol_basic } from '../DataCubeQueryBuilderUtils.js';
+import { _aggCol_base } from '../DataCubeQueryBuilderUtils.js';
 import type { DataCubeColumnConfiguration } from '../model/DataCubeConfiguration.js';
+import type { V1_ColSpec } from '@finos/legend-graph';
+import { _agg_base } from '../DataCubeQuerySnapshotBuilderUtils.js';
 
 export class DataCubeQueryAggregateOperation__Max extends DataCubeQueryAggregateOperation {
   override get label() {
@@ -42,11 +45,30 @@ export class DataCubeQueryAggregateOperation__Max extends DataCubeQueryAggregate
     return DataCubeQueryAggregateOperator.MAX;
   }
 
-  isCompatibleWithColumn(column: DataCubeColumn) {
+  override isCompatibleWithColumn(column: DataCubeColumn) {
     return ofDataType(column.type, [DataCubeColumnDataType.NUMBER]);
   }
 
-  buildAggregateColumn(column: DataCubeColumnConfiguration) {
-    return _aggCol_basic(column, DataCubeFunction.MAX);
+  override isCompatibleWithParameterValues(values: DataCubeOperationValue[]) {
+    return !values.length;
+  }
+
+  override generateDefaultParameterValues(
+    column: DataCubeColumn,
+  ): DataCubeOperationValue[] {
+    return [];
+  }
+
+  override buildAggregateColumnSnapshot(
+    colSpec: V1_ColSpec,
+    columnGetter: (name: string) => DataCubeColumn,
+  ) {
+    return this._finalizeAggregateColumnSnapshot(
+      _agg_base(colSpec, DataCubeFunction.MAX, columnGetter),
+    );
+  }
+
+  override buildAggregateColumnExpression(column: DataCubeColumnConfiguration) {
+    return _aggCol_base(column, DataCubeFunction.MAX);
   }
 }

package/src/stores/core/aggregation/DataCubeQueryAggregateOperation__Min.tsx

@@ -21,9 +21,12 @@ import {
   DataCubeColumnDataType,
   DataCubeFunction,
   ofDataType,
+  type DataCubeOperationValue,
 } from '../DataCubeQueryEngine.js';
-import { _aggCol_basic } from '../DataCubeQueryBuilderUtils.js';
+import { _aggCol_base } from '../DataCubeQueryBuilderUtils.js';
 import type { DataCubeColumnConfiguration } from '../model/DataCubeConfiguration.js';
+import type { V1_ColSpec } from '@finos/legend-graph';
+import { _agg_base } from '../DataCubeQuerySnapshotBuilderUtils.js';
 
 export class DataCubeQueryAggregateOperation__Min extends DataCubeQueryAggregateOperation {
   override get label() {
@@ -42,11 +45,30 @@ export class DataCubeQueryAggregateOperation__Min extends DataCubeQueryAggregate
     return DataCubeQueryAggregateOperator.MIN;
   }
 
-  isCompatibleWithColumn(column: DataCubeColumn) {
+  override isCompatibleWithColumn(column: DataCubeColumn) {
     return ofDataType(column.type, [DataCubeColumnDataType.NUMBER]);
   }
 
-  buildAggregateColumn(column: DataCubeColumnConfiguration) {
-    return _aggCol_basic(column, DataCubeFunction.MIN);
+  override isCompatibleWithParameterValues(values: DataCubeOperationValue[]) {
+    return !values.length;
+  }
+
+  override generateDefaultParameterValues(
+    column: DataCubeColumn,
+  ): DataCubeOperationValue[] {
+    return [];
+  }
+
+  override buildAggregateColumnSnapshot(
+    colSpec: V1_ColSpec,
+    columnGetter: (name: string) => DataCubeColumn,
+  ) {
+    return this._finalizeAggregateColumnSnapshot(
+      _agg_base(colSpec, DataCubeFunction.MIN, columnGetter),
+    );
+  }
+
+  override buildAggregateColumnExpression(column: DataCubeColumnConfiguration) {
+    return _aggCol_base(column, DataCubeFunction.MIN);
   }
 }

package/src/stores/core/aggregation/DataCubeQueryAggregateOperation__StdDevPopulation.tsx

@@ -21,9 +21,12 @@ import {
   DataCubeColumnDataType,
   DataCubeFunction,
   ofDataType,
+  type DataCubeOperationValue,
 } from '../DataCubeQueryEngine.js';
-import { _aggCol_basic } from '../DataCubeQueryBuilderUtils.js';
+import { _aggCol_base } from '../DataCubeQueryBuilderUtils.js';
 import type { DataCubeColumnConfiguration } from '../model/DataCubeConfiguration.js';
+import type { V1_ColSpec } from '@finos/legend-graph';
+import { _agg_base } from '../DataCubeQuerySnapshotBuilderUtils.js';
 
 export class DataCubeQueryAggregateOperation__StdDevPopulation extends DataCubeQueryAggregateOperation {
   override get label() {
@@ -42,14 +45,34 @@ export class DataCubeQueryAggregateOperation__StdDevPopulation extends DataCubeQ
     return DataCubeQueryAggregateOperator.STANDARD_DEVIATION_POPULATION;
   }
 
-  isCompatibleWithColumn(column: DataCubeColumn) {
+  override isCompatibleWithColumn(column: DataCubeColumn) {
     return ofDataType(column.type, [DataCubeColumnDataType.NUMBER]);
   }
 
-  buildAggregateColumn(column: DataCubeColumnConfiguration) {
-    return _aggCol_basic(
-      column,
-      DataCubeFunction.STANDARD_DEVIATION_POPULATION,
+  override isCompatibleWithParameterValues(values: DataCubeOperationValue[]) {
+    return !values.length;
+  }
+
+  override generateDefaultParameterValues(
+    column: DataCubeColumn,
+  ): DataCubeOperationValue[] {
+    return [];
+  }
+
+  override buildAggregateColumnSnapshot(
+    colSpec: V1_ColSpec,
+    columnGetter: (name: string) => DataCubeColumn,
+  ) {
+    return this._finalizeAggregateColumnSnapshot(
+      _agg_base(
+        colSpec,
+        DataCubeFunction.STANDARD_DEVIATION_POPULATION,
+        columnGetter,
+      ),
     );
   }
+
+  override buildAggregateColumnExpression(column: DataCubeColumnConfiguration) {
+    return _aggCol_base(column, DataCubeFunction.STANDARD_DEVIATION_POPULATION);
+  }
 }

package/src/stores/core/aggregation/DataCubeQueryAggregateOperation__StdDevSample.tsx

@@ -21,9 +21,12 @@ import {
   DataCubeColumnDataType,
   DataCubeFunction,
   ofDataType,
+  type DataCubeOperationValue,
 } from '../DataCubeQueryEngine.js';
-import { _aggCol_basic } from '../DataCubeQueryBuilderUtils.js';
+import { _aggCol_base } from '../DataCubeQueryBuilderUtils.js';
 import type { DataCubeColumnConfiguration } from '../model/DataCubeConfiguration.js';
+import type { V1_ColSpec } from '@finos/legend-graph';
+import { _agg_base } from '../DataCubeQuerySnapshotBuilderUtils.js';
 
 export class DataCubeQueryAggregateOperation__StdDevSample extends DataCubeQueryAggregateOperation {
   override get label() {
@@ -42,11 +45,34 @@ export class DataCubeQueryAggregateOperation__StdDevSample extends DataCubeQuery
     return DataCubeQueryAggregateOperator.STANDARD_DEVIATION_SAMPLE;
   }
 
-  isCompatibleWithColumn(column: DataCubeColumn) {
+  override isCompatibleWithColumn(column: DataCubeColumn) {
     return ofDataType(column.type, [DataCubeColumnDataType.NUMBER]);
   }
 
-  buildAggregateColumn(column: DataCubeColumnConfiguration) {
-    return _aggCol_basic(column, DataCubeFunction.STANDARD_DEVIATION_SAMPLE);
+  override isCompatibleWithParameterValues(values: DataCubeOperationValue[]) {
+    return !values.length;
+  }
+
+  override generateDefaultParameterValues(
+    column: DataCubeColumn,
+  ): DataCubeOperationValue[] {
+    return [];
+  }
+
+  override buildAggregateColumnSnapshot(
+    colSpec: V1_ColSpec,
+    columnGetter: (name: string) => DataCubeColumn,
+  ) {
+    return this._finalizeAggregateColumnSnapshot(
+      _agg_base(
+        colSpec,
+        DataCubeFunction.STANDARD_DEVIATION_SAMPLE,
+        columnGetter,
+      ),
+    );
+  }
+
+  override buildAggregateColumnExpression(column: DataCubeColumnConfiguration) {
+    return _aggCol_base(column, DataCubeFunction.STANDARD_DEVIATION_SAMPLE);
   }
 }

package/src/stores/core/aggregation/DataCubeQueryAggregateOperation__Sum.tsx

@@ -21,9 +21,12 @@ import {
   DataCubeColumnDataType,
   DataCubeFunction,
   ofDataType,
+  type DataCubeOperationValue,
 } from '../DataCubeQueryEngine.js';
-import { _aggCol_basic } from '../DataCubeQueryBuilderUtils.js';
+import { _aggCol_base } from '../DataCubeQueryBuilderUtils.js';
 import type { DataCubeColumnConfiguration } from '../model/DataCubeConfiguration.js';
+import { type V1_ColSpec } from '@finos/legend-graph';
+import { _agg_base } from '../DataCubeQuerySnapshotBuilderUtils.js';
 
 export class DataCubeQueryAggregateOperation__Sum extends DataCubeQueryAggregateOperation {
   override get label() {
@@ -42,11 +45,30 @@ export class DataCubeQueryAggregateOperation__Sum extends DataCubeQueryAggregate
     return DataCubeQueryAggregateOperator.SUM;
   }
 
-  isCompatibleWithColumn(column: DataCubeColumn) {
+  override isCompatibleWithColumn(column: DataCubeColumn) {
     return ofDataType(column.type, [DataCubeColumnDataType.NUMBER]);
   }
 
-  buildAggregateColumn(column: DataCubeColumnConfiguration) {
-    return _aggCol_basic(column, DataCubeFunction.SUM);
+  override isCompatibleWithParameterValues(values: DataCubeOperationValue[]) {
+    return !values.length;
+  }
+
+  override generateDefaultParameterValues(
+    column: DataCubeColumn,
+  ): DataCubeOperationValue[] {
+    return [];
+  }
+
+  override buildAggregateColumnSnapshot(
+    colSpec: V1_ColSpec,
+    columnGetter: (name: string) => DataCubeColumn,
+  ) {
+    return this._finalizeAggregateColumnSnapshot(
+      _agg_base(colSpec, DataCubeFunction.SUM, columnGetter),
+    );
+  }
+
+  override buildAggregateColumnExpression(column: DataCubeColumnConfiguration) {
+    return _aggCol_base(column, DataCubeFunction.SUM);
   }
 }

package/src/stores/core/aggregation/DataCubeQueryAggregateOperation__UniqueValue.tsx

@@ -21,9 +21,12 @@ import {
   DataCubeColumnDataType,
   DataCubeFunction,
   ofDataType,
+  type DataCubeOperationValue,
 } from '../DataCubeQueryEngine.js';
-import { _aggCol_basic } from '../DataCubeQueryBuilderUtils.js';
+import { _aggCol_base } from '../DataCubeQueryBuilderUtils.js';
 import type { DataCubeColumnConfiguration } from '../model/DataCubeConfiguration.js';
+import type { V1_ColSpec } from '@finos/legend-graph';
+import { _agg_base } from '../DataCubeQuerySnapshotBuilderUtils.js';
 
 export class DataCubeQueryAggregateOperation__UniqueValue extends DataCubeQueryAggregateOperation {
   override get label() {
@@ -42,7 +45,7 @@ export class DataCubeQueryAggregateOperation__UniqueValue extends DataCubeQueryA
     return DataCubeQueryAggregateOperator.UNIQUE;
   }
 
-  isCompatibleWithColumn(column: DataCubeColumn) {
+  override isCompatibleWithColumn(column: DataCubeColumn) {
     return ofDataType(column.type, [
       DataCubeColumnDataType.TEXT,
       DataCubeColumnDataType.NUMBER,
@@ -51,7 +54,26 @@ export class DataCubeQueryAggregateOperation__UniqueValue extends DataCubeQueryA
     ]);
   }
 
-  buildAggregateColumn(column: DataCubeColumnConfiguration) {
-    return _aggCol_basic(column, DataCubeFunction.UNIQUE_VALUE_ONLY);
+  override isCompatibleWithParameterValues(values: DataCubeOperationValue[]) {
+    return !values.length;
+  }
+
+  override generateDefaultParameterValues(
+    column: DataCubeColumn,
+  ): DataCubeOperationValue[] {
+    return [];
+  }
+
+  override buildAggregateColumnSnapshot(
+    colSpec: V1_ColSpec,
+    columnGetter: (name: string) => DataCubeColumn,
+  ) {
+    return this._finalizeAggregateColumnSnapshot(
+      _agg_base(colSpec, DataCubeFunction.UNIQUE_VALUE_ONLY, columnGetter),
+    );
+  }
+
+  override buildAggregateColumnExpression(column: DataCubeColumnConfiguration) {
+    return _aggCol_base(column, DataCubeFunction.UNIQUE_VALUE_ONLY);
   }
 }