@finos/legend-data-cube 0.0.36 → 0.0.38

package/src/stores/view/DataCubeViewState.ts

@@ -17,11 +17,11 @@
 import { DataCubeGridState } from './grid/DataCubeGridState.js';
 import { DataCubeEditorState } from './editor/DataCubeEditorState.js';
 import {
+  ActionState,
   assertErrorThrown,
   IllegalStateError,
-  uuid,
 } from '@finos/legend-shared';
-import { DataCubeQuerySnapshotManager } from './DataCubeQuerySnapshotManager.js';
+import { DataCubeQuerySnapshotService } from '../services/DataCubeQuerySnapshotService.js';
 import { DataCubeInfoState } from './DataCubeInfoState.js';
 import { validateAndBuildQuerySnapshot } from '../core/DataCubeQuerySnapshotBuilder.js';
 import {
@@ -34,31 +34,25 @@ import {
 import { DataCubeFilterEditorState } from './filter/DataCubeFilterEditorState.js';
 import { DataCubeExtendManagerState } from './extend/DataCubeExtendManagerState.js';
 import type { DataCubeState } from '../DataCubeState.js';
-import type { DataCubeEngine } from '../core/DataCubeEngine.js';
-import { AlertType } from '../../components/core/DataCubeAlert.js';
-import type { DataCubeSource } from '../core/models/DataCubeSource.js';
-import type { DataCubeQuery } from '../core/models/DataCubeQuery.js';
-
-class DataCubeTask {
-  uuid = uuid();
-  name: string;
-  startTime = Date.now();
-  endTime?: number | undefined;
-
-  constructor(name: string) {
-    this.name = name;
-  }
-
-  end() {
-    this.endTime = Date.now();
-  }
-}
+import { type DataCubeEngine } from '../core/DataCubeEngine.js';
+import type { DataCubeSource } from '../core/model/DataCubeSource.js';
+import { DataCubeQuery } from '../core/model/DataCubeQuery.js';
+import { DataCubeTaskService } from '../services/DataCubeTaskService.js';
+import type { DataCubeLogService } from '../services/DataCubeLogService.js';
+import { DataCubeConfiguration } from '../core/model/DataCubeConfiguration.js';
+import type { DataCubeLayoutService } from '../services/DataCubeLayoutService.js';
+import type { DataCubeAlertService } from '../services/DataCubeAlertService.js';
+import type { DataCubeSettingService } from '../services/DataCubeSettingService.js';
 
 export class DataCubeViewState {
   readonly dataCube: DataCubeState;
   readonly engine: DataCubeEngine;
-
-  readonly snapshotManager: DataCubeQuerySnapshotManager;
+  readonly logService: DataCubeLogService;
+  readonly taskService: DataCubeTaskService;
+  readonly layoutService: DataCubeLayoutService;
+  readonly alertService: DataCubeAlertService;
+  readonly settingService: DataCubeSettingService;
+  readonly snapshotService: DataCubeQuerySnapshotService;
 
   readonly info: DataCubeInfoState;
   readonly editor: DataCubeEditorState;
@@ -66,7 +60,7 @@ export class DataCubeViewState {
   readonly filter: DataCubeFilterEditorState;
   readonly extend: DataCubeExtendManagerState;
 
-  readonly runningTasks = new Map<string, DataCubeTask>();
+  readonly initializeState = ActionState.create();
 
   private _source?: DataCubeSource | undefined;
 
@@ -74,19 +68,22 @@ export class DataCubeViewState {
     makeObservable<DataCubeViewState, '_source'>(this, {
       _source: observable,
       source: computed,
-      isSourceProcessed: computed,
 
-      runningTasks: observable,
-      newTask: action,
-      endTask: action,
+      initialize: action,
     });
 
     this.dataCube = dataCube;
     this.engine = dataCube.engine;
-    this.engine = dataCube.engine;
-
+    this.logService = dataCube.logService;
+    this.taskService = new DataCubeTaskService(dataCube.taskService.manager);
+    this.layoutService = dataCube.layoutService;
+    this.alertService = dataCube.alertService;
+    this.settingService = dataCube.settingService;
     // NOTE: snapshot manager must be instantiated before subscribers
-    this.snapshotManager = new DataCubeQuerySnapshotManager(this);
+    this.snapshotService = new DataCubeQuerySnapshotService(
+      this.engine,
+      this.logService,
+    );
 
     this.info = new DataCubeInfoState(this);
     this.editor = new DataCubeEditorState(this);
@@ -95,8 +92,15 @@ export class DataCubeViewState {
     this.extend = new DataCubeExtendManagerState(this);
   }
 
-  get isSourceProcessed() {
-    return Boolean(this._source);
+  async generateDataCubeQuery() {
+    const snapshot = this.snapshotService.currentSnapshot;
+    const query = new DataCubeQuery();
+    query.source = this.dataCube.query.source;
+    query.configuration = DataCubeConfiguration.serialization.fromJson(
+      snapshot.data.configuration,
+    );
+    query.query = await this.engine.getPartialQueryCode(snapshot);
+    return query;
   }
 
   get source() {
@@ -106,20 +110,10 @@ export class DataCubeViewState {
     return this._source;
   }
 
-  newTask(name: string) {
-    const task = new DataCubeTask(name);
-    this.runningTasks.set(task.uuid, task);
-    return task;
-  }
-
-  endTask(task: DataCubeTask) {
-    task.end();
-    this.runningTasks.delete(task.uuid);
-    return task;
-  }
+  async initialize(query: DataCubeQuery) {
+    this.initializeState.inProgress();
+    const task = this.taskService.newTask('Initializing');
 
-  async initialize(initialQuery?: DataCubeQuery | undefined) {
-    const task = this.newTask('Initializing');
     try {
       await Promise.all(
         [
@@ -130,42 +124,40 @@ export class DataCubeViewState {
           this.filter,
           this.extend,
         ].map(async (state) => {
-          this.snapshotManager.registerSubscriber(state);
+          this.snapshotService.registerSubscriber(state);
         }),
       );
-      const baseQuery = initialQuery ?? (await this.engine.getBaseQuery());
-      if (!baseQuery) {
-        this.dataCube.alertAction({
-          message: `Initialization Failure: No initial input provided`,
-          prompt: `Make sure to either specify the initial input when setting up DataCube or the initial input getter in engine.`,
-          type: AlertType.ERROR,
-          actions: [],
-        });
-        return;
-      }
-      const source = await this.engine.processQuerySource(baseQuery.source);
+      const source = await this.engine.processQuerySource(query.source);
       runInAction(() => {
         this._source = source;
       });
       const partialQuery = await this.engine.parseValueSpecification(
-        baseQuery.query,
+        query.query,
       );
       const initialSnapshot = validateAndBuildQuerySnapshot(
         partialQuery,
-        this.source,
-        baseQuery,
+        source,
+        query,
       );
-      this.snapshotManager.broadcastSnapshot(initialSnapshot);
-    } catch (error: unknown) {
+      this.snapshotService.broadcastSnapshot(initialSnapshot);
+      this.dataCube.options?.onViewInitialized?.({
+        api: this.dataCube.api,
+        source,
+      });
+      this.initializeState.pass();
+    } catch (error) {
       assertErrorThrown(error);
-      this.dataCube.alertAction({
+      this.alertService.alertError(error, {
         message: `Initialization Failure: ${error.message}`,
-        prompt: `Resolve the issue and reload the engine.`,
-        type: AlertType.ERROR,
-        actions: [],
+        text: `Resolve the issue and reload the engine.`,
       });
+      this.initializeState.fail();
     } finally {
-      this.endTask(task);
+      this.taskService.endTask(task);
     }
   }
+
+  dispose() {
+    this.taskService.dispose();
+  }
 }

package/src/stores/view/editor/DataCubeEditorColumnPropertiesPanelState.ts

@@ -25,13 +25,12 @@ import {
   guaranteeNonNullable,
   type PlainObject,
 } from '@finos/legend-shared';
-import type { DataCubeConfiguration } from '../../core/models/DataCubeConfiguration.js';
+import type { DataCubeConfiguration } from '../../core/model/DataCubeConfiguration.js';
 
 export class DataCubeEditorColumnPropertiesPanelState
   implements DataCubeQueryEditorPanelState
 {
-  readonly view!: DataCubeViewState;
-  readonly editor!: DataCubeEditorState;
+  private readonly _view!: DataCubeViewState;
 
   columns: DataCubeEditorMutableColumnConfiguration[] = [];
   selectedColumnName?: string | undefined;
@@ -52,8 +51,7 @@ export class DataCubeEditorColumnPropertiesPanelState
       applySnaphot: action,
     });
 
-    this.editor = editor;
-    this.view = editor.view;
+    this._view = editor.view;
   }
 
   getColumnConfiguration(colName: string | undefined) {
@@ -89,7 +87,7 @@ export class DataCubeEditorColumnPropertiesPanelState
           DataCubeEditorMutableColumnConfiguration.create(
             column,
             snapshot,
-            this.view.engine.aggregateOperations,
+            this._view.engine.aggregateOperations,
           ),
       ),
     );

package/src/stores/view/editor/DataCubeEditorColumnSelectorState.ts

@@ -15,10 +15,9 @@
  */
 
 import { makeObservable, observable, action, computed } from 'mobx';
-import type { DataCubeViewState } from '../DataCubeViewState.js';
 import type { DataCubeEditorState } from './DataCubeEditorState.js';
 import { guaranteeNonNullable } from '@finos/legend-shared';
-import { _sortByColName } from '../../core/models/DataCubeColumn.js';
+import { _sortByColName } from '../../core/model/DataCubeColumn.js';
 
 export class DataCubeEditorColumnSelectorColumnState {
   readonly name: string;
@@ -33,8 +32,7 @@ export class DataCubeEditorColumnSelectorColumnState {
 export abstract class DataCubeEditorColumnSelectorState<
   T extends DataCubeEditorColumnSelectorColumnState,
 > {
-  readonly view!: DataCubeViewState;
-  readonly editor!: DataCubeEditorState;
+  protected readonly _editor!: DataCubeEditorState;
 
   selectedColumns: T[] = [];
 
@@ -68,8 +66,7 @@ export abstract class DataCubeEditorColumnSelectorState<
       setSelectedColumnsSearchText: action,
     });
 
-    this.editor = editor;
-    this.view = editor.view;
+    this._editor = editor;
     this.onChange = options?.onChange;
   }
 

package/src/stores/view/editor/DataCubeEditorColumnsPanelState.ts

@@ -15,16 +15,15 @@
  */
 
 import { action, makeObservable, observable, override } from 'mobx';
-import type { DataCubeViewState } from '../DataCubeViewState.js';
 import { type DataCubeQuerySnapshot } from '../../core/DataCubeQuerySnapshot.js';
-import { _toCol } from '../../core/models/DataCubeColumn.js';
+import { _toCol } from '../../core/model/DataCubeColumn.js';
 import type { DataCubeQueryEditorPanelState } from './DataCubeEditorPanelState.js';
 import {
   DataCubeEditorColumnSelectorColumnState,
   DataCubeEditorColumnSelectorState,
 } from './DataCubeEditorColumnSelectorState.js';
 import type { DataCubeEditorState } from './DataCubeEditorState.js';
-import { type DataCubeConfiguration } from '../../core/models/DataCubeConfiguration.js';
+import { type DataCubeConfiguration } from '../../core/model/DataCubeConfiguration.js';
 
 export class DataCubeEditorBasicColumnSelectorState extends DataCubeEditorColumnSelectorState<DataCubeEditorColumnSelectorColumnState> {
   showHiddenColumns = false;
@@ -59,9 +58,9 @@ export class DataCubeEditorBasicColumnSelectorState extends DataCubeEditorColumn
 
   override get availableColumns() {
     return [
-      ...this.editor.sourceColumns,
-      ...this.editor.leafExtendColumns,
-      ...this.editor.groupExtendColumns,
+      ...this._editor.sourceColumns,
+      ...this._editor.leafExtendColumns,
+      ...this._editor.groupExtendColumns,
     ].map(
       (col) => new DataCubeEditorColumnSelectorColumnState(col.name, col.type),
     );
@@ -71,7 +70,7 @@ export class DataCubeEditorBasicColumnSelectorState extends DataCubeEditorColumn
     return super.availableColumnsForDisplay.filter(
       (column) =>
         this.showHiddenColumns ||
-        !this.editor.columnProperties.getColumnConfiguration(column.name)
+        !this._editor.columnProperties.getColumnConfiguration(column.name)
           .hideFromView,
     );
   }
@@ -80,7 +79,7 @@ export class DataCubeEditorBasicColumnSelectorState extends DataCubeEditorColumn
     return super.selectedColumnsForDisplay.filter(
       (column) =>
         this.showHiddenColumns ||
-        !this.editor.columnProperties.getColumnConfiguration(column.name)
+        !this._editor.columnProperties.getColumnConfiguration(column.name)
           .hideFromView,
     );
   }
@@ -103,8 +102,8 @@ export class DataCubeEditorBasicColumnSelectorState extends DataCubeEditorColumn
 export class DataCubeEditorColumnsPanelState
   implements DataCubeQueryEditorPanelState
 {
-  readonly view!: DataCubeViewState;
-  readonly editor!: DataCubeEditorState;
+  private readonly _editor!: DataCubeEditorState;
+
   readonly selector!: DataCubeEditorBasicColumnSelectorState;
 
   constructor(editor: DataCubeEditorState) {
@@ -112,16 +111,15 @@ export class DataCubeEditorColumnsPanelState
       applySnaphot: action,
     });
 
-    this.editor = editor;
-    this.view = editor.view;
+    this._editor = editor;
     this.selector = new DataCubeEditorBasicColumnSelectorState(editor, {
       onChange: (selector) => {
         const selectedColumnConfigurations = selector.selectedColumns.map(
           (col) =>
-            this.editor.columnProperties.getColumnConfiguration(col.name),
+            this._editor.columnProperties.getColumnConfiguration(col.name),
         );
         const unselectedColumnConfigurations =
-          this.editor.columnProperties.columns.filter(
+          this._editor.columnProperties.columns.filter(
             (col) => !selectedColumnConfigurations.includes(col),
           );
 
@@ -132,7 +130,7 @@ export class DataCubeEditorColumnsPanelState
         unselectedColumnConfigurations.forEach((col) =>
           col.setIsSelected(false),
         );
-        this.editor.columnProperties.setColumns([
+        this._editor.columnProperties.setColumns([
           ...selectedColumnConfigurations,
           ...unselectedColumnConfigurations,
         ]);
@@ -147,7 +145,7 @@ export class DataCubeEditorColumnsPanelState
    * (i.e. publishes a new snapshot)
    */
   propagateChanges(): void {
-    this.editor.sorts.adaptPropagatedChanges();
+    this._editor.sorts.adaptPropagatedChanges();
   }
 
   applySnaphot(
@@ -155,7 +153,7 @@ export class DataCubeEditorColumnsPanelState
     configuration: DataCubeConfiguration,
   ) {
     this.selector.setSelectedColumns(
-      this.editor.columnProperties.columns
+      this._editor.columnProperties.columns
         // extract from the configuration since it specifies the order of columns
         // there taking into account group-level extended columns
         .filter((col) => col.isSelected)
@@ -187,7 +185,7 @@ export class DataCubeEditorColumnsPanelState
       // filter out group-level extended columns since these columns are technically not selectable
       .filter(
         (col) =>
-          !this.editor.groupExtendColumns.find(
+          !this._editor.groupExtendColumns.find(
             (column) => column.name === col.name,
           ),
       )

package/src/stores/view/editor/DataCubeEditorGeneralPropertiesPanelState.ts

@@ -15,19 +15,15 @@
  */
 
 import { action, makeObservable, observable } from 'mobx';
-import type { DataCubeViewState } from '../DataCubeViewState.js';
 import { type DataCubeQuerySnapshot } from '../../core/DataCubeQuerySnapshot.js';
 import type { DataCubeQueryEditorPanelState } from './DataCubeEditorPanelState.js';
 import type { DataCubeEditorState } from './DataCubeEditorState.js';
 import { DataCubeEditorMutableConfiguration } from './DataCubeEditorMutableConfiguration.js';
-import type { DataCubeConfiguration } from '../../core/models/DataCubeConfiguration.js';
+import type { DataCubeConfiguration } from '../../core/model/DataCubeConfiguration.js';
 
 export class DataCubeEditorGeneralPropertiesPanelState
   implements DataCubeQueryEditorPanelState
 {
-  readonly view!: DataCubeViewState;
-  readonly editor!: DataCubeEditorState;
-
   limit: number | undefined = undefined;
   configuration = new DataCubeEditorMutableConfiguration();
 
@@ -40,9 +36,6 @@ export class DataCubeEditorGeneralPropertiesPanelState
 
       applySnaphot: action,
     });
-
-    this.editor = editor;
-    this.view = editor.view;
   }
 
   setLimit(val: number | undefined): void {

package/src/stores/view/editor/DataCubeEditorHorizontalPivotsPanelState.ts

@@ -15,8 +15,7 @@
  */
 
 import { action, computed, makeObservable, observable } from 'mobx';
-import type { DataCubeViewState } from '../DataCubeViewState.js';
-import type { DataCubeConfiguration } from '../../core/models/DataCubeConfiguration.js';
+import type { DataCubeConfiguration } from '../../core/model/DataCubeConfiguration.js';
 import {
   DataCubeColumnKind,
   isPivotResultColumnName,
@@ -25,7 +24,7 @@ import { type DataCubeQuerySnapshot } from '../../core/DataCubeQuerySnapshot.js'
 import {
   _toCol,
   type DataCubeColumn,
-} from '../../core/models/DataCubeColumn.js';
+} from '../../core/model/DataCubeColumn.js';
 import {
   DataCubeEditorColumnSelectorColumnState,
   DataCubeEditorColumnSelectorState,
@@ -45,12 +44,12 @@ export class DataCubeEditorHorizontalPivotColumnSelectorState extends DataCubeEd
   }
 
   override get availableColumns() {
-    return this.editor.columnProperties.columns
+    return this._editor.columnProperties.columns
       .filter(
         (col) =>
           col.kind === DataCubeColumnKind.DIMENSION &&
           // exclude group-level extended columns
-          !this.editor.groupExtendColumns.find(
+          !this._editor.groupExtendColumns.find(
             (column) => column.name === col.name,
           ),
       )
@@ -64,8 +63,8 @@ export class DataCubeEditorHorizontalPivotColumnSelectorState extends DataCubeEd
 export class DataCubeEditorHorizontalPivotsPanelState
   implements DataCubeQueryEditorPanelState
 {
-  readonly view!: DataCubeViewState;
-  readonly editor!: DataCubeEditorState;
+  private readonly _editor!: DataCubeEditorState;
+
   readonly selector!: DataCubeEditorHorizontalPivotColumnSelectorState;
 
   castColumns: DataCubeColumn[] = [];
@@ -79,8 +78,7 @@ export class DataCubeEditorHorizontalPivotsPanelState
       applySnaphot: action,
     });
 
-    this.editor = editor;
-    this.view = editor.view;
+    this._editor = editor;
     this.selector = new DataCubeEditorHorizontalPivotColumnSelectorState(
       editor,
     );
@@ -97,8 +95,8 @@ export class DataCubeEditorHorizontalPivotsPanelState
   }
 
   propagateChanges() {
-    this.editor.verticalPivots.adaptPropagatedChanges();
-    this.editor.sorts.adaptPropagatedChanges();
+    this._editor.verticalPivots.adaptPropagatedChanges();
+    this._editor.sorts.adaptPropagatedChanges();
   }
 
   applySnaphot(

package/src/stores/view/editor/DataCubeEditorMutableConfiguration.ts

@@ -45,7 +45,7 @@ import {
   DataCubeColumnConfiguration,
   DataCubeConfiguration,
   DataCubePivotLayoutConfiguration,
-} from '../../core/models/DataCubeConfiguration.js';
+} from '../../core/model/DataCubeConfiguration.js';
 import { buildDefaultColumnConfiguration } from '../../core/DataCubeConfigurationBuilder.js';
 import { type DataCubeQuerySnapshot } from '../../core/DataCubeQuerySnapshot.js';
 import {

package/src/stores/view/editor/DataCubeEditorPanelState.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import type { DataCubeConfiguration } from '../../core/models/DataCubeConfiguration.js';
+import type { DataCubeConfiguration } from '../../core/model/DataCubeConfiguration.js';
 import type { DataCubeQuerySnapshot } from '../../core/DataCubeQuerySnapshot.js';
 
 export interface DataCubeQueryEditorPanelState {

package/src/stores/view/editor/DataCubeEditorPivotLayoutPanelState.ts

@@ -15,20 +15,18 @@
  */
 
 import { action, makeObservable, observable } from 'mobx';
-import type { DataCubeViewState } from '../DataCubeViewState.js';
 import { type DataCubeQuerySnapshot } from '../../core/DataCubeQuerySnapshot.js';
 import type { DataCubeQueryEditorPanelState } from './DataCubeEditorPanelState.js';
 import type { DataCubeEditorState } from './DataCubeEditorState.js';
 import { DataCubeEditorMutablePivotLayoutConfiguration } from './DataCubeEditorMutableConfiguration.js';
-import type { DataCubeConfiguration } from '../../core/models/DataCubeConfiguration.js';
+import type { DataCubeConfiguration } from '../../core/model/DataCubeConfiguration.js';
 import type { PlainObject } from '@finos/legend-shared';
 import { _pruneExpandedPaths } from '../../core/DataCubeQuerySnapshotBuilderUtils.js';
 
 export class DataCubeEditorPivotLayoutPanelState
   implements DataCubeQueryEditorPanelState
 {
-  readonly view!: DataCubeViewState;
-  readonly editor!: DataCubeEditorState;
+  private readonly _editor!: DataCubeEditorState;
 
   pivotLayout = new DataCubeEditorMutablePivotLayoutConfiguration();
 
@@ -39,8 +37,7 @@ export class DataCubeEditorPivotLayoutPanelState
       applySnaphot: action,
     });
 
-    this.editor = editor;
-    this.view = editor.view;
+    this._editor = editor;
   }
 
   applySnaphot(
@@ -59,7 +56,7 @@ export class DataCubeEditorPivotLayoutPanelState
     this.pivotLayout.setExpandedPaths(
       _pruneExpandedPaths(
         baseSnapshot.data.groupBy?.columns ?? [],
-        this.editor.verticalPivots.selector.selectedColumns,
+        this._editor.verticalPivots.selector.selectedColumns,
         this.pivotLayout.expandedPaths,
       ),
     );

package/src/stores/view/editor/DataCubeEditorSortsPanelState.ts

@@ -15,9 +15,8 @@
  */
 
 import { action, makeObservable, observable } from 'mobx';
-import type { DataCubeViewState } from '../DataCubeViewState.js';
 import { type DataCubeQuerySnapshot } from '../../core/DataCubeQuerySnapshot.js';
-import { _toCol } from '../../core/models/DataCubeColumn.js';
+import { _toCol } from '../../core/model/DataCubeColumn.js';
 import {
   DataCubeColumnKind,
   DataCubeQuerySortDirection,
@@ -28,7 +27,7 @@ import {
   DataCubeEditorColumnSelectorState,
 } from './DataCubeEditorColumnSelectorState.js';
 import type { DataCubeEditorState } from './DataCubeEditorState.js';
-import type { DataCubeConfiguration } from '../../core/models/DataCubeConfiguration.js';
+import type { DataCubeConfiguration } from '../../core/model/DataCubeConfiguration.js';
 import { uniqBy } from '@finos/legend-shared';
 
 export class DataCubeEditorSortColumnState extends DataCubeEditorColumnSelectorColumnState {
@@ -68,27 +67,27 @@ export class DataCubeEditorSortColumnSelectorState extends DataCubeEditorColumnS
       [
         // if pivot is active, take the pivot result columns and include
         // selected dimension columns which are not part of pivot columns
-        ...(this.editor.horizontalPivots.selector.selectedColumns.length
+        ...(this._editor.horizontalPivots.selector.selectedColumns.length
           ? [
-              ...this.editor.horizontalPivots.pivotResultColumns,
+              ...this._editor.horizontalPivots.pivotResultColumns,
               ...[
-                ...this.editor.columns.selector.selectedColumns,
-                ...this.editor.verticalPivots.selector.selectedColumns,
+                ...this._editor.columns.selector.selectedColumns,
+                ...this._editor.verticalPivots.selector.selectedColumns,
               ].filter(
                 (column) =>
-                  this.editor.columnProperties.getColumnConfiguration(
+                  this._editor.columnProperties.getColumnConfiguration(
                     column.name,
                   ).kind === DataCubeColumnKind.DIMENSION &&
-                  !this.editor.horizontalPivots.selector.selectedColumns.find(
+                  !this._editor.horizontalPivots.selector.selectedColumns.find(
                     (col) => col.name === column.name,
                   ),
               ),
             ]
           : [
-              ...this.editor.columns.selector.selectedColumns,
-              ...this.editor.verticalPivots.selector.selectedColumns,
+              ...this._editor.columns.selector.selectedColumns,
+              ...this._editor.verticalPivots.selector.selectedColumns,
             ]),
-        ...this.editor.groupExtendColumns,
+        ...this._editor.groupExtendColumns,
       ],
       (col) => col.name,
     ).map(
@@ -105,13 +104,9 @@ export class DataCubeEditorSortColumnSelectorState extends DataCubeEditorColumnS
 export class DataCubeEditorSortsPanelState
   implements DataCubeQueryEditorPanelState
 {
-  readonly view!: DataCubeViewState;
-  readonly editor!: DataCubeEditorState;
   readonly selector!: DataCubeEditorColumnSelectorState<DataCubeEditorSortColumnState>;
 
   constructor(editor: DataCubeEditorState) {
-    this.editor = editor;
-    this.view = editor.view;
     this.selector = new DataCubeEditorSortColumnSelectorState(editor);
   }