@finos/legend-data-cube 0.0.30 → 0.0.32

package/src/components/view/filter/DataCubeFilterEditor.tsx

@@ -349,7 +349,7 @@ const DataCubeEditorFilterConditionNodeValueEditor = observer(
       case PRIMITIVE_TYPE.STRING:
         return (
           <DataCubeEditorFilterConditionNodeTextValueEditor
-            ref={ref as React.MutableRefObject<HTMLInputElement>}
+            ref={ref as React.RefObject<HTMLInputElement>}
             value={value.value as string}
             updateValue={(val) => updateValue(val)}
           />
@@ -360,7 +360,7 @@ const DataCubeEditorFilterConditionNodeValueEditor = observer(
       case PRIMITIVE_TYPE.INTEGER:
         return (
           <DataCubeEditorFilterConditionNodeNumberValueEditor
-            ref={ref as React.MutableRefObject<HTMLInputElement>}
+            ref={ref as React.RefObject<HTMLInputElement>}
             value={value.value as number}
             updateValue={(val) => updateValue(val)}
           />
@@ -370,7 +370,7 @@ const DataCubeEditorFilterConditionNodeValueEditor = observer(
       case PRIMITIVE_TYPE.DATETIME:
         return (
           <DataCubeEditorFilterConditionNodeDateValueEditor
-            ref={ref as React.MutableRefObject<HTMLInputElement>}
+            ref={ref as React.RefObject<HTMLInputElement>}
             value={value.value as string}
             updateValue={(val) => updateValue(val)}
           />
@@ -378,7 +378,7 @@ const DataCubeEditorFilterConditionNodeValueEditor = observer(
       case DataCubeOperationAdvancedValueType.COLUMN:
         return (
           <DataCubeEditorFilterConditionNodeColumnSelector
-            ref={ref as React.MutableRefObject<HTMLButtonElement>}
+            ref={ref as React.RefObject<HTMLButtonElement>}
             value={value.value as string}
             updateValue={(val) => updateValue(val)}
             view={view}

package/src/components/view/grid/DataCubeGrid.tsx

@@ -15,16 +15,9 @@
  */
 
 import { observer } from 'mobx-react-lite';
-import { ClientSideRowModelModule } from '@ag-grid-community/client-side-row-model';
-import { ServerSideRowModelModule } from '@ag-grid-enterprise/server-side-row-model';
-import { RowGroupingModule } from '@ag-grid-enterprise/row-grouping';
-import { ClipboardModule } from '@ag-grid-enterprise/clipboard';
-import { MenuModule } from '@ag-grid-enterprise/menu';
-import { SideBarModule } from '@ag-grid-enterprise/side-bar';
-import { ColumnsToolPanelModule } from '@ag-grid-enterprise/column-tool-panel';
-import { AgGridReact } from '@ag-grid-community/react';
-import { CsvExportModule } from '@ag-grid-community/csv-export';
-import { ExcelExportModule } from '@ag-grid-enterprise/excel-export';
+import { AllCommunityModule } from 'ag-grid-community';
+import { AllEnterpriseModule } from 'ag-grid-enterprise';
+import { AgGridReact } from 'ag-grid-react';
 import { DataCubeIcon, Switch, cn, Global, css } from '@finos/legend-art';
 import {
   generateBackgroundColorUtilityClassName,
@@ -36,7 +29,6 @@ import {
   generateTextColorUtilityClassName,
   INTERNAL__GridClientUtilityCssClassName,
 } from '../../../stores/view/grid/DataCubeGridClientEngine.js';
-import { RangeSelectionModule } from '@ag-grid-enterprise/range-selection';
 import {
   DataCubeFont,
   DataCubeFontCase,
@@ -343,6 +335,7 @@ const DataCubeGridClient = observer((props: { view: DataCubeViewState }) => {
   return (
     <div className="relative h-[calc(100%_-_20px)] w-full">
       <AgGridReact
+        theme="legacy"
         className="data-cube-grid ag-theme-quartz"
         rowModelType="serverSide"
         serverSideDatasource={grid.clientDataSource}
@@ -357,20 +350,7 @@ const DataCubeGridClient = observer((props: { view: DataCubeViewState }) => {
             console.error = __INTERNAL__original_console_error; // eslint-disable-line no-console
           }
         }}
-        modules={[
-          // community
-          ClientSideRowModelModule,
-          CsvExportModule,
-          // enterprise
-          ServerSideRowModelModule,
-          RowGroupingModule,
-          MenuModule,
-          ClipboardModule,
-          RangeSelectionModule,
-          SideBarModule,
-          ColumnsToolPanelModule,
-          ExcelExportModule,
-        ]}
+        modules={[AllCommunityModule, AllEnterpriseModule]}
         {...generateBaseGridOptions(view)}
       />
     </div>

package/src/components/view/grid/DataCubeGridShared.tsx

@@ -14,10 +14,7 @@
  * limitations under the License.
  */
 
-import {
-  useGridMenuItem,
-  type CustomMenuItemProps,
-} from '@ag-grid-community/react';
+import { useGridMenuItem, type CustomMenuItemProps } from 'ag-grid-react';
 import { FormBadge_WIP } from '../../core/DataCubeFormUtils.js';
 
 export function WIP_GridMenuItem({

package/src/stores/core/DataCubeEngine.tsx

@@ -73,7 +73,7 @@ import { DataCubeFont } from './DataCubeQueryEngine.js';
 import type { DataCubeQuerySnapshot } from './DataCubeQuerySnapshot.js';
 import { buildExecutableQuery } from './DataCubeQueryBuilder.js';
 import type { DataCubeColumn } from './models/DataCubeColumn.js';
-import { LicenseManager } from '@ag-grid-enterprise/core';
+import { LicenseManager } from 'ag-grid-enterprise';
 import type { DataCubeQuery } from './models/DataCubeQuery.js';
 import {
   type DataCubeSource,

package/src/stores/core/DataCubeQuerySnapshotBuilder.ts

@@ -305,7 +305,7 @@ export function validateAndBuildQuerySnapshot(
   // --------------------------------- SOURCE ---------------------------------
 
   data.sourceColumns = source.sourceColumns;
-  data.sourceColumns.map((col) => colsMap.set(col.name, col));
+  data.sourceColumns.forEach((col) => colsMap.set(col.name, col));
 
   // --------------------------------- LEAF-LEVEL EXTEND ---------------------------------
   /** TODO: @datacube roundtrip */

package/src/stores/view/grid/DataCubeGridClientEngine.ts

@@ -19,7 +19,7 @@ import type {
   IRowNode,
   IServerSideDatasource,
   IServerSideGetRowsParams,
-} from '@ag-grid-community/core';
+} from 'ag-grid-community';
 import type { DataCubeGridState } from './DataCubeGridState.js';
 import {
   IllegalStateError,
@@ -205,7 +205,7 @@ export function computeHashCodeForDataFetchManualTrigger(
       },
       leafExtendedColumns: snapshot.data.leafExtendedColumns,
       filter: snapshot.data.filter,
-      selectColumns: snapshot.data.selectColumns.slice().sort(_sortByColName), // sort to make sure column reordering does not trigger data fetching
+      selectColumns: snapshot.data.selectColumns.toSorted(_sortByColName), // sort to make sure column reordering does not trigger data fetching
       groupExtendedColumns: snapshot.data.groupExtendedColumns,
       limit: snapshot.data.limit,
     }),

package/src/stores/view/grid/DataCubeGridConfigurationBuilder.tsx

@@ -31,7 +31,7 @@ import type {
   ColGroupDef,
   GridOptions,
   ICellRendererParams,
-} from '@ag-grid-community/core';
+} from 'ag-grid-community';
 import {
   DataCubeGridClientSortDirection,
   INTERNAL__GRID_CLIENT_COLUMN_MIN_WIDTH,
@@ -85,7 +85,7 @@ import {
   TREE_COLUMN_VALUE_SEPARATOR,
   DEFAULT_ROOT_AGGREGATION_COLUMN_VALUE,
 } from '../../core/DataCubeQueryEngine.js';
-import type { CustomLoadingCellRendererProps } from '@ag-grid-community/react';
+import type { CustomLoadingCellRendererProps } from 'ag-grid-react';
 import { DataCubeIcon } from '@finos/legend-art';
 import type { DataCubeViewState } from '../DataCubeViewState.js';
 
@@ -498,7 +498,7 @@ export function generateBaseGridOptions(view: DataCubeViewState): GridOptions {
     // use the auto-generated group column to make it work with pivot mode
     // See https://github.com/ag-grid/ag-grid/issues/8088
     groupDisplayType: 'singleColumn',
-    suppressRowGroupHidesColumns: true, // keeps the column set stable even when row grouping is used
+    suppressGroupChangesColumnVisibility: true, // keeps the column set stable when row grouping is used
     suppressAggFuncInHeader: true, //  keeps the columns stable when aggregation is used
     getChildCount: (data) =>
       data[INTERNAL__GRID_CLIENT_ROW_GROUPING_COUNT_AGG_COLUMN_ID],

package/src/stores/view/grid/DataCubeGridControllerState.ts

@@ -39,10 +39,11 @@ import {
   getPivotResultColumnBaseColumnName,
 } from '../../core/DataCubeQueryEngine.js';
 import type {
+  DefaultMenuItem,
   GetContextMenuItemsParams,
   GetMainMenuItemsParams,
   MenuItemDef,
-} from '@ag-grid-community/core';
+} from 'ag-grid-community';
 import type { DataCubeViewState } from '../DataCubeViewState.js';
 import { generateMenuBuilder } from './DataCubeGridMenuBuilder.js';
 import {
@@ -79,7 +80,7 @@ export class DataCubeGridControllerState extends DataCubeQuerySnapshotController
           | GetContextMenuItemsParams<unknown, { view: DataCubeViewState }>
           | GetMainMenuItemsParams<unknown, { view: DataCubeViewState }>,
         fromHeader: boolean,
-      ) => (string | MenuItemDef)[])
+      ) => (DefaultMenuItem | MenuItemDef)[])
     | undefined;
 
   getColumnConfiguration(colName: string | undefined) {

package/src/stores/view/grid/DataCubeGridMenuBuilder.tsx

@@ -15,10 +15,11 @@
  */
 
 import type {
+  DefaultMenuItem,
   GetContextMenuItemsParams,
   GetMainMenuItemsParams,
   MenuItemDef,
-} from '@ag-grid-community/core';
+} from 'ag-grid-community';
 import { WIP_GridMenuItem } from '../../../components/view/grid/DataCubeGridShared.js';
 import {
   DataCubeQuerySortDirection,
@@ -161,7 +162,7 @@ export function generateMenuBuilder(
 ): (
   params: GetContextMenuItemsParams | GetMainMenuItemsParams,
   fromHeader: boolean,
-) => (string | MenuItemDef)[] {
+) => (DefaultMenuItem | MenuItemDef)[] {
   const view = controller.view;
   const engine = view.engine;
 
@@ -264,7 +265,7 @@ export function generateMenuBuilder(
           },
         ],
       },
-    ] satisfies (string | MenuItemDef)[];
+    ] satisfies (DefaultMenuItem | MenuItemDef)[];
 
     let newFilterMenu: MenuItemDef[] = [];
     if (column && value !== undefined) {
@@ -784,7 +785,7 @@ export function generateMenuBuilder(
         disabled: !columnConfiguration,
         action: () => controller.showColumn(columnName, false),
       },
-      ...(columnName === INTERNAL__GRID_CLIENT_TREE_COLUMN_ID
+      ...((columnName === INTERNAL__GRID_CLIENT_TREE_COLUMN_ID
         ? [
             'separator',
             {
@@ -794,7 +795,7 @@ export function generateMenuBuilder(
               },
             },
           ]
-        : []),
+        : []) as (DefaultMenuItem | MenuItemDef)[]),
       'separator',
       {
         name: 'Heatmap',
@@ -847,6 +848,6 @@ export function generateMenuBuilder(
           editor.display.open();
         },
       },
-    ] satisfies (string | MenuItemDef)[];
+    ] satisfies (DefaultMenuItem | MenuItemDef)[];
   };
 }

package/src/stores/view/grid/DataCubeGridState.ts

@@ -20,7 +20,7 @@ import {
   type DebouncedFunc,
 } from '@finos/legend-shared';
 import { action, makeObservable, observable } from 'mobx';
-import type { GridApi } from '@ag-grid-community/core';
+import type { GridApi } from 'ag-grid-community';
 import type { DataCubeViewState } from '../DataCubeViewState.js';
 import {
   DataCubeGridClientServerSideDataSource,