@finos/legend-data-cube 0.0.3 → 0.0.5

package/src/stores/editor/DataCubeEditorMutableConfiguration.ts

@@ -20,11 +20,11 @@ import {
   type DataCubeFont,
   type DataCubeOperationValue,
   type DataCubeNumberScale,
-  type DataCubeSelectionStat,
   type DataCubeFontFormatUnderlineVariant,
   type DataCubeFontCase,
   type DataCubeFontTextAlignment,
   type DataCubeColumnPinPlacement,
+  type DataCubeQuerySortDirection,
   DEFAULT_FONT_FAMILY,
   DEFAULT_FONT_SIZE,
   DEFAULT_FONT_BOLD,
@@ -44,6 +44,7 @@ import { makeObservable, observable, action, computed } from 'mobx';
 import {
   DataCubeColumnConfiguration,
   DataCubeConfiguration,
+  DataCubePivotLayoutConfiguration,
 } from '../core/DataCubeConfiguration.js';
 import { buildDefaultColumnConfiguration } from '../core/DataCubeConfigurationBuilder.js';
 import { type DataCubeQuerySnapshot } from '../core/DataCubeQuerySnapshot.js';
@@ -180,11 +181,14 @@ export class DataCubeEditorMutableColumnConfiguration extends DataCubeColumnConf
       aggregationParameters: observable,
       setAggregationParameters: action,
 
-      excludedFromHorizontalPivot: observable,
-      setExcludedFromHorizontalPivot: action,
+      excludedFromPivot: observable,
+      setExcludedFromPivot: action,
 
-      horizontalPivotSortFunction: observable,
-      setHorizontalPivotSortFunction: action,
+      pivotSortDirection: observable,
+      setPivotSortDirection: action,
+
+      pivotStatisticColumnFunction: observable,
+      setPivotStatisticColumnFunction: action,
     });
 
     return configuration;
@@ -382,12 +386,42 @@ export class DataCubeEditorMutableColumnConfiguration extends DataCubeColumnConf
     this.aggregationParameters = value;
   }
 
-  setExcludedFromHorizontalPivot(value: boolean) {
-    this.excludedFromHorizontalPivot = value;
+  setExcludedFromPivot(value: boolean) {
+    this.excludedFromPivot = value;
+  }
+
+  setPivotSortDirection(value: string | undefined) {
+    this.pivotSortDirection = value;
+  }
+
+  setPivotStatisticColumnFunction(value: string | undefined) {
+    this.pivotStatisticColumnFunction = value;
+  }
+}
+
+export class DataCubeEditorMutablePivotLayoutConfiguration extends DataCubePivotLayoutConfiguration {
+  static create(
+    json: PlainObject<DataCubePivotLayoutConfiguration>,
+  ): DataCubeEditorMutablePivotLayoutConfiguration {
+    const configuration = Object.assign(
+      new DataCubeEditorMutablePivotLayoutConfiguration(),
+      DataCubePivotLayoutConfiguration.serialization.fromJson(json),
+    );
+
+    makeObservable(configuration, {
+      expandedPaths: observable,
+      setExpandedPaths: action,
+    });
+
+    return configuration;
+  }
+
+  serialize() {
+    return DataCubePivotLayoutConfiguration.serialization.toJson(this);
   }
 
-  setHorizontalPivotSortFunction(value: string | undefined) {
-    this.horizontalPivotSortFunction = value;
+  setExpandedPaths(value: string[]) {
+    this.expandedPaths = value;
   }
 }
 
@@ -405,9 +439,6 @@ export class DataCubeEditorMutableConfiguration extends DataCubeConfiguration {
       description: observable,
       setDescription: action,
 
-      showTreeLines: observable,
-      setShowTreeLines: action,
-
       showHorizontalGridLines: observable,
       setShowHorizontalGridLines: action,
 
@@ -477,8 +508,8 @@ export class DataCubeEditorMutableConfiguration extends DataCubeConfiguration {
       alternateRowsStandardMode: observable,
       setAlternateRowsStandardMode: action,
 
-      selectionStats: observable,
-      setSelectionStats: action,
+      showSelectionStats: observable,
+      setShowSelectionStats: action,
 
       showWarningForTruncatedResult: observable,
       setShowWarningForTruncatedResult: action,
@@ -492,11 +523,14 @@ export class DataCubeEditorMutableConfiguration extends DataCubeConfiguration {
       showLeafCount: observable,
       setShowLeafCount: action,
 
-      pivotTotalColumnPlacement: observable,
-      setPivotTotalColumnPlacement: action,
+      treeColumnSortDirection: observable,
+      setTreeColumnSortDirection: action,
+
+      pivotStatisticColumnName: observable,
+      setPivotStatisticColumnName: action,
 
-      treeGroupSortFunction: observable,
-      setTreeGroupSortFunction: action,
+      pivotStatisticColumnPlacement: observable,
+      setPivotStatisticColumnPlacement: action,
 
       isUsingDefaultStyling: computed,
       useDefaultStyling: action,
@@ -551,10 +585,6 @@ export class DataCubeEditorMutableConfiguration extends DataCubeConfiguration {
     this.description = value;
   }
 
-  setShowTreeLines(value: boolean) {
-    this.showTreeLines = value;
-  }
-
   setShowHorizontalGridLines(value: boolean) {
     this.showHorizontalGridLines = value;
   }
@@ -647,8 +677,8 @@ export class DataCubeEditorMutableConfiguration extends DataCubeConfiguration {
     this.alternateRowsStandardMode = value;
   }
 
-  setSelectionStats(value: DataCubeSelectionStat[]) {
-    this.selectionStats = value;
+  setShowSelectionStats(value: boolean) {
+    this.showSelectionStats = value;
   }
 
   setShowWarningForTruncatedResult(value: boolean) {
@@ -667,11 +697,21 @@ export class DataCubeEditorMutableConfiguration extends DataCubeConfiguration {
     this.showLeafCount = value;
   }
 
-  setPivotTotalColumnPlacement(value: DataCubeColumnPinPlacement | undefined) {
-    this.pivotTotalColumnPlacement = value;
+  setTreeColumnSortDirection(value: DataCubeQuerySortDirection) {
+    this.treeColumnSortDirection = value;
+  }
+
+  setPivotStatisticColumnPlacement(
+    value: DataCubeColumnPinPlacement | undefined,
+  ) {
+    this.pivotStatisticColumnPlacement = value;
+  }
+
+  setPivotStatisticColumnName(value: string) {
+    this.pivotStatisticColumnName = value;
   }
 
-  setTreeGroupSortFunction(value: string | undefined) {
-    this.treeGroupSortFunction = value;
+  setExpandedPaths(value: string[]) {
+    this.pivotLayout.expandedPaths = value;
   }
 }

package/src/stores/editor/DataCubeEditorPivotLayoutPanelState.ts

@@ -0,0 +1,71 @@
+/**
+ * Copyright (c) 2020-present, Goldman Sachs
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { action, makeObservable, observable } from 'mobx';
+import type { DataCubeViewState } from '../DataCubeViewState.js';
+import { type DataCubeQuerySnapshot } from '../core/DataCubeQuerySnapshot.js';
+import type { DataCubeQueryEditorPanelState } from './DataCubeEditorPanelState.js';
+import type { DataCubeEditorState } from './DataCubeEditorState.js';
+import { DataCubeEditorMutablePivotLayoutConfiguration } from './DataCubeEditorMutableConfiguration.js';
+import type { DataCubeConfiguration } from '../core/DataCubeConfiguration.js';
+import type { PlainObject } from '@finos/legend-shared';
+import { _pruneExpandedPaths } from '../core/DataCubeQuerySnapshotBuilderUtils.js';
+
+export class DataCubeEditorPivotLayoutPanelState
+  implements DataCubeQueryEditorPanelState
+{
+  readonly view!: DataCubeViewState;
+  readonly editor!: DataCubeEditorState;
+
+  pivotLayout = new DataCubeEditorMutablePivotLayoutConfiguration();
+
+  constructor(editor: DataCubeEditorState) {
+    makeObservable(this, {
+      pivotLayout: observable,
+
+      applySnaphot: action,
+    });
+
+    this.editor = editor;
+    this.view = editor.view;
+  }
+
+  applySnaphot(
+    snapshot: DataCubeQuerySnapshot,
+    configuration: DataCubeConfiguration,
+  ) {
+    this.pivotLayout = DataCubeEditorMutablePivotLayoutConfiguration.create(
+      snapshot.data.configuration.pivotLayout as PlainObject,
+    );
+  }
+
+  buildSnapshot(
+    newSnapshot: DataCubeQuerySnapshot,
+    baseSnapshot: DataCubeQuerySnapshot,
+  ) {
+    this.pivotLayout.setExpandedPaths(
+      _pruneExpandedPaths(
+        baseSnapshot.data.groupBy?.columns ?? [],
+        this.editor.verticalPivots.selector.selectedColumns,
+        this.pivotLayout.expandedPaths,
+      ),
+    );
+    newSnapshot.data.configuration = {
+      ...newSnapshot.data.configuration,
+      pivotLayout: this.pivotLayout.serialize(),
+    };
+  }
+}

package/src/stores/editor/DataCubeEditorSortsPanelState.ts

@@ -19,7 +19,7 @@ import type { DataCubeViewState } from '../DataCubeViewState.js';
 import { type DataCubeQuerySnapshot } from '../core/DataCubeQuerySnapshot.js';
 import {
   DataCubeColumnKind,
-  DataCubeQuerySortOperator,
+  DataCubeQuerySortDirection,
 } from '../core/DataCubeQueryEngine.js';
 import type { DataCubeQueryEditorPanelState } from './DataCubeEditorPanelState.js';
 import {
@@ -31,21 +31,21 @@ import type { DataCubeConfiguration } from '../core/DataCubeConfiguration.js';
 import { uniqBy } from '@finos/legend-shared';
 
 export class DataCubeEditorSortColumnState extends DataCubeEditorColumnsSelectorColumnState {
-  operation: string;
+  direction: string;
 
   constructor(name: string, type: string, direction: string) {
     super(name, type);
 
     makeObservable(this, {
-      operation: observable,
-      setOperation: action,
+      direction: observable,
+      setDirection: action,
     });
 
-    this.operation = direction;
+    this.direction = direction;
   }
 
-  setOperation(val: DataCubeQuerySortOperator) {
-    this.operation = val;
+  setDirection(val: DataCubeQuerySortDirection) {
+    this.direction = val;
   }
 }
 
@@ -54,7 +54,7 @@ export class DataCubeEditorSortColumnsSelectorState extends DataCubeEditorColumn
     return new DataCubeEditorSortColumnState(
       column.name,
       column.type,
-      column.operation,
+      column.direction,
     );
   }
 
@@ -91,7 +91,7 @@ export class DataCubeEditorSortColumnsSelectorState extends DataCubeEditorColumn
         new DataCubeEditorSortColumnState(
           col.name,
           col.type,
-          DataCubeQuerySortOperator.ASCENDING,
+          DataCubeQuerySortDirection.ASCENDING,
         ),
     );
   }
@@ -128,7 +128,7 @@ export class DataCubeEditorSortsPanelState
         return new DataCubeEditorSortColumnState(
           column.name,
           column.type,
-          col.operation,
+          col.direction,
         );
       }),
     );
@@ -141,7 +141,7 @@ export class DataCubeEditorSortsPanelState
     newSnapshot.data.sortColumns = this.selector.selectedColumns.map((col) => ({
       name: col.name,
       type: col.type,
-      operation: col.operation,
+      direction: col.direction,
     }));
   }
 }

package/src/stores/editor/DataCubeEditorState.tsx

@@ -39,6 +39,7 @@ import { DataCubeEditor } from '../../components/editor/DataCubeEditor.js';
 import { buildExecutableQuery } from '../core/DataCubeQueryBuilder.js';
 import { _lambda } from '../core/DataCubeQueryBuilderUtils.js';
 import { DataCubeEditorHorizontalPivotsPanelState } from './DataCubeEditorHorizontalPivotsPanelState.js';
+import { DataCubeEditorPivotLayoutPanelState } from './DataCubeEditorPivotLayoutPanelState.js';
 
 export enum DataCubeEditorTab {
   GENERAL_PROPERTIES = 'General Properties',
@@ -63,6 +64,7 @@ export class DataCubeEditorState extends DataCubeQuerySnapshotController {
   readonly finalizationState = ActionState.create();
 
   readonly generalProperties: DataCubeEditorGeneralPropertiesPanelState;
+  readonly pivotLayout: DataCubeEditorPivotLayoutPanelState;
   readonly columnProperties: DataCubeEditorColumnPropertiesPanelState;
 
   readonly columns: DataCubeEditorColumnsPanelState;
@@ -97,6 +99,7 @@ export class DataCubeEditorState extends DataCubeQuerySnapshotController {
     this.generalProperties = new DataCubeEditorGeneralPropertiesPanelState(
       this,
     );
+    this.pivotLayout = new DataCubeEditorPivotLayoutPanelState(this);
     this.columnProperties = new DataCubeEditorColumnPropertiesPanelState(this);
     this.columns = new DataCubeEditorColumnsPanelState(this);
     this.horizontalPivots = new DataCubeEditorHorizontalPivotsPanelState(this);
@@ -120,6 +123,7 @@ export class DataCubeEditorState extends DataCubeQuerySnapshotController {
       snapshot.data.configuration,
     );
     this.generalProperties.applySnaphot(snapshot, configuration);
+    this.pivotLayout.applySnaphot(snapshot, configuration);
     this.columnProperties.applySnaphot(snapshot, configuration);
 
     this.columns.applySnaphot(snapshot, configuration);
@@ -138,6 +142,7 @@ export class DataCubeEditorState extends DataCubeQuerySnapshotController {
     // grid configuration must be processed before processing columns' configuration
     // to properly generate the container configuration
     this.generalProperties.buildSnapshot(newSnapshot, baseSnapshot);
+    this.pivotLayout.buildSnapshot(newSnapshot, baseSnapshot);
     this.columnProperties.buildSnapshot(newSnapshot, baseSnapshot);
 
     // NOTE: column selection must be processed first since the snapshot

package/src/stores/extend/DataCubeExtendManagerState.tsx

@@ -113,7 +113,7 @@ export class DataCubeExtendManagerState extends DataCubeQuerySnapshotController
     const columnConfiguration = buildDefaultColumnConfiguration(column);
     if (columnKind) {
       columnConfiguration.kind = columnKind;
-      columnConfiguration.excludedFromHorizontalPivot =
+      columnConfiguration.excludedFromPivot =
         columnKind === DataCubeColumnKind.DIMENSION;
     }
 

package/src/stores/grid/DataCubeGridClientEngine.ts

@@ -49,7 +49,6 @@ import {
   type DataCubeQuerySnapshotData,
 } from '../core/DataCubeQuerySnapshot.js';
 import type { DataCubeEngine } from '../engine/DataCubeEngine.js';
-import { generateColumnDefs } from './DataCubeGridConfigurationBuilder.js';
 import { type DataCubeQueryFunctionMap } from '../core/DataCubeQueryEngine.js';
 import type { DataCubeQueryFilterOperation } from '../core/filter/DataCubeQueryFilterOperation.js';
 import type { DataCubeQueryAggregateOperation } from '../core/aggregation/DataCubeQueryAggregateOperation.js';
@@ -186,10 +185,10 @@ export function computeHashCodeForDataFetchManualTrigger(
       ...snapshot.data,
       name: '', // name change should not trigger data fetching
       configuration: {
-        initialExpandLevel: configuration.initialExpandLevel,
         showRootAggregation: configuration.showRootAggregation,
-        pivotTotalColumnPlacement: configuration.pivotTotalColumnPlacement,
-        treeGroupSortFunction: configuration.treeGroupSortFunction,
+        pivotStatisticColumnPlacement:
+          configuration.pivotStatisticColumnPlacement,
+        treeColumnSortDirection: configuration.treeColumnSortDirection,
         columns: configuration.columns
           .map((column) => ({
             name: column.name,
@@ -197,8 +196,11 @@ export function computeHashCodeForDataFetchManualTrigger(
             kind: column.kind,
             aggregateOperator: column.aggregateOperator,
             aggregationParameters: column.aggregationParameters,
-            excludedFromHorizontalPivot: column.excludedFromHorizontalPivot,
-            horizontalPivotSortFunction: column.horizontalPivotSortFunction,
+            excludedFromPivot: column.excludedFromPivot,
+            pivotSortDirection: column.pivotSortDirection,
+            // technically, we just need to refresh the row-data since this computation
+            // is done on the client-side, but to simplify the flow, we can just refetch data
+            pivotStatisticColumnFunction: column.pivotStatisticColumnFunction,
           }))
           .sort(_sortByColName), // sort to make sure column reordering does not trigger data fetching
       },
@@ -317,49 +319,52 @@ export class DataCubeGridClientServerSideDataSource
     // ------------------------------ SNAPSHOT ------------------------------
 
     const currentSnapshot = guaranteeNonNullable(this.grid.getLatestSnapshot());
-    const newSnapshot = buildQuerySnapshot(params.request, currentSnapshot);
-    // NOTE: if h-pivot is enabled
-    // if h-pivot is enabled, update the cast columns
-    // and panels which might be affected by this (e.g. sorts)
-    // TOOD?: this is an expensive operation in certain case, so we might want to
-    // optimize when this gets called
-    if (newSnapshot.data.pivot) {
-      try {
-        const castColumns = await getCastColumns(
-          newSnapshot,
-          this.grid.view.engine,
-        );
-        newSnapshot.data.pivot.castColumns = castColumns;
-        newSnapshot.data.sortColumns = newSnapshot.data.sortColumns.filter(
-          (column) =>
-            [...castColumns, ...newSnapshot.data.groupExtendedColumns].find(
-              (col) => column.name === col.name,
-            ),
-        );
-      } catch (error) {
-        assertErrorThrown(error);
-        this.grid.view.application.alertError(error, {
-          message: `Query Validation Failure: Can't retrieve pivot results column metadata. ${error.message}`,
-        });
-        // fail early since we can't proceed without the cast columns validated
-        params.fail();
-        this.grid.view.endTask(task);
-        return;
+    let newSnapshot = currentSnapshot;
+
+    // only recompute the snapshot if this is not a drilldown request
+    if (params.request.groupKeys.length === 0) {
+      newSnapshot = buildQuerySnapshot(params.request, currentSnapshot);
+
+      // NOTE: if h-pivot is enabled, update the cast columns
+      // and panels which might be affected by this (e.g. sorts)
+      // Because is an expensive operation in certain case, we only
+      // recompute when it's not a drilldown or paging request,
+      // but we could still optimize further if needed.
+      if (!this.grid.isPaginationEnabled || params.request.startRow === 0) {
+        if (newSnapshot.data.pivot) {
+          try {
+            const castColumns = await getCastColumns(
+              newSnapshot,
+              this.grid.view.engine,
+            );
+            newSnapshot.data.pivot.castColumns = castColumns;
+            newSnapshot.data.sortColumns = newSnapshot.data.sortColumns.filter(
+              (column) =>
+                [...castColumns, ...newSnapshot.data.groupExtendedColumns].find(
+                  (col) => column.name === col.name,
+                ),
+            );
+          } catch (error) {
+            assertErrorThrown(error);
+            this.grid.view.application.alertError(error, {
+              message: `Query Validation Failure: Can't retrieve pivot results column metadata. ${error.message}`,
+            });
+            // fail early since we can't proceed without the cast columns validated
+            params.fail();
+            this.grid.view.endTask(task);
+            return;
+          }
+        }
       }
-    }
 
-    newSnapshot.finalize();
-    if (newSnapshot.hashCode !== currentSnapshot.hashCode) {
-      // update grid column definitions since new columns could have been added
-      // due to changes in pivot
-      this.grid.client.updateGridOptions({
-        columnDefs: generateColumnDefs(
-          newSnapshot,
-          this.grid.queryConfiguration,
-          this.grid.view,
-        ),
-      });
-      this.grid.publishSnapshot(newSnapshot);
+      newSnapshot.finalize();
+      if (newSnapshot.hashCode !== currentSnapshot.hashCode) {
+        // NOTE: if we mess up the computation of the snapshot, we run the risk
+        // of triggering an infinite loop, by keep updating the grid options
+        // so we need to be careful here when making this call!
+        await this.grid.applySnapshot(newSnapshot, currentSnapshot);
+        this.grid.publishSnapshot(newSnapshot);
+      }
     }
 
     // ------------------------------ DATA ------------------------------
@@ -447,7 +452,6 @@ export class DataCubeGridClientServerSideDataSource
                 {
                   label: 'Dismiss Warning',
                   handler: () => {
-                    // this.grid.setPaginationEnabled(true);
                     this.grid.view.engine.setGridClientSuppressLargeDatasetWarning(
                       true,
                     );

package/src/stores/grid/DataCubeGridConfigurationBuilder.tsx

@@ -74,14 +74,14 @@ import {
   DataCubeColumnDataType,
   DataCubeColumnPinPlacement,
   DataCubeNumberScale,
-  DEFAULT_ROW_BUFFER,
   DEFAULT_URL_LABEL_QUERY_PARAM,
   getDataType,
-  DataCubeQuerySortOperator,
+  DataCubeQuerySortDirection,
   DataCubeColumnKind,
   DEFAULT_MISSING_VALUE_DISPLAY_TEXT,
   PIVOT_COLUMN_NAME_VALUE_SEPARATOR,
   isPivotResultColumnName,
+  TREE_COLUMN_VALUE_SEPARATOR,
 } from '../core/DataCubeQueryEngine.js';
 import type { CustomLoadingCellRendererProps } from '@ag-grid-community/react';
 import { DataCubeIcon } from '@finos/legend-art';
@@ -430,7 +430,7 @@ function _sortSpec(columnData: ColumnData) {
   return {
     sortable: true, // if this is pivot column, no sorting is supported yet
     sort: sortCol
-      ? sortCol.operation === DataCubeQuerySortOperator.ASCENDING
+      ? sortCol.direction === DataCubeQuerySortDirection.ASCENDING
         ? GridClientSortDirection.ASCENDING
         : GridClientSortDirection.DESCENDING
       : null,
@@ -851,6 +851,27 @@ export function generateGridOptionsFromSnapshot(
   view: DataCubeViewState,
 ): GridOptions {
   const gridOptions = {
+    isServerSideGroupOpenByDefault: (params) => {
+      if (
+        configuration.initialExpandLevel !== undefined &&
+        configuration.initialExpandLevel > 0 &&
+        params.rowNode.level <= configuration.initialExpandLevel - 1
+      ) {
+        return true;
+      }
+
+      const routes = params.rowNode.getRoute();
+      if (!routes) {
+        return false;
+      }
+      const path = routes.join(TREE_COLUMN_VALUE_SEPARATOR);
+      if (configuration.pivotLayout.expandedPaths.includes(path)) {
+        return true;
+      }
+
+      return false;
+    },
+
     /**
      * NOTE: there is a strange issue where if we put dynamic configuration directly
      * such as rowClassRules which depends on some changing state (e.g. alternateRows)
@@ -866,7 +887,6 @@ export function generateGridOptionsFromSnapshot(
             configuration.alternateRowsCount,
         }
       : {},
-    rowBuffer: DEFAULT_ROW_BUFFER,
 
     // -------------------------------------- EVENT HANDLERS --------------------------------------
     // NOTE: make sure the event source must not be 'api' since these handlers are meant for direct
@@ -907,6 +927,24 @@ export function generateGridOptionsFromSnapshot(
       }
     },
 
+    onRowGroupOpened: (event) => {
+      // NOTE: only update the pivot layout expanded paths when the user manually expands/collapses
+      // a path. If the path is expanded/collapsed programmatically, such as when tree column initially-
+      // expanded-to-level is specified, causing the groups to be automatically drilled down, resultant
+      // expanded paths will not be kept for record.
+      if (event.event) {
+        const path = event.node.getRoute()?.join(TREE_COLUMN_VALUE_SEPARATOR);
+        if (!path) {
+          return;
+        }
+        if (event.expanded) {
+          view.grid.controller.expandPath(path);
+        } else {
+          view.grid.controller.collapsePath(path);
+        }
+      }
+    },
+
     // -------------------------------------- COLUMNS --------------------------------------
 
     columnDefs: generateColumnDefs(snapshot, configuration, view),
@@ -918,6 +956,9 @@ export function generateGridOptionsFromSnapshot(
       colId: INTERNAL__GRID_CLIENT_TREE_COLUMN_ID,
       headerName: '',
       cellRenderer: 'agGroupCellRenderer',
+      cellRendererParams: {
+        suppressCount: !configuration.showLeafCount,
+      },
 
       // display
       ..._groupDisplaySpec(snapshot, configuration),