@finos/legend-cube-builder 0.0.3 → 0.0.5

package/src/stores/LocalModelCatalog.ts

@@ -19,7 +19,15 @@ import type {
   CubeEngine,
   CubeModelOutline,
 } from '../graph-manager/CubeEngine.js';
-import { CUBE_NORTHWIND_MODEL } from './fixtures/CubeNorthwindModel.js';
+import {
+  CUBE_NORTHWIND_MODEL,
+  CUBE_NORTHWIND_SAMPLE_MODEL,
+} from './fixtures/CubeNorthwindModel.js';
+import { CUBE_SPORTS_MODEL } from './fixtures/CubeSportsModel.js';
+import {
+  CUBE_TRADES_MODEL,
+  CUBE_TRADES_MODEL_BEFORE_FUNCTIONS,
+} from './fixtures/CubeTradesModel.js';
 
 // The models of the slice (PLAN §6.2.3): Pure text bundled with Cube, or
 // pasted by the user. Picking one gives the model context the cube saves, the
@@ -29,13 +37,29 @@ export interface BundledModel {
   readonly id: string;
   readonly label: string;
   readonly model: ModelContext;
+  /** Earlier texts of the model, which cubes saved before may hold: shown by its label too */
+  readonly earlierModels?: readonly ModelContext[];
 }
 
 export const BUNDLED_MODELS: readonly BundledModel[] = Object.freeze([
   {
     id: 'cube-northwind',
-    label: 'Northwind (Cube fixture)',
-    model: CUBE_NORTHWIND_MODEL,
+    label: 'Northwind',
+    model: CUBE_NORTHWIND_SAMPLE_MODEL,
+    // the fixture with Cube's test tables, offered until the samples came
+    earlierModels: [CUBE_NORTHWIND_MODEL],
+  },
+  {
+    id: 'cube-sample-sports',
+    label: 'Sports',
+    model: CUBE_SPORTS_MODEL,
+  },
+  {
+    id: 'cube-sample-trades',
+    label: 'Trades',
+    model: CUBE_TRADES_MODEL,
+    // before its functions (PLAN §6.5)
+    earlierModels: [CUBE_TRADES_MODEL_BEFORE_FUNCTIONS],
   },
 ]);
 

package/src/stores/editors/CubeAggregationRows.ts

@@ -0,0 +1,299 @@
+/**
+ * Copyright (c) 2026-present, Goldman Sachs
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import {
+  AGGREGATION_SETTING_DEFAULTS,
+  AggregationFunction,
+  AggregationSetting,
+  type AggregationUse,
+  type ColumnAggregation,
+  getAggregationAutoName,
+  getAggregationSetting,
+  isAggregationFunctionOf,
+  type Schema,
+  takesAggregationColumn,
+} from '@finos/legend-cube';
+import { parseWholeNumberText } from './CubeIntegerText.js';
+
+// The rows of the editors that aggregate (Group, PLAN §11.5; Partition,
+// §11.6, §11.9): each a column, a function, a setting for a function that
+// takes one, and an output name, judged by where the aggregations are
+// (`AggregationUse`)
+
+/** A row's settings as typed, by key: Lag's and Lead's offset, NTile's bucket count */
+export type CubeAggregationSettingTexts = Readonly<
+  Partial<Record<AggregationSetting, string>>
+>;
+
+/**
+ * One aggregation row: a column (`undefined` for a function that takes none,
+ * `''` until picked), a function (`''` until picked; an unknown one is kept
+ * as saved) and an output name
+ */
+export interface CubeAggregationRow {
+  /** Identifies the row in the editor */
+  readonly key: number;
+  readonly column: string | undefined;
+  readonly function: string;
+  readonly name: string;
+  /**
+   * The settings as typed (PLAN §11.9): the function's own, and a saved one
+   * it doesn't take, kept so it is reported until the function is picked again
+   */
+  readonly settings: CubeAggregationSettingTexts;
+  /** The settings as saved, kept while their text is as it opened, so one that isn't a whole number stays reported */
+  readonly savedSettings?: Pick<ColumnAggregation, 'offset' | 'buckets'>;
+  /**
+   * The name was typed: it no longer follows the column and the function.
+   * A name equal to the auto-name follows them again.
+   */
+  readonly named: boolean;
+}
+
+let nextRowKey = 1;
+
+export const blankAggregationRow = (): CubeAggregationRow => ({
+  key: nextRowKey++,
+  column: '',
+  function: '',
+  name: '',
+  settings: {},
+  named: false,
+});
+
+/** The settings a saved aggregation holds, as texts */
+const settingTextsOf = ({
+  offset,
+  buckets,
+}: ColumnAggregation): CubeAggregationSettingTexts => ({
+  ...(offset === undefined
+    ? {}
+    : { [AggregationSetting.OFFSET]: String(offset) }),
+  ...(buckets === undefined
+    ? {}
+    : { [AggregationSetting.BUCKETS]: String(buckets) }),
+});
+
+/**
+ * The settings the texts give: a whole number, or the saved number while the
+ * text is as it opened (so a saved 2.5 stays 2.5, reported, never dropped), or
+ * none, which the node reports
+ */
+const settingsOfTexts = (
+  texts: CubeAggregationSettingTexts,
+  saved: Pick<ColumnAggregation, 'offset' | 'buckets'> = {},
+): Pick<ColumnAggregation, 'offset' | 'buckets'> => {
+  const [offset, buckets] = [
+    AggregationSetting.OFFSET,
+    AggregationSetting.BUCKETS,
+  ].map((key) => {
+    const text = texts[key];
+    const savedValue = saved[key];
+    return text === undefined
+      ? undefined
+      : (parseWholeNumberText(text) ??
+          (savedValue !== undefined && text === String(savedValue)
+            ? savedValue
+            : undefined));
+  });
+  return {
+    ...(offset === undefined ? {} : { offset }),
+    ...(buckets === undefined ? {} : { buckets }),
+  };
+};
+
+/** Whether the use knows the function and it takes no column: Count rows, and in a window the rank functions */
+export const takesNoAggregationColumn = (
+  fn: string,
+  use: AggregationUse,
+): boolean => isAggregationFunctionOf(fn, use) && !takesAggregationColumn(fn);
+
+/**
+ * Whether a row builds an aggregation: it has a column, or its function takes
+ * none, or it holds a function the use doesn't know with no column (a newer
+ * client's, or in a Group a window function such as Rank), kept as saved
+ * (Q4). A blank row, or a column function whose column isn't picked yet, is
+ * left out.
+ */
+export const isBuiltAggregationRow = (
+  row: CubeAggregationRow,
+  use: AggregationUse,
+): boolean =>
+  Boolean(row.column) ||
+  takesNoAggregationColumn(row.function, use) ||
+  (row.column === undefined && !isAggregationFunctionOf(row.function, use));
+
+/** The row with its name following the column and the function, unless typed */
+const withAutoName = (
+  row: CubeAggregationRow,
+  use: AggregationUse,
+): CubeAggregationRow =>
+  row.named
+    ? row
+    : {
+        ...row,
+        name: getAggregationAutoName(row.function, row.column, use) ?? '',
+      };
+
+/** The rows of saved aggregations, or one blank row when there are none */
+export const aggregationRowsOf = (
+  aggregations: readonly ColumnAggregation[],
+  use: AggregationUse,
+): CubeAggregationRow[] =>
+  aggregations.length
+    ? aggregations.map((aggregation) => {
+        const { column, function: fn, name } = aggregation;
+        return {
+          key: nextRowKey++,
+          column,
+          function: fn,
+          name,
+          settings: settingTextsOf(aggregation),
+          savedSettings: {
+            ...(aggregation.offset === undefined
+              ? {}
+              : { offset: aggregation.offset }),
+            ...(aggregation.buckets === undefined
+              ? {}
+              : { buckets: aggregation.buckets }),
+          },
+          named: name !== (getAggregationAutoName(fn, column, use) ?? ''),
+        };
+      })
+    : [blankAggregationRow()];
+
+/** The aggregations the rows build, in order (`isBuiltAggregationRow`) */
+export const aggregationsOfRows = (
+  rows: readonly CubeAggregationRow[],
+  use: AggregationUse,
+): ColumnAggregation[] =>
+  rows
+    .filter((row) => isBuiltAggregationRow(row, use))
+    .map(({ column, function: fn, name, settings, savedSettings }) => ({
+      column,
+      function: fn,
+      name,
+      ...settingsOfTexts(settings, savedSettings),
+    }));
+
+/** The row with its column picked; with no function yet, Count */
+export const withRowColumn = (
+  row: CubeAggregationRow,
+  column: string,
+  use: AggregationUse,
+): CubeAggregationRow =>
+  withAutoName(
+    { ...row, column, function: row.function || AggregationFunction.COUNT },
+    use,
+  );
+
+/**
+ * The row with its function picked: a function that takes no column clears
+ * it, and back to a column function leaves one to pick. It keeps only the
+ * function's own setting, as typed, or its default.
+ */
+export const withRowFunction = (
+  row: CubeAggregationRow,
+  fn: string,
+  use: AggregationUse,
+): CubeAggregationRow => {
+  const setting = getAggregationSetting(fn);
+  return withAutoName(
+    {
+      ...row,
+      function: fn,
+      column: takesNoAggregationColumn(fn, use)
+        ? undefined
+        : (row.column ?? ''),
+      settings:
+        setting === undefined
+          ? {}
+          : {
+              [setting]:
+                row.settings[setting] ??
+                String(AGGREGATION_SETTING_DEFAULTS[setting]),
+            },
+    },
+    use,
+  );
+};
+
+/** The row with a setting typed, kept exactly as text */
+export const withRowSetting = (
+  row: CubeAggregationRow,
+  setting: AggregationSetting,
+  text: string,
+): CubeAggregationRow => ({
+  ...row,
+  settings: { ...row.settings, [setting]: text },
+});
+
+/** The row with its name typed, kept exactly; the auto-name itself follows again */
+export const withRowName = (
+  row: CubeAggregationRow,
+  name: string,
+  use: AggregationUse,
+): CubeAggregationRow => ({
+  ...row,
+  name,
+  named: name !== (getAggregationAutoName(row.function, row.column, use) ?? ''),
+});
+
+export const isSameAggregations = (
+  a: readonly ColumnAggregation[],
+  b: readonly ColumnAggregation[],
+): boolean =>
+  a.length === b.length &&
+  a.every(
+    (aggregation, index) =>
+      aggregation.column === b[index]?.column &&
+      aggregation.function === b[index]?.function &&
+      aggregation.name === b[index]?.name &&
+      aggregation.offset === b[index]?.offset &&
+      aggregation.buckets === b[index]?.buckets,
+  );
+
+/**
+ * Picked columns in the input's order, then those the input doesn't have, in
+ * the order they were picked: a saved column the input lost stays listed
+ * until it is unticked (a Group's keys, a Partition's columns, Q2)
+ */
+export const inInputOrder = (
+  names: readonly string[],
+  schema: Schema,
+): string[] => [
+  ...schema.names().filter((name) => names.includes(name)),
+  ...names.filter((name) => schema.lookup(name) === undefined),
+];
+
+/** The picked columns with one ticked or unticked, in the input's order (`inInputOrder`) */
+export const toggledColumns = (
+  columns: readonly string[],
+  name: string,
+  schema: Schema,
+): string[] =>
+  inInputOrder(
+    columns.includes(name)
+      ? columns.filter((picked) => picked !== name)
+      : [...columns, name],
+    schema,
+  );
+
+export const isSameList = (
+  a: readonly string[],
+  b: readonly string[],
+): boolean =>
+  a.length === b.length && a.every((name, index) => name === b[index]);

package/src/stores/editors/CubeConcatDraft.ts

@@ -0,0 +1,49 @@
+/**
+ * Copyright (c) 2026-present, Goldman Sachs
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import type { Concat } from '@finos/legend-cube';
+import { action, makeObservable, observable } from 'mobx';
+import { CubeNodeDraft } from './CubeNodeDraft.js';
+
+/**
+ * The Concat editor's draft (PLAN §11.5): its one setting, Convert types
+ * (Q5), which converts types that differ within numbers, strings or dates
+ * to the type they share
+ */
+export class CubeConcatDraft extends CubeNodeDraft<Concat> {
+  widenTypes: boolean;
+
+  constructor(original: Concat) {
+    super(original);
+    makeObservable(this, {
+      widenTypes: observable,
+      setWidenTypes: action,
+    });
+    this.widenTypes = original.widenTypes;
+  }
+
+  setWidenTypes(widenTypes: boolean): void {
+    this.widenTypes = widenTypes;
+  }
+
+  /** The original while the setting is as it was */
+  build(): Concat {
+    const { original, widenTypes } = this;
+    return widenTypes === original.widenTypes
+      ? original
+      : original.withWidenTypes(widenTypes);
+  }
+}

package/src/stores/editors/CubeDifferenceDraft.ts

@@ -0,0 +1,147 @@
+/**
+ * Copyright (c) 2026-present, Goldman Sachs
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import {
+  type Difference,
+  isNumericFamily,
+  type Schema,
+  type SchemaColumn,
+} from '@finos/legend-cube';
+import { action, makeObservable, observable } from 'mobx';
+import { CUBE_DIFFERENCE_COLUMN_REASONS } from '../../__lib__/LegendCubeLabels.js';
+import { isSameList, toggledColumns } from './CubeAggregationRows.js';
+import {
+  blankJoinKeyPair,
+  type CubeJoinKeyPair,
+  type CubeJoinKeysDraft,
+  joinKeyListsOf,
+  joinKeyPairsOf,
+} from './CubeJoinKeyPairs.js';
+import { CubeNodeDraft } from './CubeNodeDraft.js';
+
+/**
+ * The Difference editor's draft (spec §17.6, PLAN §11.7): pairs of key
+ * columns, as a Join's (a pair with no column picked is left out when built),
+ * and the difference columns, stored in the Left input's order but kept in a
+ * saved order until the picks change (M4's Q2). Until something changes,
+ * `build()` gives the original back.
+ */
+export class CubeDifferenceDraft
+  extends CubeNodeDraft<Difference>
+  implements CubeJoinKeysDraft
+{
+  pairs: readonly CubeJoinKeyPair[];
+  differenceColumns: readonly string[];
+  /** Anything was changed; until then, `build()` gives the original back */
+  private touched = false;
+  /** The key lists the pairs built before any edit, so edits undone by hand give the original back */
+  private readonly initialKeyLists: [string[], string[]];
+
+  constructor(original: Difference) {
+    super(original);
+    makeObservable<CubeDifferenceDraft, 'touched'>(this, {
+      pairs: observable.ref,
+      differenceColumns: observable.ref,
+      touched: observable,
+      addPair: action,
+      removePair: action,
+      setLeftColumn: action,
+      setRightColumn: action,
+      toggleDifferenceColumn: action,
+      clearDifferenceColumns: action,
+    });
+    this.pairs = joinKeyPairsOf(original.leftColumns, original.rightColumns);
+    this.initialKeyLists = joinKeyListsOf(this.pairs);
+    this.differenceColumns = original.differenceColumns;
+  }
+
+  addPair(): void {
+    this.pairs = [...this.pairs, blankJoinKeyPair()];
+    this.touched = true;
+  }
+
+  removePair(key: number): void {
+    this.pairs = this.pairs.filter((pair) => pair.key !== key);
+    this.touched = true;
+  }
+
+  setLeftColumn(key: number, left: string): void {
+    this.pairs = this.pairs.map((pair) =>
+      pair.key === key ? { ...pair, left } : pair,
+    );
+    this.touched = true;
+  }
+
+  setRightColumn(key: number, right: string): void {
+    this.pairs = this.pairs.map((pair) =>
+      pair.key === key ? { ...pair, right } : pair,
+    );
+    this.touched = true;
+  }
+
+  /** Ticks or unticks a difference column; the columns then follow the Left input's order */
+  toggleDifferenceColumn(name: string, leftSchema: Schema): void {
+    this.differenceColumns = toggledColumns(
+      this.differenceColumns,
+      name,
+      leftSchema,
+    );
+    this.touched = true;
+  }
+
+  clearDifferenceColumns(): void {
+    this.differenceColumns = [];
+    this.touched = true;
+  }
+
+  build(): Difference {
+    const [leftColumns, rightColumns] = joinKeyListsOf(this.pairs);
+    const [initialLeft, initialRight] = this.initialKeyLists;
+    const { original } = this;
+    return !this.touched ||
+      (isSameList(leftColumns, initialLeft) &&
+        isSameList(rightColumns, initialRight) &&
+        isSameList(this.differenceColumns, original.differenceColumns))
+      ? original
+      : original.withSettings({
+          leftColumns,
+          rightColumns,
+          differenceColumns: this.differenceColumns,
+        });
+  }
+}
+
+/**
+ * Why a column of the Left input can't be a difference column, `undefined`
+ * when it can: it is a join column on either side, or not a number, or not in
+ * the Right input with the same type (PLAN §11.7)
+ */
+export const getDifferenceColumnUnpickableReason = (
+  column: SchemaColumn,
+  rightSchema: Schema,
+  joinColumns: readonly string[],
+): string | undefined => {
+  const rightType = rightSchema.type(column.name);
+  return joinColumns.includes(column.name)
+    ? CUBE_DIFFERENCE_COLUMN_REASONS.JOIN_COLUMN
+    : !isNumericFamily(column.type.family)
+      ? CUBE_DIFFERENCE_COLUMN_REASONS.NOT_NUMERIC
+      : rightType === undefined
+        ? CUBE_DIFFERENCE_COLUMN_REASONS.NOT_IN_RIGHT
+        : !rightType.equals(column.type)
+          ? CUBE_DIFFERENCE_COLUMN_REASONS.TYPE_DIFFERS(rightType.displayName)
+          : undefined;
+};