@finos/legend-application 1.1.7 → 1.2.1

package/src/components/LambdaEditor.tsx

@@ -55,7 +55,7 @@ export type LambdaEditorOnKeyDownEventHandler = {
 
 const LambdaErrorFeedback: React.FC<{
   error?: EngineError | undefined;
-  discardChanges: () => Promise<void>;
+  discardChanges: () => void;
 }> = (props) => {
   const { error, discardChanges } = props;
 
@@ -138,15 +138,15 @@ const LambdaEditorInline = observer(
       transformStringToLambda?.cancel();
       return await flowResult(
         lambdaEditorState.convertLambdaObjectToGrammarString(pretty),
-      ).catch(applicationStore.alertIllegalUnhandledError);
+      ).catch(applicationStore.alertUnhandledError);
     };
-    const discardChanges = applicationStore.guaranteeSafeAction(() =>
+    const discardChanges = applicationStore.guardUnhandledError(() =>
       transformLambdaToString(isExpanded),
     );
     const toggleExpandedMode = (): void => {
       if (!forceExpansion && !parserError) {
         transformLambdaToString(!isExpanded).catch(
-          applicationStore.alertIllegalUnhandledError,
+          applicationStore.alertUnhandledError,
         );
         setExpanded(!isExpanded);
       }
@@ -273,7 +273,7 @@ const LambdaEditorInline = observer(
             const stringToLambdaTransformation = transformStringToLambda();
             if (stringToLambdaTransformation) {
               flowResult(stringToLambdaTransformation).catch(
-                applicationStore.alertIllegalUnhandledError,
+                applicationStore.alertUnhandledError,
               );
             }
           }
@@ -461,9 +461,9 @@ const LambdaEditorPopUp = observer(
       transformStringToLambda?.cancel();
       return await flowResult(
         lambdaEditorState.convertLambdaObjectToGrammarString(pretty),
-      ).catch(applicationStore.alertIllegalUnhandledError);
+      ).catch(applicationStore.alertUnhandledError);
     };
-    const discardChanges = applicationStore.guaranteeSafeAction(() =>
+    const discardChanges = applicationStore.guardUnhandledError(() =>
       transformLambdaToString(true),
     );
 
@@ -531,7 +531,7 @@ const LambdaEditorPopUp = observer(
             const stringToLambdaTransformation = transformStringToLambda();
             if (stringToLambdaTransformation) {
               flowResult(stringToLambdaTransformation).catch(
-                applicationStore.alertIllegalUnhandledError,
+                applicationStore.alertUnhandledError,
               );
             }
           }
@@ -598,7 +598,7 @@ const LambdaEditorPopUp = observer(
     useEffect(() => {
       flowResult(
         lambdaEditorState.convertLambdaObjectToGrammarString(true),
-      ).catch(applicationStore.alertIllegalUnhandledError);
+      ).catch(applicationStore.alertUnhandledError);
     }, [applicationStore, lambdaEditorState]);
 
     useEffect(

package/src/components/NotificationManager.tsx

@@ -84,8 +84,9 @@ export const NotificationManager = observer(() => {
     applicationStore.setNotification(undefined);
     setIsExpanded(false);
   };
-  const handleCopy = (): Promise<void> =>
-    applicationStore.copyTextToClipboard(message);
+  const handleCopy = applicationStore.guardUnhandledError(() =>
+    applicationStore.copyTextToClipboard(message),
+  );
   const toggleExpansion = (): void => setIsExpanded(!isExpanded);
 
   const onSnackbarAutoHideOrClickAway = (
@@ -102,9 +103,6 @@ export const NotificationManager = observer(() => {
 
   return (
     <Notification
-      TransitionProps={{
-        appear: false,
-      }}
       classes={{
         root: 'notification',
         anchorOriginBottomRight: 'notification__position',

package/src/index.ts

@@ -27,12 +27,13 @@ export * from './components/ApplicationStoreProviderTestUtils';
 export * from './components/WebApplicationNavigatorProviderTestUtils';
 
 export { AppHeader } from './components/AppHeader';
+export { DocumentationLink } from './components/DocumentationLink';
 export * from './components/TextInputEditor';
 export * from './components/LambdaEditor';
 
 export * from './stores/ApplicationStore';
 export { APPLICATION_LOG_EVENT } from './stores/ApplicationLogEvent';
-export * from './stores/ApplicationConfig';
+export * from './stores/LegendApplicationConfig';
 export { WebApplicationNavigator } from './stores/WebApplicationNavigator';
 export { LambdaEditorState } from './stores/LambdaEditorState';
 export * from './stores/PackageableElementOption';

package/src/stores/ApplicationStore.ts

@@ -28,9 +28,10 @@ import {
 } from '@finos/legend-shared';
 import { makeAutoObservable, action } from 'mobx';
 import { APPLICATION_LOG_EVENT } from './ApplicationLogEvent';
-import type { LegendApplicationConfig } from './ApplicationConfig';
+import type { LegendApplicationConfig } from './LegendApplicationConfig';
 import type { WebApplicationNavigator } from './WebApplicationNavigator';
 import type { LegendApplicationPluginManager } from '../application/LegendApplicationPluginManager';
+import type { LegendApplicationDocumentationRegistry } from './LegendApplicationDocumentationRegistry';
 
 export enum ActionAlertType {
   STANDARD = 'STANDARD',
@@ -105,6 +106,7 @@ export class ApplicationStore<T extends LegendApplicationConfig> {
   blockingAlertInfo?: BlockingAlertInfo | undefined;
   actionAlertInfo?: ActionAlertInfo | undefined;
   config: T;
+  docRegistry: LegendApplicationDocumentationRegistry;
 
   log: Log = new Log();
   telemetryService = new TelemetryService();
@@ -129,6 +131,7 @@ export class ApplicationStore<T extends LegendApplicationConfig> {
     });
 
     this.config = config;
+    this.docRegistry = config.docRegistry;
     this.navigator = navigator;
 
     // Register plugins
@@ -273,10 +276,10 @@ export class ApplicationStore<T extends LegendApplicationConfig> {
    * When we call store/state functions from the component, we should handle error thrown at these functions instead
    * of throwing them to the UI. This enforces that by throwing `IllegalStateError`
    */
-  alertIllegalUnhandledError = (error: Error): void => {
+  alertUnhandledError = (error: Error): void => {
     this.log.error(
       LogEvent.create(APPLICATION_LOG_EVENT.ILLEGAL_APPLICATION_STATE_OCCURRED),
-      'Encountered unhandled rejection in component',
+      'Encountered unhandled error in component tree',
       error,
     );
     this.notifyIllegalState(error.message);
@@ -285,10 +288,11 @@ export class ApplicationStore<T extends LegendApplicationConfig> {
   /**
    * Guarantee that the action being used by the component does not throw unhandled errors
    */
-  guaranteeSafeAction =
-    (actionFn: () => Promise<void>): (() => Promise<void>) =>
-    (): Promise<void> =>
-      actionFn().catch(this.alertIllegalUnhandledError);
+  guardUnhandledError =
+    (actionFn: () => Promise<void>): (() => void) =>
+    (): void => {
+      actionFn().catch(this.alertUnhandledError);
+    };
 
   async copyTextToClipboard(text: string): Promise<void> {
     if (typeof navigator.clipboard.writeText === 'function') {

package/src/stores/ApplicationStoreTestUtils.ts

@@ -17,7 +17,7 @@
 import { ApplicationStore } from './ApplicationStore';
 import { createBrowserHistory } from 'history';
 import { WebApplicationNavigator } from './WebApplicationNavigator';
-import type { LegendApplicationConfig } from './ApplicationConfig';
+import type { LegendApplicationConfig } from './LegendApplicationConfig';
 import type { LegendApplicationPluginManager } from '../application/LegendApplicationPluginManager';
 
 export const TEST_DATA__applicationVersion = {

package/src/stores/{ApplicationConfig.ts → LegendApplicationConfig.ts}

@@ -18,6 +18,7 @@ import {
   guaranteeNonEmptyString,
   guaranteeNonNullable,
 } from '@finos/legend-shared';
+import { LegendApplicationDocumentationRegistry } from './LegendApplicationDocumentationRegistry';
 
 export interface LegendApplicationVersionData {
   buildTime: string;
@@ -28,6 +29,10 @@ export interface LegendApplicationVersionData {
 export interface LegendApplicationConfigurationData {
   appName: string;
   env: string;
+  documentation?: {
+    url: string;
+    entries?: Record<string, string>;
+  };
   // TODO: when we support vault-like settings
   // See https://github.com/finos/legend-studio/issues/407
   // settingOverrides
@@ -39,6 +44,8 @@ export abstract class LegendApplicationConfig {
   readonly baseUrl: string;
   readonly env: string;
 
+  readonly docRegistry: LegendApplicationDocumentationRegistry;
+
   readonly appVersion: string;
   readonly appVersionBuildTime: string;
   readonly appVersionCommitId: string;
@@ -58,6 +65,13 @@ export abstract class LegendApplicationConfig {
       `Can't configure application: 'env' field is missing or empty`,
     );
 
+    // Documentation
+    this.docRegistry = new LegendApplicationDocumentationRegistry();
+    this.docRegistry.url = configData.documentation?.url;
+    Object.entries(configData.documentation?.entries ?? []).forEach((entry) =>
+      this.docRegistry.registerEntry(entry[0], entry[1]),
+    );
+
     // Version
     this.appVersion = guaranteeNonNullable(
       versionData.version,

package/src/stores/LegendApplicationDocumentationRegistry.ts

@@ -0,0 +1,29 @@
+/**
+ * Copyright (c) 2020-present, Goldman Sachs
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+export class LegendApplicationDocumentationRegistry {
+  url?: string | undefined;
+
+  private registry = new Map<string, string>();
+
+  registerEntry(key: string, value: string): void {
+    this.registry.set(key, value);
+  }
+
+  getEntry(key: string): string | undefined {
+    return this.registry.get(key);
+  }
+}

package/tsconfig.json

@@ -34,11 +34,12 @@
     "./src/const.ts",
     "./src/index.ts",
     "./src/components/ApplicationTestID.ts",
-    "./src/stores/ApplicationConfig.ts",
     "./src/stores/ApplicationLogEvent.ts",
     "./src/stores/ApplicationStore.ts",
     "./src/stores/ApplicationStoreTestUtils.ts",
     "./src/stores/LambdaEditorState.ts",
+    "./src/stores/LegendApplicationConfig.ts",
+    "./src/stores/LegendApplicationDocumentationRegistry.ts",
     "./src/stores/PackageableElementOption.ts",
     "./src/stores/PureLanguageSupport.ts",
     "./src/stores/WebApplicationNavigator.ts",
@@ -49,6 +50,7 @@
     "./src/components/ApplicationStoreProvider.tsx",
     "./src/components/ApplicationStoreProviderTestUtils.tsx",
     "./src/components/BlockingAlert.tsx",
+    "./src/components/DocumentationLink.tsx",
     "./src/components/LambdaEditor.tsx",
     "./src/components/LegendApplicationComponentFrameworkProvider.tsx",
     "./src/components/NotificationManager.tsx",

package/lib/stores/ApplicationConfig.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"ApplicationConfig.d.ts","sourceRoot":"","sources":["../../src/stores/ApplicationConfig.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;GAcG;AAOH,MAAM,WAAW,4BAA4B;IAC3C,SAAS,EAAE,MAAM,CAAC;IAClB,OAAO,EAAE,MAAM,CAAC;IAChB,SAAS,EAAE,MAAM,CAAC;CACnB;AAED,MAAM,WAAW,kCAAkC;IACjD,OAAO,EAAE,MAAM,CAAC;IAChB,GAAG,EAAE,MAAM,CAAC;IAIZ,UAAU,CAAC,EAAE,MAAM,CAAC,WAAW,EAAE,OAAO,CAAC,CAAC;CAC3C;AAED,8BAAsB,uBAAuB;IAC3C,QAAQ,CAAC,OAAO,EAAE,MAAM,CAAC;IACzB,QAAQ,CAAC,OAAO,EAAE,MAAM,CAAC;IACzB,QAAQ,CAAC,GAAG,EAAE,MAAM,CAAC;IAErB,QAAQ,CAAC,UAAU,EAAE,MAAM,CAAC;IAC5B,QAAQ,CAAC,mBAAmB,EAAE,MAAM,CAAC;IACrC,QAAQ,CAAC,kBAAkB,EAAE,MAAM,CAAC;gBAGlC,UAAU,EAAE,kCAAkC,EAC9C,WAAW,EAAE,4BAA4B,EACzC,OAAO,EAAE,MAAM;CA0BlB"}

package/lib/stores/ApplicationConfig.js.map

@@ -1 +0,0 @@
-{"version":3,"file":"ApplicationConfig.js","sourceRoot":"","sources":["../../src/stores/ApplicationConfig.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;GAcG;AAEH,OAAO,EACL,uBAAuB,EACvB,oBAAoB,GACrB,MAAM,sBAAsB,CAAC;AAiB9B,MAAM,OAAgB,uBAAuB;IAClC,OAAO,CAAS;IAChB,OAAO,CAAS;IAChB,GAAG,CAAS;IAEZ,UAAU,CAAS;IACnB,mBAAmB,CAAS;IAC5B,kBAAkB,CAAS;IAEpC,YACE,UAA8C,EAC9C,WAAyC,EACzC,OAAe;QAEf,IAAI,CAAC,OAAO,GAAG,OAAO,CAAC;QACvB,IAAI,CAAC,OAAO,GAAG,uBAAuB,CACpC,UAAU,CAAC,OAAO,EAClB,kEAAkE,CACnE,CAAC;QACF,IAAI,CAAC,GAAG,GAAG,uBAAuB,CAChC,UAAU,CAAC,GAAG,EACd,8DAA8D,CAC/D,CAAC;QAEF,UAAU;QACV,IAAI,CAAC,UAAU,GAAG,oBAAoB,CACpC,WAAW,CAAC,OAAO,EACnB,+DAA+D,CAChE,CAAC;QACF,IAAI,CAAC,mBAAmB,GAAG,oBAAoB,CAC7C,WAAW,CAAC,SAAS,EACrB,iEAAiE,CAClE,CAAC;QACF,IAAI,CAAC,kBAAkB,GAAG,oBAAoB,CAC5C,WAAW,CAAC,SAAS,EACrB,iEAAiE,CAClE,CAAC;IACJ,CAAC;CACF"}