@finos/legend-application-studio 28.5.9 → 28.7.0

package/src/components/editor/side-bar/ProjectOverview.tsx

@@ -23,7 +23,6 @@ import {
   ShareIcon,
   PanelLoadingIndicator,
   ContextMenu,
-  SyncIcon,
   PencilIcon,
   InfoCircleIcon,
   TimesIcon,
@@ -338,7 +337,15 @@ const ReleaseEditor = observer(() => {
   const canCreateVersion =
     !isCurrentProjectVersionLatest &&
     !isDispatchingAction &&
-    editorStore.sdlcServerClient.features.canCreateVersion;
+    editorStore.sdlcServerClient.features.canCreateVersion &&
+    editorStore.sdlcState.canCreateVersion;
+  const disabledCreateVersionTitle = isCurrentProjectVersionLatest
+    ? `Can't create version: project version not the latest`
+    : !editorStore.sdlcServerClient.features.canCreateVersion
+    ? `Can't create version: current svn system does not support creating versions`
+    : !editorStore.sdlcState.canCreateVersion
+    ? `Can't create version: You do not have the rights to create a version`
+    : undefined;
 
   // since this can be affected by other users, we refresh it more proactively
   useEffect(() => {
@@ -381,6 +388,7 @@ const ReleaseEditor = observer(() => {
               onClick={createMajorRelease}
               disabled={!canCreateVersion}
               title={
+                disabledCreateVersionTitle ??
                 'Create a major release which comes with backward-incompatible features'
               }
             >
@@ -391,6 +399,7 @@ const ReleaseEditor = observer(() => {
               onClick={createMinorRelease}
               disabled={!canCreateVersion}
               title={
+                disabledCreateVersionTitle ??
                 'Create a minor release which comes with backward-compatible features'
               }
             >
@@ -401,6 +410,7 @@ const ReleaseEditor = observer(() => {
               onClick={createPatchRelease}
               disabled={!canCreateVersion}
               title={
+                disabledCreateVersionTitle ??
                 'Create a patch release which comes with backward-compatible bug fixes'
               }
             >
@@ -637,7 +647,9 @@ const PatchEditor = observer(() => {
             Create Patch
             <DocumentationLink
               className="project-overview__patch__documentation"
-              documentationKey={LEGEND_STUDIO_DOCUMENTATION_KEY.CREATE_PATCH}
+              documentationKey={
+                LEGEND_STUDIO_DOCUMENTATION_KEY.QUESTION_WHAT_ARE_PROJECT_ROLES
+              }
             />
           </div>
         </div>
@@ -883,7 +895,8 @@ const OverviewViewer = observer(() => {
   const initialName = sdlcState.currentProject?.name ?? '';
   const initialDescription = sdlcState.currentProject?.description ?? '';
   const initialTags = sdlcState.currentProject?.tags ?? [];
-  const isDispatchingAction = projectOverviewState.isUpdatingProject;
+  const isDispatchingAction =
+    projectOverviewState.updatingProjectState.isInProgress;
   const [projectIdentifier, setProjectIdentifier] = useState(initialName);
   const [description, setDescription] = useState(initialDescription);
   const [itemValue, setItemValue] = useState<string>('');
@@ -948,7 +961,6 @@ const OverviewViewer = observer(() => {
       ),
     ).catch(applicationStore.alertUnhandledError);
   };
-
   return (
     <div className="panel side-bar__panel project-overview__panel project-overview__overview">
       <div className="panel__header">
@@ -957,14 +969,20 @@ const OverviewViewer = observer(() => {
             {PROJECT_OVERVIEW_ACTIVITY_MODE.OVERVIEW}
           </div>
         </div>
-        <button
-          className="panel__header__action side-bar__header__action local-changes__sync-btn"
-          onClick={handleUpdate}
-          tabIndex={-1}
-          title="Update project"
-        >
-          <SyncIcon />
-        </button>
+        <div className="panel__header__actions">
+          <button
+            className="panel__header__action project-overview__update-btn"
+            onClick={handleUpdate}
+            title="Update Project"
+            tabIndex={-1}
+          >
+            <div className="project-overview__update-btn__label">
+              <div className="project-overview__update-btn__label__title">
+                Update
+              </div>
+            </div>
+          </button>
+        </div>
       </div>
       <div className="panel__content project-overview__panel__content">
         <PanelLoadingIndicator isLoading={isDispatchingAction} />
@@ -981,6 +999,25 @@ const OverviewViewer = observer(() => {
               onChange={changeProjectIdentifier}
             />
           </div>
+          {
+            <div className="panel__content__form__section">
+              <div className="panel__content__form__section__header__label">
+                Project User Role
+                <DocumentationLink
+                  documentationKey={
+                    LEGEND_STUDIO_DOCUMENTATION_KEY.QUESTION_WHAT_ARE_PROJECT_ROLES
+                  }
+                />
+              </div>
+              <input
+                className="panel__content__form__section__input"
+                title="Project User Role"
+                disabled={true}
+                spellCheck={false}
+                value={sdlcState.accessRole?.accessRole ?? '(unknown)'}
+              />
+            </div>
+          }
         </div>
         <div className="panel__content__form">
           <div className="panel__content__form__section">

package/src/components/editor/side-bar/WorkspaceReview.tsx

@@ -33,7 +33,10 @@ import { ACTIVITY_MODE } from '../../../stores/editor/EditorConfig.js';
 import { generateReviewRoute } from '../../../__lib__/LegendStudioNavigation.js';
 import { LEGEND_STUDIO_TEST_ID } from '../../../__lib__/LegendStudioTesting.js';
 import { flowResult } from 'mobx';
-import type { EntityDiff } from '@finos/legend-server-sdlc';
+import {
+  AuthorizableProjectAction,
+  type EntityDiff,
+} from '@finos/legend-server-sdlc';
 import { entityDiffSorter } from '../../../stores/editor/EditorSDLCState.js';
 import { useEditorStore } from '../EditorStoreProvider.js';
 import { useLegendStudioApplicationStore } from '../../LegendStudioFrameworkProvider.js';
@@ -128,6 +131,19 @@ export const WorkspaceReview = observer(() => {
       applicationStore.alertUnhandledError,
     );
   };
+  // commit Review
+  const isCommitReviewDisabled =
+    isDispatchingAction ||
+    Boolean(!workspaceReview) ||
+    workspaceContainsSnapshotDependencies ||
+    !workspaceReviewState.canMergeReview;
+  const commitReviewTitle = workspaceContainsSnapshotDependencies
+    ? `Can't commit review: workspace has snapshot dependencies`
+    : !workspaceReviewState.canMergeReview
+    ? workspaceReviewState.sdlcState.unAuthorizedActionMessage(
+        AuthorizableProjectAction.COMMIT_REVIEW,
+      )
+    : 'Commit review';
   const commitReview = (): void => {
     if (workspaceReview && !isDispatchingAction) {
       editorStore.localChangesState.alertUnsavedChanges((): void => {
@@ -138,6 +154,20 @@ export const WorkspaceReview = observer(() => {
       });
     }
   };
+  // create Review
+  const isCreateReviewDisabled =
+    isDispatchingAction ||
+    Boolean(workspaceReview) ||
+    !workspaceReviewState.reviewTitle ||
+    workspaceContainsSnapshotDependencies ||
+    !workspaceReviewState.canCreateReview;
+  const createReviewTitle = workspaceContainsSnapshotDependencies
+    ? `Can't create review: workspace has snapshot dependencies`
+    : !workspaceReviewState.canCreateReview
+    ? workspaceReviewState.sdlcState.unAuthorizedActionMessage(
+        AuthorizableProjectAction.SUBMIT_REVIEW,
+      )
+    : 'Create review';
   const createReview = (): void => {
     if (
       workspaceReviewState.reviewTitle &&
@@ -229,17 +259,8 @@ export const WorkspaceReview = observer(() => {
                     'btn--error': workspaceContainsSnapshotDependencies,
                   })}
                   onClick={createReview}
-                  disabled={
-                    isDispatchingAction ||
-                    Boolean(workspaceReview) ||
-                    !workspaceReviewState.reviewTitle ||
-                    workspaceContainsSnapshotDependencies
-                  }
-                  title={
-                    !workspaceContainsSnapshotDependencies
-                      ? 'Create review'
-                      : `Can't create review: workspace has snapshot dependencies`
-                  }
+                  disabled={isCreateReviewDisabled}
+                  title={createReviewTitle}
                 >
                   <PlusIcon />
                 </button>
@@ -283,17 +304,9 @@ export const WorkspaceReview = observer(() => {
                     { 'btn--error': workspaceContainsSnapshotDependencies },
                   )}
                   onClick={commitReview}
-                  disabled={
-                    isDispatchingAction ||
-                    Boolean(!workspaceReview) ||
-                    workspaceContainsSnapshotDependencies
-                  }
+                  disabled={isCommitReviewDisabled}
                   tabIndex={-1}
-                  title={
-                    !workspaceContainsSnapshotDependencies
-                      ? 'Commit review'
-                      : `Can't commit review: workspace has snapshot dependencies`
-                  }
+                  title={commitReviewTitle}
                 >
                   <TruncatedGitMergeIcon />
                 </button>

package/src/stores/editor/EditorSDLCState.ts

@@ -33,6 +33,7 @@ import {
   guaranteeNonNullable,
   assertTrue,
   ActionState,
+  prettyCONSTName,
 } from '@finos/legend-shared';
 import { EDITOR_MODE, ACTIVITY_MODE } from './EditorConfig.js';
 import { type Entity, extractEntityNameFromPath } from '@finos/legend-storage';
@@ -47,6 +48,8 @@ import {
   Workspace,
   WorkspaceAccessType,
   Patch,
+  ProjectAccessRole,
+  AuthorizableProjectAction,
 } from '@finos/legend-server-sdlc';
 import { LEGEND_STUDIO_APP_EVENT } from '../../__lib__/LegendStudioEvent.js';
 
@@ -73,6 +76,8 @@ export class EditorSDLCState {
   workspaceWorkflows: Workflow[] = [];
   projectVersions: Version[] = [];
   projectPublishedVersions: string[] = [];
+  authorizedActions: AuthorizableProjectAction[] | undefined;
+  accessRole: ProjectAccessRole | undefined;
 
   constructor(editorStore: EditorStore) {
     makeObservable(this, {
@@ -88,11 +93,15 @@ export class EditorSDLCState {
       isFetchingProjectVersions: observable,
       isFetchingProject: observable,
       projectPublishedVersions: observable,
+      authorizedActions: observable,
+      accessRole: observable,
       activeProject: computed,
       activeWorkspace: computed,
       activeRevision: computed,
       activePatch: computed,
       activeRemoteWorkspaceRevision: computed,
+      canCreateWorkspace: computed,
+      canCreateVersion: computed,
       isWorkspaceOutOfSync: computed,
       setCurrentProject: action,
       setCurrentPatch: action,
@@ -112,6 +121,7 @@ export class EditorSDLCState {
       buildProjectLatestRevisionEntityHashesIndex: flow,
       fetchWorkspaceWorkflows: flow,
       fetchPublishedProjectVersions: flow,
+      fetchAuthorizedActions: flow,
     });
 
     this.editorStore = editorStore;
@@ -153,6 +163,32 @@ export class EditorSDLCState {
     return this.activeRemoteWorkspaceRevision.id !== this.activeRevision.id;
   }
 
+  get canCreateWorkspace(): boolean {
+    return this.userCanPerformAction(
+      AuthorizableProjectAction.CREATE_WORKSPACE,
+    );
+  }
+
+  get canCreateVersion(): boolean {
+    return this.userCanPerformAction(AuthorizableProjectAction.CREATE_VERSION);
+  }
+
+  unAuthorizedActionMessage(_action: AuthorizableProjectAction): string {
+    if (this.accessRole) {
+      return `Your role ${
+        this.accessRole.accessRole
+      } does not allow you to perform the action '${prettyCONSTName(_action)}'`;
+    }
+    return `Your are not entitled to perform the action: ${_action}`;
+  }
+
+  userCanPerformAction(authorizedAction: AuthorizableProjectAction): boolean {
+    return Boolean(
+      this.authorizedActions === undefined ||
+        this.authorizedActions.includes(authorizedAction),
+    );
+  }
+
   setCurrentProject(val: Project): void {
     this.currentProject = val;
   }
@@ -530,6 +566,31 @@ export class EditorSDLCState {
     }
   }
 
+  *fetchAuthorizedActions(): GeneratorFn<void> {
+    try {
+      const [authorizedActions, accessRoleRaw] = (yield Promise.all([
+        this.editorStore.sdlcServerClient.getAutorizedActions(
+          this.activeProject.projectId,
+        ),
+        this.editorStore.sdlcServerClient.getAccessRole(
+          this.activeProject.projectId,
+        ),
+      ])) as [AuthorizableProjectAction[], PlainObject<ProjectAccessRole>];
+      this.authorizedActions = authorizedActions;
+      this.accessRole = ProjectAccessRole.serialization.fromJson(accessRoleRaw);
+    } catch (error) {
+      assertErrorThrown(error);
+      // if there is an error fetching authorized actions we should set undefined
+      this.authorizedActions = undefined;
+      this.accessRole = undefined;
+      this.editorStore.applicationStore.logService.error(
+        LogEvent.create(LEGEND_STUDIO_APP_EVENT.SDLC_MANAGER_FAILURE),
+        error,
+      );
+      this.editorStore.applicationStore.notificationService.notifyError(error);
+    }
+  }
+
   *fetchPublishedProjectVersions(): GeneratorFn<void> {
     try {
       this.fetchPublishedProjectVersionsState.inProgress();

package/src/stores/editor/EditorStore.ts

@@ -748,6 +748,7 @@ export class EditorStore implements CommandRegistrar {
       this.graphState.fetchAvailableRelationalDatabseTypeConfigurations(),
       this.sdlcState.fetchProjectVersions(),
       this.sdlcState.fetchPublishedProjectVersions(),
+      this.sdlcState.fetchAuthorizedActions(),
     ]);
   }
 
@@ -790,6 +791,7 @@ export class EditorStore implements CommandRegistrar {
       this.graphState.fetchAvailableRelationalDatabseTypeConfigurations(),
       this.sdlcState.fetchProjectVersions(),
       this.sdlcState.fetchPublishedProjectVersions(),
+      this.sdlcState.fetchAuthorizedActions(),
     ]);
   }
 

package/src/stores/editor/NewElementState.ts

@@ -558,12 +558,6 @@ export class NewServiceDriver extends NewElementDriver<Service> {
       this.editorStore.changeDetectionState.observerContext,
     );
     service_initNewService(service);
-    const currentUserId =
-      this.editorStore.graphManagerState.graphManager.TEMPORARY__getEngineConfig()
-        .currentUserId;
-    if (currentUserId) {
-      service.owners = [currentUserId];
-    }
     return service;
   }
 }

package/src/stores/editor/editor-state/element-editor-state/service/ServiceEditorState.ts

@@ -38,6 +38,8 @@ import {
   Service,
   PureSingleExecution,
   PureMultiExecution,
+  DeploymentOwnership,
+  UserListOwnership,
   isStubbed_RawLambda,
   getValueSpecificationReturnType,
   type Type,
@@ -48,6 +50,7 @@ import { ServiceTestableState } from './testable/ServiceTestableState.js';
 import { User } from '@finos/legend-server-sdlc';
 import { ServicePostValidationsState } from './ServicePostValidationState.js';
 import { valueSpecReturnTDS } from '@finos/legend-query-builder';
+import { service_setOwnership } from '../../../../graph-modifier/DSL_Service_GraphModifierHelper.js';
 
 export enum SERVICE_TAB {
   GENERAL = 'GENERAL',
@@ -57,6 +60,11 @@ export enum SERVICE_TAB {
   POST_VALIDATION = 'POST_VALIDATION',
 }
 
+enum ServiceOwnershipType {
+  DEPLOYMENT_OWNERSHIP = 'deploymentOwnership',
+  USERLIST_OWNERSHIP = 'userListOwnership',
+}
+
 export const resolveServiceQueryValueSpec = (
   service: Service,
   editorStore: EditorStore,
@@ -101,6 +109,24 @@ export const isServiceQueryTDS = (
 };
 
 export const MINIMUM_SERVICE_OWNERS = 2;
+export const DeploymentOwnershipLabel = 'Deployment';
+export const UserlistOwnershipLabel = 'User List';
+export const OWNERSHIP_OPTIONS = [
+  {
+    label: DeploymentOwnershipLabel,
+    value: ServiceOwnershipType.DEPLOYMENT_OWNERSHIP,
+  },
+  {
+    label: UserlistOwnershipLabel,
+    value: ServiceOwnershipType.USERLIST_OWNERSHIP,
+  },
+];
+
+export type ServiceOwnerOption = {
+  label: string;
+  value: string;
+};
+
 export class ServiceEditorState extends ElementEditorState {
   executionState: ServiceExecutionState;
   registrationState: ServiceRegistrationState;
@@ -113,10 +139,12 @@ export class ServiceEditorState extends ElementEditorState {
 
     makeObservable(this, {
       executionState: observable,
+      selectedOwnership: computed,
       registrationState: observable,
       selectedTab: observable,
       postValidationState: observable,
       setSelectedTab: action,
+      setSelectedOwnership: action,
       resetExecutionState: action,
       openToTestTab: action,
       service: computed,
@@ -153,6 +181,52 @@ export class ServiceEditorState extends ElementEditorState {
     this.selectedTab = SERVICE_TAB.TEST;
   }
 
+  get selectedOwnership(): ServiceOwnerOption | undefined {
+    const ownership = this.service.ownership;
+    if (ownership instanceof DeploymentOwnership) {
+      return {
+        label: DeploymentOwnershipLabel,
+        value: ServiceOwnershipType.DEPLOYMENT_OWNERSHIP,
+      };
+    } else if (ownership instanceof UserListOwnership) {
+      return {
+        label: UserlistOwnershipLabel,
+        value: ServiceOwnershipType.USERLIST_OWNERSHIP,
+      };
+    }
+    return undefined;
+  }
+
+  setSelectedOwnership(o: ServiceOwnerOption): void {
+    switch (o.value) {
+      case ServiceOwnershipType.DEPLOYMENT_OWNERSHIP: {
+        service_setOwnership(
+          this.service,
+          new DeploymentOwnership('', this.service),
+        );
+        break;
+      }
+      case ServiceOwnershipType.USERLIST_OWNERSHIP: {
+        const currentUserId =
+          this.editorStore.graphManagerState.graphManager.TEMPORARY__getEngineConfig()
+            .currentUserId;
+        service_setOwnership(
+          this.service,
+          new UserListOwnership(
+            currentUserId ? [currentUserId] : [],
+            this.service,
+          ),
+        );
+        break;
+      }
+      default: {
+        this.editorStore.applicationStore.notificationService.notifyError(
+          'Unsupported ownership type',
+        );
+      }
+    }
+  }
+
   resetExecutionState(): void {
     this.executionState = this.buildExecutionState();
   }

package/src/stores/editor/editor-state/element-editor-state/service/ServiceRegistrationState.ts

@@ -354,7 +354,10 @@ export class ServiceRegistrationState extends ServiceConfigState {
       assertNonEmptyString(owner, `Service can't have an empty owner name`),
     );
     assertTrue(
-      this.service.owners.length >= MINIMUM_SERVICE_OWNERS,
+      Boolean(
+        this.service.ownership ??
+          this.service.owners.length >= MINIMUM_SERVICE_OWNERS,
+      ),
       `Service needs to have at least 2 owners in order to be registered`,
     );
     guaranteeNonNullable(

package/src/stores/editor/sidebar-state/ProjectOverviewState.ts

@@ -67,7 +67,7 @@ export class ProjectOverviewState {
   isCreatingVersion = false;
   isFetchingProjectWorkspaces = false;
   isDeletingWorkspace = false;
-  isUpdatingProject = false;
+  updatingProjectState = ActionState.create();
   isFetchingLatestVersion = false;
   isFetchingCurrentProjectRevision = false;
 
@@ -85,7 +85,7 @@ export class ProjectOverviewState {
       isCreatingVersion: observable,
       isFetchingProjectWorkspaces: observable,
       isDeletingWorkspace: observable,
-      isUpdatingProject: observable,
+      updatingProjectState: observable,
       isFetchingLatestVersion: observable,
       isFetchingCurrentProjectRevision: observable,
       setActivityMode: action,
@@ -193,7 +193,7 @@ export class ProjectOverviewState {
     tags: string[],
   ): GeneratorFn<void> {
     try {
-      this.isUpdatingProject = true;
+      this.updatingProjectState.inProgress();
       yield this.editorStore.sdlcServerClient.updateProject(
         this.sdlcState.activeProject.projectId,
         {
@@ -214,7 +214,7 @@ export class ProjectOverviewState {
       assertErrorThrown(error);
       this.editorStore.applicationStore.notificationService.notifyError(error);
     } finally {
-      this.isUpdatingProject = false;
+      this.updatingProjectState.complete();
     }
   }
 

package/src/stores/editor/sidebar-state/WorkspaceReviewState.ts

@@ -14,7 +14,14 @@
  * limitations under the License.
  */
 
-import { action, makeObservable, flowResult, observable, flow } from 'mobx';
+import {
+  action,
+  makeObservable,
+  flowResult,
+  observable,
+  flow,
+  computed,
+} from 'mobx';
 import type { EditorStore } from '../EditorStore.js';
 import type { EditorSDLCState } from '../EditorSDLCState.js';
 import { LEGEND_STUDIO_APP_EVENT } from '../../../__lib__/LegendStudioEvent.js';
@@ -36,6 +43,7 @@ import {
   Review,
   ReviewState,
   RevisionAlias,
+  AuthorizableProjectAction,
 } from '@finos/legend-server-sdlc';
 import { ActionAlertActionType } from '@finos/legend-application';
 
@@ -69,6 +77,8 @@ export class WorkspaceReviewState {
       isCreatingWorkspaceReview: observable,
       isCommittingWorkspaceReview: observable,
       isRecreatingWorkspaceAfterCommittingReview: observable,
+      canCreateReview: computed,
+      canMergeReview: computed,
       setReviewTitle: action,
       openReviewChange: action,
       refreshWorkspaceChanges: flow,
@@ -83,6 +93,18 @@ export class WorkspaceReviewState {
     this.sdlcState = sdlcState;
   }
 
+  get canCreateReview(): boolean {
+    return this.sdlcState.userCanPerformAction(
+      AuthorizableProjectAction.SUBMIT_REVIEW,
+    );
+  }
+
+  get canMergeReview(): boolean {
+    return this.sdlcState.userCanPerformAction(
+      AuthorizableProjectAction.COMMIT_REVIEW,
+    );
+  }
+
   setReviewTitle(val: string): void {
     this.reviewTitle = val;
   }

package/src/stores/editor/utils/MockDataUtils.ts

@@ -56,6 +56,7 @@ import {
   Date as ColumnDate,
   SemiStructured,
   Json,
+  MILESTONING_VERSION_PROPERTY_SUFFIX,
 } from '@finos/legend-graph';
 import {
   CLASS_PROPERTY_TYPE,
@@ -116,10 +117,23 @@ export const createMockClassInstance = (
   depth = 0,
 ): PlainObject => {
   const properties = traverseNonRequiredProperties
-    ? getAllClassProperties(_class)
-    : getAllClassProperties(_class).filter((p) => p.multiplicity.lowerBound);
+    ? getAllClassProperties(_class, true)
+    : getAllClassProperties(_class, true).filter(
+        (p) => p.multiplicity.lowerBound,
+      );
+  const propertyNames = properties.map((property) => property.name);
+  const filteredProperties = properties.filter(
+    (prop) =>
+      prop.name.endsWith(MILESTONING_VERSION_PROPERTY_SUFFIX.ALL_VERSIONS) ||
+      (!propertyNames.includes(
+        prop.name + MILESTONING_VERSION_PROPERTY_SUFFIX.ALL_VERSIONS,
+      ) &&
+        !prop.name.endsWith(
+          MILESTONING_VERSION_PROPERTY_SUFFIX.ALL_VERSIONS_IN_RANGE,
+        )),
+  );
   const mockData: Record<string, object | string | number | boolean> = {};
-  properties.forEach((property) => {
+  filteredProperties.forEach((property) => {
     const propertyType = property.genericType.value.rawType;
     let propertyMockData: PlainObject | string | number | boolean | undefined;
     switch (getClassPropertyType(propertyType)) {

package/src/stores/graph-modifier/DSL_Service_GraphModifierHelper.ts

@@ -23,6 +23,9 @@ import {
   type RawLambda,
   type Runtime,
   type Service,
+  DeploymentOwnership,
+  type UserListOwnership,
+  type ServiceOwnership,
   type ServiceExecution,
   type ObserverContext,
   type ServiceTestSuite,
@@ -47,6 +50,7 @@ import {
   observe_PostValidationAssertion,
   TestData,
   observe_TestData,
+  observe_Ownership,
 } from '@finos/legend-graph';
 import { addUniqueEntry, deleteEntry, uuid } from '@finos/legend-shared';
 import { action } from 'mobx';
@@ -158,12 +162,20 @@ export const service_deleteTestSuite = action(
   },
 );
 
+export const service_setOwnership = action(
+  (service: Service, value: ServiceOwnership | undefined): void => {
+    service.ownership = value ? observe_Ownership(value) : undefined;
+  },
+);
+
 export const service_initNewService = action(
   (service: Service, userId?: string): void => {
     service.pattern = `/${uuid()}`; // initialize the service pattern with an UUID to avoid people leaving the pattern as /
     if (userId) {
-      service.owners.push(userId);
-    } // this is used to add the current user as the first owner by default
+      service.owners = [userId];
+    } else {
+      service_setOwnership(service, new DeploymentOwnership('', service));
+    }
   },
 );
 export const service_setExecution = action(
@@ -180,6 +192,31 @@ export const service_setPattern = action(
     service.pattern = value;
   },
 );
+
+export const service_deploymentOwnership = action(
+  (deployment: DeploymentOwnership, value: string): void => {
+    deployment.identifier = value;
+  },
+);
+
+export const service_addUserOwnership = action(
+  (userList: UserListOwnership, value: string): void => {
+    userList.users.push(value);
+  },
+);
+
+export const service_updateUserOwnership = action(
+  (userList: UserListOwnership, value: string, index: number): void => {
+    userList.users[index] = value;
+  },
+);
+
+export const service_deleteValueFromUserOwnership = action(
+  (userList: UserListOwnership, index: number): void => {
+    userList.users.splice(index, 1);
+  },
+);
+
 export const service_setDocumentation = action(
   (service: Service, value: string): void => {
     service.documentation = value;