@finos/legend-application-studio 28.21.7 → 28.21.9

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@finos/legend-application-studio",
-  "version": "28.21.7",
+  "version": "28.21.9",
   "description": "Legend Studio application core",
   "keywords": [
     "legend",
@@ -47,17 +47,17 @@
   },
   "dependencies": {
     "@dagrejs/dagre": "1.1.4",
-    "@finos/legend-application": "16.0.107",
-    "@finos/legend-art": "7.1.148",
-    "@finos/legend-code-editor": "2.0.172",
-    "@finos/legend-data-cube": "0.3.89",
-    "@finos/legend-extension-dsl-data-product": "0.0.82",
-    "@finos/legend-extension-dsl-diagram": "8.1.236",
-    "@finos/legend-graph": "32.6.4",
-    "@finos/legend-lego": "2.0.192",
-    "@finos/legend-query-builder": "4.18.11",
+    "@finos/legend-application": "16.0.108",
+    "@finos/legend-art": "7.1.149",
+    "@finos/legend-code-editor": "2.0.174",
+    "@finos/legend-data-cube": "0.3.91",
+    "@finos/legend-extension-dsl-data-product": "0.0.84",
+    "@finos/legend-extension-dsl-diagram": "8.1.238",
+    "@finos/legend-graph": "32.6.6",
+    "@finos/legend-lego": "2.0.194",
+    "@finos/legend-query-builder": "4.18.13",
     "@finos/legend-server-depot": "6.1.12",
-    "@finos/legend-server-lakehouse": "0.3.53",
+    "@finos/legend-server-lakehouse": "0.3.55",
     "@finos/legend-server-sdlc": "5.4.3",
     "@finos/legend-server-showcase": "0.2.66",
     "@finos/legend-shared": "11.0.25",

package/src/application/LegendStudioApplicationConfig.ts

@@ -191,6 +191,7 @@ export interface LegendStudioApplicationConfigurationData
   query?: { url: string };
   showcase?: { url: string };
   pct?: { reportUrl: string };
+  legendAI?: { url: string };
 }
 
 export class LegendStudioApplicationConfig extends LegendApplicationConfig {
@@ -205,6 +206,7 @@ export class LegendStudioApplicationConfig extends LegendApplicationConfig {
   readonly queryApplicationUrl?: string | undefined;
   readonly showcaseServerUrl?: string | undefined;
   readonly pctReportUrl?: string | undefined;
+  readonly legendAIUrl?: string | undefined;
 
   constructor(
     input: LegendApplicationConfigurationInput<LegendStudioApplicationConfigurationData>,
@@ -275,6 +277,13 @@ export class LegendStudioApplicationConfig extends LegendApplicationConfig {
       );
     }
 
+    // legend AI
+    if (input.configData.legendAI?.url) {
+      this.legendAIUrl = LegendApplicationConfig.resolveAbsoluteUrl(
+        input.configData.legendAI.url,
+      );
+    }
+
     // options
     this.options = LegendStudioApplicationCoreOptions.create(
       input.configData.extensions?.core ?? {},

package/src/components/editor/editor-group/accessor/AccessorQueryBuilderHelper.tsx

@@ -45,7 +45,7 @@ export const queryAccessorSource = async (
             editorStore.applicationStore.config.options.queryBuilderConfig,
             editorStore.editorMode.getSourceInfo(),
           );
-          queryBuilderState.changeAccessorOwner(element);
+          await queryBuilderState.changeAccessorOwner(element);
           const compatibleRuntimes = getCompatibleRuntimesFromAccessorOwner(
             element,
             editorStore.graphManagerState,

package/src/components/editor/editor-group/dataProduct/DataProductEditor.tsx

@@ -847,7 +847,7 @@ export const LakehouseDataProductAccessPointEditor = observer(
                 applicationStore.config.options.queryBuilderConfig,
                 editorStore.editorMode.getSourceInfo(),
               );
-              queryBuilderState.changeAccessorOwner(ingestDefinition);
+              await queryBuilderState.changeAccessorOwner(ingestDefinition);
               const compatibleRuntimes = getCompatibleRuntimesFromAccessorOwner(
                 ingestDefinition,
                 editorStore.graphManagerState,
@@ -2232,9 +2232,6 @@ const AccessPointGroupTab = observer(
 const DataProductSidebar = observer(
   (props: { dataProductEditorState: DataProductEditorState }) => {
     const { dataProductEditorState } = props;
-    const showTestingTab =
-      dataProductEditorState.editorStore.applicationStore.config.options
-        .NonProductionFeatureFlag;
     const sidebarTabs = [
       {
         label: DATA_PRODUCT_TAB.HOME,
@@ -2250,15 +2247,11 @@ const DataProductSidebar = observer(
         title: 'Operational Metadata',
         icon: <GearSuggestIcon />,
       },
-      ...(showTestingTab
-        ? [
-            {
-              label: DATA_PRODUCT_TAB.TESTING,
-              title: 'Testing',
-              icon: <FlaskIcon />,
-            },
-          ]
-        : []),
+      {
+        label: DATA_PRODUCT_TAB.TESTING,
+        title: 'Testing',
+        icon: <FlaskIcon />,
+      },
       {
         label: DATA_PRODUCT_TAB.SUPPORT,
         icon: <QuestionCircleIcon />,
@@ -3367,8 +3360,6 @@ export const DataProductEditor = observer(() => {
   const [showPreview, setShowPreview] = useState(false);
   const [dataProductViewerState, setDataProductViewerState] =
     useState<DataProductViewerState>();
-  const showTestingTab =
-    editorStore.applicationStore.config.options.NonProductionFeatureFlag;
 
   const selectedActivity = dataProductEditorState.selectedTab;
   const renderActivivtyBarTab = (): React.ReactNode => {
@@ -3402,12 +3393,12 @@ export const DataProductEditor = observer(() => {
           />
         );
       case DATA_PRODUCT_TAB.TESTING:
-        return showTestingTab ? (
+        return (
           <DataProductTestableEditor
             dataProductEditorState={dataProductEditorState}
             isReadOnly={isReadOnly}
           />
-        ) : null;
+        );
       default:
         return null;
     }
@@ -3423,15 +3414,6 @@ export const DataProductEditor = observer(() => {
     );
   }, [dataProductEditorState]);
 
-  useEffect(() => {
-    if (
-      !showTestingTab &&
-      dataProductEditorState.selectedTab === DATA_PRODUCT_TAB.TESTING
-    ) {
-      dataProductEditorState.setSelectedTab(DATA_PRODUCT_TAB.HOME);
-    }
-  }, [dataProductEditorState, showTestingTab]);
-
   useEffect(
     () =>
       autorun(

package/src/components/editor/editor-group/service-editor/ServiceEditor.tsx

@@ -35,6 +35,7 @@ import {
   CustomSelectorInput,
   PanelFormValidatedTextField,
   PanelContentLists,
+  SparkleIcon,
 } from '@finos/legend-art';
 import { debounce, prettyCONSTName } from '@finos/legend-shared';
 import { ServiceExecutionEditor } from './ServiceExecutionEditor.js';
@@ -72,6 +73,7 @@ import { flowResult } from 'mobx';
 import { LEGEND_STUDIO_DOCUMENTATION_KEY } from '../../../../__lib__/LegendStudioDocumentation.js';
 import { DocumentationLink } from '@finos/legend-lego/application';
 import { ServicePostValidationsEditor } from './ServicePostValidationEditor.js';
+import type { DSL_Service_LegendStudioApplicationPlugin_Extension } from '../../../../stores/extensions/DSL_Service_LegendStudioApplicationPlugin_Extension.js';
 
 type UserOption = { label: string; value: string };
 
@@ -242,6 +244,43 @@ const ServiceGeneralEditor = observer(() => {
     }
   };
 
+  // AI documentation suggestion
+  const legendAIUrl = editorStore.applicationStore.config.legendAIUrl;
+  const aiDocSuggester = legendAIUrl
+    ? editorStore.pluginManager
+        .getApplicationPlugins()
+        .map((p) =>
+          (
+            p as DSL_Service_LegendStudioApplicationPlugin_Extension
+          ).getExtraServiceDocumentationAISuggester?.(),
+        )
+        .find(Boolean)
+    : undefined;
+  const [isSuggestingWithAI, setIsSuggestingWithAI] = useState(false);
+  const [aiDocSuggestion, setAIDocSuggestion] = useState<string | undefined>(
+    undefined,
+  );
+  const suggestDocumentationWithAI = async (): Promise<void> => {
+    if (!aiDocSuggester || !legendAIUrl) {
+      return;
+    }
+    setIsSuggestingWithAI(true);
+    setAIDocSuggestion(undefined);
+    try {
+      const suggestion = await aiDocSuggester(service, legendAIUrl);
+      setAIDocSuggestion(suggestion);
+    } finally {
+      setIsSuggestingWithAI(false);
+    }
+  };
+  const applyAIDocSuggestion = (): void => {
+    if (!aiDocSuggestion) {
+      return;
+    }
+    service_setDocumentation(service, aiDocSuggestion);
+    setAIDocSuggestion(undefined);
+  };
+
   const changeTitle: React.ChangeEventHandler<HTMLInputElement> = (event) => {
     if (!isReadOnly) {
       service_setTitle(service, event.target.value);
@@ -392,29 +431,76 @@ const ServiceGeneralEditor = observer(() => {
         <div className="panel__content__form__section">
           <div className="panel__content__form__section__header__label">
             Documentation
+            {aiDocSuggestion && (
+              <span className="service-editor__ai-suggestion-badge">
+                <SparkleIcon />
+                AI Suggestion
+              </span>
+            )}
+            {aiDocSuggester && !aiDocSuggestion && (
+              <button
+                className="service-editor__ai-suggest-btn"
+                onClick={(): void => {
+                  suggestDocumentationWithAI().catch(
+                    editorStore.applicationStore.alertUnhandledError,
+                  );
+                }}
+                disabled={isSuggestingWithAI || isReadOnly}
+                title="Use AI to suggest documentation for this service"
+              >
+                <SparkleIcon />
+                <span>
+                  {isSuggestingWithAI ? 'Suggesting...' : 'Suggest with AI'}
+                </span>
+              </button>
+            )}
           </div>
           <div
             className={clsx('panel__content__form__section__header__prompt', {
-              'service-editor__general__warning-prompt': !service.documentation,
+              'service-editor__general__warning-prompt':
+                !service.documentation && !aiDocSuggestion,
             })}
           >
-            {!service.documentation && (
+            {!service.documentation && !aiDocSuggestion && (
               <ErrorWarnIcon style={{ fontSize: '1.2rem' }} />
             )}
             {`Provide a brief description of the service's functionalities and usage`}
           </div>
           <textarea
-            className="panel__content__form__section__textarea service-editor__documentation__input"
+            className={clsx(
+              'panel__content__form__section__textarea service-editor__documentation__input',
+              { 'textarea--ai-suggested': Boolean(aiDocSuggestion) },
+            )}
             spellCheck={false}
             disabled={isReadOnly}
-            value={service.documentation}
+            readOnly={Boolean(aiDocSuggestion)}
+            value={aiDocSuggestion ?? service.documentation}
             onChange={changeDocumentation}
             style={{
-              borderColor: !service.documentation
-                ? 'var(--color-red-300)'
-                : undefined,
+              borderColor:
+                !service.documentation && !aiDocSuggestion
+                  ? 'var(--color-red-300)'
+                  : undefined,
             }}
           />
+          {aiDocSuggestion && (
+            <div className="service-editor__ai-suggestion__actions">
+              <button
+                className="btn btn--dark service-editor__ai-suggestion__apply-btn"
+                onClick={applyAIDocSuggestion}
+                title="Apply AI suggestion to documentation"
+              >
+                Apply Suggestion
+              </button>
+              <button
+                className="btn service-editor__ai-suggestion__dismiss-btn"
+                onClick={(): void => setAIDocSuggestion(undefined)}
+                title="Dismiss AI suggestion"
+              >
+                Dismiss
+              </button>
+            </div>
+          )}
         </div>
       </PanelForm>
       <PanelForm>

package/src/stores/editor/editor-state/element-editor-state/dataProduct/testable/DataProductTestableState.ts

@@ -322,11 +322,12 @@ export class DataProductElementTestDataState {
         let columns: string[] = [];
         try {
           if (element instanceof IngestDefinition) {
-            const accessor = graphManager.createAccessorFromPackageableElement(
-              element,
-              graph,
-              { schemaName: undefined, tableName: item.id },
-            );
+            const accessor =
+              await graphManager.createAccessorFromPackageableElement(
+                element,
+                graph,
+                { schemaName: undefined, tableName: item.id },
+              );
             if (accessor) {
               columns = accessor.relationType.columns.map((c) => c.name);
             }
@@ -575,10 +576,8 @@ export class DataProductTestSuiteState extends TestableTestSuiteEditorState {
           rawLambdaForTest,
           this.editorStore.graphManagerState.graph,
         )) as Accessor[];
-      resolvedAccessors = all.filter(
-        (accessor) =>
-          isIngestOrDataProductAccessor(accessor) &&
-          accessor.parentElement.path !== this.testableState.dataProduct.path,
+      resolvedAccessors = all.filter((accessor) =>
+        isIngestOrDataProductAccessor(accessor),
       );
     }
 
@@ -833,10 +832,8 @@ export class DataProductTestableState {
           rawLambdaForSuite,
           this.editorStore.graphManagerState.graph,
         )) as Accessor[];
-      const externalAccessors = all.filter(
-        (accessor) =>
-          isIngestOrDataProductAccessor(accessor) &&
-          accessor.parentElement.path !== dp.path,
+      const externalAccessors = all.filter((accessor) =>
+        isIngestOrDataProductAccessor(accessor),
       );
       const byElement = new Map<string, Accessor[]>();
       for (const acc of externalAccessors) {

package/src/stores/extensions/DSL_Service_LegendStudioApplicationPlugin_Extension.ts

@@ -23,6 +23,7 @@ import type {
   ObserverContext,
   PostDeploymentProperties,
   HostedService,
+  Service,
 } from '@finos/legend-graph';
 
 export type ServiceTestRuntimeConnectionBuilder = (
@@ -48,6 +49,11 @@ export type PostDeploymentActionTypeGetter = (
   metamodel: PostDeploymentProperties,
 ) => string | undefined;
 
+export type ServiceDocumentationAISuggester = (
+  service: Service,
+  legendAIUrl: string,
+) => Promise<string>;
+
 export interface DSL_Service_LegendStudioApplicationPlugin_Extension
   extends DSL_LegendStudioApplicationPlugin_Extension {
   /**
@@ -70,4 +76,8 @@ export interface DSL_Service_LegendStudioApplicationPlugin_Extension
    * Get the list of the Classifiers for Post Deployment Actions.
    */
   getExtraPostDeploymentActionClassifierGetters?(): PostDeploymentActionTypeGetter[];
+  /**
+   * Get a suggester function that generates AI-suggested documentation for a service.
+   */
+  getExtraServiceDocumentationAISuggester?(): ServiceDocumentationAISuggester;
 }