@finos/legend-application-studio 28.21.5 → 28.21.7

package/src/__lib__/LegendStudioUserDataHelper.ts

@@ -1,5 +1,12 @@
 import type { UserDataService } from '@finos/legend-application';
-import { returnUndefOnError } from '@finos/legend-shared';
+import {
+  type PlainObject,
+  SerializationFactory,
+  returnUndefOnError,
+  usingModelSchema,
+} from '@finos/legend-shared';
+import { WorkspaceType } from '@finos/legend-server-sdlc';
+import { createModelSchema, list, optional, primitive } from 'serializr';
 
 /**
  * Copyright (c) 2020-present, Goldman Sachs
@@ -29,6 +36,139 @@ export enum LEGEND_STUDIO_USER_DATA_KEY {
   // drop the toggle button in the tab header, and retarget the SCSS
   // `.database-editor--light` block at the framework's color-theme tokens.
   DATABASE_EDITOR_THEME = 'studio-editor.database-editor.theme',
+  // Recently-opened projects and (non-patch) workspaces shown on the
+  // workspace setup screen to speed up re-opening common work.
+  WORKSPACE_SETUP_RECENTS = 'studio-editor.workspace-setup.recents',
+  // Per-user cache of the sandbox-access boolean + the sandbox project id,
+  // so the workspace setup screen can render the sandbox UI without waiting
+  // on the `userHasPrototypeProjectAccess` graph manager call AND a
+  // sandbox-tag project search on every mount. Revalidated against SDLC in
+  // the background; invalidated automatically on 404 or after the TTL.
+  WORKSPACE_SETUP_SANDBOX_INFO = 'studio-editor.workspace-setup.sandboxInfo',
+}
+
+// --- Workspace setup recents -------------------------------------------------
+
+const WORKSPACE_SETUP_RECENTS_VERSION = 1;
+const MAX_RECENT_PROJECTS = 10;
+const MAX_RECENT_WORKSPACES = 20;
+
+export class RecentProjectEntry {
+  projectId!: string;
+  name!: string;
+  description!: string;
+  webUrl!: string;
+  tags!: string[];
+  lastOpenedAt!: number;
+
+  static readonly serialization = new SerializationFactory(
+    createModelSchema(RecentProjectEntry, {
+      description: primitive(),
+      lastOpenedAt: primitive(),
+      name: primitive(),
+      projectId: primitive(),
+      tags: list(primitive()),
+      webUrl: primitive(),
+    }),
+  );
+}
+
+export class RecentWorkspaceEntry {
+  projectId!: string;
+  workspaceId!: string;
+  workspaceType!: WorkspaceType;
+  lastOpenedAt!: number;
+
+  static readonly serialization = new SerializationFactory(
+    createModelSchema(RecentWorkspaceEntry, {
+      lastOpenedAt: primitive(),
+      projectId: primitive(),
+      workspaceId: primitive(),
+      // WorkspaceType is a string enum; stored/loaded as a plain string and
+      // validated when the entry is consumed.
+      workspaceType: primitive(),
+    }),
+  );
+}
+
+export class WorkspaceSetupRecents {
+  version: number = WORKSPACE_SETUP_RECENTS_VERSION;
+  projects: RecentProjectEntry[] = [];
+  workspaces: RecentWorkspaceEntry[] = [];
+
+  static readonly serialization = new SerializationFactory(
+    createModelSchema(WorkspaceSetupRecents, {
+      projects: list(usingModelSchema(RecentProjectEntry.serialization.schema)),
+      version: primitive(),
+      workspaces: list(
+        usingModelSchema(RecentWorkspaceEntry.serialization.schema),
+      ),
+    }),
+  );
+}
+
+const isValidWorkspaceType = (v: unknown): v is WorkspaceType =>
+  v === WorkspaceType.USER || v === WorkspaceType.GROUP;
+
+const emptyRecents = (): WorkspaceSetupRecents => new WorkspaceSetupRecents();
+
+const readRecents = (service: UserDataService): WorkspaceSetupRecents => {
+  const raw = returnUndefOnError(() =>
+    service.getObjectValue(LEGEND_STUDIO_USER_DATA_KEY.WORKSPACE_SETUP_RECENTS),
+  );
+  if (!raw) {
+    return emptyRecents();
+  }
+  const parsed = returnUndefOnError(() =>
+    WorkspaceSetupRecents.serialization.fromJson(
+      raw as PlainObject<WorkspaceSetupRecents>,
+    ),
+  );
+  if (!parsed) {
+    return emptyRecents();
+  }
+  // Defensive post-checks: drop entries with invalid enum values and enforce
+  // the LRU caps in case the persisted blob was tampered with.
+  parsed.workspaces = parsed.workspaces
+    .filter((w) => isValidWorkspaceType(w.workspaceType))
+    .slice(0, MAX_RECENT_WORKSPACES);
+  parsed.projects = parsed.projects.slice(0, MAX_RECENT_PROJECTS);
+  return parsed;
+};
+
+const writeRecents = (
+  service: UserDataService,
+  recents: WorkspaceSetupRecents,
+): void => {
+  service.persistValue(
+    LEGEND_STUDIO_USER_DATA_KEY.WORKSPACE_SETUP_RECENTS,
+    WorkspaceSetupRecents.serialization.toJson(recents),
+  );
+};
+
+// --- Cached sandbox info -----------------------------------------------------
+
+// Sandbox access and the sandbox project id rarely change for a given user,
+// but they're costly to look up on every setup mount (one graph manager call
+// + one tagged-project search). Cache the result for a day and revalidate
+// in the background on the fast path.
+const SANDBOX_INFO_TTL_MS = 24 * 60 * 60 * 1000;
+
+export class CachedSandboxInfo {
+  userId!: string;
+  hasAccess!: boolean;
+  /** undefined when the user has access but hasn't created a sandbox yet. */
+  projectId?: string | undefined;
+  fetchedAt!: number;
+
+  static readonly serialization = new SerializationFactory(
+    createModelSchema(CachedSandboxInfo, {
+      fetchedAt: primitive(),
+      hasAccess: primitive(),
+      projectId: optional(primitive()),
+      userId: primitive(),
+    }),
+  );
 }
 
 export class LegendStudioUserDataHelper {
@@ -70,4 +210,172 @@ export class LegendStudioUserDataHelper {
       val,
     );
   }
+
+  // --- Workspace setup recents ---------------------------------------------
+
+  static workspaceSetup_getRecentProjects(
+    service: UserDataService,
+  ): RecentProjectEntry[] {
+    return readRecents(service).projects;
+  }
+
+  static workspaceSetup_getRecentWorkspaces(
+    service: UserDataService,
+  ): RecentWorkspaceEntry[] {
+    return readRecents(service).workspaces;
+  }
+
+  static workspaceSetup_recordRecentProject(
+    service: UserDataService,
+    entry: {
+      projectId: string;
+      name: string;
+      description: string;
+      webUrl: string;
+      tags: string[];
+    },
+  ): RecentProjectEntry[] {
+    const recents = readRecents(service);
+    const next = new RecentProjectEntry();
+    next.projectId = entry.projectId;
+    next.name = entry.name;
+    next.description = entry.description;
+    next.webUrl = entry.webUrl;
+    next.tags = entry.tags;
+    next.lastOpenedAt = Date.now();
+    recents.projects = [
+      next,
+      ...recents.projects.filter((p) => p.projectId !== entry.projectId),
+    ].slice(0, MAX_RECENT_PROJECTS);
+    writeRecents(service, recents);
+    return recents.projects;
+  }
+
+  static workspaceSetup_recordRecentWorkspace(
+    service: UserDataService,
+    entry: {
+      projectId: string;
+      workspaceId: string;
+      workspaceType: WorkspaceType;
+    },
+  ): RecentWorkspaceEntry[] {
+    const recents = readRecents(service);
+    const next = new RecentWorkspaceEntry();
+    next.projectId = entry.projectId;
+    next.workspaceId = entry.workspaceId;
+    next.workspaceType = entry.workspaceType;
+    next.lastOpenedAt = Date.now();
+    recents.workspaces = [
+      next,
+      ...recents.workspaces.filter(
+        (w) =>
+          !(
+            w.projectId === entry.projectId &&
+            w.workspaceId === entry.workspaceId &&
+            w.workspaceType === entry.workspaceType
+          ),
+      ),
+    ].slice(0, MAX_RECENT_WORKSPACES);
+    writeRecents(service, recents);
+    return recents.workspaces;
+  }
+
+  static workspaceSetup_removeRecentProject(
+    service: UserDataService,
+    projectId: string,
+  ): WorkspaceSetupRecents {
+    const recents = readRecents(service);
+    recents.projects = recents.projects.filter(
+      (p) => p.projectId !== projectId,
+    );
+    recents.workspaces = recents.workspaces.filter(
+      (w) => w.projectId !== projectId,
+    );
+    writeRecents(service, recents);
+    return recents;
+  }
+
+  static workspaceSetup_removeRecentWorkspace(
+    service: UserDataService,
+    entry: {
+      projectId: string;
+      workspaceId: string;
+      workspaceType: WorkspaceType;
+    },
+  ): RecentWorkspaceEntry[] {
+    const recents = readRecents(service);
+    recents.workspaces = recents.workspaces.filter(
+      (w) =>
+        !(
+          w.projectId === entry.projectId &&
+          w.workspaceId === entry.workspaceId &&
+          w.workspaceType === entry.workspaceType
+        ),
+    );
+    writeRecents(service, recents);
+    return recents.workspaces;
+  }
+
+  static workspaceSetup_clearRecents(service: UserDataService): void {
+    writeRecents(service, emptyRecents());
+  }
+
+  // --- Cached sandbox info -------------------------------------------------
+
+  static workspaceSetup_getCachedSandboxInfo(
+    service: UserDataService,
+    currentUserId: string,
+  ): CachedSandboxInfo | undefined {
+    const raw = returnUndefOnError(() =>
+      service.getObjectValue(
+        LEGEND_STUDIO_USER_DATA_KEY.WORKSPACE_SETUP_SANDBOX_INFO,
+      ),
+    );
+    if (!raw) {
+      return undefined;
+    }
+    const parsed = returnUndefOnError(() =>
+      CachedSandboxInfo.serialization.fromJson(
+        raw as PlainObject<CachedSandboxInfo>,
+      ),
+    );
+    if (!parsed) {
+      return undefined;
+    }
+    // Discard entries that don't belong to the user looking at the screen
+    // (e.g., after a user switch on a shared machine) or that have aged out.
+    if (parsed.userId !== currentUserId) {
+      return undefined;
+    }
+    if (Date.now() - parsed.fetchedAt > SANDBOX_INFO_TTL_MS) {
+      return undefined;
+    }
+    return parsed;
+  }
+
+  static workspaceSetup_recordSandboxInfo(
+    service: UserDataService,
+    info: {
+      userId: string;
+      hasAccess: boolean;
+      projectId?: string | undefined;
+    },
+  ): void {
+    const entry = new CachedSandboxInfo();
+    entry.userId = info.userId;
+    entry.hasAccess = info.hasAccess;
+    entry.projectId = info.projectId;
+    entry.fetchedAt = Date.now();
+    service.persistValue(
+      LEGEND_STUDIO_USER_DATA_KEY.WORKSPACE_SETUP_SANDBOX_INFO,
+      CachedSandboxInfo.serialization.toJson(entry),
+    );
+  }
+
+  static workspaceSetup_clearSandboxInfo(service: UserDataService): void {
+    service.persistValue(
+      LEGEND_STUDIO_USER_DATA_KEY.WORKSPACE_SETUP_SANDBOX_INFO,
+      undefined,
+    );
+  }
 }

package/src/components/editor/editor-group/data-editor/EmbeddedDataEditor.tsx

@@ -400,6 +400,7 @@ export function renderEmbeddedDataEditor(
         dataState={embeddedDataState}
         isReadOnly={isReadOnly}
         isSharedData={isSharedData}
+        hideColumnDefinitions={true}
       />
     );
   } else if (embeddedDataState instanceof DataElementReferenceState) {

package/src/components/editor/editor-group/data-editor/RelationElementsDataEditor.tsx

@@ -426,7 +426,8 @@ export const RelationElementEditor = observer(
               </div>
             </div>
           ) : null}
-          {embeddedData.rows.length === 0 ? (
+          {embeddedData.rows.length === 0 &&
+          embeddedData.columns.length === 0 ? (
             <div className="relation-test-data-editor__empty-data">
               <div className="relation-test-data-editor__empty-text">
                 No test data rows. Click &quot;+&quot; below to start entering
@@ -440,13 +441,20 @@ export const RelationElementEditor = observer(
                   <tr>
                     {embeddedData.columns.map((column, columnIndex) => (
                       <th
-                        key={column}
+                        key={`col-${guaranteeNonNullable(columnIndex)}`}
                         className="relation-test-data-editor__th"
                       >
                         <div className="relation-test-data-editor__th__inner">
-                          <span className="relation-test-data-editor__th__label">
-                            {column}
-                          </span>
+                          <input
+                            className="relation-test-data-editor__th__label relation-test-data-editor__th__label--editable"
+                            type="text"
+                            value={column}
+                            onChange={(e) =>
+                              updateColumn(columnIndex, e.target.value)
+                            }
+                            disabled={!canEditColumns}
+                            title={column}
+                          />
                           <button
                             className="relation-test-data-editor__th__delete"
                             onClick={() => removeColumn(columnIndex)}

package/src/components/editor/editor-group/dataProduct/DataProductEditor.tsx

@@ -661,6 +661,7 @@ const SampleValuesEditorModal = observer(
                             accessPointState.relationElementState
                           }
                           isReadOnly={isReadOnly}
+                          hideColumnDefinitions={true}
                         />
                       </div>
                     </Tooltip>

package/src/components/editor/editor-group/testable/TestableSharedComponents.tsx

@@ -595,6 +595,7 @@ const EqualToRelationAsssertionEditor = observer(
           equalToRelationAssertionState.expectedRelationElementState
         }
         isReadOnly={isReadOnly}
+        hideColumnDefinitions={true}
       />
     );
   },

package/src/components/workspace-setup/RecentWorkspacesPanel.tsx

@@ -0,0 +1,181 @@
+/**
+ * Copyright (c) 2020-present, Goldman Sachs
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { observer } from 'mobx-react-lite';
+import {
+  FolderIcon,
+  HistoryIcon,
+  TimesIcon,
+  UserIcon,
+  UsersIcon,
+} from '@finos/legend-art';
+import { WorkspaceType } from '@finos/legend-server-sdlc';
+import type { WorkspaceSetupStore } from '../../stores/workspace-setup/WorkspaceSetupStore.js';
+import { generateEditorRoute } from '../../__lib__/LegendStudioNavigation.js';
+
+const MAX_TILES = 6;
+
+const formatRelativeTime = (timestamp: number): string => {
+  const diffMs = Date.now() - timestamp;
+  if (diffMs < 0) {
+    return 'just now';
+  }
+  const minutes = Math.floor(diffMs / 60_000);
+  if (minutes < 1) {
+    return 'just now';
+  }
+  if (minutes < 60) {
+    return `${minutes}m ago`;
+  }
+  const hours = Math.floor(minutes / 60);
+  if (hours < 24) {
+    return `${hours}h ago`;
+  }
+  const days = Math.floor(hours / 24);
+  if (days < 7) {
+    return `${days}d ago`;
+  }
+  const weeks = Math.floor(days / 7);
+  if (weeks < 4) {
+    return `${weeks}w ago`;
+  }
+  const months = Math.floor(days / 30);
+  if (months < 12) {
+    return `${months}mo ago`;
+  }
+  return `${Math.floor(days / 365)}y ago`;
+};
+
+export const RecentWorkspacesPanel = observer(
+  (props: { setupStore: WorkspaceSetupStore }) => {
+    const { setupStore } = props;
+    const applicationStore = setupStore.applicationStore;
+
+    // Recents are stored in LRU order (most-recent first). Show the top N
+    // workspaces; look up each one's cached project entry for richer tile
+    // metadata (name, description tooltip, tag badges).
+    const tiles = setupStore.recentWorkspaces.slice(0, MAX_TILES);
+    if (tiles.length === 0) {
+      return null;
+    }
+
+    const projectById = new Map(
+      setupStore.recentProjects.map((p) => [p.projectId, p]),
+    );
+
+    const openWorkspace = (
+      projectId: string,
+      workspaceId: string,
+      workspaceType: WorkspaceType,
+    ): void => {
+      applicationStore.navigationService.navigator.goToLocation(
+        generateEditorRoute(projectId, undefined, workspaceId, workspaceType),
+      );
+    };
+
+    return (
+      <div className="workspace-setup__recents">
+        <div className="workspace-setup__recents__header">
+          <div className="workspace-setup__recents__header__title">
+            <HistoryIcon />
+            <span>Recent workspaces</span>
+          </div>
+        </div>
+        <div className="workspace-setup__recents__grid">
+          {tiles.map((entry) => {
+            const cachedProject = projectById.get(entry.projectId);
+            const projectName = cachedProject?.name ?? entry.projectId;
+            const projectDescription = cachedProject?.description ?? '';
+            const projectTags = cachedProject?.tags ?? [];
+            const tileTitle =
+              projectDescription.trim().length > 0
+                ? `${projectName} / ${entry.workspaceId}\n${projectDescription}`
+                : `Open ${projectName} / ${entry.workspaceId}`;
+            const key = `${entry.projectId}::${entry.workspaceType}::${entry.workspaceId}`;
+            const handleRemove = (
+              event: React.MouseEvent<HTMLButtonElement>,
+            ): void => {
+              event.stopPropagation();
+              setupStore.removeRecentWorkspace({
+                projectId: entry.projectId,
+                workspaceId: entry.workspaceId,
+                workspaceType: entry.workspaceType,
+              });
+            };
+            return (
+              <button
+                key={key}
+                type="button"
+                className="workspace-setup__recents__tile"
+                title={tileTitle}
+                onClick={() =>
+                  openWorkspace(
+                    entry.projectId,
+                    entry.workspaceId,
+                    entry.workspaceType,
+                  )
+                }
+              >
+                <button
+                  type="button"
+                  tabIndex={-1}
+                  className="workspace-setup__recents__tile__remove"
+                  title="Remove from recents"
+                  onClick={handleRemove}
+                >
+                  <TimesIcon />
+                </button>
+                <div className="workspace-setup__recents__tile__project">
+                  <FolderIcon />
+                  <span className="workspace-setup__recents__tile__project__name">
+                    {projectName}
+                  </span>
+                </div>
+                <div className="workspace-setup__recents__tile__workspace">
+                  {entry.workspaceType === WorkspaceType.GROUP ? (
+                    <UsersIcon />
+                  ) : (
+                    <UserIcon />
+                  )}
+                  <span className="workspace-setup__recents__tile__workspace__name">
+                    {entry.workspaceId}
+                  </span>
+                </div>
+                <div className="workspace-setup__recents__tile__meta">
+                  {projectTags.length > 0 && (
+                    <div className="workspace-setup__recents__tile__tags">
+                      {projectTags.slice(0, 2).map((tag) => (
+                        <span
+                          key={tag}
+                          className="workspace-setup__recents__tile__tag"
+                        >
+                          {tag}
+                        </span>
+                      ))}
+                    </div>
+                  )}
+                  <div className="workspace-setup__recents__tile__time">
+                    {formatRelativeTime(entry.lastOpenedAt)}
+                  </div>
+                </div>
+              </button>
+            );
+          })}
+        </div>
+      </div>
+    );
+  },
+);