@finos/legend-application-studio 28.21.46 → 28.21.48

package/src/stores/editor/editor-state/element-editor-state/service/testable/ServiceTestDataState.ts

@@ -117,19 +117,12 @@ export const createMockPrimitiveValueSpecificationFromRelationalDataType = (
   relationalDataType: RelationalDataType,
   graph: PureModel,
   observerContext: ObserverContext,
-): ValueSpecification | undefined => {
-  const primitiveTypeFromRelational =
-    getPrimitiveTypeFromRelationalType(relationalDataType);
-
-  if (primitiveTypeFromRelational) {
-    return createMockPrimitiveValueSpecification(
-      primitiveTypeFromRelational,
-      graph,
-      observerContext,
-    );
-  }
-  return undefined;
-};
+): ValueSpecification =>
+  createMockPrimitiveValueSpecification(
+    getPrimitiveTypeFromRelationalType(relationalDataType),
+    graph,
+    observerContext,
+  );
 
 export class ServiceTestDataParametersState extends LambdaParametersState {
   connectionTestDataState: ConnectionTestDataState;
@@ -280,14 +273,12 @@ export class TableRowIdentifierState {
         this.connectionTestDataState.editorStore.changeDetectionState
           .observerContext,
       );
-    if (valueSpec) {
-      const rowIdentifierState = new RowIdentifierState(
-        this.connectionTestDataState,
-        column,
-        valueSpec,
-      );
-      this.rowIdentifierStates.push(rowIdentifierState);
-    }
+    const rowIdentifierState = new RowIdentifierState(
+      this.connectionTestDataState,
+      column,
+      valueSpec,
+    );
+    this.rowIdentifierStates.push(rowIdentifierState);
   }
 
   removeRowIdentifierState(rowIdentifierState: RowIdentifierState): void {

package/src/stores/editor/sidebar-state/BulkServiceRegistrationState.ts

@@ -233,24 +233,67 @@ export class GlobalBulkServiceRegistrationState {
       const successfulResults = registrationResults.filter(
         (result) => result instanceof ServiceRegistrationSuccess,
       );
+      const failedResults = registrationResults.filter(
+        (result) => result instanceof ServiceRegistrationFail,
+      );
 
+      let activationFailedCount: number | undefined;
       if (this.activatePostRegistration) {
-        yield Promise.resolve(
+        // Wait for every activation to settle so a single rejected activation
+        // neither hides the registration results nor goes unhandled.
+        const activationResults = (yield Promise.allSettled(
           successfulResults.map((serviceResult) =>
             this.editorStore.graphManagerState.graphManager.activateService(
               config.executionUrl,
               serviceResult.serviceInstanceId,
             ),
           ),
+        )) as PromiseSettledResult<void>[];
+        const activationFailures = activationResults.filter(
+          (result): result is PromiseRejectedResult =>
+            result.status === 'rejected',
+        );
+        activationFailedCount = activationFailures.length;
+        activationFailures.forEach((result) =>
+          this.editorStore.applicationStore.logService.error(
+            LogEvent.create(
+              LEGEND_STUDIO_APP_EVENT.SERVICE_REGISTRATION_FAILURE,
+            ),
+            result.reason,
+          ),
         );
       }
       this.handleResults(registrationResults);
       this.isServiceRegistering.complete();
-      LegendStudioTelemetryHelper.logEvent_ServiceRegistrationSucceeded(
-        this.editorStore.applicationStore.telemetryService,
-        this.editorStore.editorMode.getSourceInfo(),
-        { ...telemetryBase, durationMs: Date.now() - startedAt },
-      );
+      const outcomeCounts = {
+        registeredCount: successfulResults.length,
+        failedCount: failedResults.length,
+        activationFailedCount,
+      };
+      // A bulk run where nothing got registered is a failed run; partial
+      // success is reported on the success payload via the outcome counts.
+      const firstFailure = failedResults[0];
+      if (successfulResults.length === 0 && firstFailure) {
+        LegendStudioTelemetryHelper.logEvent_ServiceRegistrationFailure(
+          this.editorStore.applicationStore.telemetryService,
+          this.editorStore.editorMode.getSourceInfo(),
+          {
+            ...telemetryBase,
+            ...outcomeCounts,
+            errorMessage: firstFailure.errorMessage,
+          },
+        );
+      } else {
+        LegendStudioTelemetryHelper.logEvent_ServiceRegistrationSucceeded(
+          this.editorStore.applicationStore.telemetryService,
+          this.editorStore.editorMode.getSourceInfo(),
+          {
+            ...telemetryBase,
+            ...outcomeCounts,
+            durationMs: Date.now() - startedAt,
+          },
+        );
+      }
     } catch (error) {
       assertErrorThrown(error);
       this.editorStore.applicationStore.logService.error(

package/src/stores/editor/sidebar-state/LocalChangesState.ts

@@ -461,6 +461,10 @@ export abstract class LocalChangesState {
           revisionId: latestRevision.id,
         },
       );
+      this.editorStore.legendAIAppliedSuggestionRegistry.reportPushedChanges(
+        this.editorStore,
+        localChanges,
+      );
 
       // ======= (RE)START CHANGE DETECTION =======
 

package/src/stores/editor/sidebar-state/WorkflowManagerState.ts

@@ -414,13 +414,7 @@ export class WorkflowState {
         WORKFLOW_MANAGER_JOB_ACTION.CANCEL,
         workflowJob,
         treeData,
-        // NOTE: unlike retry/runManual, the current implementation does not
-        // `yield` the underlying cancel call — see `cancelJob` below. The
-        // launch event will still fire, and success will fire after the
-        // refresh completes.
-        () => {
-          this.workflowManagerState.cancelJob(workflowJob);
-        },
+        () => flowResult(this.workflowManagerState.cancelJob(workflowJob)),
       ),
     );
   }
@@ -479,7 +473,7 @@ export class WorkflowState {
     jobAction: WORKFLOW_MANAGER_JOB_ACTION,
     workflowJob: WorkflowJob,
     treeData: TreeData<WorkflowExplorerTreeNodeData>,
-    invoke: () => Promise<void> | void,
+    invoke: () => Promise<void>,
   ): GeneratorFn<void> {
     const telemetryService = this.editorStore.applicationStore.telemetryService;
     const sourceInfo = this.editorStore.editorMode.getSourceInfo();
@@ -497,10 +491,7 @@ export class WorkflowState {
     const started = Date.now();
     try {
       this.isExecutingWorkflowRequest = true;
-      const result = invoke();
-      if (result) {
-        yield result;
-      }
+      yield invoke();
       yield flowResult(this.refreshWorkflow(workflowJob.workflowId, treeData));
       LegendStudioTelemetryHelper.logEvent_WorkflowManagerJobActionSucceeded(
         telemetryService,

package/src/stores/editor/utils/MockDataUtils.ts

@@ -21,7 +21,6 @@ import {
   Randomizer,
   UnsupportedOperationError,
   type PlainObject,
-  isNonNullable,
   filterByType,
 } from '@finos/legend-shared';
 import type { EditorStore } from '../EditorStore.js';
@@ -37,16 +36,12 @@ import {
   TableAlias,
   Table,
   Column,
-  VarChar,
   type RelationalDataType,
-  Char,
-  VarBinary,
+  BigInt,
   TinyInt,
   Float,
   Timestamp,
-  Binary,
   Bit,
-  Other,
   Numeric,
   Decimal,
   Double,
@@ -220,49 +215,56 @@ export const createMockDataForClassWithFormat = (
   }
 };
 
+/**
+ * Maps a relational column type to the standard primitive type used to read
+ * the column with a TDS getter (e.g. `$row.getFloat('COL')`) and to mock its
+ * values.
+ *
+ * NOTE: this matches how the engine types `tableToTDS()` columns, except that
+ * `DECIMAL` and `NUMERIC` map to `Decimal` (the engine uses `Float`), so mock
+ * values keep exact-numeric semantics. Binary, JSON, semi-structured and other
+ * types have no TDS getter or literal of their own and map to `String`.
+ */
 export const getPrimitiveTypeFromRelationalType = (
   type: RelationalDataType,
-): PrimitiveType | undefined => {
-  if (
-    type instanceof VarChar ||
-    type instanceof Char ||
-    type instanceof VarBinary ||
-    type instanceof Binary ||
-    type instanceof Bit ||
-    type instanceof Other
-  ) {
-    return PrimitiveType.STRING;
-  } else if (type instanceof Numeric) {
-    return PrimitiveType.NUMBER;
-  } else if (type instanceof Decimal) {
-    return PrimitiveType.DECIMAL;
+): PrimitiveType => {
+  if (type instanceof Bit) {
+    return PrimitiveType.BOOLEAN;
   } else if (
-    type instanceof Double ||
     type instanceof Integer ||
-    type instanceof Real ||
+    type instanceof BigInt ||
     type instanceof SmallInt ||
     type instanceof TinyInt
   ) {
     return PrimitiveType.INTEGER;
-  } else if (type instanceof Float) {
+  } else if (
+    type instanceof Float ||
+    type instanceof Double ||
+    type instanceof Real
+  ) {
     return PrimitiveType.FLOAT;
+  } else if (type instanceof Decimal || type instanceof Numeric) {
+    return PrimitiveType.DECIMAL;
   } else if (type instanceof ColumnDate) {
-    return PrimitiveType.DATE;
+    return PrimitiveType.STRICTDATE;
   } else if (type instanceof Timestamp) {
     return PrimitiveType.DATETIME;
   }
-  return undefined;
+  // VARCHAR, CHAR, BINARY, VARBINARY, JSON, SEMISTRUCTURED, OTHER
+  return PrimitiveType.STRING;
 };
+
 export const createMockDataForColumn = (
   col: Column,
   isPrimaryKey: boolean,
   idx?: number | undefined,
-): string | undefined => {
+): string => {
   const type = col.type;
 
   if (
     (type instanceof Double ||
       type instanceof Integer ||
+      type instanceof BigInt ||
       type instanceof Real ||
       type instanceof SmallInt ||
       type instanceof TinyInt) &&
@@ -271,13 +273,13 @@ export const createMockDataForColumn = (
   ) {
     return idx.toString();
   }
-  const primitive = getPrimitiveTypeFromRelationalType(type);
-  if (primitive) {
-    return createMockPrimitiveProperty(primitive, col.name).toString();
-  } else if (type instanceof Json || type instanceof SemiStructured) {
+  if (type instanceof Json || type instanceof SemiStructured) {
     return '{}';
   }
-  return undefined;
+  return createMockPrimitiveProperty(
+    getPrimitiveTypeFromRelationalType(type),
+    col.name,
+  ).toString();
 };
 
 export const createMockDataForTable = (
@@ -292,7 +294,6 @@ export const createMockDataForTable = (
         .map((col) =>
           createMockDataForColumn(col, table.primaryKey.includes(col), idx),
         )
-        .filter(isNonNullable)
         .join(','),
     )
     .join('\n');

package/src/stores/graph-modifier/DSL_DataProduct_GraphModifierHelper.ts

@@ -104,6 +104,24 @@ export const accessPointGroup_setTitle = action(
   },
 );
 
+export const accessPointGroup_addTarget = action(
+  (group: AccessPointGroup, target: string) => {
+    if (!group.targets) {
+      group.targets = [target];
+    } else {
+      addUniqueEntry(group.targets, target);
+    }
+  },
+);
+
+export const accessPointGroup_deleteTarget = action(
+  (group: AccessPointGroup, target: string) => {
+    if (group.targets) {
+      deleteEntry(group.targets, target);
+    }
+  },
+);
+
 export const modelAccessPointGroup_setMapping = action(
   (
     group: ModelAccessPointGroup,

package/src/stores/graph-modifier/DSL_LakehouseRuntime_GraphModifierHelper.ts

@@ -17,10 +17,14 @@
 import {
   ConnectionPointer,
   type PackageableConnection,
+  type PackageableRuntime,
+  type ObserverContext,
   PackageableElementExplicitReference,
-  type LakehouseRuntime,
+  LakehouseRuntime,
+  LakehouseSingleStoreRuntime,
 } from '@finos/legend-graph';
 import { action } from 'mobx';
+import { packageableRuntime_setRuntimeValue } from './DSL_Mapping_GraphModifierHelper.js';
 
 export const lakehouseRuntime_setWarehouse = action(
   (runtime: LakehouseRuntime, warehouse: string | undefined) => {
@@ -28,12 +32,6 @@ export const lakehouseRuntime_setWarehouse = action(
   },
 );
 
-export const lakehouseRuntime_setEnvironment = action(
-  (runtime: LakehouseRuntime, environment: string | undefined) => {
-    runtime.environment = environment;
-  },
-);
-
 export const lakehouseRuntime_setConnection = action(
   (
     runtime: LakehouseRuntime,
@@ -47,3 +45,60 @@ export const lakehouseRuntime_setConnection = action(
         : undefined;
   },
 );
+
+export enum LakehouseComputeEngine {
+  SNOWFLAKE = 'SNOWFLAKE',
+  SINGLE_STORE = 'SINGLE_STORE',
+}
+
+/**
+ * Vendor product names, so they are spelled the way the vendor spells them --
+ * `prettyCONSTName` cannot produce "SingleStore" from any all-caps constant.
+ */
+export const LAKEHOUSE_COMPUTE_ENGINE_LABEL: Record<
+  LakehouseComputeEngine,
+  string
+> = {
+  [LakehouseComputeEngine.SNOWFLAKE]: 'Snowflake',
+  [LakehouseComputeEngine.SINGLE_STORE]: 'SingleStore',
+};
+
+export const getLakehouseComputeEngine = (
+  runtimeValue: LakehouseRuntime | LakehouseSingleStoreRuntime,
+): LakehouseComputeEngine =>
+  runtimeValue instanceof LakehouseRuntime
+    ? LakehouseComputeEngine.SNOWFLAKE
+    : LakehouseComputeEngine.SINGLE_STORE;
+
+/**
+ * Swaps the concrete Lakehouse runtime class backing `packageableRuntime`
+ * between `LakehouseRuntime` (Snowflake) and `LakehouseSingleStoreRuntime`.
+ * These are distinct classes with distinct wire `_type`s, not a flag on one
+ * class, so switching compute engine means constructing a new instance --
+ * `environment` carries over, `warehouse`/`connectionPointer` naturally fall
+ * away (or reset to undefined) since the target class may not have them.
+ */
+export const lakehouseRuntime_setComputeEngine = action(
+  (
+    packageableRuntime: PackageableRuntime,
+    computeEngine: LakehouseComputeEngine,
+    observerContext: ObserverContext,
+  ): LakehouseRuntime | LakehouseSingleStoreRuntime => {
+    const current = packageableRuntime.runtimeValue;
+    const environment =
+      current instanceof LakehouseRuntime ||
+      current instanceof LakehouseSingleStoreRuntime
+        ? current.environment
+        : undefined;
+    const next =
+      computeEngine === LakehouseComputeEngine.SNOWFLAKE
+        ? new LakehouseRuntime(environment)
+        : new LakehouseSingleStoreRuntime(environment);
+    packageableRuntime_setRuntimeValue(
+      packageableRuntime,
+      next,
+      observerContext,
+    );
+    return next;
+  },
+);

package/tsconfig.json

@@ -72,6 +72,7 @@
     "./src/application/LegendStudioApplicationConfig.ts",
     "./src/application/LegendStudioPluginManager.ts",
     "./src/components/__test-utils__/EmbeddedQueryBuilderTestUtils.ts",
+    "./src/components/editor/editor-group/LegendAISuggestTelemetryHooks.ts",
     "./src/components/editor/editor-group/dataProduct/DataProductQueryBuilderHelper.ts",
     "./src/components/editor/editor-group/database-editor/DatabaseDiagramHelper.ts",
     "./src/components/shared/StudioSDLCErrors.ts",
@@ -94,6 +95,7 @@
     "./src/stores/editor/GraphEditFormModeState.ts",
     "./src/stores/editor/GraphEditGrammarModeState.ts",
     "./src/stores/editor/GraphEditorMode.ts",
+    "./src/stores/editor/LegendAISuggestTelemetry.ts",
     "./src/stores/editor/LegendSQLStudioPlaygroundState.ts",
     "./src/stores/editor/NewElementState.ts",
     "./src/stores/editor/QuickInputState.ts",