@finos/legend-application-studio 28.21.27 → 28.21.29

package/lib/stores/extensions/DSL_DataSpace_LegendStudioApplicationPlugin_Extension.js

@@ -0,0 +1,17 @@
+/**
+ * Copyright (c) 2020-present, Goldman Sachs
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+export {};
+//# sourceMappingURL=DSL_DataSpace_LegendStudioApplicationPlugin_Extension.js.map

package/lib/stores/extensions/DSL_DataSpace_LegendStudioApplicationPlugin_Extension.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"DSL_DataSpace_LegendStudioApplicationPlugin_Extension.js","sourceRoot":"","sources":["../../../src/stores/extensions/DSL_DataSpace_LegendStudioApplicationPlugin_Extension.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;GAcG"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@finos/legend-application-studio",
-  "version": "28.21.27",
+  "version": "28.21.29",
   "description": "Legend Studio application core",
   "keywords": [
     "legend",
@@ -47,21 +47,21 @@
   },
   "dependencies": {
     "@dagrejs/dagre": "1.1.4",
-    "@finos/legend-application": "16.0.117",
-    "@finos/legend-art": "7.1.157",
-    "@finos/legend-code-editor": "2.0.191",
-    "@finos/legend-data-cube": "0.3.108",
-    "@finos/legend-extension-dsl-data-product": "0.0.101",
-    "@finos/legend-extension-dsl-diagram": "8.1.255",
-    "@finos/legend-graph": "32.6.22",
-    "@finos/legend-lego": "2.0.211",
-    "@finos/legend-query-builder": "4.18.30",
-    "@finos/legend-server-depot": "6.1.16",
-    "@finos/legend-server-lakehouse": "0.3.71",
-    "@finos/legend-server-sdlc": "5.4.6",
-    "@finos/legend-server-showcase": "0.2.67",
-    "@finos/legend-shared": "11.0.26",
-    "@finos/legend-storage": "3.0.148",
+    "@finos/legend-application": "16.0.118",
+    "@finos/legend-art": "7.1.158",
+    "@finos/legend-code-editor": "2.0.193",
+    "@finos/legend-data-cube": "0.3.110",
+    "@finos/legend-extension-dsl-data-product": "0.0.103",
+    "@finos/legend-extension-dsl-diagram": "8.1.257",
+    "@finos/legend-graph": "32.6.24",
+    "@finos/legend-lego": "2.0.213",
+    "@finos/legend-query-builder": "4.18.32",
+    "@finos/legend-server-depot": "6.1.17",
+    "@finos/legend-server-lakehouse": "0.3.73",
+    "@finos/legend-server-sdlc": "5.4.7",
+    "@finos/legend-server-showcase": "0.2.68",
+    "@finos/legend-shared": "11.0.27",
+    "@finos/legend-storage": "3.0.149",
     "@testing-library/dom": "10.4.0",
     "@testing-library/react": "16.2.0",
     "@types/react": "19.0.10",

package/src/__lib__/LegendStudioDocumentation.ts

@@ -86,6 +86,9 @@ export enum LEGEND_STUDIO_DOCUMENTATION_KEY {
   // sdlc
   QUESTION_WHAT_ARE_PROJECT_ROLES = 'question.what-are-project-roles',
 
+  // legend AI
+  LEGENDAI_HOW_TO_GET_ENTITLEMENTS = 'legend-ai.how-to-get-entitlements',
+
   // contexts
   CONTEXT_CLASS_EDITOR = 'context.class-editor',
   CONTEXT_SERVICE_TEST_EDITOR = 'context.service-editor.test',

package/src/__lib__/LegendStudioEvent.ts

@@ -90,11 +90,19 @@ export enum LEGEND_STUDIO_APP_EVENT {
   DATA_PRODUCT_LEGENDAI_SUGGEST__LAUNCH = 'editor.data-product.legendai-suggest.launch',
   DATA_PRODUCT_LEGENDAI_SUGGEST__APPLY = 'editor.data-product.legendai-suggest.apply',
   DATA_PRODUCT_LEGENDAI_SUGGEST__DISCARD = 'editor.data-product.legendai-suggest.discard',
+  DATA_PRODUCT_LEGENDAI_SUGGEST__FAILURE = 'editor.data-product.legendai-suggest.failure',
+
+  // dataspace
+  DATASPACE_LEGENDAI_SUGGEST__LAUNCH = 'editor.dataspace.legendai-suggest.launch',
+  DATASPACE_LEGENDAI_SUGGEST__APPLY = 'editor.dataspace.legendai-suggest.apply',
+  DATASPACE_LEGENDAI_SUGGEST__DISCARD = 'editor.dataspace.legendai-suggest.discard',
+  DATASPACE_LEGENDAI_SUGGEST__FAILURE = 'editor.dataspace.legendai-suggest.failure',
 
   // service
   SERVICE_LEGENDAI_SUGGEST__LAUNCH = 'editor.service-editor.legendai-suggest.launch',
   SERVICE_LEGENDAI_SUGGEST__APPLY = 'editor.service-editor.legendai-suggest.apply',
   SERVICE_LEGENDAI_SUGGEST__DISCARD = 'editor.service-editor.legendai-suggest.discard',
+  SERVICE_LEGENDAI_SUGGEST__FAILURE = 'editor.service-editor.legendai-suggest.failure',
 
   // push to dev
   METADATA_PUSH_TO_METADATA = 'editor.metadata.push-to-metadata',

package/src/__lib__/LegendStudioTelemetryHelper.ts

@@ -214,6 +214,59 @@ export class LegendStudioTelemetryHelper {
     );
   }
 
+  static logEvent_ServiceLegendAISuggestFailure(
+    telemetryService: TelemetryService,
+    servicePath: string,
+    errorMessage: string,
+  ): void {
+    telemetryService.logEvent(
+      LEGEND_STUDIO_APP_EVENT.SERVICE_LEGENDAI_SUGGEST__FAILURE,
+      { servicePath, errorMessage },
+    );
+  }
+
+  // DataSpace Legend AI
+  static logEvent_DataSpaceLegendAISuggestLaunched(
+    telemetryService: TelemetryService,
+    dataSpacePath: string,
+  ): void {
+    telemetryService.logEvent(
+      LEGEND_STUDIO_APP_EVENT.DATASPACE_LEGENDAI_SUGGEST__LAUNCH,
+      { dataSpacePath },
+    );
+  }
+
+  static logEvent_DataSpaceLegendAISuggestApplied(
+    telemetryService: TelemetryService,
+    dataSpacePath: string,
+  ): void {
+    telemetryService.logEvent(
+      LEGEND_STUDIO_APP_EVENT.DATASPACE_LEGENDAI_SUGGEST__APPLY,
+      { dataSpacePath },
+    );
+  }
+
+  static logEvent_DataSpaceLegendAISuggestDiscarded(
+    telemetryService: TelemetryService,
+    dataSpacePath: string,
+  ): void {
+    telemetryService.logEvent(
+      LEGEND_STUDIO_APP_EVENT.DATASPACE_LEGENDAI_SUGGEST__DISCARD,
+      { dataSpacePath },
+    );
+  }
+
+  static logEvent_DataSpaceLegendAISuggestFailure(
+    telemetryService: TelemetryService,
+    dataSpacePath: string,
+    errorMessage: string,
+  ): void {
+    telemetryService.logEvent(
+      LEGEND_STUDIO_APP_EVENT.DATASPACE_LEGENDAI_SUGGEST__FAILURE,
+      { dataSpacePath, errorMessage },
+    );
+  }
+
   static logEvent_DataProductLegendAISuggestLaunched(
     telemetryService: TelemetryService,
     dataProductPath: string,
@@ -244,6 +297,17 @@ export class LegendStudioTelemetryHelper {
     );
   }
 
+  static logEvent_DataProductLegendAISuggestFailure(
+    telemetryService: TelemetryService,
+    dataProductPath: string,
+    errorMessage: string,
+  ): void {
+    telemetryService.logEvent(
+      LEGEND_STUDIO_APP_EVENT.DATA_PRODUCT_LEGENDAI_SUGGEST__FAILURE,
+      { dataProductPath, errorMessage },
+    );
+  }
+
   // Lakehouse
   static logEvent_LakehouseDeployIngest(
     service: TelemetryService,

package/src/components/editor/editor-group/dataProduct/DataProductEditor.tsx

@@ -95,7 +95,9 @@ import {
   assertErrorThrown,
   guaranteeNonNullable,
   guaranteeType,
+  HttpStatus,
   isNonNullable,
+  NetworkClientError,
   UserSearchService,
 } from '@finos/legend-shared';
 import {
@@ -209,6 +211,7 @@ import type {
   DSL_DataProduct_LegendStudioApplicationPlugin_Extension,
 } from '../../../../stores/extensions/DSL_DataProduct_LegendStudioApplicationPlugin_Extension.js';
 import { LegendStudioTelemetryHelper } from '../../../../__lib__/LegendStudioTelemetryHelper.js';
+import { LEGEND_STUDIO_DOCUMENTATION_KEY } from '../../../../__lib__/LegendStudioDocumentation.js';
 
 export enum AP_GROUP_MODAL_ERRORS {
   GROUP_NAME_EMPTY = 'Group Name is empty',
@@ -1872,6 +1875,27 @@ const AccessPointGroupEditor = observer(
         runInAction(() => {
           setAISuggestion(suggestion);
         });
+      } catch (error) {
+        assertErrorThrown(error);
+        LegendStudioTelemetryHelper.logEvent_DataProductLegendAISuggestFailure(
+          editorStore.applicationStore.telemetryService,
+          productEditorState.product.path,
+          error.message,
+        );
+        if (
+          error instanceof NetworkClientError &&
+          (error.response.status === HttpStatus.UNAUTHORIZED ||
+            error.response.status === HttpStatus.FORBIDDEN)
+        ) {
+          const docEntry =
+            editorStore.applicationStore.documentationService.getDocEntry(
+              LEGEND_STUDIO_DOCUMENTATION_KEY.LEGENDAI_HOW_TO_GET_ENTITLEMENTS,
+            );
+          if (docEntry?.url) {
+            error.message = `${error.message}. Please check how to get entitlements: ${docEntry.url}`;
+          }
+        }
+        throw error;
       } finally {
         runInAction(() => {
           setIsSuggestingWithAI(false);

package/src/components/editor/editor-group/dataProduct/testable/DataProductTestableEditor.tsx

@@ -17,11 +17,13 @@
 import { observer } from 'mobx-react-lite';
 import { flowResult } from 'mobx';
 import {
+  BlankPanelContent,
   BlankPanelPlaceholder,
   clsx,
   ContextMenu,
   CustomSelectorInput,
   Dialog,
+  FilledWindowMaximizeIcon,
   MenuContent,
   MenuContentItem,
   Modal,
@@ -37,20 +39,42 @@ import {
   PanelHeaderActions,
   PanelLoadingIndicator,
   PlusIcon,
+  RefreshIcon,
+  TimesIcon,
 } from '@finos/legend-art';
-import type { DataProductTestSuite } from '@finos/legend-graph';
+import {
+  PrimitiveInstanceValue,
+  PrimitiveType,
+  type DataProductTestSuite,
+  type ValueSpecification,
+} from '@finos/legend-graph';
 import type { DataProductEditorState } from '../../../../../stores/editor/editor-state/element-editor-state/dataProduct/DataProductEditorState.js';
 import {
+  DataProductValueSpecificationTestParameterState,
+  type DataProductTestParameterState,
+  DataProductTestState,
+  getAccessPointLambda,
   type DataProductTestableState,
   type DataProductTestSuiteState,
 } from '../../../../../stores/editor/editor-state/element-editor-state/dataProduct/testable/DataProductTestableState.js';
-import { forwardRef, useRef, useState } from 'react';
-import { validateTestableId } from '../../../../../stores/editor/utils/TestableUtils.js';
+import { forwardRef, useEffect, useRef, useState } from 'react';
+import {
+  getContentTypeWithParamFromQuery,
+  type TestParamContentType,
+  validateTestableId,
+} from '../../../../../stores/editor/utils/TestableUtils.js';
 import { useEditorStore } from '../../../EditorStoreProvider.js';
 import { guaranteeNonNullable } from '@finos/legend-shared';
-import { RenameModal } from '../../testable/TestableSharedComponents.js';
+import {
+  ExternalFormatParameterEditorModal,
+  RenameModal,
+} from '../../testable/TestableSharedComponents.js';
 import { testSuite_setId } from '../../../../../stores/graph-modifier/Testable_GraphModifierHelper.js';
 import { LakehouseTestSuiteEditor } from '../../testable/LakehouseTestableEditor.js';
+import {
+  BasicValueSpecificationEditor,
+  instanceValue_setValue,
+} from '@finos/legend-query-builder';
 
 // ─── Create Suite Modal ───────────────────────────────────────────────────────
 
@@ -291,6 +315,343 @@ const CreateTestModal = observer(
   },
 );
 
+const DataProductTestParameterEditor = observer(
+  (props: {
+    testState: DataProductTestState;
+    paramState: DataProductTestParameterState;
+    isReadOnly: boolean;
+    contentTypeParamPair: TestParamContentType | undefined;
+  }) => {
+    const { testState, paramState, isReadOnly, contentTypeParamPair } = props;
+    const [showPopUp, setShowPopup] = useState(false);
+    const valueSpecParamState =
+      paramState instanceof DataProductValueSpecificationTestParameterState
+        ? paramState
+        : undefined;
+    const valueSpec = valueSpecParamState?.valueSpec;
+
+    const paramIsRequired = Boolean(
+      testState.queryVariableExpressions.find(
+        (v) =>
+          v.name === paramState.parameterValue.name &&
+          v.multiplicity.lowerBound > 0,
+      ),
+    );
+
+    const showCodeEditor =
+      Boolean(contentTypeParamPair) &&
+      valueSpecParamState?.varExpression.genericType?.value.rawType ===
+        PrimitiveType.STRING &&
+      valueSpec instanceof PrimitiveInstanceValue;
+
+    const type = contentTypeParamPair
+      ? contentTypeParamPair.contentType
+      : (valueSpecParamState?.varExpression.genericType?.value.rawType.name ??
+        'unknown');
+
+    const openInPopUp = (): void => setShowPopup(!showPopUp);
+    const closePopUp = (): void => setShowPopup(false);
+
+    const updateParamValue = (val: string): void => {
+      if (
+        !(valueSpec instanceof PrimitiveInstanceValue) ||
+        !valueSpecParamState
+      ) {
+        return;
+      }
+      const nextValue =
+        valueSpecParamState.varExpression.genericType?.value.rawType ===
+        PrimitiveType.BYTE
+          ? btoa(val)
+          : val;
+      instanceValue_setValue(
+        valueSpec,
+        nextValue,
+        0,
+        testState.editorStore.changeDetectionState.observerContext,
+      );
+      valueSpecParamState.updateValueSpecification(valueSpec);
+    };
+
+    return (
+      <div
+        key={paramState.parameterValue.name}
+        className="panel__content__form__section"
+      >
+        <div className="panel__content__form__section__header__label">
+          {paramState.parameterValue.name}
+          <button
+            className={clsx('type-tree__node__type__label', {})}
+            tabIndex={-1}
+            title={type}
+          >
+            {type}
+          </button>
+        </div>
+
+        {!valueSpecParamState && (
+          <BlankPanelContent>Unsupported parameter value</BlankPanelContent>
+        )}
+
+        {valueSpecParamState &&
+          showCodeEditor &&
+          valueSpec instanceof PrimitiveInstanceValue && (
+            <div className="data-product-test-editor__parameter__code-editor">
+              <textarea
+                className="panel__content__form__section__textarea value-spec-editor__input"
+                spellCheck={false}
+                value={
+                  valueSpecParamState.varExpression.genericType?.value
+                    .rawType === PrimitiveType.BYTE
+                    ? atob(valueSpec.values[0] as string)
+                    : (valueSpec.values[0] as string)
+                }
+                placeholder={
+                  (valueSpec.values[0] as string) === '' ? '(empty)' : undefined
+                }
+                onChange={(event) => updateParamValue(event.target.value)}
+              />
+              {showPopUp && (
+                <ExternalFormatParameterEditorModal
+                  valueSpec={valueSpecParamState.valueSpec}
+                  varExpression={valueSpecParamState.varExpression}
+                  onClose={closePopUp}
+                  isReadOnly={isReadOnly}
+                  updateParamValue={updateParamValue}
+                  contentTypeParamPair={guaranteeNonNullable(
+                    contentTypeParamPair,
+                  )}
+                />
+              )}
+              <div className="data-product-test-editor__parameter__value__actions">
+                <button
+                  className="data-product-test-editor__parameter__code-editor__expand-btn"
+                  onClick={openInPopUp}
+                  tabIndex={-1}
+                  title="Open in a popup..."
+                >
+                  <FilledWindowMaximizeIcon />
+                </button>
+                <button
+                  className="btn--icon btn--dark btn--sm data-product-test-editor__parameter__code-editor__expand-btn"
+                  disabled={isReadOnly || paramIsRequired}
+                  onClick={(): void =>
+                    testState.removeParamValueState(paramState)
+                  }
+                  tabIndex={-1}
+                  title={
+                    paramIsRequired ? 'Parameter Required' : 'Remove Parameter'
+                  }
+                >
+                  <TimesIcon />
+                </button>
+              </div>
+            </div>
+          )}
+
+        {valueSpecParamState && !showCodeEditor && (
+          <div className="data-product-test-editor__parameter__value">
+            <BasicValueSpecificationEditor
+              valueSpecification={valueSpecParamState.valueSpec}
+              setValueSpecification={(val: ValueSpecification): void => {
+                valueSpecParamState.updateValueSpecification(val);
+              }}
+              graph={testState.editorStore.graphManagerState.graph}
+              observerContext={
+                testState.editorStore.changeDetectionState.observerContext
+              }
+              typeCheckOption={{
+                expectedType:
+                  valueSpecParamState.varExpression.genericType?.value
+                    .rawType ?? PrimitiveType.STRING,
+              }}
+              className="query-builder__parameters__value__editor"
+              resetValue={(): void => {
+                valueSpecParamState.resetValueSpec();
+              }}
+            />
+            <div className="data-product-test-editor__parameter__value__actions">
+              <button
+                className="btn--icon btn--dark btn--sm"
+                disabled={isReadOnly || paramIsRequired}
+                onClick={(): void =>
+                  testState.removeParamValueState(paramState)
+                }
+                tabIndex={-1}
+                title={
+                  paramIsRequired ? 'Parameter Required' : 'Remove Parameter'
+                }
+              >
+                <TimesIcon />
+              </button>
+            </div>
+          </div>
+        )}
+      </div>
+    );
+  },
+);
+
+const NewDataProductParameterModal = observer(
+  (props: { testState: DataProductTestState; isReadOnly: boolean }) => {
+    const { testState, isReadOnly } = props;
+    const applicationStore = testState.editorStore.applicationStore;
+    const currentOption = {
+      value: testState.newParameterValueName,
+      label: testState.newParameterValueName,
+    };
+    const options = testState.newParamOptions;
+    const closeModal = (): void => testState.setShowNewParameterModal(false);
+    const onChange = (val: { label: string; value: string } | null): void => {
+      if (val === null) {
+        testState.setNewParameterValueName('');
+      } else if (val.value !== testState.newParameterValueName) {
+        testState.setNewParameterValueName(val.value);
+      }
+    };
+
+    return (
+      <Dialog
+        open={testState.showNewParameterModal}
+        onClose={closeModal}
+        classes={{ container: 'search-modal__container' }}
+        slotProps={{
+          paper: {
+            classes: { root: 'search-modal__inner-container' },
+          },
+        }}
+      >
+        <form
+          onSubmit={(event) => {
+            event.preventDefault();
+            testState.addParameterValue();
+          }}
+          className="modal modal--dark search-modal"
+        >
+          <div className="modal__title">New Test Parameter Value</div>
+          <CustomSelectorInput
+            className="panel__content__form__section__dropdown"
+            options={options}
+            onChange={onChange}
+            value={currentOption}
+            escapeClearsValue={true}
+            darkMode={
+              !applicationStore.layoutService
+                .TEMPORARY__isLightColorThemeEnabled
+            }
+            disabled={isReadOnly}
+          />
+          <div className="search-modal__actions">
+            <button className="btn btn--dark" disabled={isReadOnly}>
+              Add
+            </button>
+          </div>
+        </form>
+      </Dialog>
+    );
+  },
+);
+
+const DataProductTestEditorExtension = observer(
+  (props: { testState: DataProductTestState; isReadOnly: boolean }) => {
+    const { testState, isReadOnly } = props;
+
+    useEffect(() => {
+      testState.syncWithQuery();
+    }, [testState]);
+
+    const hasQueryParameters = Boolean(
+      testState.queryVariableExpressions.length,
+    );
+    if (!hasQueryParameters) {
+      return null;
+    }
+
+    const accessPoint = testState.suiteState.testableState.ownAccessPoints.find(
+      (ap) => ap.id === testState.test.accessPointId,
+    );
+    const query = accessPoint ? getAccessPointLambda(accessPoint) : undefined;
+    const contentTypeParamPairs = getContentTypeWithParamFromQuery(
+      query,
+      testState.editorStore,
+    );
+
+    const addParameter = (): void => {
+      testState.openNewParamModal();
+    };
+
+    const generateParameterValues = (): void => {
+      testState.generateTestParameterValues();
+    };
+
+    return (
+      <div className="data-product-test-editor__parameters-panel-container">
+        <div className="panel data-product-test-editor__parameters-panel">
+          <div className="data-product-test-editor__parameters-header">
+            <div className="data-product-test-editor__parameters-header__title">
+              <div className="data-product-test-editor__parameters-header__title__label">
+                Parameters
+              </div>
+            </div>
+            <div className="data-product-test-editor__parameters-header__actions">
+              <button
+                className="panel__header__action data-product-test-editor__generate-btn"
+                onClick={generateParameterValues}
+                disabled={!testState.newParamOptions.length}
+                title="Generate test parameter values"
+                tabIndex={-1}
+              >
+                <div className="data-product-test-editor__generate-btn__label">
+                  <RefreshIcon className="data-product-test-editor__generate-btn__label__icon" />
+                  <div className="data-product-test-editor__generate-btn__label__title">
+                    Generate
+                  </div>
+                </div>
+              </button>
+              <button
+                className="panel__header__action"
+                tabIndex={-1}
+                disabled={!testState.newParamOptions.length}
+                onClick={addParameter}
+                title="Add Parameter Value"
+              >
+                <PlusIcon />
+              </button>
+            </div>
+          </div>
+
+          <div className="data-product-test-editor__parameters">
+            {testState.parameterValueStates.map((paramState) => (
+              <DataProductTestParameterEditor
+                key={paramState.uuid}
+                isReadOnly={isReadOnly}
+                paramState={paramState}
+                testState={testState}
+                contentTypeParamPair={contentTypeParamPairs.find(
+                  (pair) => pair.param === paramState.parameterValue.name,
+                )}
+              />
+            ))}
+            {testState.parameterValueStates.length === 0 && (
+              <BlankPanelPlaceholder
+                text="No parameter values"
+                tooltipText="Generate or add a parameter value"
+              />
+            )}
+          </div>
+        </div>
+
+        {testState.showNewParameterModal && (
+          <NewDataProductParameterModal
+            testState={testState}
+            isReadOnly={isReadOnly}
+          />
+        )}
+      </div>
+    );
+  },
+);
+
 // ─── Suite Tab Context Menu ───────────────────────────────────────────────────
 
 const SuiteHeaderTabContextMenu = observer(
@@ -407,6 +768,14 @@ export const DataProductTestableEditor = observer(
               suiteState={selectedSuiteState}
               testableState={testableState}
               isReadOnly={isReadOnly}
+              renderTestStateExtension={(testState) =>
+                testState instanceof DataProductTestState ? (
+                  <DataProductTestEditorExtension
+                    testState={testState}
+                    isReadOnly={isReadOnly}
+                  />
+                ) : null
+              }
             />
           )}
           {!dp.tests.length && (