@finos/legend-application-studio 28.21.11 → 28.21.13

package/src/stores/editor/editor-state/element-editor-state/DatabaseEditorState.ts

@@ -42,7 +42,6 @@ import {
   type View,
 } from '@finos/legend-graph';
 import type { EditorStore } from '../../EditorStore.js';
-import { LegendStudioUserDataHelper } from '../../../../__lib__/LegendStudioUserDataHelper.js';
 
 /**
  * Top-level tabs inside the Database form-mode editor. `VIEW` shows the ERD
@@ -397,19 +396,6 @@ export class DatabaseEditorState extends ElementEditorState {
   // by `react-reflex` and not tracked here — only the binary collapse flag.
   isSidePanelCollapsed = false;
 
-  // ---- Theme --------------------------------------------------------------
-  // The wider Studio app is dark-mode-only today. We allow this editor (and
-  // only this editor) to opt into a light theme via a toolbar toggle. The
-  // setting lives on the editor state so it survives tab switches and
-  // recompiles within the same session, and is persisted per-user via
-  // `UserDataService` (localStorage) so the choice survives reloads.
-  // TODO: when Studio adopts app-wide theming via `LayoutService` (Query
-  // already does this with `setColorTheme(..., { persist: true })`), drop
-  // this local observable + persistence and react to
-  // `applicationStore.layoutService.currentColorTheme` instead so this
-  // editor stays in sync with the rest of the app.
-  theme: 'dark' | 'light' = 'dark';
-
   constructor(editorStore: EditorStore, element: PackageableElement) {
     super(editorStore, element);
 
@@ -435,7 +421,6 @@ export class DatabaseEditorState extends ElementEditorState {
       viewGroupByFormulas: observable,
       isLoadingViewGroupByFormulas: observable,
       isSidePanelCollapsed: observable,
-      theme: observable,
       database: computed,
       setSelectedTab: action,
       setSelectedRelation: action,
@@ -451,7 +436,6 @@ export class DatabaseEditorState extends ElementEditorState {
       collapseAll: action,
       setSidePanelCollapsed: action,
       toggleSidePanelCollapsed: action,
-      toggleTheme: action,
       setSearchText: action,
       requestFitAll: action,
       requestResetLayout: action,
@@ -467,16 +451,6 @@ export class DatabaseEditorState extends ElementEditorState {
       this.expandedSchemaIds.add(getSchemaNodeId(schema.name));
     });
 
-    // Hydrate the persisted theme preference (if any). Falls through to the
-    // default 'dark' when the user has never set it. Done synchronously in
-    // the constructor so the first render already reflects the stored choice.
-    const persistedTheme = LegendStudioUserDataHelper.databaseEditor_getTheme(
-      this.editorStore.applicationStore.userDataService,
-    );
-    if (persistedTheme) {
-      this.theme = persistedTheme;
-    }
-
     // Kick off the formula load eagerly. The flow is async and writes into
     // `viewColumnFormulas` when ready — components render with the placeholder
     // until then, so the UI is never blocked on this. Errors are logged and
@@ -876,21 +850,6 @@ export class DatabaseEditorState extends ElementEditorState {
     this.isSidePanelCollapsed = !this.isSidePanelCollapsed;
   }
 
-  /**
-   * Flip the editor's local theme between dark (the Studio default) and
-   * light. Scoped to this editor only — the rest of Studio remains in its
-   * configured theme. The toggle is exposed via a button in the editor's
-   * tab header. The new value is persisted to `UserDataService` so the
-   * choice survives reloads.
-   */
-  toggleTheme(): void {
-    this.theme = this.theme === 'dark' ? 'light' : 'dark';
-    LegendStudioUserDataHelper.databaseEditor_setTheme(
-      this.editorStore.applicationStore.userDataService,
-      this.theme,
-    );
-  }
-
   /**
    * Set the tree search/filter text. Empty string means \u201cno filter\u201d.
    * The schema-tree consumer derives a lowercase form per render rather
@@ -927,7 +886,6 @@ export class DatabaseEditorState extends ElementEditorState {
     next.expandedSchemaIds = new Set(this.expandedSchemaIds);
     next.expandedRelationIds = new Set(this.expandedRelationIds);
     next.isSidePanelCollapsed = this.isSidePanelCollapsed;
-    next.theme = this.theme;
     // Note: `viewColumnFormulas` and `filterFormulas` deliberately do NOT
     // carry over. They're derived from operations on the new element and may
     // have changed; the constructor's `loadViewColumnFormulas()` and

package/src/stores/extensions/DSL_DataProduct_LegendStudioApplicationPlugin_Extension.ts

@@ -0,0 +1,77 @@
+/**
+ * Copyright (c) 2020-present, Goldman Sachs
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import type { DSL_LegendStudioApplicationPlugin_Extension } from '../LegendStudioApplicationPlugin.js';
+
+// ── Response types ─────────────────────────────────────────────────────────────
+
+export type DataProductMeta = {
+  title: string;
+  description: string;
+  confidence: number;
+};
+
+export type AccessPointGroupMeta = {
+  name: string;
+  title: string;
+  description: string;
+  confidence: number;
+};
+
+export type AccessPointMeta = {
+  group: string;
+  name: string;
+  title: string;
+  description: string;
+  confidence: number;
+};
+
+export type DataProductDocResponse = {
+  data_product: DataProductMeta;
+  access_point_groups: AccessPointGroupMeta[];
+  access_points: AccessPointMeta[];
+};
+
+// ── Request type ───────────────────────────────────────────────────────────────
+
+export type DataProductDocRequest = {
+  /**
+   * Raw Pure grammar text containing the data product definitions.
+   */
+  definitions: string;
+  /**
+   * Fully-qualified name of the data product (e.g. dataProduct::MY_PRODUCT).
+   */
+  data_product_name: string;
+  /**
+   * LLM model override (uses server default if omitted).
+   */
+  model?: string;
+};
+
+// ── Plugin extension interface ─────────────────────────────────────────────────
+
+export interface DSL_DataProduct_LegendStudioApplicationPlugin_Extension
+  extends DSL_LegendStudioApplicationPlugin_Extension {
+  /**
+   * Generate AI-suggested documentation for a data product
+   * (title, description, access point groups, access points).
+   */
+  getExtraDataProductDocumentationAISuggester?(
+    request: DataProductDocRequest,
+    legendAIUrl: string,
+  ): Promise<DataProductDocResponse>;
+}

package/src/stores/extensions/DSL_Service_LegendStudioApplicationPlugin_Extension.ts

@@ -23,7 +23,6 @@ import type {
   ObserverContext,
   PostDeploymentProperties,
   HostedService,
-  Service,
 } from '@finos/legend-graph';
 
 export type ServiceTestRuntimeConnectionBuilder = (
@@ -50,7 +49,7 @@ export type PostDeploymentActionTypeGetter = (
 ) => string | undefined;
 
 export type ServiceDocumentationAISuggester = (
-  service: Service,
+  serviceGrammar: string,
   legendAIUrl: string,
 ) => Promise<string>;
 

package/src/stores/workspace-setup/WorkspaceSetupStore.ts

@@ -444,6 +444,10 @@ export class WorkspaceSetupStore {
           // custom selector. This avoids losing some results with the additional filtering.
           isValidSearchString ? exactSearch(searchText) : undefined,
           undefined,
+          // Sandbox projects are loaded via a separate, dedicated call (see
+          // `loadSandboxProject`); exclude them here so they do not appear
+          // in the main workspace setup project picker.
+          [SANDBOX_SDLC_TAG],
           DEFAULT_TYPEAHEAD_SEARCH_LIMIT,
         )) as PlainObject<Project>[]
       ).map((v) => Project.serialization.fromJson(v));
@@ -518,6 +522,7 @@ export class WorkspaceSetupStore {
           undefined,
           userId,
           [SANDBOX_SDLC_TAG],
+          undefined,
           1,
         )) as PlainObject<Project>[]
       ).map((v) => Project.serialization.fromJson(v));

package/tsconfig.json

@@ -197,6 +197,7 @@
     "./src/stores/editor/utils/PackageTreeUtils.ts",
     "./src/stores/editor/utils/TestableUtils.ts",
     "./src/stores/editor/utils/TreeUtils.ts",
+    "./src/stores/extensions/DSL_DataProduct_LegendStudioApplicationPlugin_Extension.ts",
     "./src/stores/extensions/DSL_Data_LegendStudioApplicationPlugin_Extension.ts",
     "./src/stores/extensions/DSL_Generation_LegendStudioApplicationPlugin_Extension.ts",
     "./src/stores/extensions/DSL_Mapping_LegendStudioApplicationPlugin_Extension.ts",