@finos/legend-application-studio 28.19.79 → 28.19.80

package/src/components/editor/editor-group/dataProduct/DataProductEditor.tsx

@@ -80,6 +80,7 @@ import {
   GitBranchIcon,
   ListIcon,
   PanelLoadingIndicator,
+  GearSuggestIcon,
 } from '@finos/legend-art';
 import {
   type ChangeEventHandler,
@@ -101,13 +102,11 @@ import { CodeEditor } from '@finos/legend-lego/code-editor';
 import {
   type DataProductElement,
   type DataProductElementScope,
-  type DataProductRuntimeInfo,
   type Expertise,
   type GraphManagerState,
   type LakehouseAccessPoint,
   type Mapping,
   type PackageableElement,
-  type PackageableRuntime,
   type DataProduct,
   type DataProductDiagram,
   DataProductEmbeddedImageIcon,
@@ -124,6 +123,8 @@ import {
   ExternalDataProductType,
   DataProductLink,
   observer_DataProductLink,
+  DataProduct_Region,
+  DataProduct_DeliveryFrequency,
 } from '@finos/legend-graph';
 import {
   accessPoint_setClassification,
@@ -139,8 +140,6 @@ import {
   supportInfo_setDocumentationUrl,
   supportInfo_setFaqUrl,
   supportInfo_setLinkLabel,
-  runtimeInfo_setId,
-  runtimeInfo_setDescription,
   supportInfo_setSupportUrl,
   supportInfo_setWebsite,
   dataProduct_setType,
@@ -153,6 +152,9 @@ import {
   accessPointGroup_setTitle,
   accessPoint_setDescription,
   accessPoint_setTitle,
+  dataProduct_setOperationalMetadataIfAbsent,
+  operationalMetadata_deleteCoverageRegion,
+  operationalMetadata_addCoverageRegion,
   dataProductDiagram_setTitle,
   dataProductDiagram_setDescription,
 } from '../../../../stores/graph-modifier/DSL_DataProduct_GraphModifierHelper.js';
@@ -1266,140 +1268,6 @@ const AccessPointGroupPublicToggle = observer(
   },
 );
 
-export const CompatibleRuntimesEditor = observer(
-  (props: { groupState: ModelAccessPointGroupState }) => {
-    const { groupState } = props;
-    const group = groupState.value;
-
-    const handleSelectRuntime = (runtime: DataProductRuntimeInfo) => {
-      groupState.setDefaultRuntime(runtime);
-    };
-
-    // Event handlers
-    const handleAddRuntime = (option: {
-      label: string;
-      value: PackageableRuntime;
-    }): void => {
-      if (typeof option.value === 'object') {
-        groupState.addCompatibleRuntime(option.value);
-      }
-    };
-
-    const handleRemoveRuntime = (runtime: DataProductRuntimeInfo): void => {
-      groupState.removeCompatibleRuntime(runtime);
-    };
-
-    const handleRuntimeTitleChange = (
-      runtimeInfo: DataProductRuntimeInfo,
-      value: string | undefined,
-    ): void => {
-      runtimeInfo_setId(runtimeInfo, value ?? '');
-    };
-
-    const handleRuntimeDescriptionChange = (
-      runtimeInfo: DataProductRuntimeInfo,
-      value: string | undefined,
-    ): void => {
-      runtimeInfo_setDescription(runtimeInfo, value);
-    };
-
-    // ListEditor component renderers
-    const RuntimeComponent = observer(
-      (runtimeComponentProps: {
-        item: DataProductRuntimeInfo;
-      }): React.ReactElement => {
-        const { item } = runtimeComponentProps;
-
-        return (
-          <>
-            <div className="panel__content__form__section__list__item__content">
-              <div className="panel__content__form__section__header__label">
-                Default?
-              </div>
-              <input
-                type="radio"
-                name="defaultRuntimeRadio"
-                value={item.id}
-                checked={group.defaultRuntime === item}
-                onChange={() => handleSelectRuntime(item)}
-              />
-            </div>
-            <div className="panel__content__form__section__list__item__content">
-              <div className="panel__content__form__section__header__label">
-                Runtime
-              </div>
-              <div className="panel__content__form__section__list__item__content__title">
-                {item.runtime.value.path}
-              </div>
-            </div>
-            <div className="panel__content__form__section__list__item__form">
-              <PanelFormTextField
-                name="Title"
-                value={item.id}
-                update={(value) => handleRuntimeTitleChange(item, value)}
-                placeholder="Enter title"
-                className="dataSpace-editor__general__diagrams__title"
-              />
-              <PanelFormTextField
-                name="Description"
-                value={item.description ?? ''}
-                update={(value) => handleRuntimeDescriptionChange(item, value)}
-                placeholder="Enter description"
-                className="dataSpace-editor__general__diagrams__description"
-              />
-            </div>
-          </>
-        );
-      },
-    );
-
-    const NewRuntimeComponent = observer(
-      (newRuntimeProps: {
-        onFinishEditing: () => void;
-      }): React.ReactElement => {
-        const { onFinishEditing } = newRuntimeProps;
-
-        return (
-          <div className="panel__content__form__section__list__new-item__input">
-            <CustomSelectorInput
-              options={groupState.getCompatibleRuntimeOptions()}
-              onChange={(event: {
-                label: string;
-                value: PackageableRuntime;
-              }) => {
-                onFinishEditing();
-                handleAddRuntime(event);
-              }}
-              placeholder="Select a runtime to add..."
-              darkMode={
-                !groupState.state.editorStore.applicationStore.layoutService
-                  .TEMPORARY__isLightColorThemeEnabled
-              }
-            />
-          </div>
-        );
-      },
-    );
-
-    return (
-      <ListEditor
-        title="Compatible Runtimes"
-        prompt="Add compatible runtimes to include in this Data Product. Set a title and description for each runtime."
-        items={group.compatibleRuntimes}
-        keySelector={(element: DataProductRuntimeInfo) =>
-          element.runtime.value.path
-        }
-        ItemComponent={RuntimeComponent}
-        NewItemComponent={NewRuntimeComponent}
-        handleRemoveItem={handleRemoveRuntime}
-        isReadOnly={groupState.state.isReadOnly}
-        emptyMessage="No runtimes specified"
-        emptyClassName="data-product-editor__empty-runtime"
-      />
-    );
-  },
-);
-
 export const CompatibleDiagramsEditor = observer(
   (props: { groupState: ModelAccessPointGroupState }) => {
     const { groupState } = props;
@@ -1678,7 +1546,6 @@ const ModelAccessPointGroupEditor = observer(
             <LongArrowRightIcon />
           </button>
         </div>
-        <CompatibleRuntimesEditor groupState={groupState} />
         <CompatibleDiagramsEditor groupState={groupState} />
         <FeaturedElementsEditor
           groupState={groupState}
@@ -2181,6 +2048,11 @@ const DataProductSidebar = observer(
         title: 'Access Point Groups',
         icon: <GroupWorkIcon />,
       },
+      {
+        label: DATA_PRODUCT_TAB.OPERATIONAL,
+        title: 'Operational Metadata',
+        icon: <GearSuggestIcon />,
+      },
       {
         label: DATA_PRODUCT_TAB.SUPPORT,
         icon: <QuestionCircleIcon />,
@@ -2206,8 +2078,8 @@ const DataProductSidebar = observer(
               title={activity.title ?? activity.label}
               style={{
                 flexDirection: 'column',
-                fontSize: '12px',
-                margin: '1rem 0rem',
+                fontSize: '10px',
+                margin: '0.5rem 0rem',
               }}
             >
               {activity.icon}
@@ -3026,6 +2898,145 @@ const getDataProductViewerState = (
   return dataProductViewerState;
 };
 
+const OperationalTab = observer(
+  (props: {
+    dataProductEditorState: DataProductEditorState;
+    isReadOnly: boolean;
+  }) => {
+    const { dataProductEditorState, isReadOnly } = props;
+    const product = dataProductEditorState.product;
+    const CHOOSE_REGION = 'Add Coverage Region...';
+
+    const getCoverageRegionOptions = () => {
+      const existingRegions =
+        product.operationalMetadata?.coverageRegions ?? [];
+      return Object.values(DataProduct_Region)
+        .filter((region) => !existingRegions.includes(region))
+        .map((region) => ({
+          label: region,
+          value: region,
+        }));
+    };
+
+    const handleAddRegion = (
+      val: { label: string; value: DataProduct_Region } | null,
+    ): void => {
+      dataProduct_setOperationalMetadataIfAbsent(product);
+      if (product.operationalMetadata && val) {
+        operationalMetadata_addCoverageRegion(
+          product.operationalMetadata,
+          val.value,
+        );
+      }
+    };
+
+    const handleRemoveRegion = (region: DataProduct_Region) => {
+      if (product.operationalMetadata) {
+        operationalMetadata_deleteCoverageRegion(
+          product.operationalMetadata,
+          region,
+        );
+      }
+    };
+
+    const handleUpdateFrequencyChange = (
+      val: { label: string; value: DataProduct_DeliveryFrequency } | null,
+    ): void => {
+      dataProduct_setOperationalMetadataIfAbsent(product);
+      if (product.operationalMetadata && val) {
+        product.operationalMetadata.updateFrequency = val.value;
+      }
+    };
+
+    return (
+      <div>
+        <div
+          className="panel__content__form__section__header__label"
+          style={{ paddingLeft: '1rem' }}
+        >
+          Operational Metadata
+        </div>
+        <div
+          className="panel__content__form__section__header__prompt"
+          style={{ paddingLeft: '1rem' }}
+        >
+          Configure operational metadata for this Data Product.
+        </div>
+        <div className="data-product-editor__operational-input">
+          <div
+            className="panel__content__form__section__header__label"
+            style={{ justifyContent: 'space-between', width: '45rem' }}
+          >
+            Coverage Regions
+          </div>
+          <div className="panel__content__form__section__header__prompt">
+            Select the regions this Data Product covers.
+          </div>
+          <div className="panel__content__form__section__list__id-list">
+            {product.operationalMetadata?.coverageRegions?.map((region) => (
+              <div
+                className="panel__content__form__section__list__item"
+                key={region}
+              >
+                {region}
+                <button
+                  className="panel__content__form__section__list__item__remove-btn"
+                  disabled={dataProductEditorState.isReadOnly}
+                  onClick={() => handleRemoveRegion(region)}
+                  tabIndex={-1}
+                >
+                  <TimesIcon />
+                </button>
+              </div>
+            ))}
+          </div>
+          <div className="panel__content__form__section__list__new-item__input">
+            <CustomSelectorInput
+              options={getCoverageRegionOptions()}
+              onChange={handleAddRegion}
+              placeholder={CHOOSE_REGION}
+              darkMode={true}
+              disabled={isReadOnly}
+            />
+          </div>
+        </div>
+        <div className="data-product-editor__operational-input">
+          <div
+            className="panel__content__form__section__header__label"
+            style={{ justifyContent: 'space-between', width: '45rem' }}
+          >
+            Update Frequency
+          </div>
+          <div className="panel__content__form__section__header__prompt">
+            Select the update frequency of this Data Product.
+          </div>
+          <div className="panel__content__form__section__list__new-item__input">
+            <CustomSelectorInput
+              options={Object.values(DataProduct_DeliveryFrequency).map(
+                (region) => ({
+                  label: region,
+                  value: region,
+                }),
+              )}
+              onChange={handleUpdateFrequencyChange}
+              value={
+                product.operationalMetadata?.updateFrequency
+                  ? {
+                      label: product.operationalMetadata.updateFrequency,
+                      value: product.operationalMetadata.updateFrequency,
+                    }
+                  : null
+              }
+              darkMode={true}
+              disabled={isReadOnly}
+            />
+          </div>
+        </div>
+      </div>
+    );
+  },
+);
+
 export const DataProductEditor = observer(() => {
   const editorStore = useEditorStore();
   const dataProductEditorState =
@@ -3085,6 +3096,13 @@ export const DataProductEditor = observer(() => {
             isReadOnly={isReadOnly}
           />
         );
+      case DATA_PRODUCT_TAB.OPERATIONAL:
+        return (
+          <OperationalTab
+            dataProductEditorState={dataProductEditorState}
+            isReadOnly={isReadOnly}
+          />
+        );
       default:
         return null;
     }

package/src/stores/editor/NewElementState.ts

@@ -89,7 +89,6 @@ import {
   AccessPointGroup,
   ModelAccessPointGroup,
   stub_Mapping,
-  DataProductRuntimeInfo,
   InternalDataProductType,
 } from '@finos/legend-graph';
 import type { DSL_Mapping_LegendStudioApplicationPlugin_Extension } from '../extensions/DSL_Mapping_LegendStudioApplicationPlugin_Extension.js';
@@ -560,7 +559,6 @@ export class NewLakehouseDataProductDriver extends NewElementDriver<DataProduct>
       defaultGroup.id = 'default';
       defaultGroup.mapping =
         PackageableElementExplicitReference.create(stub_Mapping());
-      defaultGroup.defaultRuntime = new DataProductRuntimeInfo();
       dataProduct_addAccessPointGroup(dataProduct, defaultGroup);
     }
 

package/src/stores/editor/editor-state/element-editor-state/dataProduct/DataProductEditorState.ts

@@ -33,20 +33,16 @@ import {
   getStereotype,
   type StereotypeReference,
   ModelAccessPointGroup,
-  PackageableRuntime,
   Association,
   Class,
   Enumeration,
   Package,
-  observe_DataProductRuntimeInfo,
   PackageableElementExplicitReference,
-  DataProductRuntimeInfo,
   type DataProductElement,
   type Mapping,
   Expertise,
   observe_DataProductElementScope,
   DataProductElementScope,
-  validate_PureExecutionMapping,
   type V1_RawLineageModel,
   type ArtifactGenerationExtensionResult,
   type V1_DataProductArtifact,
@@ -92,7 +88,6 @@ import {
   uuid,
   swapEntry,
   returnUndefOnError,
-  deepEqual,
 } from '@finos/legend-shared';
 import {
   accessPointGroup_swapAccessPoints,
@@ -104,11 +99,8 @@ import {
   dataProduct_deleteAccessPointGroup,
   modelAccessPointGroup_removeDiagram,
   dataProduct_swapAccessPointGroups,
-  modelAccessPointGroup_addCompatibleRuntime,
   modelAccessPointGroup_addElement,
-  modelAccessPointGroup_removeCompatibleRuntime,
   modelAccessPointGroup_removeElement,
-  modelAccessPointGroup_setDefaultRuntime,
   modelAccessPointGroup_setElementExclude,
   modelAccessPointGroup_setMapping,
   dataProduct_setSupportInfoIfAbsent,
@@ -130,6 +122,7 @@ export enum DATA_PRODUCT_TAB {
   HOME = 'Home',
   SUPPORT = 'Support',
   APG = 'APG',
+  OPERATIONAL = 'Operational',
 }
 
 export enum DATA_PRODUCT_TYPE {
@@ -782,23 +775,6 @@ export class ModelAccessPointGroupState extends AccessPointGroupState {
     );
   }
 
-  setDefaultRuntime(runtime: DataProductRuntimeInfo) {
-    modelAccessPointGroup_setDefaultRuntime(this.value, runtime);
-  }
-
-  addCompatibleRuntime(runtime: PackageableRuntime): void {
-    const newRuntime = observe_DataProductRuntimeInfo(
-      new DataProductRuntimeInfo(),
-    );
-    newRuntime.id = runtime.name;
-    newRuntime.runtime = PackageableElementExplicitReference.create(runtime);
-    modelAccessPointGroup_addCompatibleRuntime(this.value, newRuntime);
-
-    if (deepEqual(this.value.defaultRuntime, new DataProductRuntimeInfo())) {
-      this.setDefaultRuntime(newRuntime);
-    }
-  }
-
   getCompatibleDiagramOptions(): {
     label: string;
     value: PackageableElement;
@@ -816,17 +792,6 @@ export class ModelAccessPointGroupState extends AccessPointGroupState {
       }));
   }
 
-  removeCompatibleRuntime(runtime: DataProductRuntimeInfo): void {
-    modelAccessPointGroup_removeCompatibleRuntime(this.value, runtime);
-    if (runtime === this.value.defaultRuntime) {
-      if (!this.value.compatibleRuntimes.length) {
-        this.setDefaultRuntime(new DataProductRuntimeInfo());
-      } else if (this.value.compatibleRuntimes[0]) {
-        this.setDefaultRuntime(this.value.compatibleRuntimes[0]);
-      }
-    }
-  }
-
   addDiagram = (option: { label: string; value: PackageableElement }): void => {
     const diagramValue = option.value;
     const newDiagram = new DataProductDiagram();
@@ -859,33 +824,6 @@ export class ModelAccessPointGroupState extends AccessPointGroupState {
     modelAccessPointGroup_setElementExclude(element, value);
   }
 
-  override hasErrors(): boolean {
-    return Boolean(
-      super.hasErrors() ||
-        !validate_PureExecutionMapping(this.value.mapping.value) ||
-        !deepEqual(this.value.defaultRuntime, new DataProductRuntimeInfo()),
-    );
-  }
-
-  getCompatibleRuntimeOptions(): {
-    label: string;
-    value: PackageableRuntime;
-  }[] {
-    const currentRuntimes = this.value.compatibleRuntimes.map(
-      (runtimePointer) => runtimePointer.runtime.value,
-    );
-    return this.state.editorStore.graphManagerState.graph.allOwnElements
-      .filter(
-        (element): element is PackageableRuntime =>
-          element instanceof PackageableRuntime,
-      )
-      .filter((runtime) => !currentRuntimes.includes(runtime))
-      .map((runtime) => ({
-        label: runtime.path,
-        value: runtime,
-      }));
-  }
-
   isValidDataProductElement(
     element: PackageableElement,
   ): element is DataProductElement {

package/src/stores/graph-modifier/DSL_DataProduct_GraphModifierHelper.ts

@@ -39,6 +39,10 @@ import {
   type ExternalDataProductType,
   observe_Expertise,
   type Expertise,
+  observe_OperationalMetadata,
+  DataProductOperationalMetadata,
+  type DataProduct_DeliveryFrequency,
+  type DataProduct_Region,
 } from '@finos/legend-graph';
 import { addUniqueEntry, deleteEntry, swapEntry } from '@finos/legend-shared';
 import { action } from 'mobx';
@@ -97,12 +101,6 @@ export const accessPointGroup_setTitle = action(
   },
 );
 
-export const modelAccessPointGroup_setDefaultRuntime = action(
-  (group: ModelAccessPointGroup, runtime: DataProductRuntimeInfo) => {
-    group.defaultRuntime = runtime;
-  },
-);
-
 export const modelAccessPointGroup_setMapping = action(
   (
     group: ModelAccessPointGroup,
@@ -112,18 +110,6 @@ export const modelAccessPointGroup_setMapping = action(
   },
 );
 
-export const modelAccessPointGroup_addCompatibleRuntime = action(
-  (group: ModelAccessPointGroup, runtime: DataProductRuntimeInfo) => {
-    addUniqueEntry(group.compatibleRuntimes, runtime);
-  },
-);
-
-export const modelAccessPointGroup_removeCompatibleRuntime = action(
-  (group: ModelAccessPointGroup, runtime: DataProductRuntimeInfo): void => {
-    deleteEntry(group.compatibleRuntimes, runtime);
-  },
-);
-
 export const modelAccessPointGroup_addElement = action(
   (group: ModelAccessPointGroup, element: DataProductElementScope): void => {
     addUniqueEntry(group.featuredElements, element);
@@ -380,3 +366,46 @@ export const supportInfo_deleteEmail = action(
     }
   },
 );
+
+export const dataProduct_setOperationalMetadataIfAbsent = action(
+  (product: DataProduct) => {
+    if (!product.operationalMetadata) {
+      product.operationalMetadata = observe_OperationalMetadata(
+        new DataProductOperationalMetadata(),
+      );
+    }
+  },
+);
+
+export const operationalMetadata_setUpdateFrequency = action(
+  (
+    operationalMetadata: DataProductOperationalMetadata,
+    updateFrequency: DataProduct_DeliveryFrequency,
+  ) => {
+    operationalMetadata.updateFrequency = updateFrequency;
+  },
+);
+
+export const operationalMetadata_addCoverageRegion = action(
+  (
+    operationalMetadata: DataProductOperationalMetadata,
+    region: DataProduct_Region,
+  ) => {
+    if (!operationalMetadata.coverageRegions) {
+      operationalMetadata.coverageRegions = [region];
+    } else {
+      addUniqueEntry(operationalMetadata.coverageRegions, region);
+    }
+  },
+);
+
+export const operationalMetadata_deleteCoverageRegion = action(
+  (
+    operationalMetadata: DataProductOperationalMetadata,
+    region: DataProduct_Region,
+  ) => {
+    if (operationalMetadata.coverageRegions) {
+      deleteEntry(operationalMetadata.coverageRegions, region);
+    }
+  },
+);