@finos/legend-application-studio 28.18.80 → 28.18.82

package/src/stores/editor/sidebar-state/ProjectOverviewState.ts

@@ -22,7 +22,6 @@ import {
   type PlainObject,
   assertErrorThrown,
   LogEvent,
-  getNullableFirstEntry,
   ActionState,
 } from '@finos/legend-shared';
 import {
@@ -268,7 +267,7 @@ export class ProjectOverviewState {
         // 1. the revision is somehow directly added to the branch by the user (in the case of `git`, user directly pushed to unprotected default branch)
         // 2. the revision is the merged/comitted review revision (this usually happens for projects where fast forwarding merging is not default)
         // in those case, we will get the time from the revision
-        const latestProjectVersionRevisionReviewObj = getNullableFirstEntry(
+        const latestProjectVersionRevisionReviewObj = (
           (yield this.editorStore.sdlcServerClient.getReviews(
             this.sdlcState.activeProject.projectId,
             undefined,
@@ -277,8 +276,8 @@ export class ProjectOverviewState {
               revisionIds: [latestProjectVersionRevision.id],
               limit: 1,
             },
-          )) as PlainObject<Review>[],
-        );
+          )) as PlainObject<Review>[]
+        )[0];
         const latestProjectVersionRevisionReview =
           latestProjectVersionRevisionReviewObj
             ? Review.serialization.fromJson(

package/src/stores/editor/sidebar-state/WorkspaceUpdaterState.ts

@@ -23,7 +23,6 @@ import {
   LogEvent,
   assertErrorThrown,
   guaranteeNonNullable,
-  getNullableFirstEntry,
   NetworkClientError,
   HttpStatus,
 } from '@finos/legend-shared';
@@ -328,7 +327,7 @@ export class WorkspaceUpdaterState {
           RevisionAlias.BASE,
         )) as PlainObject<Revision>,
       );
-      const baseReviewObj = getNullableFirstEntry(
+      const baseReviewObj = (
         (yield this.editorStore.sdlcServerClient.getReviews(
           this.sdlcState.activeProject.projectId,
           this.sdlcState.activePatch?.patchReleaseVersionId.id,
@@ -337,8 +336,8 @@ export class WorkspaceUpdaterState {
             revisionIds: [workspaceBaseRevision.id],
             limit: 1,
           },
-        )) as PlainObject<Review>[],
-      );
+        )) as PlainObject<Review>[]
+      )[0];
       const baseReview = baseReviewObj
         ? Review.serialization.fromJson(baseReviewObj)
         : undefined;

package/src/stores/editor/utils/TestableUtils.ts

@@ -64,7 +64,6 @@ import {
   assertTrue,
   ContentType,
   generateEnumerableNameFromToken,
-  getNullableFirstEntry,
   guaranteeNonEmptyString,
   guaranteeType,
   isNonNullable,
@@ -455,9 +454,7 @@ export const getContentTypeWithParamRecursively = (
       }
       currentExpression = collection;
     } else {
-      currentExpression = getNullableFirstEntry(
-        currentExpression.parametersValues,
-      );
+      currentExpression = currentExpression.parametersValues[0];
     }
   }
   return res;