@finos/legend-application-studio 28.18.39 → 28.18.41

package/src/components/editor/editor-group/service-editor/ServicePostValidationEditor.tsx

@@ -550,9 +550,9 @@ export const ServicePostValidationsEditor = observer(
             <ResizablePanel>
               <Panel className="service-test-editor">
                 <PanelTabs
-                  tabTitles={Object.keys(POST_VALIDATION_TAB)}
+                  tabs={Object.keys(POST_VALIDATION_TAB)}
                   selectedTab={selectedTab}
-                  changeTheTab={(tab) => () =>
+                  changeTab={(tab) => () =>
                     setSelectedTab(
                       POST_VALIDATION_TAB[
                         tab as keyof typeof POST_VALIDATION_TAB

package/src/components/editor/editor-group/service-editor/ServiceRegistrationEditor.tsx

@@ -68,7 +68,7 @@ export const ServiceRegistrationEditor = observer(() => {
       }
     : null;
   const onServiceTypeSelectionChange = (
-    val: { label: ServiceExecutionMode; value: ServiceExecutionMode } | null,
+    val: { label: string; value: ServiceExecutionMode } | null,
   ): void => {
     registrationState.updateType(val?.value);
   };

package/src/components/editor/editor-group/service-editor/testable/ServiceTestsEditor.tsx

@@ -127,7 +127,7 @@ export const NewParameterModal = observer(
               !applicationStore.layoutService
                 .TEMPORARY__isLightColorThemeEnabled
             }
-            disable={isReadOnly}
+            disabled={isReadOnly}
           />
           <div className="search-modal__actions">
             <button className="btn btn--dark" disabled={isReadOnly}>
@@ -374,7 +374,7 @@ const ServiceTestSetupEditor = observer(
                         !applicationStore.layoutService
                           .TEMPORARY__isLightColorThemeEnabled
                       }
-                      disable={isReadOnly}
+                      disabled={isReadOnly}
                     />
                   </div>
                   {setupState.testState.testable.execution instanceof
@@ -399,7 +399,7 @@ const ServiceTestSetupEditor = observer(
                             .TEMPORARY__isLightColorThemeEnabled
                         }
                         isMulti={true}
-                        disable={isReadOnly}
+                        disabled={isReadOnly}
                         placeholder="Choose keys..."
                       />
                     </div>

package/src/components/editor/editor-group/uml-editor/AssociationEditor.tsx

@@ -148,13 +148,13 @@ const AssociationPropertyBasicEditor = observer(
     const filterOption = createFilter({
       ignoreCase: true,
       ignoreAccents: false,
-      stringify: (option: PackageableElementOption<Class>): string =>
-        option.value.path,
+      stringify: (option: { data: PackageableElementOption<Class> }): string =>
+        option.data.value.path,
     });
     const selectedPropertyType = {
       value: propertyType,
       label: propertyType.name,
-    };
+    } as PackageableElementOption<Class>;
     const changePropertyType = (val: PackageableElementOption<Class>): void => {
       association_changePropertyType(
         association,

package/src/components/editor/editor-group/uml-editor/ClassEditor.tsx

@@ -183,8 +183,8 @@ const PropertyBasicEditor = observer(
     const filterOption = createFilter({
       ignoreCase: true,
       ignoreAccents: false,
-      stringify: (option: PackageableElementOption<Type>): string =>
-        option.value.path,
+      stringify: (option: { data: PackageableElementOption<Type> }): string =>
+        option.data.value.path,
     });
     const selectedPropertyType = {
       value: propertyType,
@@ -530,8 +530,8 @@ const DerivedPropertyBasicEditor = observer(
     const filterOption = createFilter({
       ignoreCase: true,
       ignoreAccents: false,
-      stringify: (option: PackageableElementOption<Type>): string =>
-        option.value.path,
+      stringify: (option: { data: PackageableElementOption<Type> }): string =>
+        option.data.value.path,
     });
     const selectedPropertyType = {
       value: propertyType,
@@ -1103,10 +1103,13 @@ const SuperTypeEditor = observer(
     const filterOption = createFilter({
       ignoreCase: true,
       ignoreAccents: false,
-      stringify: (option: PackageableElementOption<Class>): string =>
-        option.value.path,
+      stringify: (option: { data: PackageableElementOption<Class> }): string =>
+        option.data.value.path,
     });
-    const selectedType = { value: rawType, label: rawType.name };
+    const selectedType = {
+      value: rawType,
+      label: rawType.name,
+    } as PackageableElementOption<Class>;
     const changeType = (val: PackageableElementOption<Class>): void =>
       setGenericTypeReferenceValue(superType, new GenericType(val.value));
     const visitDerivationSource = (): void =>

package/src/components/editor/editor-group/uml-editor/PropertyEditor.tsx

@@ -271,7 +271,7 @@ export const PropertyEditor = observer(
                       }
                       escapeClearsValue={true}
                       isClearable={true}
-                      disable={isReadOnly}
+                      disabled={isReadOnly}
                     />
                   </PanelFormSection>
                 </PanelForm>

package/src/components/editor/editor-group/uml-editor/StereotypeSelector.tsx

@@ -92,8 +92,9 @@ export const StereotypeSelector = observer(
     const filterOption = createFilter({
       ignoreCase: true,
       ignoreAccents: false,
-      stringify: (option: PackageableElementOption<Profile>): string =>
-        option.value.path,
+      stringify: (option: {
+        data: PackageableElementOption<Profile>;
+      }): string => option.data.value.path,
     });
     const [selectedProfile, setSelectedProfile] = useState<
       PackageableElementOption<Profile>
@@ -118,7 +119,8 @@ export const StereotypeSelector = observer(
     const stereotypeFilterOption = createFilter({
       ignoreCase: true,
       ignoreAccents: false,
-      stringify: (option: StereotypeOption): string => option.label,
+      stringify: (option: { data: StereotypeOption }): string =>
+        option.data.label,
     });
     const selectedStereotype = {
       value: stereotype.value,

package/src/components/editor/editor-group/uml-editor/TaggedValueEditor.tsx

@@ -99,8 +99,9 @@ export const TaggedValueEditor = observer(
     const profileFilterOption = createFilter({
       ignoreCase: true,
       ignoreAccents: false,
-      stringify: (option: PackageableElementOption<Profile>): string =>
-        option.value.path,
+      stringify: (option: {
+        data: PackageableElementOption<Profile>;
+      }): string => option.data.value.path,
     });
     const [selectedProfile, setSelectedProfile] = useState<
       PackageableElementOption<Profile>
@@ -125,7 +126,7 @@ export const TaggedValueEditor = observer(
     const tagFilterOption = createFilter({
       ignoreCase: true,
       ignoreAccents: false,
-      stringify: (option: TagOption): string => option.label,
+      stringify: (option: { data: TagOption }): string => option.data.label,
     });
     const selectedTag = {
       value: inferableTag.value,

package/src/components/editor/panel-group/SQLPlaygroundPanel.tsx

@@ -574,8 +574,8 @@ export const SQLPlaygroundPanel = observer(() => {
   const connectionFilterOption = createFilter({
     ignoreCase: true,
     ignoreAccents: false,
-    stringify: (option: RelationalDatabaseConnectionOption): string =>
-      option.value.path,
+    stringify: (option: { data: RelationalDatabaseConnectionOption }): string =>
+      option.data.value.path,
   });
   const connectionOptions = editorStore.graphManagerState.usableConnections
     .filter(
@@ -691,7 +691,7 @@ export const SQLPlaygroundPanel = observer(() => {
                       <PURE_ConnectionIcon />
                     </div>
                     <CustomSelectorInput
-                      ref={connectionSelectorRef}
+                      inputRef={connectionSelectorRef}
                       className="sql-playground__config__connection-selector__input"
                       options={connectionOptions}
                       onChange={changeConnection}
@@ -709,7 +709,7 @@ export const SQLPlaygroundPanel = observer(() => {
                       <PURE_DatabaseIcon />
                     </div>
                     <CustomSelectorInput
-                      ref={connectionSelectorRef}
+                      inputRef={connectionSelectorRef}
                       className="sql-playground__config__database-selector__input"
                       options={connectionOptions}
                       onChange={changeConnection}

package/src/components/editor/side-bar/CreateNewElementModal.tsx

@@ -179,7 +179,9 @@ const NewRuntimeDriverEditor = observer(() => {
   const mapping = newRuntimeDriver.mapping;
   const mappingOptions =
     editorStore.graphManagerState.usableMappings.map(buildElementOption);
-  const selectedMappingOption = { label: mapping?.path ?? '', value: mapping };
+  const selectedMappingOption = mapping
+    ? { label: mapping.path, value: mapping }
+    : null;
   const onMappingSelectionChange = (
     val: PackageableElementOption<Mapping>,
   ): void => {
@@ -312,7 +314,7 @@ const NewConnectionDriverEditor = observer(() => {
 
   // store
   const store = newConnectionDriver.store;
-  let storeOptions: { label: string; value?: Store | undefined }[] = [
+  let storeOptions: { label: string; value: Store | undefined }[] = [
     { label: 'ModelStore', value: undefined },
   ];
   // TODO: we should think more about this and filter the store by the connection type
@@ -329,8 +331,14 @@ const NewConnectionDriverEditor = observer(() => {
     label: store.path,
     value: store,
   };
-  const onStoreSelectionChange = (val: { label: string; value: Store }): void =>
-    newConnectionDriver.setStore(val.value);
+  const onStoreSelectionChange = (val: {
+    label: string;
+    value: Store | undefined;
+  }): void => {
+    if (val.value) {
+      newConnectionDriver.setStore(val.value);
+    }
+  };
 
   return (
     <>

package/src/components/editor/side-bar/Explorer.tsx

@@ -317,8 +317,8 @@ const SampleDataGenerator = observer(() => {
   const elementFilterOption = createFilter({
     ignoreCase: true,
     ignoreAccents: false,
-    stringify: (option: PackageableElementOption<Class>): string =>
-      option.value.path,
+    stringify: (option: { data: PackageableElementOption<Class> }): string =>
+      option.data.value.path,
   });
   const classOptions = editorStore.graphManagerState.usableClasses.map(
     (_class) => ({
@@ -381,7 +381,7 @@ const SampleDataGenerator = observer(() => {
             <PURE_ClassIcon />
           </div>
           <CustomSelectorInput
-            ref={classSelectorRef}
+            inputRef={classSelectorRef}
             className="sample-data-generator__controller__class-selector"
             options={classOptions}
             onChange={changeClass}

package/src/components/editor/side-bar/ProjectOverview.tsx

@@ -753,7 +753,11 @@ const PatchEditor = observer(() => {
                       label: p.patchReleaseVersionId.id,
                       value: p,
                     }))}
-                    onChange={onPatchOptionChange}
+                    onChange={(val: PatchOption | null) => {
+                      onPatchOptionChange(val).catch(
+                        applicationStore.alertUnhandledError,
+                      );
+                    }}
                     value={selectedPatchOption}
                     placeholder={'Select patch you want to release'}
                     isClearable={true}

package/src/components/lazy-text-editor/LazyTextEditor.tsx

@@ -311,7 +311,7 @@ const LazyStatusBar = observer((props: { actionsDisabled: boolean }) => {
 export const LazyTextEditor = withEditorStore(
   observer(() => {
     const params = useParams<WorkspaceEditorPathParams>();
-    const projectId = params.projectId;
+    const projectId = guaranteeNonNullable(params.projectId);
     const patchReleaseVersionId = params.patchReleaseVersionId;
     const workspaceType = params.groupWorkspaceId
       ? WorkspaceType.GROUP
@@ -367,6 +367,7 @@ export const LazyTextEditor = withEditorStore(
     useEffect(() => {
       editorStore.internalizeEntityPath(params);
     }, [editorStore, params]);
+
     useEffect(() => {
       flowResult(
         editorStore.lazyTextEditorStore.init(

package/src/components/project-reviewer/ProjectReviewer.tsx

@@ -46,6 +46,7 @@ import {
 } from '../editor/EditorStoreProvider.js';
 import { useApplicationStore } from '@finos/legend-application';
 import { useParams } from '@finos/legend-application/browser';
+import { guaranteeNonNullable } from '@finos/legend-shared';
 
 const ProjectReviewerStatusBar = observer(() => {
   const reviewStore = useProjectReviewerStore();
@@ -185,8 +186,8 @@ export const ProjectReviewer = withEditorStore(
   withProjectReviewerStore(
     observer(() => {
       const params = useParams<ProjectReviewerPathParams>();
-      const projectId = params.projectId;
-      const reviewId = params.reviewId;
+      const projectId = guaranteeNonNullable(params.projectId);
+      const reviewId = guaranteeNonNullable(params.reviewId);
       const reviewStore = useProjectReviewerStore();
       const editorStore = useEditorStore();
       const changeActivity =

package/src/stores/LegendStudioBaseStore.ts

@@ -31,7 +31,7 @@ import {
   LegendApplicationTelemetryHelper,
   APPLICATION_EVENT,
 } from '@finos/legend-application';
-import { matchPath } from '@finos/legend-application/browser';
+import { matchRoutes } from '@finos/legend-application/browser';
 import {
   action,
   computed,
@@ -118,14 +118,19 @@ export class LegendStudioBaseStore {
 
     // authorize SDLC, unless navigation location match SDLC-bypassed patterns
     if (
-      !matchPath(
-        this.applicationStore.navigationService.navigator.getCurrentLocation(),
+      !matchRoutes(
         [
-          LEGEND_STUDIO_SDLC_BYPASSED_ROUTE_PATTERN.VIEW_BY_GAV,
-          LEGEND_STUDIO_SDLC_BYPASSED_ROUTE_PATTERN.VIEW_BY_GAV_ENTITY,
-          LEGEND_STUDIO_SDLC_BYPASSED_ROUTE_PATTERN.PREVIEW_BY_GAV_ENTITY,
-          LEGEND_STUDIO_SDLC_BYPASSED_ROUTE_PATTERN.SHOWCASE_PROJECT,
+          { path: LEGEND_STUDIO_SDLC_BYPASSED_ROUTE_PATTERN.VIEW_BY_GAV },
+          {
+            path: LEGEND_STUDIO_SDLC_BYPASSED_ROUTE_PATTERN.VIEW_BY_GAV_ENTITY,
+          },
+          {
+            path: LEGEND_STUDIO_SDLC_BYPASSED_ROUTE_PATTERN.PREVIEW_BY_GAV_ENTITY,
+          },
+          { path: LEGEND_STUDIO_SDLC_BYPASSED_ROUTE_PATTERN.SHOWCASE },
+          { path: LEGEND_STUDIO_SDLC_BYPASSED_ROUTE_PATTERN.PCT_REPORT },
         ],
+        this.applicationStore.navigationService.navigator.getCurrentLocation(),
       )
     ) {
       // setup SDLC server client

package/src/stores/editor/EditorStore.ts

@@ -538,7 +538,7 @@ export class EditorStore implements CommandRegistrar {
     this.explorerTreeState = new ExplorerTreeState(this);
   }
 
-  internalizeEntityPath(params: WorkspaceEditorPathParams): void {
+  internalizeEntityPath(params: Partial<WorkspaceEditorPathParams>): void {
     const { projectId, entityPath } = params;
     const workspaceType = params.groupWorkspaceId
       ? WorkspaceType.GROUP
@@ -551,7 +551,7 @@ export class EditorStore implements CommandRegistrar {
       this.initialEntityPath = entityPath;
       this.applicationStore.navigationService.navigator.updateCurrentLocation(
         generateEditorRoute(
-          projectId,
+          guaranteeNonNullable(projectId),
           params.patchReleaseVersionId,
           workspaceId,
           workspaceType,

package/src/stores/showcase/ShowcaseViewerStore.ts

@@ -82,7 +82,7 @@ export class ShowcaseViewerStore {
       return;
     }
 
-    const showcasePath = params[0];
+    const showcasePath = params.showcasePath;
     this.editorStore.initState.inProgress();
     const onLeave = (hasBuildSucceeded: boolean): void => {
       this.editorStore.initState.complete(hasBuildSucceeded);