@finos/legend-application-studio 28.18.147 → 28.18.148

package/src/components/editor/side-bar/CreateNewElementModal.tsx

@@ -27,6 +27,7 @@ import {
   NewServiceDriver,
   CONNECTION_TYPE,
   type RuntimeOption,
+  NewLakehouseDataProductDriver,
 } from '../../../stores/editor/NewElementState.js';
 import { Dialog, compareLabelFn, CustomSelectorInput } from '@finos/legend-art';
 import type { EditorStore } from '../../../stores/editor/EditorStore.js';
@@ -89,7 +90,7 @@ export const getElementTypeLabel = (
     case PACKAGEABLE_ELEMENT_TYPE.TEMPORARY__LOCAL_CONNECTION:
       return 'local connection';
     case PACKAGEABLE_ELEMENT_TYPE._DATA_PRODUCT:
-      return 'lakehouse data product';
+      return 'Lakehouse Data Product';
     default: {
       if (type) {
         const extraElementTypeLabelGetters = editorStore.pluginManager
@@ -440,11 +441,42 @@ const NewServiceDriverEditor = observer(() => {
 });
 
 const NewLakehouseDataProductEditor = observer(() => {
-  // const editorStore = useEditorStore();
-  // const newProductDriver = editorStore.newElementState.getNewElementDriver(
-  //   NewLakehouseDataProductDriver,
-  // );
-  return null;
+  const editorStore = useEditorStore();
+  const newProductDriver = editorStore.newElementState.getNewElementDriver(
+    NewLakehouseDataProductDriver,
+  );
+  const handleTitleChange: React.ChangeEventHandler<HTMLInputElement> = (
+    event,
+  ) => newProductDriver.setTitle(event.target.value);
+  const handleDescriptionChange: React.ChangeEventHandler<HTMLInputElement> = (
+    event,
+  ) => newProductDriver.setDescription(event.target.value);
+  return (
+    <>
+      <div className="panel__content__form__section__header__label">Title</div>
+      <div className="explorer__new-element-modal__driver">
+        <input
+          className="input--dark explorer__new-element-modal__name-input"
+          spellCheck={false}
+          value={newProductDriver.title}
+          onChange={handleTitleChange}
+          placeholder={`Choose a title for this Data Product to display in Marketplace`}
+        />
+      </div>
+      <div className="panel__content__form__section__header__label">
+        Description
+      </div>
+      <div className="explorer__new-element-modal__driver">
+        <input
+          className="input--dark explorer__new-element-modal__name-input"
+          spellCheck={false}
+          value={newProductDriver.description}
+          onChange={handleDescriptionChange}
+          placeholder={`Provide a meaningful description for this Data Product`}
+        />
+      </div>
+    </>
+  );
 });
 
 const NewFileGenerationDriverEditor = observer(() => {

package/src/stores/editor/NewElementState.ts

@@ -109,7 +109,10 @@ import {
 } from '@finos/legend-lego/graph-editor';
 import { EmbeddedDataType } from './editor-state/ExternalFormatState.js';
 import { createEmbeddedData } from './editor-state/element-editor-state/data/EmbeddedDataState.js';
-import { dataProduct_setTitle } from '../graph-modifier/DSL_DataProduct_GraphModifierHelper.js';
+import {
+  dataProduct_setDescription,
+  dataProduct_setTitle,
+} from '../graph-modifier/DSL_DataProduct_GraphModifierHelper.js';
 
 export const CUSTOM_LABEL = '(custom)';
 
@@ -484,27 +487,35 @@ export class NewPackageableConnectionDriver extends NewElementDriver<Packageable
 
 export class NewLakehouseDataProductDriver extends NewElementDriver<DataProduct> {
   title: string;
+  description: string;
 
   constructor(editorStore: EditorStore) {
     super(editorStore);
     this.title = '';
+    this.description = '';
     makeObservable(this, {
       title: observable,
+      description: observable,
       setTitle: action,
+      setDescription: action,
       isValid: computed,
     });
   }
 
   override get isValid(): boolean {
-    return true;
+    return Boolean(this.title && this.description);
   }
 
   setTitle(val: string) {
     this.title = val;
   }
+  setDescription(val: string) {
+    this.description = val;
+  }
   override createElement(name: string): DataProduct {
     const dataProduct = new DataProduct(name);
     dataProduct_setTitle(dataProduct, this.title);
+    dataProduct_setDescription(dataProduct, this.description);
     return dataProduct;
   }
 }

package/src/stores/editor/editor-state/element-editor-state/connection/ConnectionEditorState.ts

@@ -171,8 +171,9 @@ export class RelationalDatabaseConnectionValueState extends ConnectionValueState
   };
 
   get storeValidationResult(): ValidationIssue | undefined {
-    return isStubbed_PackageableElement(this.connection.store.value)
-      ? createValidationError(['Connection database cannot be empty'])
+    return !this.connection.store ||
+      isStubbed_PackageableElement(this.connection.store.value)
+      ? createValidationError(['Connection database is empty'])
       : undefined;
   }
 

package/src/stores/editor/editor-state/element-editor-state/connection/DatabaseBuilderState.ts

@@ -373,12 +373,15 @@ export class DatabaseSchemaExplorerState {
     });
 
     this.connection = connection;
-    this.database = guaranteeType(connection.store.value, Database);
+    this.database = guaranteeType(connection.store?.value, Database);
     this.editorStore = editorStore;
     this.targetDatabasePath = DEFAULT_DATABASE_PATH;
   }
 
   get isCreatingNewDatabase(): boolean {
+    if (!this.connection.store) {
+      return false;
+    }
     return isStubbed_PackageableElement(this.connection.store.value);
   }
 

package/src/stores/editor/panel-group/SQLPlaygroundPanelState.ts

@@ -95,7 +95,7 @@ export class SQLPlaygroundPanelState implements CommandRegistrar {
     this.connection = val;
     if (val) {
       const connection = guaranteeRelationalDatabaseConnection(val);
-      this.database = connection.store.value;
+      this.database = connection.store?.value;
       this.schemaExplorerState = new DatabaseSchemaExplorerState(
         this.editorStore,
         connection,