@finos/legend-application-studio 28.16.21 → 28.16.23

package/src/components/editor/editor-group/project-configuration-editor/ProjectDependencyEditor.tsx

@@ -891,8 +891,8 @@ const ProjectVersionDependencyEditor = observer(
     const projectSelectorPlaceholder = !projectDependency.projectId.length
       ? 'Choose project'
       : versionDisabled
-      ? 'No project version found. Please create a new one.'
-      : 'Select version';
+        ? 'No project version found. Please create a new one.'
+        : 'Select version';
 
     return (
       <div className="project-dependency-editor">
@@ -1005,8 +1005,8 @@ export const ProjectDependencyEditor = observer(() => {
           {configState.updatingConfigurationState.isInProgress
             ? `Updating configuration...`
             : configState.fetchingProjectVersionsState.isInProgress
-            ? `Fetching dependency versions`
-            : 'Updating project dependency tree and potential conflicts'}
+              ? `Fetching dependency versions`
+              : 'Updating project dependency tree and potential conflicts'}
         </div>
       )}
       <ProjectDependencyActions dependencyEditorState={dependencyEditorState} />

package/src/components/editor/editor-group/service-editor/BulkServiceRegistrationEditor.tsx

@@ -119,9 +119,9 @@ export const BulkServiceRegistrationEditor = observer(() => {
           ServiceExecutionMode.SEMI_INTERACTIVE,
         )} and ${prettyCONSTName(ServiceExecutionMode.PROD)} service types`
       : !globalBulkServiceRegistrationState.serviceConfigState.versionOptions
-          .length
-      ? 'Project has no versions'
-      : undefined;
+            .length
+        ? 'Project has no versions'
+        : undefined;
 
   // activate
   const toggleActivatePostRegistration = (): void => {

package/src/components/editor/editor-group/service-editor/ServiceExecutionEditor.tsx

@@ -565,10 +565,10 @@ export const NewExecutionParameterModal = observer(
       keyValue === ''
         ? `Execution context key can't be empty`
         : executionState.execution.executionParameters?.find(
-            (e) => e.key === keyValue,
-          )
-        ? 'Execution context key already exists'
-        : undefined;
+              (e) => e.key === keyValue,
+            )
+          ? 'Execution context key already exists'
+          : undefined;
 
     const closeModal = (): void =>
       executionState.setNewKeyParameterModal(false);

package/src/components/editor/editor-group/service-editor/ServicePostValidationEditor.tsx

@@ -71,8 +71,8 @@ const ServicePostValidationAssertionEditor = observer(
       assertion.id === ''
         ? `assertion ID can't be empty`
         : assertion.id.includes(' ')
-        ? `assertion ID can't include spaced`
-        : undefined;
+          ? `assertion ID can't include spaced`
+          : undefined;
 
     return (
       <div className="service-post-validation-editor__parameters">
@@ -469,8 +469,8 @@ const ServicePostValidationResultsViewer = observer(
               />
             ))
           : isInProgress
-          ? 'Post validation(s) running...'
-          : 'Run post validation(s) to see results'}
+            ? 'Post validation(s) running...'
+            : 'Run post validation(s) to see results'}
       </div>
     );
   },

package/src/components/editor/editor-group/service-editor/ServiceRegistrationEditor.tsx

@@ -94,8 +94,8 @@ export const ServiceRegistrationEditor = observer(() => {
           ServiceExecutionMode.SEMI_INTERACTIVE,
         )} and ${prettyCONSTName(ServiceExecutionMode.PROD)} service types`
       : !registrationState.versionOptions.length
-      ? 'Project has no versions'
-      : undefined;
+        ? 'Project has no versions'
+        : undefined;
 
   // activate
   const toggleActivatePostRegistration = (): void => {

package/src/components/editor/editor-group/uml-editor/AssociationEditor.tsx

@@ -183,8 +183,8 @@ const AssociationPropertyBasicEditor = observer(
         upper === MULTIPLICITY_INFINITE
           ? undefined
           : typeof upper === 'number'
-          ? upper
-          : parseInt(upper, 10);
+            ? upper
+            : parseInt(upper, 10);
       if (!isNaN(lBound) && (uBound === undefined || !isNaN(uBound))) {
         property_setMultiplicity(
           property,

package/src/components/editor/editor-group/uml-editor/ClassEditor.tsx

@@ -210,8 +210,8 @@ const PropertyBasicEditor = observer(
         upper === MULTIPLICITY_INFINITE
           ? undefined
           : typeof upper === 'number'
-          ? upper
-          : parseInt(upper, 10);
+            ? upper
+            : parseInt(upper, 10);
       if (!isNaN(lBound) && (uBound === undefined || !isNaN(uBound))) {
         property_setMultiplicity(
           property,
@@ -557,8 +557,8 @@ const DerivedPropertyBasicEditor = observer(
         upper === MULTIPLICITY_INFINITE
           ? undefined
           : typeof upper === 'number'
-          ? upper
-          : parseInt(upper, 10);
+            ? upper
+            : parseInt(upper, 10);
       if (!isNaN(lBound) && (uBound === undefined || !isNaN(uBound))) {
         property_setMultiplicity(
           derivedProperty,

package/src/components/editor/side-bar/Explorer.tsx

@@ -190,12 +190,12 @@ const ElementRenamer = observer(() => {
     const errorMessage = !isElementPathNonEmpty
       ? `Element path cannot be empty`
       : !isNotTopLevelElement
-      ? `Creating top level element is not allowed`
-      : !isValidElementPath
-      ? `Element path is not valid`
-      : !isElementUnique
-      ? `Element of the same path already existed`
-      : '';
+        ? `Creating top level element is not allowed`
+        : !isValidElementPath
+          ? `Element path is not valid`
+          : !isElementUnique
+            ? `Element of the same path already existed`
+            : '';
     setElementRenameValidationErrorMessage(errorMessage);
     setCanRenameElement(
       isElementPathNonEmpty &&
@@ -960,10 +960,10 @@ const PackageTreeNodeContainer = observer(
     const iconPackageColor = isGeneratedElement(node.packageableElement)
       ? 'color--generated'
       : isSystemElement(node.packageableElement)
-      ? 'color--system'
-      : isDependencyElement(node.packageableElement)
-      ? 'color--dependency'
-      : '';
+        ? 'color--system'
+        : isDependencyElement(node.packageableElement)
+          ? 'color--dependency'
+          : '';
 
     const nodeIcon = isPackage ? (
       node.isOpen ? (

package/src/components/editor/side-bar/ProjectOverview.tsx

@@ -350,10 +350,10 @@ const ReleaseEditor = observer(() => {
   const disabledCreateVersionTitle = isCurrentProjectVersionLatest
     ? `Can't create version: project version not the latest`
     : !editorStore.sdlcServerClient.features.canCreateVersion
-    ? `Can't create version: current svn system does not support creating versions`
-    : !editorStore.sdlcState.canCreateVersion
-    ? `Can't create version: You do not have the rights to create a version`
-    : undefined;
+      ? `Can't create version: current svn system does not support creating versions`
+      : !editorStore.sdlcState.canCreateVersion
+        ? `Can't create version: You do not have the rights to create a version`
+        : undefined;
 
   // since this can be affected by other users, we refresh it more proactively
   useEffect(() => {

package/src/components/editor/side-bar/WorkspaceReview.tsx

@@ -140,12 +140,12 @@ export const WorkspaceReview = observer(() => {
   const commitReviewTitle = workspaceContainsSnapshotDependencies
     ? `Can't commit review: workspace has snapshot dependencies`
     : workspaceReviewState.sdlcState.isActiveProjectSandbox
-    ? `Can't commit review: reviews are not allowed on sandbox projects`
-    : !workspaceReviewState.canMergeReview
-    ? workspaceReviewState.sdlcState.unAuthorizedActionMessage(
-        AuthorizableProjectAction.COMMIT_REVIEW,
-      )
-    : 'Commit review';
+      ? `Can't commit review: reviews are not allowed on sandbox projects`
+      : !workspaceReviewState.canMergeReview
+        ? workspaceReviewState.sdlcState.unAuthorizedActionMessage(
+            AuthorizableProjectAction.COMMIT_REVIEW,
+          )
+        : 'Commit review';
   const commitReview = (): void => {
     if (workspaceReview && !isDispatchingAction) {
       editorStore.localChangesState.alertUnsavedChanges((): void => {
@@ -167,12 +167,12 @@ export const WorkspaceReview = observer(() => {
   const createReviewTitle = workspaceContainsSnapshotDependencies
     ? `Can't create review: workspace has snapshot dependencies`
     : workspaceReviewState.sdlcState.isActiveProjectSandbox
-    ? `Can't create review: reviews are not allowed on sandbox projects`
-    : !workspaceReviewState.canCreateReview
-    ? workspaceReviewState.sdlcState.unAuthorizedActionMessage(
-        AuthorizableProjectAction.SUBMIT_REVIEW,
-      )
-    : 'Create review';
+      ? `Can't create review: reviews are not allowed on sandbox projects`
+      : !workspaceReviewState.canCreateReview
+        ? workspaceReviewState.sdlcState.unAuthorizedActionMessage(
+            AuthorizableProjectAction.SUBMIT_REVIEW,
+          )
+        : 'Create review';
   const createReview = (): void => {
     if (
       workspaceReviewState.reviewTitle &&

package/src/components/lazy-text-editor/LazyTextEditor.tsx

@@ -108,17 +108,17 @@ const LazyStatusBar = observer((props: { actionsDisabled: boolean }) => {
     editorStore.changeDetectionState.initState.hasFailed
       ? 'change detection halted'
       : !editorStore.changeDetectionState.initState.hasSucceeded
-      ? editorStore.changeDetectionState.workspaceLocalLatestRevisionState
-          .isBuildingEntityHashesIndex
-        ? 'building indexes...'
-        : 'starting change detection...'
-      : editorStore.localChangesState.pushChangesState.isInProgress
-      ? 'pushing local changes...'
-      : configurationState.updatingConfigurationState.isInProgress
-      ? 'updating configuration...'
-      : changes
-      ? `${changes} unpushed changes`
-      : 'no changes detected';
+        ? editorStore.changeDetectionState.workspaceLocalLatestRevisionState
+            .isBuildingEntityHashesIndex
+          ? 'building indexes...'
+          : 'starting change detection...'
+        : editorStore.localChangesState.pushChangesState.isInProgress
+          ? 'pushing local changes...'
+          : configurationState.updatingConfigurationState.isInProgress
+            ? 'updating configuration...'
+            : changes
+              ? `${changes} unpushed changes`
+              : 'no changes detected';
   const workspaceOutOfSync =
     !actionsDisabled && editorStore.sdlcState.isWorkspaceOutOfSync;
 

package/src/components/project-reviewer/ProjectReviewer.tsx

@@ -60,14 +60,14 @@ const ProjectReviewerStatusBar = observer(() => {
   const reviewStatus = reviewStore.approveState.isInProgress
     ? 'approving review...'
     : reviewStore.commitState.isInProgress
-    ? 'committing review...'
-    : reviewStore.closeState.isInProgress
-    ? 'closing review...'
-    : reviewStore.reOpenState.isInProgress
-    ? 'reopening review...'
-    : reviewStore.buildReviewReportState.isInProgress
-    ? 'loading changes...'
-    : undefined;
+      ? 'committing review...'
+      : reviewStore.closeState.isInProgress
+        ? 'closing review...'
+        : reviewStore.reOpenState.isInProgress
+          ? 'reopening review...'
+          : reviewStore.buildReviewReportState.isInProgress
+            ? 'loading changes...'
+            : undefined;
   const toggleAssistant = (): void =>
     applicationStore.assistantService.toggleAssistant();
 

package/src/components/project-view/ProjectViewer.tsx

@@ -93,8 +93,8 @@ const ProjectViewerStatusBar = observer(() => {
         ? 'latest behind project'
         : 'latest'
       : currentRevision
-      ? 'current'
-      : ''
+        ? 'current'
+        : ''
   }`;
 
   const editable =

package/src/components/workspace-setup/WorkspaceSetup.tsx

@@ -570,10 +570,10 @@ export const WorkspaceSetup = withWorkspaceSetupStore(
                               setupStore.loadWorkspacesState.isInProgress
                                 ? 'Loading workspaces...'
                                 : !setupStore.currentProject
-                                ? 'In order to choose a workspace, a project must be chosen'
-                                : workspaceOptions.length
-                                ? 'Choose an existing workspace'
-                                : 'You have no workspaces. Please create one to proceed...'
+                                  ? 'In order to choose a workspace, a project must be chosen'
+                                  : workspaceOptions.length
+                                    ? 'Choose an existing workspace'
+                                    : 'You have no workspaces. Please create one to proceed...'
                             }
                             isClearable={true}
                             escapeClearsValue={true}
@@ -597,9 +597,8 @@ export const WorkspaceSetup = withWorkspaceSetupStore(
                         title="Create a Workspace after choosing one project"
                         disabled={
                           !setupStore.currentProject ||
-                          !setupStore.currentProjectConfigurationStatus ||
                           !setupStore.currentProjectConfigurationStatus
-                            .isConfigured
+                            ?.isConfigured
                         }
                       >
                         {`Need to create a new workspace?`}

package/src/stores/editor/NewElementState.ts

@@ -128,12 +128,12 @@ export const resolvePackageAndElementName = (
     !selectedPackageName && !additionalPackageName
       ? ''
       : selectedPackageName
-      ? `${selectedPackageName}${
-          additionalPackageName
-            ? `${ELEMENT_PATH_DELIMITER}${additionalPackageName}`
-            : ''
-        }`
-      : additionalPackageName;
+        ? `${selectedPackageName}${
+            additionalPackageName
+              ? `${ELEMENT_PATH_DELIMITER}${additionalPackageName}`
+              : ''
+          }`
+        : additionalPackageName;
   return [packagePath, elementName];
 };
 

package/src/stores/editor/editor-state/element-editor-state/ProtocolValueBuilderState.ts

@@ -249,8 +249,8 @@ export class ProtocolValueBuilderState {
                 childNodeValue === undefined
                   ? undefined
                   : isString(childNodeValue)
-                  ? childNodeValue
-                  : '',
+                    ? childNodeValue
+                    : '',
               );
             } else if (multiplicity.upperBound === 1) {
               childNode = new StringFieldNode(

package/src/stores/editor/editor-state/element-editor-state/mapping/MappingEditorState.ts

@@ -759,8 +759,8 @@ export class MappingEditorState extends ElementEditorState {
           openIndex >= 0
             ? this.openedTabStates[openIndex]
             : this.openedTabStates.length
-            ? this.openedTabStates[0]
-            : undefined;
+              ? this.openedTabStates[0]
+              : undefined;
         if (tabStateToOpen) {
           yield flowResult(this.openTab(tabStateToOpen));
         } else {
@@ -1477,8 +1477,8 @@ export class MappingEditorState extends ElementEditorState {
     return numberOfTestFailed
       ? TEST_RESULT.FAILED
       : numberOfTestPassed
-      ? TEST_RESULT.PASSED
-      : TEST_RESULT.NONE;
+        ? TEST_RESULT.PASSED
+        : TEST_RESULT.NONE;
   }
 
   *runTests(): GeneratorFn<void> {

package/src/stores/editor/editor-state/element-editor-state/mapping/MappingElementDecorator.ts

@@ -741,8 +741,7 @@ export class MappingElementDecorationCleaner
         (propertyMapping) =>
           (propertyMapping instanceof FlatDataPropertyMapping &&
             !isStubbed_RawLambda(propertyMapping.transform)) ||
-          (propertyMapping instanceof EmbeddedFlatDataPropertyMapping &&
-            propertyMapping.property),
+          propertyMapping instanceof EmbeddedFlatDataPropertyMapping,
       ),
       this.editorStore.changeDetectionState.observerContext,
     );

package/src/stores/project-reviewer/ProjectReviewerStore.ts

@@ -332,7 +332,7 @@ export class ProjectReviewerStore {
           ),
       ]);
       if (comparison.projectConfigurationUpdated) {
-        [
+        yield Promise.all([
           this.editorStore.sdlcServerClient
             .getReviewFromConfiguration(
               this.projectId,
@@ -347,7 +347,7 @@ export class ProjectReviewerStore {
               this.reviewId,
             )
             .then((config) => report.addToConfig(config)),
-        ];
+        ]);
       }
       yield fromToRequests;
     } catch (error) {

package/src/stores/project-view/ProjectViewerEditorMode.ts

@@ -57,21 +57,21 @@ export class ProjectViewerEditorMode extends EditorMode {
           elementPath,
         )
       : this.viewerStore.version
-      ? generateViewVersionRoute(
-          this.viewerStore.editorStore.sdlcState.activeProject.projectId,
-          this.viewerStore.version.id.id,
-          elementPath,
-        )
-      : this.viewerStore.revision
-      ? generateViewRevisionRoute(
-          this.viewerStore.editorStore.sdlcState.activeProject.projectId,
-          this.viewerStore.revision.id,
-          elementPath,
-        )
-      : generateViewEntityRoute(
-          this.viewerStore.editorStore.sdlcState.activeProject.projectId,
-          elementPath,
-        );
+        ? generateViewVersionRoute(
+            this.viewerStore.editorStore.sdlcState.activeProject.projectId,
+            this.viewerStore.version.id.id,
+            elementPath,
+          )
+        : this.viewerStore.revision
+          ? generateViewRevisionRoute(
+              this.viewerStore.editorStore.sdlcState.activeProject.projectId,
+              this.viewerStore.revision.id,
+              elementPath,
+            )
+          : generateViewEntityRoute(
+              this.viewerStore.editorStore.sdlcState.activeProject.projectId,
+              elementPath,
+            );
   }
 
   generateDependencyElementLink(

package/src/stores/project-view/ProjectViewerStore.ts

@@ -132,8 +132,8 @@ export class ProjectViewerStore {
           versionId
             ? generateViewVersionRoute(projectId, versionId)
             : revisionId
-            ? generateViewRevisionRoute(projectId, revisionId)
-            : generateViewProjectRoute(projectId),
+              ? generateViewRevisionRoute(projectId, revisionId)
+              : generateViewProjectRoute(projectId),
         );
       } else if (gav) {
         const {

package/src/stores/workspace-setup/WorkspaceSetupStore.ts

@@ -288,11 +288,11 @@ export class WorkspaceSetupStore {
             workspaceId
               ? { workspaceId: workspaceId, workspaceType: WorkspaceType.USER }
               : groupWorkspaceId
-              ? {
-                  workspaceId: groupWorkspaceId,
-                  workspaceType: WorkspaceType.GROUP,
-                }
-              : undefined,
+                ? {
+                    workspaceId: groupWorkspaceId,
+                    workspaceType: WorkspaceType.GROUP,
+                  }
+                : undefined,
           ),
         );
       }

package/tsconfig.json

@@ -24,7 +24,23 @@
     "outDir": "./lib",
     "tsBuildInfoFile": "./build/prod.tsbuildinfo",
     "rootDir": "./src",
-    "jsx": "react-jsx"
+    "jsx": "react-jsx",
+    "moduleResolution": "nodenext",
+    "moduleDetection": "force",
+    "isolatedModules": true,
+    "esModuleInterop": true,
+    "allowSyntheticDefaultImports": true,
+    "preserveConstEnums": true,
+    "incremental": true,
+    "useDefineForClassFields": true,
+    "noImplicitAny": true,
+    "noImplicitThis": true,
+    "strictNullChecks": true,
+    "strictFunctionTypes": true,
+    "strictBindCallApply": true,
+    "strictPropertyInitialization": true,
+    "alwaysStrict": true,
+    "useUnknownInCatchVariables": true
   },
   "references": [
     {

package/tsconfig.package.json

@@ -23,7 +23,23 @@
     "forceConsistentCasingInFileNames": true,
     "outDir": "./lib",
     "tsBuildInfoFile": "./build/package.tsbuildinfo",
-    "rootDir": "./"
+    "rootDir": "./",
+    "moduleResolution": "nodenext",
+    "moduleDetection": "force",
+    "isolatedModules": true,
+    "esModuleInterop": true,
+    "allowSyntheticDefaultImports": true,
+    "preserveConstEnums": true,
+    "incremental": true,
+    "useDefineForClassFields": true,
+    "noImplicitAny": true,
+    "noImplicitThis": true,
+    "strictNullChecks": true,
+    "strictFunctionTypes": true,
+    "strictBindCallApply": true,
+    "strictPropertyInitialization": true,
+    "alwaysStrict": true,
+    "useUnknownInCatchVariables": true
   },
   "files": [
     "./package.json"