@finos/legend-application-studio 26.1.11 → 27.0.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@finos/legend-application-studio",
-  "version": "26.1.11",
+  "version": "27.0.0",
   "description": "Legend Studio application core",
   "keywords": [
     "legend",
@@ -45,18 +45,18 @@
     "test:watch": "jest --watch"
   },
   "dependencies": {
-    "@finos/legend-application": "15.0.23",
-    "@finos/legend-art": "7.0.23",
-    "@finos/legend-graph": "30.0.8",
-    "@finos/legend-lego": "1.0.21",
-    "@finos/legend-query-builder": "4.0.12",
-    "@finos/legend-server-depot": "6.0.15",
-    "@finos/legend-server-sdlc": "5.0.16",
-    "@finos/legend-shared": "10.0.14",
-    "@finos/legend-storage": "3.0.64",
+    "@finos/legend-application": "15.0.24",
+    "@finos/legend-art": "7.0.24",
+    "@finos/legend-graph": "30.0.9",
+    "@finos/legend-lego": "1.1.0",
+    "@finos/legend-query-builder": "4.0.13",
+    "@finos/legend-server-depot": "6.0.16",
+    "@finos/legend-server-sdlc": "5.0.17",
+    "@finos/legend-shared": "10.0.15",
+    "@finos/legend-storage": "3.0.65",
     "@testing-library/react": "14.0.0",
-    "@types/react": "18.2.12",
-    "@types/react-dom": "18.2.5",
+    "@types/react": "18.2.13",
+    "@types/react-dom": "18.2.6",
     "fast-xml-parser": "4.2.4",
     "mobx": "6.9.0",
     "mobx-react-lite": "3.4.3",
@@ -70,10 +70,10 @@
     "yaml": "2.3.1"
   },
   "devDependencies": {
-    "@finos/legend-dev-utils": "2.0.68",
+    "@finos/legend-dev-utils": "2.0.69",
     "@jest/globals": "29.5.0",
     "cross-env": "7.0.3",
-    "eslint": "8.42.0",
+    "eslint": "8.43.0",
     "jest": "29.5.0",
     "npm-run-all": "4.1.5",
     "rimraf": "5.0.1",

package/src/components/editor/editor-group/project-configuration-editor/ProjectDependencyEditor.tsx

@@ -118,16 +118,12 @@ const ProjectDependencyActions = observer(
       dependencyEditorState.dependencyReport?.conflicts.length;
     const viewTree = (): void => {
       if (dependencyEditorState.dependencyReport) {
-        dependencyEditorState.setDependencyReport(
-          DEPENDENCY_REPORT_TAB.EXPLORER,
-        );
+        dependencyEditorState.setReportTab(DEPENDENCY_REPORT_TAB.EXPLORER);
       }
     };
     const viewConflict = (): void => {
       if (dependencyEditorState.dependencyReport) {
-        dependencyEditorState.setDependencyReport(
-          DEPENDENCY_REPORT_TAB.CONFLICTS,
-        );
+        dependencyEditorState.setReportTab(DEPENDENCY_REPORT_TAB.CONFLICTS);
       }
     };
     return (
@@ -604,17 +600,17 @@ const ProjectDependencyReportModal = observer(
     const changeTab =
       (tab: DEPENDENCY_REPORT_TAB): (() => void) =>
       (): void =>
-        dependencyEditorState.setDependencyReport(tab);
+        dependencyEditorState.setReportTab(tab);
     const dependencyReport = dependencyEditorState.dependencyReport;
     const closeModal = (): void =>
-      dependencyEditorState.setDependencyReport(undefined);
+      dependencyEditorState.setReportTab(undefined);
     const [flattenView, setFlattenView] = useState(false);
     const [isExpandingDependencies, setIsExpandingDependencies] =
       useState(false);
     const setTreeData = (
-      treeData: TreeData<ProjectDependencyTreeNodeData>,
+      val: TreeData<ProjectDependencyTreeNodeData>,
     ): void => {
-      dependencyEditorState.setTreeData(treeData, flattenView);
+      dependencyEditorState.setTreeData(val, flattenView);
     };
     const toggleViewAsListOrAsTree = (): void => {
       setFlattenView(!flattenView);

package/src/components/editor/editor-group/service-editor/testable/ServiceTestsEditor.tsx

@@ -225,6 +225,14 @@ const ServiceTestParameterEditor = observer(
     const type = bindingParamPair
       ? bindingParamPair.binding.contentType
       : paramState.varExpression.genericType?.value.rawType.name ?? 'unknown';
+    const paramValue = (
+      paramState.varExpression.genericType?.value.rawType === PrimitiveType.BYTE
+        ? atob(
+            (paramState.valueSpec as PrimitiveInstanceValue)
+              .values[0] as string,
+          )
+        : (paramState.valueSpec as PrimitiveInstanceValue).values[0]
+    ) as string;
 
     const openInPopUp = (): void => setShowPopUp(!showPopUp);
     const closePopUp = (): void => setShowPopUp(false);
@@ -232,7 +240,10 @@ const ServiceTestParameterEditor = observer(
       if (paramState.valueSpec instanceof PrimitiveInstanceValue) {
         instanceValue_setValue(
           paramState.valueSpec,
-          val,
+          paramState.varExpression.genericType?.value.rawType ===
+            PrimitiveType.BYTE
+            ? btoa(val)
+            : val,
           0,
           setupState.editorStore.changeDetectionState.observerContext,
         );
@@ -261,10 +272,7 @@ const ServiceTestParameterEditor = observer(
               <textarea
                 className="panel__content__form__section__textarea value-spec-editor__input"
                 spellCheck={false}
-                value={
-                  (paramState.valueSpec as PrimitiveInstanceValue)
-                    .values[0] as string
-                }
+                value={paramValue}
                 placeholder={
                   ((paramState.valueSpec as PrimitiveInstanceValue)
                     .values[0] as string) === ''

package/src/components/editor/side-bar/testable/GlobalTestRunner.tsx

@@ -54,7 +54,6 @@ import {
   type GeneratorFn,
   isNonNullable,
   prettyCONSTName,
-  toTitleCase,
 } from '@finos/legend-shared';
 import { observer } from 'mobx-react-lite';
 import { forwardRef, useEffect, useState } from 'react';
@@ -429,23 +428,28 @@ export const GlobalTestRunner = observer(
     const editorStore = useEditorStore();
     const globalTestRunnerState = props.globalTestRunnerState;
     const isDispatchingAction = globalTestRunnerState.isDispatchingAction;
-    const testRunnerTabs = (Object.values(TEST_RUNNER_TABS) as string[])
-      .concat(
-        editorStore.pluginManager
-          .getApplicationPlugins()
-          .flatMap(
-            (plugin) => plugin.getExtraTestRunnerTabClassifiers?.() ?? [],
-          ),
-      )
-      .map((e) => ({
-        value: e,
-        label: prettyCONSTName(e),
-      }));
 
     const [selectedTab, setSelectedTab] = useState(
       TEST_RUNNER_TABS.TEST_RUNNER.valueOf(),
     );
 
+    const extractTestRunnerTabConfigurations = editorStore.pluginManager
+      .getApplicationPlugins()
+      .flatMap((plugin) => plugin.getExtraTestRunnerTabConfigurations?.() ?? [])
+      .filter((configuration) => configuration.renderer(editorStore));
+
+    const testRunnerTabs = (Object.values(TEST_RUNNER_TABS) as string[])
+      .map((e) => ({
+        value: e,
+        label: prettyCONSTName(e),
+      }))
+      .concat(
+        extractTestRunnerTabConfigurations.map((config) => ({
+          value: config.key,
+          label: config.title,
+        })),
+      );
+
     const changeTab = (tab: string): void => {
       setSelectedTab(tab);
     };
@@ -544,7 +548,7 @@ export const GlobalTestRunner = observer(
                     ['panel__header__tab--active']: tab.value === selectedTab,
                   })}
                 >
-                  {toTitleCase(prettyCONSTName(tab.value))}
+                  {tab.label}
                 </div>
               ))}
             </div>
@@ -578,15 +582,9 @@ export const GlobalTestRunner = observer(
           </div>
         );
       } else {
-        const extraTestRunnerTabEditorRenderers = editorStore.pluginManager
-          .getApplicationPlugins()
-          .flatMap(
-            (plugin) => plugin.getExtraTestRunnerTabEditorRenderers?.() ?? [],
-          );
-        for (const editorRenderer of extraTestRunnerTabEditorRenderers) {
-          const editor = editorRenderer(selectedTab, editorStore);
-          if (editor) {
-            return editor;
+        for (const testRunnerTabConfiguration of extractTestRunnerTabConfigurations) {
+          if (testRunnerTabConfiguration.key === selectedTab) {
+            return testRunnerTabConfiguration.renderer(editorStore);
           }
         }
         return (

package/src/stores/LegendStudioApplicationPlugin.ts

@@ -77,10 +77,11 @@ export type TestableMetadataGetter = (
   editorStore: EditorStore,
 ) => TestableMetadata | undefined;
 
-export type TestRunnerTabRenderer = (
-  selectedTab: string,
-  editorStore: EditorStore,
-) => React.ReactNode | undefined;
+export type TestRunnerTabConfiguration = {
+  key: string;
+  title: string;
+  renderer: (editorStore: EditorStore) => React.ReactNode | undefined;
+};
 
 export abstract class LegendStudioApplicationPlugin extends LegendApplicationPlugin {
   /**
@@ -126,14 +127,9 @@ export abstract class LegendStudioApplicationPlugin extends LegendApplicationPlu
   getExtraTestableMetadata?(): TestableMetadataGetter[];
 
   /**
-   * Get the list of the supported classifers for test runner tabs.
-   */
-  getExtraTestRunnerTabClassifiers?(): string[];
-
-  /**
-   * Get the list of renderers for the editor for a test runner tab.
+   * Get the list of configurations for the editor for a test runner tab.
    */
-  getExtraTestRunnerTabEditorRenderers?(): TestRunnerTabRenderer[];
+  getExtraTestRunnerTabConfigurations?(): TestRunnerTabConfiguration[];
 }
 
 export type PureGrammarElementLabeler = (

package/src/stores/editor/GraphEditFormModeState.ts

@@ -578,7 +578,6 @@ export class GraphEditFormModeState extends GraphEditorMode {
 
   *onLeave(): GeneratorFn<void> {
     this.editorStore.sqlPlaygroundState.setConnection(undefined);
-    return;
   }
 
   *cleanupBeforeEntering(fallbackOptions?: {

package/src/stores/editor/NewElementState.ts

@@ -66,7 +66,6 @@ import {
   PackageableElementExplicitReference,
   RelationalDatabaseConnection,
   DatabaseType,
-  StaticDatasourceSpecification,
   DefaultH2AuthenticationStrategy,
   ModelGenerationSpecification,
   DataElement,
@@ -74,6 +73,7 @@ import {
   Measure,
   Multiplicity,
   PrimitiveType,
+  LocalH2DatasourceSpecification,
 } from '@finos/legend-graph';
 import type { DSL_Mapping_LegendStudioApplicationPlugin_Extension } from '../extensions/DSL_Mapping_LegendStudioApplicationPlugin_Extension.js';
 import {
@@ -302,6 +302,8 @@ export class NewFlatDataConnectionDriver extends NewConnectionValueDriver<FlatDa
   }
 }
 
+const DEFAULT_H2_SQL =
+  '-- loads sample data for getting started. See https://github.com/pthom/northwind_psql for more info\n call loadNorthwindData()';
 export class NewRelationalDatabaseConnectionDriver extends NewConnectionValueDriver<RelationalDatabaseConnection> {
   constructor(editorStore: EditorStore) {
     super(editorStore);
@@ -327,10 +329,12 @@ export class NewRelationalDatabaseConnectionDriver extends NewConnectionValueDri
       const dbs = this.editorStore.graphManagerState.usableDatabases;
       selectedStore = dbs.length ? (dbs[0] as Database) : stub_Database();
     }
+    const spec = new LocalH2DatasourceSpecification();
+    spec.testDataSetupSqls = [DEFAULT_H2_SQL];
     return new RelationalDatabaseConnection(
       PackageableElementExplicitReference.create(selectedStore),
       DatabaseType.H2,
-      new StaticDatasourceSpecification('dummyHost', 80, 'myDb'),
+      spec,
       new DefaultH2AuthenticationStrategy(),
     );
   }
@@ -440,7 +444,6 @@ export class NewPackageableConnectionDriver extends NewElementDriver<Packageable
       this.store = store;
       this.newConnectionValueDriver = newDriver;
     }
-    return;
   }
 
   get isValid(): boolean {

package/src/stores/editor/editor-state/element-editor-state/service/ServicePostValidationState.ts

@@ -411,7 +411,7 @@ export class PostValidationState {
     );
     serviceValidation_deleteAssertion(this.validation, assertion);
     this.assertionStates = this.assertionStates.filter(
-      (e) => !(e === _assertionState),
+      (e) => e !== _assertionState,
     );
   }
 }

package/src/stores/editor/editor-state/element-editor-state/service/testable/ServiceTestEditorState.ts

@@ -254,10 +254,20 @@ export class ServiceTestSetupState {
             ),
             this.editorStore.graphManagerState.graph,
           );
-
         if (valueSpec instanceof LambdaFunctionInstanceValue) {
           return this.getBindingWithParamRecursively(
-            valueSpec.values[0]?.expressionSequence[0],
+            valueSpec.values[0]?.expressionSequence.find(
+              (exp) =>
+                exp instanceof SimpleFunctionExpression &&
+                (matchFunctionName(
+                  exp.functionName,
+                  QUERY_BUILDER_SUPPORTED_FUNCTIONS.SERIALIZE,
+                ) ||
+                  matchFunctionName(
+                    exp.functionName,
+                    QUERY_BUILDER_SUPPORTED_FUNCTIONS.EXTERNALIZE,
+                  )),
+            ),
           );
         }
       } catch (error) {

package/src/stores/editor/editor-state/project-configuration-editor-state/ProjectDependencyEditorState.ts

@@ -316,7 +316,7 @@ export class ProjectDependencyEditorState {
       reportTab: observable,
       expandConflictsState: observable,
       buildConflictPathState: observable,
-      setDependencyReport: action,
+      setReportTab: action,
       expandAllConflicts: action,
       setFlattenDependencyTreeData: action,
       clearTrees: action,
@@ -356,7 +356,7 @@ export class ProjectDependencyEditorState {
     }
   }
 
-  setDependencyReport(tab: DEPENDENCY_REPORT_TAB | undefined): void {
+  setReportTab(tab: DEPENDENCY_REPORT_TAB | undefined): void {
     this.reportTab = tab;
   }
 

package/src/stores/editor/sidebar-state/BulkServiceRegistrationState.ts

@@ -152,7 +152,7 @@ export class GlobalBulkServiceRegistrationState {
   }
 
   setSelectAll(val: boolean): void {
-    this.bulkServiceRegistrationStates.map(
+    this.bulkServiceRegistrationStates.forEach(
       (serviceRegistrationState) => (serviceRegistrationState.isSelected = val),
     );
   }

package/src/stores/editor/utils/MockDataUtils.ts

@@ -242,7 +242,7 @@ export const getPrimitiveTypeFromRelationalType = (
 export const createMockDataForColumn = (
   col: Column,
   isPrimaryKey: boolean,
-  idx?: number | number,
+  idx?: number | undefined,
 ): string | undefined => {
   const type = col.type;
 

package/src/stores/editor/utils/PackageTreeUtils.ts

@@ -367,7 +367,7 @@ export const openNode = (
   let currentElement: PackageableElement | undefined = element;
   let openingNode: PackageTreeNodeData | undefined;
   while (currentElement.package) {
-    const node: PackageTreeNodeData =
+    const currentNode: PackageTreeNodeData =
       treeData.nodes.get(currentElement.path) ??
       addNode(
         editorStore,
@@ -376,8 +376,8 @@ export const openNode = (
         childFilter,
         isDependencyElement,
       );
-    node.isOpen = currentElement instanceof Package;
-    openingNode = !openingNode ? node : openingNode;
+    currentNode.isOpen = currentElement instanceof Package;
+    openingNode = !openingNode ? currentNode : openingNode;
     currentElement = currentElement.package;
   }
   // Open the dependency root