@finos/legend-application-studio 23.0.0 → 23.0.2

package/src/stores/editor/GraphEditGrammarModeState.ts

@@ -0,0 +1,512 @@
+/**
+ * Copyright (c) 2020-present, Goldman Sachs
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import {
+  ActionAlertActionType,
+  ActionAlertType,
+} from '@finos/legend-application';
+import {
+  type PackageableElement,
+  GRAPH_MANAGER_EVENT,
+  type TextCompilationResult,
+  EngineError,
+  GraphBuilderError,
+  type GraphManagerOperationReport,
+  reportGraphAnalytics,
+} from '@finos/legend-graph';
+import {
+  type GeneratorFn,
+  assertErrorThrown,
+  LogEvent,
+  ActionState,
+  StopWatch,
+} from '@finos/legend-shared';
+import type { Entity } from '@finos/legend-storage';
+import { makeObservable, flow, flowResult, observable } from 'mobx';
+import { GrammarTextEditorState } from './editor-state/GrammarTextEditorState.js';
+import type { EditorStore } from './EditorStore.js';
+import { ExplorerTreeState } from './ExplorerTreeState.js';
+
+import { TextLocalChangesState } from './sidebar-state/LocalChangesState.js';
+import { GraphCompilationOutcome, type Problem } from './EditorGraphState.js';
+import { GRAPH_EDITOR_MODE, AUX_PANEL_MODE } from './EditorConfig.js';
+import { graph_dispose } from './shared/modifier/GraphModifierHelper.js';
+import { LegendStudioTelemetryHelper } from '../../application/LegendStudioTelemetryHelper.js';
+import { GraphEditorMode } from './GraphEditorMode.js';
+import { ElementEditorState } from './editor-state/element-editor-state/ElementEditorState.js';
+
+export class GraphEditGrammarModeState extends GraphEditorMode {
+  grammarTextEditorState: GrammarTextEditorState;
+
+  constructor(editorStore: EditorStore) {
+    super(editorStore);
+    makeObservable(this, {
+      grammarTextEditorState: observable,
+      setGraphGrammar: flow,
+      setGraphGrammarFromEntites: flow,
+      compileText: flow,
+    });
+    this.grammarTextEditorState = new GrammarTextEditorState(this.editorStore);
+  }
+
+  async computeEntitiesFromCurrentGrammar(): Promise<Entity[]> {
+    return this.editorStore.graphManagerState.graphManager.pureCodeToEntities(
+      this.grammarTextEditorState.graphGrammarText,
+    );
+  }
+
+  *initialize(isFallback?: boolean): GeneratorFn<void> {
+    this.editorStore.localChangesState = new TextLocalChangesState(
+      this.editorStore,
+      this.editorStore.sdlcState,
+    );
+    this.editorStore.graphState.clearProblems();
+    this.editorStore.changeDetectionState.stop();
+    try {
+      yield flowResult(
+        this.editorStore.changeDetectionState.computeLocalChangesInTextMode(
+          (yield this.computeEntitiesFromCurrentGrammar()) as Entity[],
+        ),
+      );
+    } catch (error) {
+      assertErrorThrown(error);
+      this.editorStore.applicationStore.logService.warn(
+        LogEvent.create(GRAPH_MANAGER_EVENT.PARSING_FAILURE),
+        error,
+      );
+    }
+    if (isFallback) {
+      yield flowResult(
+        this.globalCompile({
+          ignoreBlocking: true,
+          suppressCompilationFailureMessage: true,
+        }),
+      );
+    }
+    // navigate to the currently opened element immediately after entering text mode editor
+    if (
+      this.editorStore.tabManagerState.currentTab instanceof ElementEditorState
+    ) {
+      this.grammarTextEditorState.setCurrentElementLabelRegexString(
+        this.editorStore.tabManagerState.currentTab.element,
+      );
+    }
+  }
+
+  *setGraphGrammarFromEntites(entities: Entity[]): GeneratorFn<void> {
+    const editorGrammar =
+      (yield this.editorStore.graphManagerState.graphManager.entitiesToPureCode(
+        entities,
+      )) as string;
+    yield flowResult(
+      this.grammarTextEditorState.setGraphGrammarText(editorGrammar),
+    );
+  }
+
+  *setGraphGrammar(): GeneratorFn<void> {
+    const graphGrammar =
+      (yield this.editorStore.graphManagerState.graphManager.graphToPureCode(
+        this.editorStore.graphManagerState.graph,
+      )) as string;
+    yield flowResult(
+      this.grammarTextEditorState.setGraphGrammarText(graphGrammar),
+    );
+  }
+
+  *compileText(
+    options?: {
+      onError?: () => void;
+    },
+    report?: GraphManagerOperationReport,
+  ): GeneratorFn<TextCompilationResult> {
+    return (yield this.editorStore.graphManagerState.graphManager.compileText(
+      this.grammarTextEditorState.graphGrammarText,
+      this.editorStore.graphManagerState.graph,
+      options,
+    )) as TextCompilationResult;
+  }
+
+  getCurrentGraphHash(): string {
+    return this.grammarTextEditorState.currentTextGraphHash;
+  }
+
+  *addElement(
+    element: PackageableElement,
+    packagePath: string | undefined,
+    openAfterCreate: boolean,
+  ): GeneratorFn<void> {
+    return;
+  }
+
+  *deleteElement(element: PackageableElement): GeneratorFn<void> {
+    return;
+  }
+
+  *renameElement(
+    element: PackageableElement,
+    newPath: string,
+  ): GeneratorFn<void> {
+    return;
+  }
+
+  get mode(): GRAPH_EDITOR_MODE {
+    return GRAPH_EDITOR_MODE.GRAMMAR_TEXT;
+  }
+
+  /**
+   * Creates a new explorer tree state when compiling in text mode. It resets the explorer state properly
+   * after the new graph is built. It tries to maintain the explorer state similar to what it was before compilation.
+   * To achieve that we store node ids of the opened nodes before creating a new explorer state. After creating a
+   * new state we open the nodes which were opened before so that user see the same explorer state as before.
+   */
+  reprocessExplorerTreeInTextMode(): void {
+    const mainTreeOpenedNodeIds = this.editorStore.explorerTreeState.treeData
+      ? Array.from(this.editorStore.explorerTreeState.treeData.nodes.values())
+          .filter((node) => node.isOpen)
+          .map((node) => node.id)
+      : [];
+    const generationTreeOpenedNodeIds = this.editorStore.explorerTreeState
+      .generationTreeData
+      ? Array.from(
+          this.editorStore.explorerTreeState.generationTreeData.nodes.values(),
+        )
+          .filter((node) => node.isOpen)
+          .map((node) => node.id)
+      : [];
+    // Storing dependencyTree, filegenerationTree, systemTree as is as they don't
+    // hold any reference to actual graph
+    const systemTreeData = this.editorStore.explorerTreeState.systemTreeData;
+    const dependencyTreeData =
+      this.editorStore.explorerTreeState.dependencyTreeData;
+    const selectedNodeId = this.editorStore.explorerTreeState.selectedNode?.id;
+    this.editorStore.explorerTreeState = new ExplorerTreeState(
+      this.editorStore,
+    );
+    this.editorStore.explorerTreeState.systemTreeData = systemTreeData;
+    this.editorStore.explorerTreeState.dependencyTreeData = dependencyTreeData;
+    this.editorStore.explorerTreeState.buildTreeInTextMode();
+    this.editorStore.explorerTreeState.openExplorerTreeNodes(
+      mainTreeOpenedNodeIds,
+      generationTreeOpenedNodeIds,
+      selectedNodeId,
+    );
+  }
+
+  *updateGraphAndApplication(entities: Entity[]): GeneratorFn<void> {
+    const startTime = Date.now();
+    this.editorStore.graphState.isUpdatingApplication = true;
+    this.editorStore.graphState.isUpdatingGraph = true;
+    try {
+      const newGraph = this.editorStore.graphManagerState.createEmptyGraph();
+      yield flowResult(
+        this.editorStore.graphState.rebuildDependencies(newGraph),
+      );
+      yield flowResult(graph_dispose(this.editorStore.graphManagerState.graph));
+
+      const graphBuildState = ActionState.create();
+      yield this.editorStore.graphManagerState.graphManager.buildLightGraph(
+        newGraph,
+        entities,
+        graphBuildState,
+        {
+          TEMPORARY__preserveSectionIndex:
+            this.editorStore.applicationStore.config.options
+              .TEMPORARY__preserveSectionIndex,
+          strict: this.editorStore.graphState.enableStrictMode,
+        },
+      );
+
+      this.editorStore.graphManagerState.graph = newGraph;
+      // NOTE: here we don't want to modify the current graph build state directly
+      // instead, we quietly run this in the background and then sync it with the current build state
+      this.editorStore.graphManagerState.graphBuildState.sync(graphBuildState);
+      this.reprocessExplorerTreeInTextMode();
+
+      this.editorStore.applicationStore.logService.info(
+        LogEvent.create(GRAPH_MANAGER_EVENT.UPDATE_AND_REBUILD_GRAPH__SUCCESS),
+        '[TOTAL]',
+        Date.now() - startTime,
+        'ms',
+      );
+      this.editorStore.graphState.isUpdatingGraph = false;
+    } catch (error) {
+      assertErrorThrown(error);
+      this.editorStore.applicationStore.logService.error(
+        LogEvent.create(GRAPH_MANAGER_EVENT.GRAPH_BUILDER_FAILURE),
+        error,
+      );
+      this.editorStore.graphState.isUpdatingGraph = false;
+      if (error instanceof GraphBuilderError) {
+        this.editorStore.applicationStore.notificationService.notifyError(
+          `Can't build graph: ${error.message}`,
+        );
+      }
+    } finally {
+      this.editorStore.graphState.isUpdatingApplication = false;
+      this.editorStore.applicationStore.alertService.setBlockingAlert(
+        undefined,
+      );
+    }
+  }
+
+  // TODO: when we support showing multiple notifications, we can take this `suppressCompilationFailureMessage` out as
+  // we can show the transition between form mode and text mode warning and the compilation failure warning at the same time
+  *globalCompile(options?: {
+    ignoreBlocking?: boolean | undefined;
+    suppressCompilationFailureMessage?: boolean | undefined;
+    disableNotificationOnSuccess?: boolean | undefined;
+    openConsole?: boolean;
+  }): GeneratorFn<void> {
+    if (
+      !options?.ignoreBlocking &&
+      this.editorStore.graphState.checkIfApplicationUpdateOperationIsRunning()
+    ) {
+      this.editorStore.graphState.setMostRecentCompilationOutcome(
+        GraphCompilationOutcome.SKIPPED,
+      );
+      return;
+    }
+
+    const stopWatch = new StopWatch();
+    const report = reportGraphAnalytics(
+      this.editorStore.graphManagerState.graph,
+    );
+    LegendStudioTelemetryHelper.logEvent_TextCompilationLaunched(
+      this.editorStore.applicationStore.telemetryService,
+    );
+
+    const currentGraphHash = this.getCurrentGraphHash();
+
+    try {
+      this.editorStore.graphState.isRunningGlobalCompile = true;
+      this.editorStore.graphState.clearProblems();
+      if (options?.openConsole) {
+        this.editorStore.setActiveAuxPanelMode(AUX_PANEL_MODE.CONSOLE);
+      }
+
+      const compilationResult = (yield flowResult(
+        this.compileText({}, report),
+      )) as TextCompilationResult;
+
+      const entities = compilationResult.entities;
+      this.editorStore.graphState.setMostRecentCompilationGraphHash(
+        currentGraphHash,
+      );
+      this.editorStore.graphState.warnings = compilationResult.warnings
+        ? this.editorStore.graphState.TEMPORARY__removeDependencyProblems(
+            compilationResult.warnings,
+          )
+        : [];
+
+      if (!options?.disableNotificationOnSuccess) {
+        if (this.editorStore.graphState.warnings.length) {
+          this.editorStore.applicationStore.notificationService.notifyWarning(
+            `Compilation suceeded with warnings`,
+          );
+        } else {
+          if (!options?.disableNotificationOnSuccess) {
+            this.editorStore.applicationStore.notificationService.notifySuccess(
+              'Compiled successfully',
+            );
+          }
+        }
+      }
+
+      yield flowResult(this.updateGraphAndApplication(entities));
+
+      // Remove `SectionIndex when computing changes in text mode as engine after
+      // transforming grammarToJson would return `SectionIndex` which is not
+      // required to do change detection.
+      yield flowResult(
+        this.editorStore.changeDetectionState.computeLocalChangesInTextMode(
+          this.editorStore.graphManagerState.graphManager.getElementEntities(
+            entities,
+          ),
+        ),
+      );
+      this.editorStore.graphState.setMostRecentCompilationOutcome(
+        GraphCompilationOutcome.SUCCEEDED,
+      );
+      report.timings =
+        this.editorStore.applicationStore.timeService.finalizeTimingsRecord(
+          stopWatch,
+          report.timings,
+        );
+      LegendStudioTelemetryHelper.logEvent_TextCompilationSucceeded(
+        this.editorStore.applicationStore.telemetryService,
+        report,
+      );
+    } catch (error) {
+      assertErrorThrown(error);
+      this.editorStore.graphState.setMostRecentCompilationGraphHash(
+        currentGraphHash,
+      );
+      if (error instanceof EngineError) {
+        this.editorStore.graphState.error = error;
+        if (error.sourceInformation) {
+          this.grammarTextEditorState.setForcedCursorPosition({
+            lineNumber: error.sourceInformation.startLine,
+            column: error.sourceInformation.startColumn,
+          });
+        }
+      }
+      if (
+        !this.editorStore.applicationStore.notificationService.notification ||
+        !options?.suppressCompilationFailureMessage
+      ) {
+        this.editorStore.applicationStore.notificationService.notifyWarning(
+          `Compilation failed: ${error.message}`,
+        );
+      }
+      this.editorStore.graphState.setMostRecentCompilationOutcome(
+        GraphCompilationOutcome.FAILED,
+      );
+    } finally {
+      this.editorStore.graphState.isRunningGlobalCompile = false;
+    }
+  }
+
+  goToProblem(problem: Problem): void {
+    // NOTE: in text mode, we allow click to go to position even when the problems might already be stale
+    if (problem.sourceInformation) {
+      this.grammarTextEditorState.setForcedCursorPosition({
+        lineNumber: problem.sourceInformation.startLine,
+        column: problem.sourceInformation.startColumn,
+      });
+    }
+  }
+
+  *onLeave(fallbackOptions?: {
+    isCompilationFailure?: boolean;
+    isGraphBuildFailure?: boolean;
+  }): GeneratorFn<void> {
+    if (!fallbackOptions) {
+      this.editorStore.graphState.isApplicationLeavingGraphEditMode = true;
+      this.editorStore.graphState.clearProblems();
+      this.editorStore.applicationStore.alertService.setBlockingAlert({
+        message: 'Compiling graph before leaving text mode...',
+        showLoading: true,
+      });
+      const compilationResult = (yield flowResult(
+        this.compileText(
+          // surpress the modal to reveal error properly in the text editor
+          // if the blocking modal is not dismissed, the edior will not be able to gain focus as modal has a focus trap
+          // therefore, the editor will not be able to get the focus
+          {
+            onError: () =>
+              this.editorStore.applicationStore.alertService.setBlockingAlert(
+                undefined,
+              ),
+          },
+        ),
+      )) as TextCompilationResult;
+      this.editorStore.graphState.setMostRecentCompilationOutcome(
+        GraphCompilationOutcome.SUCCEEDED,
+      );
+
+      this.editorStore.graphState.warnings = compilationResult.warnings
+        ? this.editorStore.graphState.TEMPORARY__removeDependencyProblems(
+            compilationResult.warnings,
+          )
+        : [];
+      this.editorStore.graphState.compilationResultEntities =
+        compilationResult.entities;
+      this.editorStore.applicationStore.alertService.setBlockingAlert({
+        message: 'Leaving text mode and rebuilding graph...',
+        showLoading: true,
+      });
+    }
+  }
+
+  *handleCleanupFailure(error: unknown): GeneratorFn<void> {
+    assertErrorThrown(error);
+    this.editorStore.graphState.setMostRecentCompilationOutcome(
+      GraphCompilationOutcome.FAILED,
+    );
+    this.editorStore.graphState.setMostRecentCompilationGraphHash(
+      this.getCurrentGraphHash(),
+    );
+    if (error instanceof EngineError && error.sourceInformation) {
+      this.grammarTextEditorState.setForcedCursorPosition({
+        lineNumber: error.sourceInformation.startLine,
+        column: error.sourceInformation.startColumn,
+      });
+    }
+    this.editorStore.applicationStore.logService.error(
+      LogEvent.create(GRAPH_MANAGER_EVENT.COMPILATION_FAILURE),
+      'Compilation failed:',
+      error,
+    );
+    if (this.editorStore.graphManagerState.graphBuildState.hasFailed) {
+      // TODO: when we support showing multiple notification, we can split this into 2 messages
+      this.editorStore.applicationStore.notificationService.notifyWarning(
+        `Can't build graph, please resolve compilation error before leaving text mode. Compilation failed with error: ${error.message}`,
+      );
+    } else {
+      this.editorStore.applicationStore.notificationService.notifyWarning(
+        `Compilation failed: ${error.message}`,
+      );
+      this.editorStore.applicationStore.alertService.setActionAlertInfo({
+        message: 'Project is not in a compiled state',
+        prompt:
+          'All changes made since the last time the graph was built successfully will be lost',
+        type: ActionAlertType.CAUTION,
+        actions: [
+          {
+            label: 'Discard Changes',
+            default: true,
+            type: ActionAlertActionType.PROCEED_WITH_CAUTION,
+            handler: (): void => {
+              flowResult(
+                this.editorStore.switchModes(GRAPH_EDITOR_MODE.FORM, {
+                  isCompilationFailure: true,
+                }),
+              ).catch(this.editorStore.applicationStore.alertUnhandledError);
+            },
+          },
+          {
+            label: 'Stay',
+            default: true,
+            type: ActionAlertActionType.PROCEED,
+          },
+        ],
+      });
+    }
+  }
+
+  *cleanupBeforeEntering(fallbackOptions?: {
+    isCompilationFailure?: boolean;
+    isGraphBuildFailure?: boolean;
+  }): GeneratorFn<void> {
+    if (fallbackOptions?.isGraphBuildFailure) {
+      yield flowResult(
+        this.setGraphGrammarFromEntites(
+          this.editorStore.changeDetectionState
+            .workspaceLocalLatestRevisionState.entities,
+        ),
+      );
+    } else {
+      yield flowResult(this.setGraphGrammar());
+    }
+    this.editorStore.applicationStore.alertService.setBlockingAlert(undefined);
+  }
+
+  openElement(element: PackageableElement): void {
+    // in text mode, we want to select the block of code that corresponds to the element if possible
+    // the cheap way to do this is to search by element label text, e.g. `Mapping some::package::someMapping`
+    this.grammarTextEditorState.setCurrentElementLabelRegexString(element);
+  }
+}

package/src/stores/editor/NewElementState.ts

@@ -22,7 +22,7 @@ import {
   flowResult,
   flow,
 } from 'mobx';
-import type { EditorStore } from '../EditorStore.js';
+import type { EditorStore } from './EditorStore.js';
 import {
   type Clazz,
   type GeneratorFn,
@@ -31,12 +31,12 @@ import {
   UnsupportedOperationError,
   guaranteeNonNullable,
 } from '@finos/legend-shared';
-import { decorateRuntimeWithNewMapping } from '../editor-state/element-editor-state/RuntimeEditorState.js';
+import { decorateRuntimeWithNewMapping } from './editor-state/element-editor-state/RuntimeEditorState.js';
 import type { DSL_LegendStudioApplicationPlugin_Extension } from '../LegendStudioApplicationPlugin.js';
 import {
   type FileGenerationTypeOption,
   DEFAULT_GENERATION_SPECIFICATION_NAME,
-} from '../editor-state/GraphGenerationState.js';
+} from './editor-state/GraphGenerationState.js';
 import {
   type PackageableElement,
   type Runtime,
@@ -75,29 +75,29 @@ import {
   Multiplicity,
   PrimitiveType,
 } from '@finos/legend-graph';
-import type { DSL_Mapping_LegendStudioApplicationPlugin_Extension } from '../DSL_Mapping_LegendStudioApplicationPlugin_Extension.js';
+import type { DSL_Mapping_LegendStudioApplicationPlugin_Extension } from '../extensions/DSL_Mapping_LegendStudioApplicationPlugin_Extension.js';
 import {
   packageableConnection_setConnectionValue,
   runtime_addMapping,
-} from '../shared/modifier/DSL_Mapping_GraphModifierHelper.js';
+} from './shared/modifier/DSL_Mapping_GraphModifierHelper.js';
 import {
   fileGeneration_setScopeElements,
   fileGeneration_setType,
   generationSpecification_addGenerationElement,
-} from '../shared/modifier/DSL_Generation_GraphModifierHelper.js';
+} from './shared/modifier/DSL_Generation_GraphModifierHelper.js';
 import {
   service_initNewService,
   service_setExecution,
-} from '../shared/modifier/DSL_Service_GraphModifierHelper.js';
-import type { EmbeddedDataTypeOption } from '../editor-state/element-editor-state/data/DataEditorState.js';
-import { dataElement_setEmbeddedData } from '../shared/modifier/DSL_Data_GraphModifierHelper.js';
-import { PACKAGEABLE_ELEMENT_TYPE } from '../shared/ModelClassifierUtils.js';
+} from './shared/modifier/DSL_Service_GraphModifierHelper.js';
+import type { EmbeddedDataTypeOption } from './editor-state/element-editor-state/data/DataEditorState.js';
+import { dataElement_setEmbeddedData } from './shared/modifier/DSL_Data_GraphModifierHelper.js';
+import { PACKAGEABLE_ELEMENT_TYPE } from './shared/ModelClassifierUtils.js';
 import {
   buildElementOption,
   type PackageableElementOption,
 } from '@finos/legend-application';
-import { EmbeddedDataType } from '../editor-state/ExternalFormatState.js';
-import { createEmbeddedData } from '../editor-state/element-editor-state/data/EmbeddedDataState.js';
+import { EmbeddedDataType } from './editor-state/ExternalFormatState.js';
+import { createEmbeddedData } from './editor-state/element-editor-state/data/EmbeddedDataState.js';
 
 export const resolvePackageAndElementName = (
   _package: Package,

package/src/stores/editor/StandardEditorMode.ts

@@ -20,7 +20,7 @@ import {
 } from '@finos/legend-server-depot';
 import type { ProjectDependency } from '@finos/legend-server-sdlc';
 import { guaranteeNonNullable } from '@finos/legend-shared';
-import type { EditorStore } from '../EditorStore.js';
+import type { EditorStore } from './EditorStore.js';
 import {
   generateEditorRoute,
   generateViewProjectByGAVRoute,