@finos/legend-application-studio 22.5.0 → 23.0.0

package/src/stores/EditorTabManagerState.ts

@@ -15,13 +15,48 @@
  */
 
 import { TabManagerState } from '@finos/legend-application';
-import { Package, type PackageableElement } from '@finos/legend-graph';
-import { type Clazz, guaranteeType, isNonNullable } from '@finos/legend-shared';
+import {
+  Association,
+  Class,
+  ConcreteFunctionDefinition,
+  Database,
+  DataElement,
+  Enumeration,
+  FileGenerationSpecification,
+  FlatData,
+  GenerationSpecification,
+  Mapping,
+  Measure,
+  PackageableConnection,
+  PackageableRuntime,
+  PrimitiveType,
+  Profile,
+  Service,
+  type PackageableElement,
+} from '@finos/legend-graph';
+import {
+  type Clazz,
+  guaranteeType,
+  isNonNullable,
+  UnsupportedOperationError,
+} from '@finos/legend-shared';
 import { makeObservable, action } from 'mobx';
 import type { EditorState } from './editor-state/EditorState.js';
+import { ClassEditorState } from './editor-state/element-editor-state/ClassEditorState.js';
+import { PackageableConnectionEditorState } from './editor-state/element-editor-state/connection/ConnectionEditorState.js';
+import { PackageableDataEditorState } from './editor-state/element-editor-state/data/DataEditorState.js';
 import { ElementEditorState } from './editor-state/element-editor-state/ElementEditorState.js';
+import { FileGenerationEditorState } from './editor-state/element-editor-state/FileGenerationEditorState.js';
+import { FunctionEditorState } from './editor-state/element-editor-state/FunctionEditorState.js';
+import { MappingEditorState } from './editor-state/element-editor-state/mapping/MappingEditorState.js';
+import { PackageableRuntimeEditorState } from './editor-state/element-editor-state/RuntimeEditorState.js';
+import { ServiceEditorState } from './editor-state/element-editor-state/service/ServiceEditorState.js';
+import { UMLEditorState } from './editor-state/element-editor-state/UMLEditorState.js';
 import { EntityDiffViewerState } from './editor-state/entity-diff-editor-state/EntityDiffEditorState.js';
+import { GenerationSpecificationEditorState } from './editor-state/GenerationSpecificationEditorState.js';
+import { UnsupportedElementEditorState } from './editor-state/UnsupportedElementEditorState.js';
 import type { EditorStore } from './EditorStore.js';
+import type { DSL_LegendStudioApplicationPlugin_Extension } from './LegendStudioApplicationPlugin.js';
 
 export class EditorTabManagerState extends TabManagerState {
   readonly editorStore: EditorStore;
@@ -33,7 +68,6 @@ export class EditorTabManagerState extends TabManagerState {
     super();
 
     makeObservable(this, {
-      openElementEditor: action,
       refreshCurrentEntityDiffViewer: action,
       recoverTabs: action,
     });
@@ -53,29 +87,62 @@ export class EditorTabManagerState extends TabManagerState {
     );
   }
 
-  openElementEditor(element: PackageableElement): void {
-    if (this.editorStore.isInGrammarTextMode) {
-      // in text mode, we want to select the block of code that corresponds to the element if possible
-      // the cheap way to do this is to search by element label text, e.g. `Mapping some::package::someMapping`
-      this.editorStore.grammarTextEditorState.setCurrentElementLabelRegexString(
-        element,
+  createElementEditorState(
+    element: PackageableElement,
+  ): ElementEditorState | undefined {
+    if (element instanceof PrimitiveType) {
+      throw new UnsupportedOperationError(
+        `Can't create element state for primitive type`,
       );
-    } else if (!(element instanceof Package)) {
-      const existingElementState = this.tabs.find(
-        (state) =>
-          state instanceof ElementEditorState && state.element === element,
+    } else if (element instanceof Class) {
+      return new ClassEditorState(this.editorStore, element);
+    } else if (
+      element instanceof Association ||
+      element instanceof Enumeration ||
+      element instanceof Profile
+    ) {
+      return new UMLEditorState(this.editorStore, element);
+    } else if (element instanceof ConcreteFunctionDefinition) {
+      return new FunctionEditorState(this.editorStore, element);
+    } else if (
+      element instanceof Measure ||
+      element instanceof Database ||
+      element instanceof FlatData
+    ) {
+      return new UnsupportedElementEditorState(this.editorStore, element);
+    } else if (element instanceof PackageableRuntime) {
+      return new PackageableRuntimeEditorState(this.editorStore, element);
+    } else if (element instanceof PackageableConnection) {
+      return new PackageableConnectionEditorState(this.editorStore, element);
+    } else if (element instanceof Mapping) {
+      return new MappingEditorState(this.editorStore, element);
+    } else if (element instanceof Service) {
+      return new ServiceEditorState(this.editorStore, element);
+    } else if (element instanceof GenerationSpecification) {
+      return new GenerationSpecificationEditorState(this.editorStore, element);
+    } else if (element instanceof FileGenerationSpecification) {
+      return new FileGenerationEditorState(this.editorStore, element);
+    } else if (element instanceof DataElement) {
+      return new PackageableDataEditorState(this.editorStore, element);
+    }
+    const extraElementEditorStateCreators = this.editorStore.pluginManager
+      .getApplicationPlugins()
+      .flatMap(
+        (plugin) =>
+          (
+            plugin as DSL_LegendStudioApplicationPlugin_Extension
+          ).getExtraElementEditorStateCreators?.() ?? [],
       );
-      const newTab =
-        existingElementState ??
-        this.editorStore.createElementEditorState(element);
-      if (newTab) {
-        this.openTab(newTab);
-      } else {
-        this.editorStore.applicationStore.notificationService.notifyWarning(
-          `Can't open editor for element '${element.path}'`,
-        );
+    for (const creator of extraElementEditorStateCreators) {
+      const elementEditorState = creator(this.editorStore, element);
+      if (elementEditorState) {
+        return elementEditorState;
       }
     }
+    throw new UnsupportedOperationError(
+      `Can't create editor state for element: no compatible editor state creator available from plugins`,
+      element,
+    );
   }
 
   refreshCurrentEntityDiffViewer(): void {
@@ -109,9 +176,7 @@ export class EditorTabManagerState extends TabManagerState {
             editorPath,
           );
         if (correspondingElement) {
-          return this.editorStore.createElementEditorState(
-            correspondingElement,
-          );
+          return this.createElementEditorState(correspondingElement);
         }
         return undefined;
       })

package/src/stores/EmbeddedQueryBuilderState.ts

@@ -16,11 +16,12 @@
 
 import {
   type QueryBuilderState,
-  QUERY_BUILDER_BACKDROP_CONTAINER_ID,
+  QUERY_BUILDER_COMPONENT_ELEMENT_ID,
 } from '@finos/legend-query-builder';
 import type { GeneratorFn } from '@finos/legend-shared';
 import { flow, flowResult, makeObservable, observable } from 'mobx';
-import { FormModeCompilationOutcome } from './EditorGraphState.js';
+import { GRAPH_EDITOR_MODE } from './EditorConfig.js';
+import { GraphCompilationOutcome } from './EditorGraphState.js';
 import type { EditorStore } from './EditorStore.js';
 
 type EmbeddedQueryBuilderActionConfiguration = {
@@ -32,7 +33,6 @@ type EmbeddedQueryBuilderConfiguration = {
   setupQueryBuilderState: () => QueryBuilderState;
   disableCompile?: boolean | undefined;
   actionConfigs: EmbeddedQueryBuilderActionConfiguration[];
-  applicationContext: string;
 };
 
 export class EmbeddedQueryBuilderState {
@@ -57,7 +57,7 @@ export class EmbeddedQueryBuilderState {
     config: EmbeddedQueryBuilderConfiguration | undefined,
   ): GeneratorFn<void> {
     if (config) {
-      if (!this.editorStore.isInFormMode) {
+      if (this.editorStore.graphEditorMode.mode !== GRAPH_EDITOR_MODE.FORM) {
         return;
       }
       if (!config.disableCompile) {
@@ -65,15 +65,15 @@ export class EmbeddedQueryBuilderState {
           message: 'Compiling graph before building query...',
           showLoading: true,
         });
-        const compilationOutcome = (yield flowResult(
-          this.editorStore.graphState.globalCompileInFormMode({
+        yield flowResult(
+          this.editorStore.graphEditorMode.globalCompile({
             // we don't want to notify about compilation success since this is just a simple check
             // in order to be able to open query builder
             disableNotificationOnSuccess: true,
           }),
-        )) as FormModeCompilationOutcome;
-        switch (compilationOutcome) {
-          case FormModeCompilationOutcome.SKIPPED: {
+        );
+        switch (this.editorStore.graphState.mostRecentCompilationOutcome) {
+          case GraphCompilationOutcome.SKIPPED: {
             this.editorStore.applicationStore.alertService.setBlockingAlert(
               undefined,
             );
@@ -82,7 +82,7 @@ export class EmbeddedQueryBuilderState {
             );
             return;
           }
-          case FormModeCompilationOutcome.SUCCEEDED: {
+          case GraphCompilationOutcome.SUCCEEDED: {
             this.editorStore.applicationStore.alertService.setBlockingAlert(
               undefined,
             );
@@ -103,7 +103,7 @@ export class EmbeddedQueryBuilderState {
         this.queryBuilderState = config.setupQueryBuilderState();
         this.actionConfigs = config.actionConfigs;
         this.editorStore.applicationStore.layoutService.setBackdropContainerElementID(
-          QUERY_BUILDER_BACKDROP_CONTAINER_ID,
+          QUERY_BUILDER_COMPONENT_ELEMENT_ID.BACKDROP_CONTAINER,
         );
       }
     } else {

package/src/stores/ExplorerTreeState.ts

@@ -32,7 +32,7 @@ import {
   openNodes,
   populatePackageTreeNodeChildren,
 } from './shared/PackageTreeUtils.js';
-import { LEGEND_STUDIO_APP_EVENT } from './LegendStudioAppEvent.js';
+import { LEGEND_STUDIO_APP_EVENT } from '../application/LegendStudioEvent.js';
 import type { PackageTreeNodeData } from './shared/TreeUtils.js';
 import type { TreeData } from '@finos/legend-art';
 import {
@@ -449,9 +449,7 @@ export class ExplorerTreeState {
   ): void => {
     // Open non-package element
     if (!(node.packageableElement instanceof Package)) {
-      this.editorStore.tabManagerState.openElementEditor(
-        node.packageableElement,
-      );
+      this.editorStore.graphEditorMode.openElement(node.packageableElement);
     }
     // Expand package element
     if (node.childrenIds?.length) {