@finos/legend-application-studio 20.1.2 → 20.2.0

package/src/stores/editor-state/element-editor-state/service/testable/ServiceTestEditorState.ts

@@ -23,11 +23,13 @@ import {
   ParameterValue,
   buildLambdaVariableExpressions,
   VariableExpression,
+  PureMultiExecution,
 } from '@finos/legend-graph';
 import { action, flow, makeObservable, observable } from 'mobx';
 import { TestableTestEditorState } from '../../testable/TestableEditorState.js';
 import type { ServiceTestSuiteState } from './ServiceTestableState.js';
 import {
+  service_addAssertKeyForTest,
   service_addParameterValue,
   service_deleteParameterValue,
   service_setParameterName,
@@ -77,6 +79,11 @@ export type SerializationFormatOption = {
   label: string;
 };
 
+export type KeyOption = {
+  value: string;
+  label: string;
+};
+
 export class ServiceTestParameterState {
   readonly uuid = uuid();
   readonly editorStore: EditorStore;
@@ -167,6 +174,7 @@ export class ServiceTestSetupState {
       setShowNewParameterModal: action,
       openNewParamModal: action,
       addParameterValue: action,
+      addServiceTestAssertKeys: action,
       syncWithQuery: action,
       removeParamValueState: action,
     });
@@ -193,6 +201,30 @@ export class ServiceTestSetupState {
     }));
   }
 
+  get keyOptions(): KeyOption[] {
+    const keys =
+      this.testState.testable.execution instanceof PureMultiExecution
+        ? this.testState.testable.execution.executionParameters.map(
+            (p) => p.key,
+          )
+        : [];
+    return keys.map((k) => ({
+      value: k,
+      label: k,
+    }));
+  }
+
+  getSelectedKeyOptions(): KeyOption[] {
+    return this.testState.test.keys.map((k) => ({
+      value: k,
+      label: k,
+    }));
+  }
+
+  addServiceTestAssertKeys(val: string[]): void {
+    service_addAssertKeyForTest(this.testState.test, val);
+  }
+
   get newParamOptions(): { value: string; label: string }[] {
     const queryVarExpressions = this.queryVariableExpressions;
     const currentParams = this.testState.test.parameters;

package/src/stores/editor-state/entity-diff-editor-state/EntityChangeConflictEditorState.ts

@@ -25,7 +25,7 @@ import {
 import type { EditorStore } from '../../EditorStore.js';
 import {
   type SPECIAL_REVISION_ALIAS,
-  EntityDiffEditorState,
+  EntityDiffViewerState,
 } from './EntityDiffEditorState.js';
 import {
   type GeneratorFn,
@@ -37,6 +37,7 @@ import { type Entity, extractEntityNameFromPath } from '@finos/legend-storage';
 import { EntityChangeConflictResolution } from '@finos/legend-server-sdlc';
 import { ParserError } from '@finos/legend-graph';
 import type { AbstractConflictResolutionState } from '../../AbstractConflictResolutionState.js';
+import type { EditorState } from '../EditorState.js';
 
 const START_HEADER_MARKER = '<<<<<<<';
 const COMMON_BASE_MARKER = '|||||||';
@@ -127,7 +128,7 @@ export enum ENTITY_CHANGE_CONFLICT_EDITOR_VIEW_MODE {
   CURRENT_INCOMING = 'CURRENT_INCOMING',
 }
 
-export class EntityChangeConflictEditorState extends EntityDiffEditorState {
+export class EntityChangeConflictEditorState extends EntityDiffViewerState {
   entityPath: string;
   // revision
   baseRevision: SPECIAL_REVISION_ALIAS | string;
@@ -207,7 +208,7 @@ export class EntityChangeConflictEditorState extends EntityDiffEditorState {
       currentMergeEditorLine: observable,
       mergeEditorParserError: observable,
       currentMode: observable,
-      headerName: computed,
+      label: computed,
       sortedMergedConflicts: computed,
       canUseTheirs: computed,
       canUseYours: computed,
@@ -253,18 +254,23 @@ export class EntityChangeConflictEditorState extends EntityDiffEditorState {
   setReadOnly(val: boolean): void {
     this.isReadOnly = val;
   }
+
   setMergedText(val: string): void {
     this.mergedText = val;
   }
+
   setCurrentMode(mode: ENTITY_CHANGE_CONFLICT_EDITOR_VIEW_MODE): void {
     this.currentMode = mode;
   }
+
   setCurrentMergeEditorLine(val: number | undefined): void {
     this.currentMergeEditorLine = val;
   }
+
   setCurrentMergeEditorConflict(conflict: MergeConflict | undefined): void {
     this.currentMergeEditorConflict = conflict;
   }
+
   clearMergeEditorError(): void {
     this.mergeEditorParserError = undefined;
   }
@@ -275,24 +281,28 @@ export class EntityChangeConflictEditorState extends EntityDiffEditorState {
     }
   }
 
-  get headerName(): string {
+  get label(): string {
     return extractEntityNameFromPath(this.entityPath);
   }
+
   private get sortedMergedConflicts(): MergeConflict[] {
     return this.mergeConflicts
       .slice()
       .sort((a, b) => a.startHeader - b.startHeader);
   }
+
   get canUseTheirs(): boolean {
     return (
       this.currentMode !== ENTITY_CHANGE_CONFLICT_EDITOR_VIEW_MODE.BASE_CURRENT
     );
   }
+
   get canUseYours(): boolean {
     return (
       this.currentMode !== ENTITY_CHANGE_CONFLICT_EDITOR_VIEW_MODE.BASE_INCOMING
     );
   }
+
   get canMarkAsResolved(): boolean {
     return Boolean(
       !this.mergeConflicts.length &&
@@ -318,6 +328,13 @@ export class EntityChangeConflictEditorState extends EntityDiffEditorState {
     );
   }
 
+  match(tab: EditorState): boolean {
+    return (
+      tab instanceof EntityChangeConflictEditorState &&
+      tab.entityPath === this.entityPath
+    );
+  }
+
   getModeComparisonViewInfo(
     mode: ENTITY_CHANGE_CONFLICT_EDITOR_VIEW_MODE,
   ): MergeEditorComparisonViewInfo {

package/src/stores/editor-state/entity-diff-editor-state/EntityDiffEditorState.ts

@@ -43,6 +43,6 @@ export const getPrettyLabelForRevision = (
   }
 };
 
-export abstract class EntityDiffEditorState extends EditorState {
+export abstract class EntityDiffViewerState extends EditorState {
   abstract refresh(): void;
 }

package/src/stores/editor-state/entity-diff-editor-state/EntityDiffViewState.ts

@@ -26,11 +26,12 @@ import {
 import type { EditorStore } from '../../EditorStore.js';
 import {
   type SPECIAL_REVISION_ALIAS,
-  EntityDiffEditorState,
+  EntityDiffViewerState,
 } from './EntityDiffEditorState.js';
 import { type Entity, extractEntityNameFromPath } from '@finos/legend-storage';
 import { LEGEND_STUDIO_APP_EVENT } from '../../LegendStudioAppEvent.js';
 import type { PackageableElement } from '@finos/legend-graph';
+import type { EditorState } from '../EditorState.js';
 
 /**
  * NOTE: when we support comparison between entities, we should create a new editor state
@@ -44,7 +45,7 @@ export enum DIFF_VIEW_MODE {
   GRAMMAR = 'Grammar',
 }
 
-export class EntityDiffViewState extends EntityDiffEditorState {
+export class EntityDiffViewState extends EntityDiffViewerState {
   diffMode = DIFF_VIEW_MODE.GRAMMAR;
   fromEntityPath?: string | undefined;
   toEntityPath?: string | undefined;
@@ -93,8 +94,8 @@ export class EntityDiffViewState extends EntityDiffEditorState {
       toEntityGetter: observable,
       effectiveEntityPath: computed,
       element: computed,
-      headerName: computed,
-      headerTooltip: computed,
+      label: computed,
+      description: computed,
       summaryText: computed,
       setDiffMode: action,
       setToGrammarText: action,
@@ -133,15 +134,18 @@ export class EntityDiffViewState extends EntityDiffEditorState {
       'Neither from nor to entity paths can be missing',
     );
   }
+
   get element(): PackageableElement | undefined {
     return this.editorStore.graphManagerState.graph.getNullableElement(
       this.effectiveEntityPath,
     );
   }
-  get headerName(): string {
+
+  get label(): string {
     return extractEntityNameFromPath(this.effectiveEntityPath);
   }
-  get headerTooltip(): string {
+
+  override get description(): string {
     return this.effectiveEntityPath;
   }
 
@@ -161,15 +165,27 @@ export class EntityDiffViewState extends EntityDiffEditorState {
     return `Entity '${this.toEntityPath}' is modified`;
   }
 
-  setDiffMode = (diffMode: DIFF_VIEW_MODE): void => {
+  setDiffMode(diffMode: DIFF_VIEW_MODE): void {
     this.diffMode = diffMode;
-  };
-  private setToGrammarText = (text: string): void => {
+  }
+
+  private setToGrammarText(text: string): void {
     this.toGrammarText = text;
-  };
-  private setFromGrammarText = (text: string): void => {
+  }
+
+  private setFromGrammarText(text: string): void {
     this.fromGrammarText = text;
-  };
+  }
+
+  match(tab: EditorState): boolean {
+    return (
+      tab instanceof EntityDiffViewState &&
+      tab.fromEntityPath === this.fromEntityPath &&
+      tab.toEntityPath === this.toEntityPath &&
+      tab.fromRevision === this.fromRevision &&
+      tab.toRevision === this.toRevision
+    );
+  }
 
   refresh(): void {
     this.fromEntity = this.fromEntityGetter

package/src/stores/project-viewer/ProjectViewerStore.ts

@@ -560,7 +560,7 @@ export class ProjectViewerStore {
         this.initialEntityPath
       ) {
         try {
-          this.editorStore.openElement(
+          this.editorStore.tabManagerState.openElementEditor(
             this.editorStore.graphManagerState.graph.getElement(
               this.initialEntityPath,
             ),

package/src/stores/shared/DnDUtils.ts

@@ -58,7 +58,7 @@ export enum CORE_DND_TYPE {
 // See https://github.com/react-dnd/react-dnd/issues/1094
 // See https://github.com/react-dnd/react-dnd/pull/1079
 export class TypeDragSource {
-  data: TypeTreeNodeData;
+  data: TypeTreeNodeData | undefined;
 
   constructor(data: TypeTreeNodeData) {
     this.data = data;

package/src/stores/shared/modifier/DSL_Service_GraphModifierHelper.ts

@@ -87,6 +87,12 @@ export const service_setSerializationFormat = action(
   },
 );
 
+export const service_addAssertKeyForTest = action(
+  (test: ServiceTest, keys: string[]) => {
+    test.keys = keys;
+  },
+);
+
 export const service_addTestSuite = action(
   (
     service: Service,

package/src/stores/sidebar-state/LocalChangesState.ts

@@ -288,7 +288,7 @@ export class LocalChangesState {
           `Can't find entity with path  '${diff.newPath}'`,
         )
       : undefined;
-    this.editorStore.openEntityDiff(
+    this.editorStore.tabManagerState.openTab(
       new EntityDiffViewState(
         this.editorStore,
         SPECIAL_REVISION_ALIAS.WORKSPACE_HEAD,
@@ -336,7 +336,7 @@ export class LocalChangesState {
           `Can't find entity with path  '${diff.newPath}'`,
         )
       : undefined;
-    this.editorStore.openEntityDiff(
+    this.editorStore.tabManagerState.openTab(
       new EntityDiffViewState(
         this.editorStore,
         SPECIAL_REVISION_ALIAS.LOCAL,
@@ -395,7 +395,7 @@ export class LocalChangesState {
       incomingChangeEntityGetter,
     );
     conflictEditorState.setReadOnly(true);
-    this.editorStore.openEntityChangeConflict(conflictEditorState);
+    this.editorStore.tabManagerState.openTab(conflictEditorState);
   }
 
   *refreshLocalChanges(): GeneratorFn<void> {
@@ -636,7 +636,7 @@ export class LocalChangesState {
             ),
           ),
         );
-        this.editorStore.refreshCurrentEntityDiffEditorState();
+        this.editorStore.tabManagerState.refreshCurrentEntityDiffViewer();
       } catch (error) {
         assertErrorThrown(error);
         /**

package/src/stores/sidebar-state/WorkspaceReviewState.ts

@@ -117,7 +117,7 @@ export class WorkspaceReviewState {
           `Can't find entity with path  '${diff.newPath}'`,
         )
       : undefined;
-    this.editorStore.openEntityDiff(
+    this.editorStore.tabManagerState.openTab(
       new EntityDiffViewState(
         this.editorStore,
         SPECIAL_REVISION_ALIAS.WORKSPACE_BASE,

package/src/stores/sidebar-state/WorkspaceSyncState.ts

@@ -33,7 +33,7 @@ import {
 import { CHANGE_DETECTION_EVENT } from '../ChangeDetectionEvent.js';
 import { EntityChangeConflictEditorState } from '../editor-state/entity-diff-editor-state/EntityChangeConflictEditorState.js';
 import {
-  type EntityDiffEditorState,
+  type EntityDiffViewerState,
   SPECIAL_REVISION_ALIAS,
 } from '../editor-state/entity-diff-editor-state/EntityDiffEditorState.js';
 import { EntityDiffViewState } from '../editor-state/entity-diff-editor-state/EntityDiffViewState.js';
@@ -55,8 +55,8 @@ import { AbstractConflictResolutionState } from '../AbstractConflictResolutionSt
 class WorkspaceSyncConflictResolutionState extends AbstractConflictResolutionState {
   showModal = false;
   conflicts: EntityChangeConflict[] = [];
-  openMergedEditorStates: EntityDiffEditorState[] = [];
-  currentDiffEditorState: EntityDiffEditorState | undefined;
+  openMergedEditorStates: EntityDiffViewerState[] = [];
+  currentDiffEditorState: EntityDiffViewerState | undefined;
   resolutions: EntityChangeConflictResolution[] = [];
   baseToLocalChanges: EntityDiff[] = [];
 
@@ -154,7 +154,7 @@ class WorkspaceSyncConflictResolutionState extends AbstractConflictResolutionSta
       .concat(this.resolvedChanges);
   }
 
-  openState(entityDiffEditorState: EntityDiffEditorState): void {
+  openState(entityDiffEditorState: EntityDiffViewerState): void {
     if (entityDiffEditorState instanceof EntityChangeConflictEditorState) {
       this.openConflictState(entityDiffEditorState);
     }
@@ -207,7 +207,7 @@ class WorkspaceSyncConflictResolutionState extends AbstractConflictResolutionSta
     this.openEntityChangeConflict(mergeEditorState);
   }
 
-  closeConflict(conflictState: EntityDiffEditorState): void {
+  closeConflict(conflictState: EntityDiffViewerState): void {
     const conflictIndex = this.openMergedEditorStates.findIndex(
       (e) => e === conflictState,
     );
@@ -328,7 +328,7 @@ class WorkspaceSyncConflictResolutionState extends AbstractConflictResolutionSta
     this.showModal = val;
   }
 
-  setCurrentMergeEditorState(val: EntityDiffEditorState | undefined): void {
+  setCurrentMergeEditorState(val: EntityDiffViewerState | undefined): void {
     this.currentDiffEditorState = val;
   }
 

package/src/stores/sidebar-state/WorkspaceUpdateConflictResolutionState.ts

@@ -157,7 +157,7 @@ export class WorkspaceUpdateConflictResolutionState extends AbstractConflictReso
       (state) => state.entityPath === conflict.entityPath,
     );
     if (existingMergeEditorState) {
-      this.editorStore.openEntityChangeConflict(existingMergeEditorState);
+      this.editorStore.tabManagerState.openTab(existingMergeEditorState);
       return;
     }
     const baseEntityGetter = (
@@ -199,11 +199,11 @@ export class WorkspaceUpdateConflictResolutionState extends AbstractConflictReso
       incomingChangeEntityGetter,
     );
     this.mergeEditorStates.push(mergeEditorState);
-    this.editorStore.openEntityChangeConflict(mergeEditorState);
+    this.editorStore.tabManagerState.openTab(mergeEditorState);
   }
 
   closeConflict(conflict: EntityChangeConflictEditorState): void {
-    this.editorStore.closeState(conflict);
+    this.editorStore.tabManagerState.closeTab(conflict);
   }
 
   resolveConflict(resolution: EntityChangeConflictResolution): void {
@@ -319,7 +319,7 @@ export class WorkspaceUpdateConflictResolutionState extends AbstractConflictReso
         this.hasResolvedAllConflicts,
       'Editor must be in conflict resolution mode and all conflicts must have been marked as resolved to call this method',
     );
-    this.editorStore.closeAllEditorTabs();
+    this.editorStore.tabManagerState.closeAllTabs();
     this.editorStore.setActiveActivity(ACTIVITY_MODE.EXPLORER, {
       keepShowingIfMatchedCurrent: true,
     });
@@ -412,7 +412,7 @@ export class WorkspaceUpdateConflictResolutionState extends AbstractConflictReso
           ),
         ),
       );
-      this.editorStore.refreshCurrentEntityDiffEditorState();
+      this.editorStore.tabManagerState.refreshCurrentEntityDiffViewer();
     } catch (error) {
       assertErrorThrown(error);
       this.editorStore.applicationStore.log.error(
@@ -446,7 +446,7 @@ export class WorkspaceUpdateConflictResolutionState extends AbstractConflictReso
           ),
         ),
       );
-      this.editorStore.refreshCurrentEntityDiffEditorState();
+      this.editorStore.tabManagerState.refreshCurrentEntityDiffViewer();
     } catch (error) {
       assertErrorThrown(error);
       this.editorStore.applicationStore.log.error(
@@ -698,7 +698,7 @@ export class WorkspaceUpdateConflictResolutionState extends AbstractConflictReso
           `Can't find entity with path  '${diff.newPath}'`,
         )
       : undefined;
-    this.editorStore.openEntityDiff(
+    this.editorStore.tabManagerState.openTab(
       new EntityDiffViewState(
         this.editorStore,
         SPECIAL_REVISION_ALIAS.WORKSPACE_BASE,

package/src/stores/sidebar-state/WorkspaceUpdaterState.ts

@@ -97,7 +97,7 @@ export class WorkspaceUpdaterState {
           `Can't find entity with path  '${diff.newPath}'`,
         )
       : undefined;
-    this.editorStore.openEntityDiff(
+    this.editorStore.tabManagerState.openTab(
       new EntityDiffViewState(
         this.editorStore,
         SPECIAL_REVISION_ALIAS.WORKSPACE_BASE,
@@ -152,7 +152,7 @@ export class WorkspaceUpdaterState {
       incomingChangeEntityGetter,
     );
     conflictEditorState.setReadOnly(true);
-    this.editorStore.openEntityChangeConflict(conflictEditorState);
+    this.editorStore.tabManagerState.openTab(conflictEditorState);
   }
 
   *refreshWorkspaceUpdater(): GeneratorFn<void> {

package/tsconfig.json

@@ -51,6 +51,7 @@
     "./src/stores/EditorSDLCState.ts",
     "./src/stores/EditorStore.ts",
     "./src/stores/EditorStoreTestUtils.ts",
+    "./src/stores/EditorTabManagerState.ts",
     "./src/stores/EmbeddedQueryBuilderState.ts",
     "./src/stores/ExplorerTreeState.ts",
     "./src/stores/LegendStudioAppEvent.ts",
@@ -98,6 +99,7 @@
     "./src/stores/editor-state/element-editor-state/mapping/MappingElementState.ts",
     "./src/stores/editor-state/element-editor-state/mapping/MappingExecutionQueryBuilderState.ts",
     "./src/stores/editor-state/element-editor-state/mapping/MappingExecutionState.ts",
+    "./src/stores/editor-state/element-editor-state/mapping/MappingTabManagerState.ts",
     "./src/stores/editor-state/element-editor-state/mapping/MappingTestState.ts",
     "./src/stores/editor-state/element-editor-state/mapping/PureInstanceSetImplementationState.ts",
     "./src/stores/editor-state/element-editor-state/mapping/UnsupportedInstanceSetImplementationState.ts",