@finos/legend-application-studio 20.0.10 → 20.1.1

package/src/stores/editor-state/element-editor-state/service/testable/ServiceTestEditorState.ts

@@ -23,11 +23,13 @@ import {
   ParameterValue,
   buildLambdaVariableExpressions,
   VariableExpression,
+  PureMultiExecution,
 } from '@finos/legend-graph';
 import { action, flow, makeObservable, observable } from 'mobx';
 import { TestableTestEditorState } from '../../testable/TestableEditorState.js';
 import type { ServiceTestSuiteState } from './ServiceTestableState.js';
 import {
+  service_addAssertKeyForTest,
   service_addParameterValue,
   service_deleteParameterValue,
   service_setParameterName,
@@ -77,6 +79,11 @@ export type SerializationFormatOption = {
   label: string;
 };
 
+export type KeyOption = {
+  value: string;
+  label: string;
+};
+
 export class ServiceTestParameterState {
   readonly uuid = uuid();
   readonly editorStore: EditorStore;
@@ -167,6 +174,7 @@ export class ServiceTestSetupState {
       setShowNewParameterModal: action,
       openNewParamModal: action,
       addParameterValue: action,
+      addServiceTestAssertKeys: action,
       syncWithQuery: action,
       removeParamValueState: action,
     });
@@ -193,6 +201,30 @@ export class ServiceTestSetupState {
     }));
   }
 
+  get keyOptions(): KeyOption[] {
+    const keys =
+      this.testState.testable.execution instanceof PureMultiExecution
+        ? this.testState.testable.execution.executionParameters.map(
+            (p) => p.key,
+          )
+        : [];
+    return keys.map((k) => ({
+      value: k,
+      label: k,
+    }));
+  }
+
+  getSelectedKeyOptions(): KeyOption[] {
+    return this.testState.test.keys.map((k) => ({
+      value: k,
+      label: k,
+    }));
+  }
+
+  addServiceTestAssertKeys(val: string[]): void {
+    service_addAssertKeyForTest(this.testState.test, val);
+  }
+
   get newParamOptions(): { value: string; label: string }[] {
     const queryVarExpressions = this.queryVariableExpressions;
     const currentParams = this.testState.test.parameters;

package/src/stores/shared/modifier/DSL_Service_GraphModifierHelper.ts

@@ -87,6 +87,12 @@ export const service_setSerializationFormat = action(
   },
 );
 
+export const service_addAssertKeyForTest = action(
+  (test: ServiceTest, keys: string[]) => {
+    test.keys = keys;
+  },
+);
+
 export const service_addTestSuite = action(
   (
     service: Service,

package/src/stores/workspace-setup/ProjectConfigurationStatus.ts

@@ -0,0 +1,62 @@
+/**
+ * Copyright (c) 2020-present, Goldman Sachs
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import type { GenericLegendApplicationStore } from '@finos/legend-application';
+import {
+  ProjectConfigurationStatusReport,
+  Review,
+  type SDLCServerClient,
+} from '@finos/legend-server-sdlc';
+import { guaranteeNonNullable } from '@finos/legend-shared';
+
+export class ProjectConfigurationStatus {
+  projectId!: string;
+  isConfigured = false;
+  reviewUrl?: string | undefined;
+  seenReview = false;
+}
+
+export const fetchProjectConfigurationStatus = async (
+  projectId: string,
+  applicationStore: GenericLegendApplicationStore,
+  sdlcServerClient: SDLCServerClient,
+): Promise<ProjectConfigurationStatus> => {
+  const status = ProjectConfigurationStatusReport.serialization.fromJson(
+    await sdlcServerClient.projectConfigurationStatus(projectId),
+  );
+  const result = new ProjectConfigurationStatus();
+  result.projectId = projectId;
+  result.isConfigured = status.projectConfigured;
+  if (status.reviewIds.length) {
+    try {
+      const review = Review.serialization.fromJson(
+        await sdlcServerClient.getReview(
+          projectId,
+          guaranteeNonNullable(status.reviewIds[0]),
+        ),
+      );
+      result.reviewUrl = review.webURL;
+    } catch {
+      // do nothing
+    }
+  }
+  if (!status.projectConfigured) {
+    applicationStore.notifyWarning(
+      `Project is not configured: please check and commit the project setup review`,
+    );
+  }
+  return result;
+};

package/src/stores/workspace-setup/WorkspaceSetupStore.ts

@@ -38,6 +38,10 @@ import {
   DEFAULT_TYPEAHEAD_SEARCH_LIMIT,
   DEFAULT_TYPEAHEAD_SEARCH_MINIMUM_SEARCH_LENGTH,
 } from '@finos/legend-application';
+import {
+  fetchProjectConfigurationStatus,
+  type ProjectConfigurationStatus,
+} from './ProjectConfigurationStatus.js';
 
 interface ImportProjectSuccessReport {
   projectId: string;
@@ -52,6 +56,7 @@ export class WorkspaceSetupStore {
 
   projects: Project[] = [];
   currentProject?: Project | undefined;
+  currentProjectConfigurationStatus?: ProjectConfigurationStatus | undefined;
   loadProjectsState = ActionState.create();
   createOrImportProjectState = ActionState.create();
   importProjectSuccessReport?: ImportProjectSuccessReport | undefined;
@@ -70,6 +75,7 @@ export class WorkspaceSetupStore {
     makeObservable(this, {
       projects: observable,
       currentProject: observable,
+      currentProjectConfigurationStatus: observable,
       importProjectSuccessReport: observable,
       showCreateProjectModal: observable,
       workspaces: observable,
@@ -114,6 +120,7 @@ export class WorkspaceSetupStore {
     this.applicationStore.navigator.updateCurrentLocation(
       generateSetupRoute(undefined, undefined, undefined),
     );
+    this.currentProjectConfigurationStatus = undefined;
   }
 
   resetWorkspace(): void {
@@ -208,10 +215,17 @@ export class WorkspaceSetupStore {
         }
       | undefined,
   ): GeneratorFn<void> {
+    this.currentProject = project;
+    this.currentProjectConfigurationStatus = undefined;
     this.loadWorkspacesState.inProgress();
 
     try {
-      this.currentProject = project;
+      this.currentProjectConfigurationStatus =
+        (yield fetchProjectConfigurationStatus(
+          project.projectId,
+          this.applicationStore,
+          this.sdlcServerClient,
+        )) as ProjectConfigurationStatus;
 
       const workspacesInConflictResolutionIds = (
         (yield this.sdlcServerClient.getWorkspacesInConflictResolutionMode(

package/tsconfig.json

@@ -143,6 +143,7 @@
     "./src/stores/sidebar-state/WorkspaceUpdaterState.ts",
     "./src/stores/sidebar-state/testable/GlobalTestRunnerState.ts",
     "./src/stores/workspace-review/WorkspaceReviewStore.ts",
+    "./src/stores/workspace-setup/ProjectConfigurationStatus.ts",
     "./src/stores/workspace-setup/WorkspaceSetupStore.ts",
     "./src/application/LegendStudio.tsx",
     "./src/components/Core_LegendStudioApplicationPlugin.tsx",