@finos/legend-application-studio 19.1.0 → 20.0.1

package/src/stores/EditorSDLCState.ts

@@ -14,7 +14,14 @@
  * limitations under the License.
  */
 
-import { action, flowResult, makeAutoObservable } from 'mobx';
+import {
+  action,
+  computed,
+  flow,
+  flowResult,
+  makeObservable,
+  observable,
+} from 'mobx';
 import type { EditorStore } from './EditorStore.js';
 import {
   type PlainObject,
@@ -48,7 +55,8 @@ export const entityDiffSorter = (a: EntityDiff, b: EntityDiff): number =>
   );
 
 export class EditorSDLCState {
-  editorStore: EditorStore;
+  readonly editorStore: EditorStore;
+
   currentProject?: Project | undefined;
   currentWorkspace?: Workspace | undefined;
   remoteWorkspaceRevision?: Revision | undefined;
@@ -61,12 +69,37 @@ export class EditorSDLCState {
   isFetchingProject = false;
 
   constructor(editorStore: EditorStore) {
-    makeAutoObservable(this, {
-      editorStore: false,
+    makeObservable(this, {
+      currentProject: observable,
+      currentWorkspace: observable,
+      remoteWorkspaceRevision: observable,
+      currentRevision: observable,
+      isWorkspaceOutdated: observable,
+      workspaceWorkflows: observable,
+      projectVersions: observable,
+      isCheckingIfWorkspaceIsOutdated: observable,
+      isFetchingProjectVersions: observable,
+      isFetchingProject: observable,
+      activeProject: computed,
+      activeWorkspace: computed,
+      activeRevision: computed,
+      activeRemoteWorkspaceRevision: computed,
+      isWorkspaceOutOfSync: computed,
       setCurrentProject: action,
       setCurrentWorkspace: action,
       setCurrentRevision: action,
       setWorkspaceLatestRevision: action,
+      fetchCurrentProject: flow,
+      fetchCurrentWorkspace: flow,
+      fetchProjectVersions: flow,
+      checkIfCurrentWorkspaceIsInConflictResolutionMode: flow,
+      fetchRemoteWorkspaceRevision: flow,
+      fetchCurrentRevision: flow,
+      checkIfWorkspaceIsOutdated: flow,
+      buildWorkspaceLatestRevisionEntityHashesIndex: flow,
+      buildWorkspaceBaseRevisionEntityHashesIndex: flow,
+      buildProjectLatestRevisionEntityHashesIndex: flow,
+      fetchWorkspaceWorkflows: flow,
     });
 
     this.editorStore = editorStore;
@@ -104,19 +137,39 @@ export class EditorSDLCState {
     return this.activeRemoteWorkspaceRevision.id !== this.activeRevision.id;
   }
 
-  setCurrentProject = (val: Project): void => {
+  setCurrentProject(val: Project): void {
     this.currentProject = val;
-  };
-  setCurrentWorkspace = (val: Workspace): void => {
+  }
+
+  setCurrentWorkspace(val: Workspace): void {
     this.currentWorkspace = val;
-  };
-  setCurrentRevision = (val: Revision): void => {
+  }
+
+  setCurrentRevision(val: Revision): void {
     this.currentRevision = val;
-  };
+  }
 
-  setWorkspaceLatestRevision = (val: Revision): void => {
+  setWorkspaceLatestRevision(val: Revision): void {
     this.remoteWorkspaceRevision = val;
-  };
+  }
+
+  handleChangeDetectionRefreshIssue(error: Error): void {
+    if (
+      !this.currentProject ||
+      !this.currentWorkspace ||
+      (error instanceof NetworkClientError &&
+        error.response.status === HttpStatus.NOT_FOUND)
+    ) {
+      this.editorStore.applicationStore.setBlockingAlert({
+        message: 'Current project or workspace no longer exists',
+        prompt: 'Please refresh the application',
+      });
+    } else {
+      this.editorStore.applicationStore.setBlockingAlert({
+        message: error.message,
+      });
+    }
+  }
 
   *fetchCurrentProject(
     projectId: string,
@@ -290,24 +343,6 @@ export class EditorSDLCState {
     }
   }
 
-  handleChangeDetectionRefreshIssue(error: Error): void {
-    if (
-      !this.currentProject ||
-      !this.currentWorkspace ||
-      (error instanceof NetworkClientError &&
-        error.response.status === HttpStatus.NOT_FOUND)
-    ) {
-      this.editorStore.applicationStore.setBlockingAlert({
-        message: 'Current project or workspace no longer exists',
-        prompt: 'Please refresh the application',
-      });
-    } else {
-      this.editorStore.applicationStore.setBlockingAlert({
-        message: error.message,
-      });
-    }
-  }
-
   *buildWorkspaceLatestRevisionEntityHashesIndex(): GeneratorFn<void> {
     try {
       let entities: Entity[] = [];

package/src/stores/EditorStore.ts

@@ -1035,7 +1035,7 @@ export class EditorStore implements CommandRegistrar {
 
   setGraphEditMode(graphEditor: GRAPH_EDITOR_MODE): void {
     this.graphEditMode = graphEditor;
-    this.graphState.clearCompilationError();
+    this.graphState.clearProblems();
   }
 
   setActiveActivity(

package/src/stores/EmbeddedQueryBuilderState.ts

@@ -92,7 +92,7 @@ export class EmbeddedQueryBuilderState {
           }
         }
       }
-      if (!this.editorStore.graphState.hasCompilationError) {
+      if (!this.editorStore.graphState.error) {
         this.queryBuilderState = config.setupQueryBuilderState();
         this.actionConfigs = config.actionConfigs;
         this.editorStore.applicationStore.setBackdropContainerElementID(

package/src/stores/editor/NewElementState.ts

@@ -19,8 +19,8 @@ import {
   observable,
   computed,
   makeObservable,
-  makeAutoObservable,
   flowResult,
+  flow,
 } from 'mobx';
 import type { EditorStore } from '../EditorStore.js';
 import {
@@ -72,7 +72,6 @@ import {
   DefaultH2AuthenticationStrategy,
   ModelGenerationSpecification,
   DataElement,
-  stub_RawLambda,
   stub_Database,
   Measure,
 } from '@finos/legend-graph';
@@ -467,7 +466,12 @@ export class NewServiceDriver extends NewElementDriver<Service> {
     }
     service_setExecution(
       service,
-      new PureSingleExecution(stub_RawLambda(), service, mapping, runtimeValue),
+      new PureSingleExecution(
+        this.editorStore.graphManagerState.graphManager.createDefaultBasicRawLambda(),
+        service,
+        mapping,
+        runtimeValue,
+      ),
       this.editorStore.changeDetectionState.observerContext,
     );
     service_initNewService(service);
@@ -595,8 +599,16 @@ export class NewElementState {
   newElementDriver?: NewElementDriver<PackageableElement> | undefined;
 
   constructor(editorStore: EditorStore) {
-    makeAutoObservable(this, {
-      editorStore: false,
+    makeObservable(this, {
+      showModal: observable,
+      showType: observable,
+      type: observable,
+      _package: observable,
+      name: observable,
+      newElementDriver: observable,
+      elementAndPackageName: computed,
+      selectedPackage: computed,
+      isValid: computed,
       setShowModal: action,
       setName: action,
       setShowType: action,
@@ -606,6 +618,7 @@ export class NewElementState {
       openModal: action,
       closeModal: action,
       createElement: action,
+      save: flow,
     });
 
     this.editorStore = editorStore;
@@ -619,11 +632,13 @@ export class NewElementState {
       this.name,
     );
   }
+
   get selectedPackage(): Package {
     return this._package
       ? this._package
       : this.editorStore.explorerTreeState.getSelectedNodePackage();
   }
+
   get isValid(): boolean {
     return this.newElementDriver?.isValid ?? true;
   }
@@ -631,17 +646,21 @@ export class NewElementState {
   setShowModal(val: boolean): void {
     this.showModal = val;
   }
+
   setName(name: string): void {
     this.name = name;
   }
+
   setShowType(showType: boolean): void {
     this.showType = showType;
   }
+
   setNewElementDriver(
     newElementDriver?: NewElementDriver<PackageableElement>,
   ): void {
     this.newElementDriver = newElementDriver;
   }
+
   setPackage(_package?: Package): void {
     this._package = _package;
   }

package/src/stores/editor/StandardEditorMode.ts

@@ -15,7 +15,7 @@
  */
 
 import type { EditorStore } from '../EditorStore.js';
-import { generateViewEntityRoute } from '../LegendStudioRouter.js';
+import { generateEditorRoute } from '../LegendStudioRouter.js';
 import { EditorMode } from './EditorMode.js';
 
 export class StandardEditorMode extends EditorMode {
@@ -27,8 +27,10 @@ export class StandardEditorMode extends EditorMode {
   }
 
   generateElementLink(elementPath: string): string {
-    return generateViewEntityRoute(
+    return generateEditorRoute(
       this.editorStore.sdlcState.activeProject.projectId,
+      this.editorStore.sdlcState.activeWorkspace.workspaceId,
+      this.editorStore.sdlcState.activeWorkspace.workspaceType,
       elementPath,
     );
   }

package/src/stores/editor-state/FileGenerationState.ts

@@ -15,7 +15,7 @@
  */
 
 import type { EditorStore } from '../EditorStore.js';
-import { observable, action, makeAutoObservable } from 'mobx';
+import { observable, action, makeObservable, flow } from 'mobx';
 import { LEGEND_STUDIO_APP_EVENT } from '../LegendStudioAppEvent.js';
 import type { TreeData } from '@finos/legend-art';
 import {
@@ -57,8 +57,9 @@ import {
 } from '../shared/modifier/DSL_Generation_GraphModifierHelper.js';
 
 export class FileGenerationState {
-  editorStore: EditorStore;
-  fileGeneration: FileGenerationSpecification;
+  readonly editorStore: EditorStore;
+  readonly fileGeneration: FileGenerationSpecification;
+
   isGenerating = false;
   root: GenerationDirectory;
   directoryTreeData?: TreeData<GenerationTreeNodeData> | undefined;
@@ -69,11 +70,12 @@ export class FileGenerationState {
     editorStore: EditorStore,
     fileGeneration: FileGenerationSpecification,
   ) {
-    makeAutoObservable(this, {
-      editorStore: false,
-      fileGeneration: false,
+    makeObservable(this, {
+      isGenerating: observable,
+      root: observable,
       directoryTreeData: observable.ref,
       selectedNode: observable.ref,
+      filesIndex: observable,
       resetFileGeneration: action,
       setIsGeneration: action,
       setDirectoryTreeData: action,
@@ -84,6 +86,7 @@ export class FileGenerationState {
       addScopeElement: action,
       deleteScopeElement: action,
       updateFileGenerationParameters: action,
+      generate: flow,
     });
 
     this.editorStore = editorStore;
@@ -91,19 +94,27 @@ export class FileGenerationState {
     this.root = new GenerationDirectory(GENERATION_FILE_ROOT_NAME);
   }
 
+  getOrCreateDirectory(directoryName: string): GenerationDirectory {
+    return GenerationDirectory.getOrCreateDirectory(
+      this.root,
+      directoryName,
+      true,
+    );
+  }
+
   resetFileGeneration(): void {
     this.fileGeneration.configurationProperties = [];
   }
+
   setIsGeneration(isGenerating: boolean): void {
     this.isGenerating = isGenerating;
   }
+
   setDirectoryTreeData(
     directoryTreeData: TreeData<GenerationTreeNodeData>,
   ): void {
     this.directoryTreeData = directoryTreeData;
   }
-  getOrCreateDirectory = (directoryName: string): GenerationDirectory =>
-    GenerationDirectory.getOrCreateDirectory(this.root, directoryName, true);
 
   *generate(): GeneratorFn<void> {
     this.isGenerating = true;

package/src/stores/editor-state/GrammarTextEditorState.ts

@@ -15,11 +15,10 @@
  */
 
 import type { EditorStore } from '../EditorStore.js';
-import { action, makeAutoObservable } from 'mobx';
-import { UnsupportedOperationError } from '@finos/legend-shared';
+import { action, makeObservable, observable } from 'mobx';
+import { hashValue, UnsupportedOperationError } from '@finos/legend-shared';
 import {
   type PackageableElement,
-  type EngineError,
   type DSL_Mapping_PureGraphManagerPlugin_Extension,
   Profile,
   Enumeration,
@@ -44,6 +43,7 @@ import {
   PURE_ELEMENT_NAME,
   PURE_CONNECTION_NAME,
 } from '@finos/legend-graph';
+import type { TextEditorPosition } from '@finos/legend-art';
 
 const getGrammarElementTypeLabelRegexString = (
   typeLabel: string,
@@ -59,18 +59,22 @@ const getGrammarElementTypeLabelRegexString = (
     .replace(/\$/g, '\\$'); // replace special character $ by \\$
 
 export class GrammarTextEditorState {
-  editorStore: EditorStore;
+  readonly editorStore: EditorStore;
+
   graphGrammarText = '';
   currentElementLabelRegexString?: string | undefined;
   wrapText = false;
-  error?: EngineError | undefined;
+  forcedCursorPosition?: TextEditorPosition | undefined;
 
   constructor(editorStore: EditorStore) {
-    makeAutoObservable(this, {
-      editorStore: false,
-      setError: action,
+    makeObservable(this, {
+      graphGrammarText: observable,
+      currentElementLabelRegexString: observable,
+      wrapText: observable,
+      forcedCursorPosition: observable,
       setGraphGrammarText: action,
       setWrapText: action,
+      setForcedCursorPosition: action,
       resetCurrentElementLabelRegexString: action,
       setCurrentElementLabelRegexString: action,
     });
@@ -78,8 +82,8 @@ export class GrammarTextEditorState {
     this.editorStore = editorStore;
   }
 
-  setError(error: EngineError | undefined): void {
-    this.error = error;
+  get currentTextGraphHash(): string {
+    return hashValue(this.graphGrammarText);
   }
 
   setGraphGrammarText(code: string): void {
@@ -90,6 +94,10 @@ export class GrammarTextEditorState {
     this.wrapText = val;
   }
 
+  setForcedCursorPosition(position: TextEditorPosition | undefined): void {
+    this.forcedCursorPosition = position;
+  }
+
   resetCurrentElementLabelRegexString(): void {
     this.currentElementLabelRegexString = undefined;
   }

package/src/stores/editor-state/element-editor-state/ClassEditorState.ts

@@ -47,7 +47,6 @@ export class ClassEditorState extends UMLEditorState {
       classState: observable,
       selectedProperty: observable,
       class: computed,
-      hasCompilationError: computed,
       reprocess: override,
       setSelectedProperty: action,
     });
@@ -109,17 +108,6 @@ export class ClassEditorState extends UMLEditorState {
     return false;
   }
 
-  override get hasCompilationError(): boolean {
-    return (
-      this.classState.constraintStates.some((state) =>
-        Boolean(state.compilationError),
-      ) ||
-      this.classState.derivedPropertyStates.some((state) =>
-        Boolean(state.compilationError),
-      )
-    );
-  }
-
   override clearCompilationError(): void {
     this.classState.constraintStates.forEach((constraintState) =>
       constraintState.setCompilationError(undefined),

package/src/stores/editor-state/element-editor-state/ElementEditorState.ts

@@ -143,10 +143,6 @@ export abstract class ElementEditorState extends EditorState {
     return false;
   }
 
-  get hasCompilationError(): boolean {
-    return false;
-  }
-
   clearCompilationError(): void {
     return;
   }

package/src/stores/editor-state/element-editor-state/ElementFileGenerationState.ts

@@ -16,7 +16,7 @@
 
 import type { EditorStore } from '../../EditorStore.js';
 import { FileGenerationState } from '../../editor-state/FileGenerationState.js';
-import { action, flow, flowResult, makeAutoObservable } from 'mobx';
+import { action, flow, flowResult, makeObservable, observable } from 'mobx';
 import { ElementEditorState } from './ElementEditorState.js';
 import { type GeneratorFn, AssertionError, uuid } from '@finos/legend-shared';
 import {
@@ -31,17 +31,19 @@ import { handlePostCreateAction } from '../../editor/NewElementState.js';
 
 export class ElementFileGenerationState {
   readonly uuid = uuid();
-  editorStore: EditorStore;
-  fileGenerationType: string;
+  readonly editorStore: EditorStore;
+  readonly fileGenerationType: string;
+
   fileGenerationState: FileGenerationState;
   showNewFileGenerationModal = false;
 
   constructor(editorStore: EditorStore, fileGenerationType: string) {
-    makeAutoObservable(this, {
-      uuid: false,
-      editorStore: false,
+    makeObservable(this, {
+      fileGenerationState: observable,
+      showNewFileGenerationModal: observable,
       setShowNewFileGenerationModal: action,
       promoteToFileGeneration: flow,
+      regenerate: flow,
     });
 
     this.editorStore = editorStore;

package/src/stores/editor-state/element-editor-state/FunctionEditorState.ts

@@ -162,7 +162,6 @@ export class FunctionEditorState extends ElementEditorState {
     makeObservable(this, {
       selectedTab: observable,
       functionElement: computed,
-      hasCompilationError: computed,
       setSelectedTab: action,
       reprocess: action,
     });
@@ -209,10 +208,6 @@ export class FunctionEditorState extends ElementEditorState {
     return revealed;
   }
 
-  override get hasCompilationError(): boolean {
-    return Boolean(this.functionBodyEditorState.compilationError);
-  }
-
   override clearCompilationError(): void {
     this.functionBodyEditorState.setCompilationError(undefined);
   }

package/src/stores/editor-state/element-editor-state/mapping/MappingEditorState.ts

@@ -603,7 +603,6 @@ export class MappingEditorState extends ElementEditorState {
       mappingExplorerTreeData: observable.ref,
       mapping: computed,
       testSuiteResult: computed,
-      hasCompilationError: computed,
       setNewMappingElementSpec: action,
       setMappingExplorerTreeNodeData: action,
       openMappingElement: action,
@@ -1311,16 +1310,6 @@ export class MappingEditorState extends ElementEditorState {
     return revealed;
   }
 
-  override get hasCompilationError(): boolean {
-    return this.openedTabStates
-      .filter(filterByType(InstanceSetImplementationState))
-      .some((tabState) =>
-        tabState.propertyMappingStates.some((pmState) =>
-          Boolean(pmState.compilationError),
-        ),
-      );
-  }
-
   override clearCompilationError(): void {
     this.openedTabStates
       .filter(filterByType(InstanceSetImplementationState))

package/src/stores/editor-state/element-editor-state/mapping/MappingExecutionState.ts

@@ -27,7 +27,6 @@ import {
   flow,
   computed,
   makeObservable,
-  makeAutoObservable,
   flowResult,
 } from 'mobx';
 import {
@@ -481,9 +480,10 @@ export class MappingExecutionRelationalInputDataState extends MappingExecutionIn
 
 export class MappingExecutionState {
   readonly uuid = uuid();
+  readonly editorStore: EditorStore;
+  readonly mappingEditorState: MappingEditorState;
+
   name: string;
-  editorStore: EditorStore;
-  mappingEditorState: MappingEditorState;
   queryState: MappingExecutionQueryState;
   inputDataState: MappingExecutionInputDataState;
   showServicePathModal = false;
@@ -499,17 +499,27 @@ export class MappingExecutionState {
     mappingEditorState: MappingEditorState,
     name: string,
   ) {
-    makeAutoObservable(this, {
-      editorStore: false,
-      mappingEditorState: false,
+    makeObservable(this, {
+      name: observable,
+      queryState: observable,
+      inputDataState: observable,
+      showServicePathModal: observable,
       executionPlanState: observable,
+      isExecuting: observable,
+      isGeneratingPlan: observable,
+      planGenerationDebugText: observable,
       setQueryState: action,
       setInputDataState: action,
       setExecutionResultText: action,
-      setPlanGenerationDebugText: action,
       setShowServicePathModal: action,
+      setPlanGenerationDebugText: action,
       setInputDataStateBasedOnSource: action,
       reset: action,
+      promoteToTest: flow,
+      promoteToService: flow,
+      executeMapping: flow,
+      generatePlan: flow,
+      buildQueryWithClassMapping: flow,
     });
 
     this.editorStore = editorStore;
@@ -530,18 +540,22 @@ export class MappingExecutionState {
     );
   }
 
-  setQueryState = (val: MappingExecutionQueryState): void => {
+  setQueryState(val: MappingExecutionQueryState): void {
     this.queryState = val;
-  };
-  setInputDataState = (val: MappingExecutionInputDataState): void => {
+  }
+
+  setInputDataState(val: MappingExecutionInputDataState): void {
     this.inputDataState = val;
-  };
-  setExecutionResultText = (val: string | undefined): void => {
+  }
+
+  setExecutionResultText(val: string | undefined): void {
     this.executionResultText = val;
-  };
-  setShowServicePathModal = (val: boolean): void => {
+  }
+
+  setShowServicePathModal(val: boolean): void {
     this.showServicePathModal = val;
-  };
+  }
+
   setPlanGenerationDebugText(val: string | undefined): void {
     this.planGenerationDebugText = val;
   }