@finos/legend-application-studio 19.1.0 → 20.0.0

package/src/stores/sidebar-state/WorkflowManagerState.ts

@@ -15,14 +15,7 @@
  */
 
 import type { TreeNodeData, TreeData } from '@finos/legend-art';
-import {
-  makeAutoObservable,
-  observable,
-  action,
-  flowResult,
-  makeObservable,
-  flow,
-} from 'mobx';
+import { observable, action, flowResult, makeObservable, flow } from 'mobx';
 import { LEGEND_STUDIO_APP_EVENT } from '../LegendStudioAppEvent.js';
 import type { EditorStore } from '../EditorStore.js';
 import type { EditorSDLCState } from '../EditorSDLCState.js';
@@ -102,11 +95,12 @@ const updateWorkflowJobData = (
 };
 
 export class WorkflowLogState {
-  editorStore: EditorStore;
-  workflowManagerState: WorkflowManagerState;
+  readonly editorStore: EditorStore;
+  readonly workflowManagerState: WorkflowManagerState;
+  readonly fetchJobLogState = ActionState.create();
+
   job: WorkflowJob | undefined;
   logs: string;
-  fetchJobLogState = ActionState.create();
 
   constructor(
     editorStore: EditorStore,
@@ -114,12 +108,14 @@ export class WorkflowLogState {
     job: WorkflowJob | undefined,
     logs: string | undefined,
   ) {
-    makeAutoObservable(this, {
-      editorStore: false,
+    makeObservable(this, {
       job: observable,
       logs: observable,
       setLogs: action,
       setJob: action,
+      closeModal: action,
+      refreshJobLogs: flow,
+      viewJobLogs: flow,
     });
 
     this.editorStore = editorStore;
@@ -187,8 +183,9 @@ export class WorkflowLogState {
 
 export class WorkflowState {
   readonly uuid = uuid();
-  editorStore: EditorStore;
-  workflowManagerState: WorkflowManagerState;
+  readonly editorStore: EditorStore;
+  readonly workflowManagerState: WorkflowManagerState;
+
   treeData: TreeData<WorkflowExplorerTreeNodeData>;
   isExecutingWorkflowRequest = false;
 
@@ -198,10 +195,15 @@ export class WorkflowState {
     workflow: Workflow,
     jobs: WorkflowJob[] | undefined,
   ) {
-    makeAutoObservable(this, {
-      editorStore: false,
+    makeObservable(this, {
       treeData: observable.ref,
+      isExecutingWorkflowRequest: observable,
       setWorkflowTreeData: action,
+      fetchAllWorkspaceWorkJobs: flow,
+      onTreeNodeSelect: flow,
+      cancelJob: flow,
+      refreshWorkflow: flow,
+      retryJob: flow,
     });
 
     this.editorStore = editorStore;
@@ -326,19 +328,15 @@ export class WorkflowState {
 }
 
 export abstract class WorkflowManagerState {
-  editorStore: EditorStore;
-  sdlcState: EditorSDLCState;
-  fetchWorkflowsState = ActionState.create();
+  readonly editorStore: EditorStore;
+  readonly sdlcState: EditorSDLCState;
+  readonly fetchWorkflowsState = ActionState.create();
+
   logState: WorkflowLogState;
   workflowStates: WorkflowState[] = [];
 
   constructor(editorStore: EditorStore, sdlcState: EditorSDLCState) {
-    this.editorStore = editorStore;
-    this.sdlcState = sdlcState;
     makeObservable(this, {
-      editorStore: false,
-      sdlcState: false,
-      fetchWorkflowsState: observable,
       logState: observable,
       workflowStates: observable,
       fetchAllWorkflows: flow,
@@ -350,6 +348,10 @@ export abstract class WorkflowManagerState {
       cancelJob: flow,
       getJobLogs: flow,
     });
+
+    this.editorStore = editorStore;
+    this.sdlcState = sdlcState;
+
     this.logState = new WorkflowLogState(
       this.editorStore,
       this,
@@ -357,18 +359,13 @@ export abstract class WorkflowManagerState {
       undefined,
     );
   }
-  abstract getWorkflows(): GeneratorFn<Workflow[]>;
 
+  abstract getWorkflows(): GeneratorFn<Workflow[]>;
   abstract getWorkflow(workflowId: string): GeneratorFn<Workflow>;
-
   abstract getJobs(workflowId: string): GeneratorFn<WorkflowJob[]>;
-
   abstract getJob(job: WorkflowJob): GeneratorFn<WorkflowJob[]>;
-
   abstract retryJob(workflowJob: WorkflowJob): GeneratorFn<void>;
-
   abstract cancelJob(workflowJob: WorkflowJob): GeneratorFn<void>;
-
   abstract getJobLogs(workflowJob: WorkflowJob): GeneratorFn<string>;
 
   *fetchAllWorkflows(): GeneratorFn<void> {

package/src/stores/sidebar-state/WorkspaceReviewState.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { action, makeAutoObservable, flowResult } from 'mobx';
+import { action, makeObservable, flowResult, observable, flow } from 'mobx';
 import type { EditorStore } from '../EditorStore.js';
 import type { EditorSDLCState } from '../EditorSDLCState.js';
 import { CHANGE_DETECTION_EVENT } from '../ChangeDetectionEvent.js';
@@ -41,8 +41,9 @@ import {
 import { ActionAlertActionType } from '@finos/legend-application';
 
 export class WorkspaceReviewState {
-  editorStore: EditorStore;
-  sdlcState: EditorSDLCState;
+  readonly editorStore: EditorStore;
+  readonly sdlcState: EditorSDLCState;
+
   reviewTitle = '';
   committedReviewsBetweenWorkspaceBaseAndProjectLatest: Review[] = [];
   workspaceReview?: Review | undefined;
@@ -57,20 +58,35 @@ export class WorkspaceReviewState {
   isRecreatingWorkspaceAfterCommittingReview = false;
 
   constructor(editorStore: EditorStore, sdlcState: EditorSDLCState) {
-    makeAutoObservable(this, {
-      editorStore: false,
-      sdlcState: false,
+    makeObservable(this, {
+      reviewTitle: observable,
+      committedReviewsBetweenWorkspaceBaseAndProjectLatest: observable,
+      workspaceReview: observable,
+      isUpdatingWorkspace: observable,
+      isRefreshingWorkspaceUpdater: observable,
+      isFetchingCurrentWorkspaceReview: observable,
+      isRefreshingWorkspaceChangesDetector: observable,
+      isClosingWorkspaceReview: observable,
+      isCreatingWorkspaceReview: observable,
+      isCommittingWorkspaceReview: observable,
+      isRecreatingWorkspaceAfterCommittingReview: observable,
       setReviewTitle: action,
       openReviewChange: action,
+      refreshWorkspaceChanges: flow,
+      fetchCurrentWorkspaceReview: flow,
+      recreateWorkspaceAfterCommittingReview: flow,
+      closeWorkspaceReview: flow,
+      createWorkspaceReview: flow,
+      commitWorkspaceReview: flow,
     });
 
     this.editorStore = editorStore;
     this.sdlcState = sdlcState;
   }
 
-  setReviewTitle = (val: string): void => {
+  setReviewTitle(val: string): void {
     this.reviewTitle = val;
-  };
+  }
 
   openReviewChange(diff: EntityDiff): void {
     const fromEntityGetter = (

package/src/stores/sidebar-state/WorkspaceSyncState.ts

@@ -14,14 +14,7 @@
  * limitations under the License.
  */
 
-import {
-  makeAutoObservable,
-  flowResult,
-  action,
-  flow,
-  makeObservable,
-  observable,
-} from 'mobx';
+import { flowResult, action, flow, makeObservable, observable } from 'mobx';
 import type { EditorStore } from '../EditorStore.js';
 import type { EditorSDLCState } from '../EditorSDLCState.js';
 import type { Entity } from '@finos/legend-storage';
@@ -373,23 +366,25 @@ class WorkspaceSyncConflictResolutionState extends AbstractConflictResolutionSta
 }
 
 export class WorkspaceSyncState {
-  editorStore: EditorStore;
-  sdlcState: EditorSDLCState;
+  readonly editorStore: EditorStore;
+  readonly sdlcState: EditorSDLCState;
 
   pullChangesState = ActionState.create();
   incomingRevisions: Revision[] = [];
   workspaceSyncConflictResolutionState: WorkspaceSyncConflictResolutionState;
 
   constructor(editorStore: EditorStore, sdlcState: EditorSDLCState) {
-    makeAutoObservable(this, {
-      editorStore: false,
-      sdlcState: false,
-      fetchIncomingRevisions: flow,
+    makeObservable(this, {
+      pullChangesState: observable,
+      incomingRevisions: observable,
+      workspaceSyncConflictResolutionState: observable,
+      resetConflictState: action,
       setIncomingRevisions: action,
+      fetchIncomingRevisions: flow,
       pullChanges: flow,
-      resetConflictState: action,
-      forcePull: flow,
       loadChanges: flow,
+      forcePull: flow,
+      applyResolutionChanges: flow,
     });
 
     this.editorStore = editorStore;

package/src/stores/sidebar-state/WorkspaceUpdaterState.ts

@@ -16,7 +16,7 @@
 
 import type { EditorStore } from '../EditorStore.js';
 import type { EditorSDLCState } from '../EditorSDLCState.js';
-import { action, makeAutoObservable, flowResult } from 'mobx';
+import { action, makeObservable, flowResult, observable, flow } from 'mobx';
 import { CHANGE_DETECTION_EVENT } from '../ChangeDetectionEvent.js';
 import {
   type GeneratorFn,
@@ -45,19 +45,23 @@ import {
 import { LEGEND_STUDIO_APP_EVENT } from '../LegendStudioAppEvent.js';
 
 export class WorkspaceUpdaterState {
-  editorStore: EditorStore;
-  sdlcState: EditorSDLCState;
-  committedReviewsBetweenWorkspaceBaseAndProjectLatest: Review[] = [];
+  readonly editorStore: EditorStore;
+  readonly sdlcState: EditorSDLCState;
 
+  committedReviewsBetweenWorkspaceBaseAndProjectLatest: Review[] = [];
   isUpdatingWorkspace = false;
   isRefreshingWorkspaceUpdater = false;
 
   constructor(editorStore: EditorStore, sdlcState: EditorSDLCState) {
-    makeAutoObservable(this, {
-      editorStore: false,
-      sdlcState: false,
+    makeObservable(this, {
+      committedReviewsBetweenWorkspaceBaseAndProjectLatest: observable,
+      isUpdatingWorkspace: observable,
+      isRefreshingWorkspaceUpdater: observable,
       openProjectLatestChange: action,
       openPotentialWorkspaceUpdateConflict: action,
+      refreshWorkspaceUpdater: flow,
+      updateWorkspace: flow,
+      fetchLatestCommittedReviews: flow,
     });
 
     this.editorStore = editorStore;

package/src/stores/workspace-review/WorkspaceReviewStore.ts

@@ -22,7 +22,14 @@ import {
   LogEvent,
   guaranteeNonNullable,
 } from '@finos/legend-shared';
-import { makeAutoObservable, action, flowResult } from 'mobx';
+import {
+  makeObservable,
+  action,
+  flowResult,
+  observable,
+  flow,
+  computed,
+} from 'mobx';
 import type { EditorStore } from '../EditorStore.js';
 import { ACTIVITY_MODE } from '../EditorConfig.js';
 import type { Entity } from '@finos/legend-storage';
@@ -31,7 +38,8 @@ import { LEGEND_STUDIO_APP_EVENT } from '../LegendStudioAppEvent.js';
 import { TAB_SIZE } from '@finos/legend-application';
 
 export class WorkspaceReviewStore {
-  editorStore: EditorStore;
+  readonly editorStore: EditorStore;
+
   currentProjectId?: string | undefined;
   currentProject?: Project | undefined;
   currentReviewId?: string | undefined;
@@ -44,12 +52,29 @@ export class WorkspaceReviewStore {
   isReopeningReview = false;
 
   constructor(editorStore: EditorStore) {
-    makeAutoObservable(this, {
-      editorStore: false,
-      projectId: false,
-      reviewId: false,
-      review: false,
+    makeObservable(this, {
+      currentProjectId: observable,
+      currentProject: observable,
+      currentReviewId: observable,
+      currentReview: observable,
+      isFetchingCurrentReview: observable,
+      isFetchingComparison: observable,
+      isApprovingReview: observable,
+      isClosingReview: observable,
+      isCommittingReview: observable,
+      isReopeningReview: observable,
+      projectId: computed,
+      reviewId: computed,
+      review: computed,
       setProjectIdAndReviewId: action,
+      initialize: flow,
+      fetchReviewComparison: flow,
+      fetchProject: flow,
+      getReview: flow,
+      approveReview: flow,
+      commitReview: flow,
+      reOpenReview: flow,
+      closeReview: flow,
     });
 
     this.editorStore = editorStore;
@@ -59,13 +84,20 @@ export class WorkspaceReviewStore {
   get projectId(): string {
     return guaranteeNonNullable(this.currentProjectId, 'Project ID must exist');
   }
+
   get reviewId(): string {
     return guaranteeNonNullable(this.currentReviewId, 'Review ID must exist');
   }
+
   get review(): Review {
     return guaranteeNonNullable(this.currentReview, 'Review must exist');
   }
 
+  setProjectIdAndReviewId(projectId: string, reviewId: string): void {
+    this.currentProjectId = projectId;
+    this.currentReviewId = reviewId;
+  }
+
   *initialize(): GeneratorFn<void> {
     try {
       // setup engine
@@ -94,11 +126,6 @@ export class WorkspaceReviewStore {
     }
   }
 
-  setProjectIdAndReviewId(projectId: string, reviewId: string): void {
-    this.currentProjectId = projectId;
-    this.currentReviewId = reviewId;
-  }
-
   *fetchReviewComparison(): GeneratorFn<void> {
     this.isFetchingComparison = true;
     try {

package/tsconfig.json

@@ -159,6 +159,7 @@
     "./src/components/editor/aux-panel/AuxiliaryPanel.tsx",
     "./src/components/editor/aux-panel/Console.tsx",
     "./src/components/editor/aux-panel/DevTool.tsx",
+    "./src/components/editor/aux-panel/Problems.tsx",
     "./src/components/editor/command-center/ProjectSearchCommand.tsx",
     "./src/components/editor/edit-panel/EditPanel.tsx",
     "./src/components/editor/edit-panel/FileGenerationViewer.tsx",