@finos/legend-application-studio 19.0.0 → 20.0.0

package/src/stores/workspace-review/WorkspaceReviewStore.ts

@@ -22,7 +22,14 @@ import {
   LogEvent,
   guaranteeNonNullable,
 } from '@finos/legend-shared';
-import { makeAutoObservable, action, flowResult } from 'mobx';
+import {
+  makeObservable,
+  action,
+  flowResult,
+  observable,
+  flow,
+  computed,
+} from 'mobx';
 import type { EditorStore } from '../EditorStore.js';
 import { ACTIVITY_MODE } from '../EditorConfig.js';
 import type { Entity } from '@finos/legend-storage';
@@ -31,7 +38,8 @@ import { LEGEND_STUDIO_APP_EVENT } from '../LegendStudioAppEvent.js';
 import { TAB_SIZE } from '@finos/legend-application';
 
 export class WorkspaceReviewStore {
-  editorStore: EditorStore;
+  readonly editorStore: EditorStore;
+
   currentProjectId?: string | undefined;
   currentProject?: Project | undefined;
   currentReviewId?: string | undefined;
@@ -44,12 +52,29 @@ export class WorkspaceReviewStore {
   isReopeningReview = false;
 
   constructor(editorStore: EditorStore) {
-    makeAutoObservable(this, {
-      editorStore: false,
-      projectId: false,
-      reviewId: false,
-      review: false,
+    makeObservable(this, {
+      currentProjectId: observable,
+      currentProject: observable,
+      currentReviewId: observable,
+      currentReview: observable,
+      isFetchingCurrentReview: observable,
+      isFetchingComparison: observable,
+      isApprovingReview: observable,
+      isClosingReview: observable,
+      isCommittingReview: observable,
+      isReopeningReview: observable,
+      projectId: computed,
+      reviewId: computed,
+      review: computed,
       setProjectIdAndReviewId: action,
+      initialize: flow,
+      fetchReviewComparison: flow,
+      fetchProject: flow,
+      getReview: flow,
+      approveReview: flow,
+      commitReview: flow,
+      reOpenReview: flow,
+      closeReview: flow,
     });
 
     this.editorStore = editorStore;
@@ -59,13 +84,20 @@ export class WorkspaceReviewStore {
   get projectId(): string {
     return guaranteeNonNullable(this.currentProjectId, 'Project ID must exist');
   }
+
   get reviewId(): string {
     return guaranteeNonNullable(this.currentReviewId, 'Review ID must exist');
   }
+
   get review(): Review {
     return guaranteeNonNullable(this.currentReview, 'Review must exist');
   }
 
+  setProjectIdAndReviewId(projectId: string, reviewId: string): void {
+    this.currentProjectId = projectId;
+    this.currentReviewId = reviewId;
+  }
+
   *initialize(): GeneratorFn<void> {
     try {
       // setup engine
@@ -94,11 +126,6 @@ export class WorkspaceReviewStore {
     }
   }
 
-  setProjectIdAndReviewId(projectId: string, reviewId: string): void {
-    this.currentProjectId = projectId;
-    this.currentReviewId = reviewId;
-  }
-
   *fetchReviewComparison(): GeneratorFn<void> {
     this.isFetchingComparison = true;
     try {

package/tsconfig.json

@@ -159,6 +159,7 @@
     "./src/components/editor/aux-panel/AuxiliaryPanel.tsx",
     "./src/components/editor/aux-panel/Console.tsx",
     "./src/components/editor/aux-panel/DevTool.tsx",
+    "./src/components/editor/aux-panel/Problems.tsx",
     "./src/components/editor/command-center/ProjectSearchCommand.tsx",
     "./src/components/editor/edit-panel/EditPanel.tsx",
     "./src/components/editor/edit-panel/FileGenerationViewer.tsx",