@finos/legend-application-studio 16.0.1 → 17.0.0

package/src/application/LegendStudioApplicationConfig.ts

@@ -34,14 +34,14 @@ import {
   type LegendApplicationConfigurationData,
 } from '@finos/legend-application';
 
-export class ServiceRegistrationEnvInfo {
+export class ServiceRegistrationEnvironmentConfig {
   env!: string;
   executionUrl!: string;
   modes: string[] = [];
   managementUrl!: string;
 
   static readonly serialization = new SerializationFactory(
-    createModelSchema(ServiceRegistrationEnvInfo, {
+    createModelSchema(ServiceRegistrationEnvironmentConfig, {
       env: primitive(),
       executionUrl: primitive(),
       managementUrl: primitive(),
@@ -51,6 +51,7 @@ export class ServiceRegistrationEnvInfo {
 }
 
 class LegendStudioApplicationCoreOptions {
+  projectCreationGroupIdSuggestion = 'org.finos.legend.*';
   /**
    * Indicates if we should keep section index and do not rewrite/flatten the paths shortened by section
    * imports.
@@ -68,13 +69,15 @@ class LegendStudioApplicationCoreOptions {
    * @modularize
    * See https://github.com/finos/legend-studio/issues/65
    */
-  TEMPORARY__serviceRegistrationConfig: ServiceRegistrationEnvInfo[] = [];
+  TEMPORARY__serviceRegistrationConfig: ServiceRegistrationEnvironmentConfig[] =
+    [];
 
   private static readonly serialization = new SerializationFactory(
     createModelSchema(LegendStudioApplicationCoreOptions, {
+      projectCreationGroupIdSuggestion: optional(primitive()),
       TEMPORARY__preserveSectionIndex: optional(primitive()),
       TEMPORARY__serviceRegistrationConfig: list(
-        object(ServiceRegistrationEnvInfo),
+        object(ServiceRegistrationEnvironmentConfig),
       ),
     }),
   );
@@ -111,6 +114,7 @@ export class LegendStudioApplicationConfig extends LegendApplicationConfig {
   ) {
     super(input);
 
+    // engine
     assertNonNullable(
       input.configData.engine,
       `Can't configure application: 'engine' field is missing`,
@@ -119,8 +123,9 @@ export class LegendStudioApplicationConfig extends LegendApplicationConfig {
       input.configData.engine.url,
       `Can't configure application: 'engine.url' field is missing or empty`,
     );
-
     this.engineQueryServerUrl = input.configData.engine.queryUrl;
+
+    // depot
     assertNonNullable(
       input.configData.depot,
       `Can't configure application: 'depot' field is missing`,
@@ -130,6 +135,7 @@ export class LegendStudioApplicationConfig extends LegendApplicationConfig {
       `Can't configure application: 'depot.url' field is missing or empty`,
     );
 
+    // sdlc
     assertNonNullable(
       input.configData.sdlc,
       `Can't configure application: 'sdlc' field is missing`,
@@ -140,6 +146,7 @@ export class LegendStudioApplicationConfig extends LegendApplicationConfig {
     );
     this.SDLCServerBaseHeaders = input.configData.sdlc.baseHeaders;
 
+    // options
     this.options = LegendStudioApplicationCoreOptions.create(
       (input.configData.extensions?.core ??
         {}) as PlainObject<LegendStudioApplicationCoreOptions>,

package/src/components/EditorComponentTestUtils.tsx

@@ -134,11 +134,7 @@ export const TEST_DATA__DefaultDepotInfo = {
 export const TEST__LegendStudioBaseStoreProvider: React.FC<{
   children: React.ReactNode;
 }> = ({ children }) => (
-  <LegendStudioBaseStoreProvider
-    pluginManager={LegendStudioPluginManager.create()}
-  >
-    {children}
-  </LegendStudioBaseStoreProvider>
+  <LegendStudioBaseStoreProvider>{children}</LegendStudioBaseStoreProvider>
 );
 
 export const TEST__provideMockedEditorStore = (customization?: {
@@ -163,7 +159,6 @@ export const TEST__provideMockedEditorStore = (customization?: {
       customization?.depotServerClient ?? TEST__getTestDepotServerClient(),
       customization?.graphManagerState ??
         TEST__getTestGraphManagerState(customization?.pluginManager),
-      pluginManager,
     );
   const MockedEditorStoreProvider = require('./editor/EditorStoreProvider.js'); // eslint-disable-line @typescript-eslint/no-unsafe-assignment
   MockedEditorStoreProvider.useEditorStore = jest.fn();

package/src/components/EmbeddedQueryBuilder.tsx

@@ -24,7 +24,7 @@ import {
   EmptyWindowRestoreIcon,
 } from '@finos/legend-art';
 import { flowResult } from 'mobx';
-import { hashObject, noop } from '@finos/legend-shared';
+import { noop } from '@finos/legend-shared';
 import {
   useApplicationNavigationContext,
   ActionAlertActionType,
@@ -65,13 +65,7 @@ const QueryBuilderDialog = observer(
     );
 
     const confirmCloseQueryBuilder = (): void => {
-      // NOTE: This is poor-man change detection for query
-      // in the future, we could consider a similar approach to how we do change detection in Studio
-      if (
-        queryBuilderState.changeDetectionState.isEnabled &&
-        queryBuilderState.changeDetectionState.queryHashCode !==
-          hashObject(queryBuilderState.buildQuery())
-      ) {
+      if (queryBuilderState.changeDetectionState.hasChanged) {
         applicationStore.setActionAlertInfo({
           message:
             'Unsaved changes to your query will be lost if you continue. Do you still want to proceed?',

package/src/components/LegendStudioApplication.tsx

@@ -210,7 +210,7 @@ export const LegendStudioApplication = observer(
             pluginManager={pluginManager}
             log={applicationStore.log}
           >
-            <LegendStudioBaseStoreProvider pluginManager={pluginManager}>
+            <LegendStudioBaseStoreProvider>
               <LegendApplicationComponentFrameworkProvider>
                 <LegendStudioApplicationRoot />
               </LegendApplicationComponentFrameworkProvider>

package/src/components/LegendStudioBaseStoreProvider.tsx

@@ -26,13 +26,12 @@ import type { LegendStudioPluginManager } from '../application/LegendStudioPlugi
 import { useLocalObservable } from 'mobx-react-lite';
 import { useApplicationStore } from '@finos/legend-application';
 import type { LegendStudioApplicationConfig } from '../application/LegendStudioApplicationConfig.js';
-import type { LegendStudioApplicationPlugin } from '../stores/LegendStudioApplicationPlugin.js';
 
 export const useLegendStudioApplicationStore =
   (): LegendStudioApplicationStore =>
     useApplicationStore<
       LegendStudioApplicationConfig,
-      LegendStudioApplicationPlugin
+      LegendStudioPluginManager
     >();
 
 const LegendStudioBaseStoreContext = createContext<
@@ -40,9 +39,8 @@ const LegendStudioBaseStoreContext = createContext<
 >(undefined);
 
 export const LegendStudioBaseStoreProvider: React.FC<{
-  pluginManager: LegendStudioPluginManager;
   children: React.ReactNode;
-}> = ({ pluginManager, children }) => {
+}> = ({ children }) => {
   const applicationStore = useLegendStudioApplicationStore();
   const sdlcServerClient = useSDLCServerClient();
   const depotServerClient = useDepotServerClient();
@@ -52,7 +50,6 @@ export const LegendStudioBaseStoreProvider: React.FC<{
         applicationStore,
         sdlcServerClient,
         depotServerClient,
-        pluginManager,
       ),
   );
   return (

package/src/components/editor/EditorStoreProvider.tsx

@@ -20,10 +20,7 @@ import { EditorStore } from '../../stores/EditorStore.js';
 import { guaranteeNonNullable } from '@finos/legend-shared';
 import { useSDLCServerClient } from '@finos/legend-server-sdlc';
 import { useDepotServerClient } from '@finos/legend-server-depot';
-import {
-  useLegendStudioApplicationStore,
-  useLegendStudioBaseStore,
-} from '../LegendStudioBaseStoreProvider.js';
+import { useLegendStudioApplicationStore } from '../LegendStudioBaseStoreProvider.js';
 import { useGraphManagerState } from '@finos/legend-graph';
 
 const EditorStoreContext = createContext<EditorStore | undefined>(undefined);
@@ -35,7 +32,6 @@ export const EditorStoreProvider: React.FC<{
   const sdlcServerClient = useSDLCServerClient();
   const depotServerClient = useDepotServerClient();
   const graphManagerState = useGraphManagerState();
-  const baseStore = useLegendStudioBaseStore();
   const store = useLocalObservable(
     () =>
       new EditorStore(
@@ -43,7 +39,6 @@ export const EditorStoreProvider: React.FC<{
         sdlcServerClient,
         depotServerClient,
         graphManagerState,
-        baseStore.pluginManager,
       ),
   );
   return (

package/src/components/editor/edit-panel/FunctionEditor.tsx

@@ -24,7 +24,7 @@ import {
   CORE_DND_TYPE,
   type UMLEditorElementDropTarget,
   type ElementDragSource,
-} from '../../../stores/shared/DnDUtil.js';
+} from '../../../stores/shared/DnDUtils.js';
 import {
   prettyCONSTName,
   UnsupportedOperationError,

package/src/components/editor/edit-panel/GenerationSpecificationEditor.tsx

@@ -47,15 +47,15 @@ import {
   CORE_DND_TYPE,
   type ElementDragSource,
   type FileGenerationSourceDropTarget,
-} from '../../../stores/shared/DnDUtil.js';
+} from '../../../stores/shared/DnDUtils.js';
 import { getNullableFirstElement } from '@finos/legend-shared';
-import type { DSLGenerationSpecification_LegendStudioApplicationPlugin_Extension } from '../../../stores/DSLGenerationSpecification_LegendStudioApplicationPlugin_Extension.js';
+import type { DSLGeneration_LegendStudioApplicationPlugin_Extension } from '../../../stores/DSLGeneration_LegendStudioApplicationPlugin_Extension.js';
 import { flowResult } from 'mobx';
 import { useEditorStore } from '../EditorStoreProvider.js';
 import {
   type PackageableElement,
   type PackageableElementReference,
-  type DSLGenerationSpecification_PureGraphManagerPlugin_Extension,
+  type DSLGeneration_PureGraphManagerPlugin_Extension,
   FileGenerationSpecification,
   PackageableElementExplicitReference,
   GenerationTreeNode,
@@ -233,7 +233,7 @@ const ModelGenerationSpecifications = observer(
       .flatMap(
         (plugin) =>
           (
-            plugin as DSLGenerationSpecification_PureGraphManagerPlugin_Extension
+            plugin as DSLGeneration_PureGraphManagerPlugin_Extension
           ).getExtraModelGenerationElementGetters?.() ?? [],
       )
       .flatMap((getter) => getter(editorStore.graphManagerState.graph));
@@ -243,7 +243,7 @@ const ModelGenerationSpecifications = observer(
         .flatMap(
           (plugin) =>
             (
-              plugin as DSLGenerationSpecification_LegendStudioApplicationPlugin_Extension
+              plugin as DSLGeneration_LegendStudioApplicationPlugin_Extension
             ).getExtraModelGenerationSpecificationElementDnDTypes?.() ?? [],
         );
     const modelGenerationElementOptions =

package/src/components/editor/edit-panel/GrammarTextEditor.tsx

@@ -49,7 +49,7 @@ import { useResizeDetector } from 'react-resize-detector';
 import {
   type ElementDragSource,
   CORE_DND_TYPE,
-} from '../../../stores/shared/DnDUtil.js';
+} from '../../../stores/shared/DnDUtils.js';
 import { useDrop } from 'react-dnd';
 import type {
   DSL_LegendStudioApplicationPlugin_Extension,
@@ -838,7 +838,7 @@ export const GrammarTextEditor = observer(() => {
   }, [editorStore, applicationStore, editor, grammarTextEditorState]);
 
   // Drag and Drop
-  const extraDnDTypes = editorStore.pluginManager
+  const extraElementDragTypes = editorStore.pluginManager
     .getApplicationPlugins()
     .flatMap(
       (plugin) =>
@@ -859,7 +859,7 @@ export const GrammarTextEditor = observer(() => {
   const [, dropConnector] = useDrop<ElementDragSource>(
     () => ({
       accept: [
-        ...extraDnDTypes,
+        ...extraElementDragTypes,
         CORE_DND_TYPE.PROJECT_EXPLORER_PACKAGE,
         CORE_DND_TYPE.PROJECT_EXPLORER_CLASS,
         CORE_DND_TYPE.PROJECT_EXPLORER_ASSOCIATION,
@@ -880,7 +880,7 @@ export const GrammarTextEditor = observer(() => {
 
       drop: (item) => handleDrop(item),
     }),
-    [extraDnDTypes, handleDrop],
+    [extraElementDragTypes, handleDrop],
   );
   dropConnector(textEditorRef);
 

package/src/components/editor/edit-panel/RuntimeEditor.tsx

@@ -56,13 +56,13 @@ import {
   PanelDropZone,
 } from '@finos/legend-art';
 import { getElementIcon } from '../../shared/ElementIconUtils.js';
-import type { RuntimeExplorerTreeNodeData } from '../../../stores/shared/TreeUtil.js';
+import type { RuntimeExplorerTreeNodeData } from '../../../stores/shared/TreeUtils.js';
 import { ConnectionEditor } from './connection-editor/ConnectionEditor.js';
 import {
   type UMLEditorElementDropTarget,
   CORE_DND_TYPE,
   ElementDragSource,
-} from '../../../stores/shared/DnDUtil.js';
+} from '../../../stores/shared/DnDUtils.js';
 import { useDrop } from 'react-dnd';
 import {
   assertErrorThrown,

package/src/components/editor/edit-panel/connection-editor/RelationalDatabaseConnectionEditor.tsx

@@ -48,6 +48,8 @@ import {
   ResizablePanelSplitterLine,
   PanelContent,
   Panel,
+  Badge,
+  PanelListSelectorItemLabel,
 } from '@finos/legend-art';
 import { capitalize, prettyCONSTName } from '@finos/legend-shared';
 
@@ -1260,6 +1262,26 @@ const PostProcessorRelationalConnectionEditor = observer(
       connectionValueState.selectPostProcessor(postProcessor);
     };
 
+    const getPostProcessorLabel = (postProcessor: PostProcessor): string => {
+      if (postProcessor instanceof MapperPostProcessor) {
+        return POST_PROCESSOR_TYPE.MAPPER;
+      } else {
+        const extraPostProcessorEditorClassifier = plugins.flatMap(
+          (plugin) =>
+            (
+              plugin as StoreRelational_LegendStudioApplicationPlugin_Extension
+            ).getExtraPostProcessorClassifierGetters?.() ?? [],
+        );
+        for (const classify of extraPostProcessorEditorClassifier) {
+          const label = classify(postProcessor);
+          if (label) {
+            return label;
+          }
+        }
+      }
+      return 'unknown type';
+    };
+
     return (
       <div className="relational-connection-editor">
         <ResizablePanelGroup orientation="horizontal">
@@ -1269,7 +1291,7 @@ const PostProcessorRelationalConnectionEditor = observer(
           <ResizablePanel>
             <div className="relational-connection-editor__content">
               <ResizablePanelGroup orientation="vertical">
-                <ResizablePanel size={150} minSize={70}>
+                <ResizablePanel size={200} minSize={100}>
                   <Panel>
                     <PanelHeader title="post-processor">
                       <DropdownMenu
@@ -1323,13 +1345,19 @@ const PostProcessorRelationalConnectionEditor = observer(
                           menuProps={{ elevation: 7 }}
                         >
                           <PanelListSelectorItem
-                            title={`Post-Processor ${idx + 1}`}
                             onSelect={() => selectPostProcessor(postProcessor)}
                             isSelected={
                               postProcessor ===
                               postProcessorState?.postProcessor
                             }
-                          />
+                          >
+                            <PanelListSelectorItemLabel
+                              title={`Post-Processor ${idx + 1}`}
+                            />
+                            <Badge
+                              title={getPostProcessorLabel(postProcessor)}
+                            />
+                          </PanelListSelectorItem>
                         </ContextMenu>
                       ))}
                     </PanelContent>

package/src/components/editor/edit-panel/connection-editor/post-processor-editor/MapperPostProcessorEditor.tsx

@@ -32,6 +32,7 @@ import {
   Panel,
   PanelHeader,
   PanelContent,
+  PanelListSelectorItemLabel,
 } from '@finos/legend-art';
 import {
   type Mapper,
@@ -181,21 +182,25 @@ export const MapperPostProcessorEditor = observer(
                       menuProps={{ elevation: 7 }}
                     >
                       <PanelListSelectorItem
-                        title={
-                          mapper instanceof TableNameMapper
-                            ? 'Table Mapper'
-                            : 'Schema Mapper'
-                        }
-                        validationErrorMessage={
-                          isMapperDuplicated(mapper)
-                            ? 'Mappers have the same values'
-                            : undefined
-                        }
+                        validationError={true}
                         isSelected={
                           mapper === postProcessorState.selectedMapper
                         }
                         onSelect={() => selectMapper(mapper)}
-                      />
+                      >
+                        <PanelListSelectorItemLabel
+                          title={
+                            mapper instanceof TableNameMapper
+                              ? 'Table Mapper'
+                              : 'Schema Mapper'
+                          }
+                          validationErrorMessage={
+                            isMapperDuplicated(mapper)
+                              ? 'Mappers have the same values'
+                              : undefined
+                          }
+                        />
+                      </PanelListSelectorItem>
                     </ContextMenu>
                   ))}
                 </PanelContent>{' '}

package/src/components/editor/edit-panel/data-editor/DataElementEditor.tsx

@@ -53,7 +53,7 @@ import {
   CORE_DND_TYPE,
   type UMLEditorElementDropTarget,
   type ElementDragSource,
-} from '../../../../stores/shared/DnDUtil.js';
+} from '../../../../stores/shared/DnDUtils.js';
 import {
   TaggedValueDragPreviewLayer,
   TaggedValueEditor,

package/src/components/editor/edit-panel/element-generation-editor/ElementGenerationEditor.tsx

@@ -105,7 +105,7 @@ const NewFileGenerationModal = observer(
           <div className="input-group">
             <input
               ref={nameRef}
-              className="modal--simple__input input--dark input-group__input"
+              className="input input--dark input-group__input"
               disabled={isReadOnly}
               value={servicePath}
               spellCheck={false}
@@ -120,9 +120,8 @@ const NewFileGenerationModal = observer(
           </div>
           <div className="search-modal__actions">
             <button
-              className="modal--simple__btn btn btn--dark btn--primary"
+              className="btn btn--dark"
               disabled={isReadOnly || elementAlreadyExists}
-              color="primary"
             >
               Create
             </button>

package/src/components/editor/edit-panel/element-generation-editor/FileGenerationEditor.tsx

@@ -61,7 +61,7 @@ import {
   type FileGenerationSourceDropTarget,
   type ElementDragSource,
   CORE_DND_TYPE,
-} from '../../../../stores/shared/DnDUtil.js';
+} from '../../../../stores/shared/DnDUtils.js';
 import type { FileGenerationState } from '../../../../stores/editor-state/FileGenerationState.js';
 import type { ElementFileGenerationState } from '../../../../stores/editor-state/element-editor-state/ElementFileGenerationState.js';
 import {
@@ -69,7 +69,7 @@ import {
   GenerationDirectory,
   GenerationFile,
   getFileGenerationChildNodes,
-} from '../../../../stores/shared/FileGenerationTreeUtil.js';
+} from '../../../../stores/shared/FileGenerationTreeUtils.js';
 import { LEGEND_STUDIO_TEST_ID } from '../../../LegendStudioTestID.js';
 import { useEditorStore } from '../../EditorStoreProvider.js';
 import {
@@ -84,7 +84,7 @@ import {
 } from '@finos/legend-graph';
 import { useApplicationStore } from '@finos/legend-application';
 import { StudioTextInputEditor } from '../../../shared/StudioTextInputEditor.js';
-import type { DSLGenerationSpecification_LegendStudioApplicationPlugin_Extension } from '../../../../stores/DSLGenerationSpecification_LegendStudioApplicationPlugin_Extension.js';
+import type { DSLGeneration_LegendStudioApplicationPlugin_Extension } from '../../../../stores/DSLGeneration_LegendStudioApplicationPlugin_Extension.js';
 import {
   fileGeneration_addScopeElement,
   fileGeneration_changeScopeElement,
@@ -239,7 +239,7 @@ export const GenerationResultViewer = observer(
             .flatMap(
               (plugin) =>
                 (
-                  plugin as DSLGenerationSpecification_LegendStudioApplicationPlugin_Extension
+                  plugin as DSLGeneration_LegendStudioApplicationPlugin_Extension
                 ).getExtraFileGenerationResultViewerActionConfigurations?.() ??
                 [],
             )

package/src/components/editor/edit-panel/external-format-editor/BindingElementEditor.tsx

@@ -50,7 +50,7 @@ import {
   CORE_DND_TYPE,
   type ElementDragSource,
   type UMLEditorElementDropTarget,
-} from '../../../../stores/shared/DnDUtil.js';
+} from '../../../../stores/shared/DnDUtils.js';
 import {
   externalFormat_Binding_setContentType,
   externalFormat_Binding_setSchemaId,

package/src/components/editor/edit-panel/external-format-editor/SchemaSetElementEditor.tsx

@@ -132,7 +132,6 @@ const SchemaLoader = observer(
           </div>
           <div className="modal__footer">
             <button
-              type="button"
               className="btn btn--dark blocking-alert__action--standard"
               onClick={importSchemas}
               disabled={!importState.files?.length}

package/src/components/editor/edit-panel/mapping-editor/ClassMappingEditor.tsx

@@ -43,7 +43,7 @@ import {
   operationMapping_setParameters,
   setImpl_setRoot,
 } from '../../../../stores/graphModifier/DSLMapping_GraphModifierHelper.js';
-import { SET_IMPLEMENTATION_TYPE } from '../../../../stores/shared/ModelUtil.js';
+import { SET_IMPLEMENTATION_TYPE } from '../../../../stores/shared/ModelClassifierUtils.js';
 import type { DSLMapping_LegendStudioApplicationPlugin_Extension } from '../../../../stores/DSLMapping_LegendStudioApplicationPlugin_Extension.js';
 
 export const OperatorSelector = observer(

package/src/components/editor/edit-panel/mapping-editor/EnumerationMappingEditor.tsx

@@ -41,7 +41,7 @@ import {
   type MappingElementSourceDropTarget,
   CORE_DND_TYPE,
   TypeDragSource,
-} from '../../../../stores/shared/DnDUtil.js';
+} from '../../../../stores/shared/DnDUtils.js';
 import { LEGEND_STUDIO_TEST_ID } from '../../../LegendStudioTestID.js';
 import { noop } from '@finos/legend-shared';
 import {

package/src/components/editor/edit-panel/mapping-editor/FlatDataPropertyMappingEditor.tsx

@@ -20,7 +20,7 @@ import {
   type FlatDataPropertyMappingTransformDropTarget,
   CORE_DND_TYPE,
   FlatDataColumnDragSource,
-} from '../../../../stores/shared/DnDUtil.js';
+} from '../../../../stores/shared/DnDUtils.js';
 import {
   type MappingElement,
   MappingEditorState,
@@ -50,7 +50,7 @@ import { flatDataPropertyMapping_setTransformer } from '../../../../stores/graph
 import {
   CLASS_PROPERTY_TYPE,
   getClassPropertyType,
-} from '../../../../stores/shared/ModelUtil.js';
+} from '../../../../stores/shared/ModelClassifierUtils.js';
 
 const SimplePropertyMappingEditor = observer(
   (props: {

package/src/components/editor/edit-panel/mapping-editor/FlatDataRecordTypeTree.tsx

@@ -26,8 +26,8 @@ import {
 import {
   CORE_DND_TYPE,
   FlatDataColumnDragSource,
-} from '../../../../stores/shared/DnDUtil.js';
-import type { FlatDataRecordTypeTreeNodeData } from '../../../../stores/shared/TreeUtil.js';
+} from '../../../../stores/shared/DnDUtils.js';
+import type { FlatDataRecordTypeTreeNodeData } from '../../../../stores/shared/TreeUtils.js';
 import { addUniqueEntry } from '@finos/legend-shared';
 import {
   DEFAULT_SOURCE_PARAMETER_NAME,

package/src/components/editor/edit-panel/mapping-editor/InstanceSetImplementationEditor.tsx

@@ -31,7 +31,7 @@ import {
   CORE_DND_TYPE,
   type ElementDragSource,
   type MappingElementSourceDropTarget,
-} from '../../../../stores/shared/DnDUtil.js';
+} from '../../../../stores/shared/DnDUtils.js';
 import { LEGEND_STUDIO_TEST_ID } from '../../../LegendStudioTestID.js';
 import {
   InstanceSetImplementationState,

package/src/components/editor/edit-panel/mapping-editor/MappingExecutionBuilder.tsx

@@ -52,13 +52,8 @@ import { NewServiceModal } from '../service-editor/NewServiceModal.js';
 import {
   type MappingElementDragSource,
   CORE_DND_TYPE,
-} from '../../../../stores/shared/DnDUtil.js';
-import {
-  assertErrorThrown,
-  guaranteeType,
-  hashObject,
-  uniq,
-} from '@finos/legend-shared';
+} from '../../../../stores/shared/DnDUtils.js';
+import { assertErrorThrown, guaranteeType, uniq } from '@finos/legend-shared';
 import {
   type MappingExecutionState,
   MappingExecutionEmptyInputDataState,
@@ -201,10 +196,6 @@ const MappingExecutionQueryEditor = observer(
               queryBuilderState.initializeWithQuery(
                 executionState.queryState.query,
               );
-              queryBuilderState.changeDetectionState.setQueryHashCode(
-                hashObject(executionState.queryState.query),
-              );
-              queryBuilderState.changeDetectionState.setIsEnabled(true);
               return queryBuilderState;
             },
             actionConfigs: [
@@ -223,9 +214,6 @@ const MappingExecutionQueryEditor = observer(
                         applicationStore.notifySuccess(
                           `Mapping execution query is updated`,
                         );
-                        queryBuilderState.changeDetectionState.setQueryHashCode(
-                          hashObject(rawLambda),
-                        );
                         embeddedQueryBuilderState.setEmbeddedQueryBuilderConfiguration(
                           undefined,
                         );

package/src/components/editor/edit-panel/mapping-editor/MappingExplorer.tsx

@@ -21,7 +21,7 @@ import {
   type ElementDragSource,
   CORE_DND_TYPE,
   MappingElementDragSource,
-} from '../../../../stores/shared/DnDUtil.js';
+} from '../../../../stores/shared/DnDUtils.js';
 import {
   type TreeNodeContainerProps,
   clsx,

package/src/components/editor/edit-panel/mapping-editor/MappingTestEditor.tsx

@@ -51,12 +51,11 @@ import { useDrop } from 'react-dnd';
 import {
   type MappingElementDragSource,
   CORE_DND_TYPE,
-} from '../../../../stores/shared/DnDUtil.js';
+} from '../../../../stores/shared/DnDUtils.js';
 import {
   IllegalStateError,
   guaranteeType,
   tryToFormatLosslessJSONString,
-  hashObject,
   assertErrorThrown,
 } from '@finos/legend-shared';
 import {
@@ -115,10 +114,6 @@ const MappingTestQueryEditor = observer(
                 embeddedQueryBuilderState.editorStore.graphManagerState,
               );
               queryBuilderState.initializeWithQuery(testState.queryState.query);
-              queryBuilderState.changeDetectionState.setQueryHashCode(
-                hashObject(testState.queryState.query),
-              );
-              queryBuilderState.changeDetectionState.setIsEnabled(true);
               return queryBuilderState;
             },
             actionConfigs: [
@@ -137,9 +132,6 @@ const MappingTestQueryEditor = observer(
                         applicationStore.notifySuccess(
                           `Mapping test query is updated`,
                         );
-                        queryBuilderState.changeDetectionState.setQueryHashCode(
-                          hashObject(rawLambda),
-                        );
                         embeddedQueryBuilderState.setEmbeddedQueryBuilderConfiguration(
                           undefined,
                         );

package/src/components/editor/edit-panel/mapping-editor/MappingTestsExplorer.tsx

@@ -42,7 +42,7 @@ import {
 import {
   type MappingElementDragSource,
   CORE_DND_TYPE,
-} from '../../../../stores/shared/DnDUtil.js';
+} from '../../../../stores/shared/DnDUtils.js';
 import { ClassMappingSelectorModal } from './MappingExecutionBuilder.js';
 import { flowResult } from 'mobx';
 import { Randomizer } from '@finos/legend-shared';