@finos/legend-application-repl 0.0.53 → 0.0.55

package/src/stores/dataCube/core/aggregation/DataCubeQueryAggregateOperation__VarianceSample.tsx

@@ -0,0 +1,52 @@
+/**
+ * Copyright (c) 2020-present, Goldman Sachs
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import type { DataCubeQuerySnapshotColumn } from '../DataCubeQuerySnapshot.js';
+import { DataCubeQueryAggregateOperation } from './DataCubeQueryAggregateOperation.js';
+import {
+  DataCubeAggregateOperator,
+  DataCubeColumnDataType,
+  DataCubeFunction,
+  ofDataType,
+} from '../DataCubeQueryEngine.js';
+import { _aggCol_basic } from '../DataCubeQueryBuilderUtils.js';
+import type { DataCubeColumnConfiguration } from '../DataCubeConfiguration.js';
+
+export class DataCubeQueryAggregateOperation__VarianceSample extends DataCubeQueryAggregateOperation {
+  override get label() {
+    return 'var (sample)';
+  }
+
+  override get textLabel() {
+    return 'variance (sample)';
+  }
+
+  override get description() {
+    return 'variance (sample)';
+  }
+
+  override get operator(): string {
+    return DataCubeAggregateOperator.VARIANCE_SAMPLE;
+  }
+
+  isCompatibleWithColumn(column: DataCubeQuerySnapshotColumn) {
+    return ofDataType(column.type, [DataCubeColumnDataType.NUMBER]);
+  }
+
+  buildAggregateColumn(column: DataCubeColumnConfiguration) {
+    return _aggCol_basic(column, DataCubeFunction.VARIANCE_SAMPLE);
+  }
+}

package/src/stores/dataCube/core/filter/DataCubeQueryFilterOperation.ts

@@ -14,7 +14,11 @@
  * limitations under the License.
  */
 
-import { formatDate, UnsupportedOperationError } from '@finos/legend-shared';
+import {
+  formatDate,
+  guaranteeNonNullable,
+  UnsupportedOperationError,
+} from '@finos/legend-shared';
 import type { DataCubeOperationValue } from '../DataCubeQueryEngine.js';
 import type {
   DataCubeQuerySnapshotColumn,
@@ -57,27 +61,14 @@ export function generateDefaultFilterConditionPrimitiveTypeValue(
   }
 }
 
-export function ofType(
-  type: string,
-  targetTypes: ('string' | 'number' | 'boolean' | 'date')[],
+export function getFilterOperation(
+  operator: string,
+  operators: DataCubeQueryFilterOperation[],
 ) {
-  switch (type) {
-    case PRIMITIVE_TYPE.STRING:
-      return targetTypes.includes('string');
-    case PRIMITIVE_TYPE.BOOLEAN:
-      return targetTypes.includes('boolean');
-    case PRIMITIVE_TYPE.NUMBER:
-    case PRIMITIVE_TYPE.DECIMAL:
-    case PRIMITIVE_TYPE.FLOAT:
-    case PRIMITIVE_TYPE.INTEGER:
-      return targetTypes.includes('number');
-    case PRIMITIVE_TYPE.DATE:
-    case PRIMITIVE_TYPE.STRICTDATE:
-    case PRIMITIVE_TYPE.DATETIME:
-      return targetTypes.includes('date');
-    default:
-      return false;
-  }
+  return guaranteeNonNullable(
+    operators.find((op) => op.operator === operator),
+    `Can't find filter operation '${operator}'`,
+  );
 }
 
 // --------------------------------- CONTRACT ---------------------------------

package/src/stores/dataCube/core/filter/DataCubeQueryFilterOperation__Contain.tsx

@@ -18,15 +18,16 @@ import { type V1_AppliedFunction } from '@finos/legend-graph';
 import {
   DataCubeQueryFilterOperation,
   generateDefaultFilterConditionPrimitiveTypeValue,
-  ofType,
 } from './DataCubeQueryFilterOperation.js';
 import type {
   DataCubeQuerySnapshotColumn,
   DataCubeQuerySnapshotFilterCondition,
 } from '../DataCubeQuerySnapshot.js';
 import {
+  DataCubeColumnDataType,
   DataCubeFunction,
   DataCubeQueryFilterOperator,
+  ofDataType,
   type DataCubeOperationValue,
 } from '../DataCubeQueryEngine.js';
 import {
@@ -55,12 +56,12 @@ export class DataCubeQueryFilterOperation__Contain extends DataCubeQueryFilterOp
   }
 
   isCompatibleWithColumn(column: DataCubeQuerySnapshotColumn) {
-    return ofType(column.type, ['string']);
+    return ofDataType(column.type, [DataCubeColumnDataType.TEXT]);
   }
 
   isCompatibleWithValue(value: DataCubeOperationValue) {
     return (
-      ofType(value.type, ['string']) &&
+      ofDataType(value.type, [DataCubeColumnDataType.TEXT]) &&
       value.value !== undefined &&
       !Array.isArray(value.value)
     );
@@ -74,7 +75,7 @@ export class DataCubeQueryFilterOperation__Contain extends DataCubeQueryFilterOp
   }
 
   buildConditionSnapshot(expression: V1_AppliedFunction) {
-    // TODO: @akphi - implement this for roundtrip testing
+    /** TODO: @datacube roundtrip */
     return undefined;
   }
 

package/src/stores/dataCube/core/filter/DataCubeQueryFilterOperation__ContainCaseInsensitive.tsx

@@ -18,15 +18,16 @@ import { type V1_AppliedFunction } from '@finos/legend-graph';
 import {
   DataCubeQueryFilterOperation,
   generateDefaultFilterConditionPrimitiveTypeValue,
-  ofType,
 } from './DataCubeQueryFilterOperation.js';
 import type {
   DataCubeQuerySnapshotColumn,
   DataCubeQuerySnapshotFilterCondition,
 } from '../DataCubeQuerySnapshot.js';
 import {
+  DataCubeColumnDataType,
   DataCubeFunction,
   DataCubeQueryFilterOperator,
+  ofDataType,
   type DataCubeOperationValue,
 } from '../DataCubeQueryEngine.js';
 import {
@@ -56,12 +57,12 @@ export class DataCubeQueryFilterOperation__ContainCaseInsensitive extends DataCu
   }
 
   isCompatibleWithColumn(column: DataCubeQuerySnapshotColumn) {
-    return ofType(column.type, ['string']);
+    return ofDataType(column.type, [DataCubeColumnDataType.TEXT]);
   }
 
   isCompatibleWithValue(value: DataCubeOperationValue) {
     return (
-      ofType(value.type, ['string']) &&
+      ofDataType(value.type, [DataCubeColumnDataType.TEXT]) &&
       value.value !== undefined &&
       !Array.isArray(value.value)
     );
@@ -75,7 +76,7 @@ export class DataCubeQueryFilterOperation__ContainCaseInsensitive extends DataCu
   }
 
   buildConditionSnapshot(expression: V1_AppliedFunction) {
-    // TODO: @akphi - implement this for roundtrip testing
+    /** TODO: @datacube roundtrip */
     return undefined;
   }
 

package/src/stores/dataCube/core/filter/DataCubeQueryFilterOperation__EndWith.tsx

@@ -18,15 +18,16 @@ import { type V1_AppliedFunction } from '@finos/legend-graph';
 import {
   DataCubeQueryFilterOperation,
   generateDefaultFilterConditionPrimitiveTypeValue,
-  ofType,
 } from './DataCubeQueryFilterOperation.js';
 import type {
   DataCubeQuerySnapshotColumn,
   DataCubeQuerySnapshotFilterCondition,
 } from '../DataCubeQuerySnapshot.js';
 import {
+  DataCubeColumnDataType,
   DataCubeFunction,
   DataCubeQueryFilterOperator,
+  ofDataType,
   type DataCubeOperationValue,
 } from '../DataCubeQueryEngine.js';
 import {
@@ -55,12 +56,12 @@ export class DataCubeQueryFilterOperation__EndWith extends DataCubeQueryFilterOp
   }
 
   isCompatibleWithColumn(column: DataCubeQuerySnapshotColumn) {
-    return ofType(column.type, ['string']);
+    return ofDataType(column.type, [DataCubeColumnDataType.TEXT]);
   }
 
   isCompatibleWithValue(value: DataCubeOperationValue) {
     return (
-      ofType(value.type, ['string']) &&
+      ofDataType(value.type, [DataCubeColumnDataType.TEXT]) &&
       value.value !== undefined &&
       !Array.isArray(value.value)
     );
@@ -74,7 +75,7 @@ export class DataCubeQueryFilterOperation__EndWith extends DataCubeQueryFilterOp
   }
 
   buildConditionSnapshot(expression: V1_AppliedFunction) {
-    // TODO: @akphi - implement this for roundtrip testing
+    /** TODO: @datacube roundtrip */
     return undefined;
   }
 

package/src/stores/dataCube/core/filter/DataCubeQueryFilterOperation__EndWithCaseInsensitive.tsx

@@ -18,15 +18,16 @@ import { type V1_AppliedFunction } from '@finos/legend-graph';
 import {
   DataCubeQueryFilterOperation,
   generateDefaultFilterConditionPrimitiveTypeValue,
-  ofType,
 } from './DataCubeQueryFilterOperation.js';
 import type {
   DataCubeQuerySnapshotColumn,
   DataCubeQuerySnapshotFilterCondition,
 } from '../DataCubeQuerySnapshot.js';
 import {
+  DataCubeColumnDataType,
   DataCubeFunction,
   DataCubeQueryFilterOperator,
+  ofDataType,
   type DataCubeOperationValue,
 } from '../DataCubeQueryEngine.js';
 import {
@@ -56,12 +57,12 @@ export class DataCubeQueryFilterOperation__EndWithCaseInsensitive extends DataCu
   }
 
   isCompatibleWithColumn(column: DataCubeQuerySnapshotColumn) {
-    return ofType(column.type, ['string']);
+    return ofDataType(column.type, [DataCubeColumnDataType.TEXT]);
   }
 
   isCompatibleWithValue(value: DataCubeOperationValue) {
     return (
-      ofType(value.type, ['string']) &&
+      ofDataType(value.type, [DataCubeColumnDataType.TEXT]) &&
       value.value !== undefined &&
       !Array.isArray(value.value)
     );
@@ -75,7 +76,7 @@ export class DataCubeQueryFilterOperation__EndWithCaseInsensitive extends DataCu
   }
 
   buildConditionSnapshot(expression: V1_AppliedFunction) {
-    // TODO: @akphi - implement this for roundtrip testing
+    /** TODO: @datacube roundtrip */
     return undefined;
   }
 

package/src/stores/dataCube/core/filter/DataCubeQueryFilterOperation__Equal.tsx

@@ -18,15 +18,16 @@ import { type V1_AppliedFunction } from '@finos/legend-graph';
 import {
   DataCubeQueryFilterOperation,
   generateDefaultFilterConditionPrimitiveTypeValue,
-  ofType,
 } from './DataCubeQueryFilterOperation.js';
 import type {
   DataCubeQuerySnapshotColumn,
   DataCubeQuerySnapshotFilterCondition,
 } from '../DataCubeQuerySnapshot.js';
 import {
+  DataCubeColumnDataType,
   DataCubeFunction,
   DataCubeQueryFilterOperator,
+  ofDataType,
   type DataCubeOperationValue,
 } from '../DataCubeQueryEngine.js';
 import {
@@ -55,12 +56,22 @@ export class DataCubeQueryFilterOperation__Equal extends DataCubeQueryFilterOper
   }
 
   isCompatibleWithColumn(column: DataCubeQuerySnapshotColumn) {
-    return ofType(column.type, ['string', 'number', 'date']);
+    return ofDataType(column.type, [
+      DataCubeColumnDataType.TEXT,
+      DataCubeColumnDataType.NUMBER,
+      DataCubeColumnDataType.DATE,
+      DataCubeColumnDataType.TIME,
+    ]);
   }
 
   isCompatibleWithValue(value: DataCubeOperationValue) {
     return (
-      ofType(value.type, ['string', 'number', 'date']) &&
+      ofDataType(value.type, [
+        DataCubeColumnDataType.TEXT,
+        DataCubeColumnDataType.NUMBER,
+        DataCubeColumnDataType.DATE,
+        DataCubeColumnDataType.TIME,
+      ]) &&
       value.value !== undefined &&
       !Array.isArray(value.value)
     );
@@ -74,7 +85,7 @@ export class DataCubeQueryFilterOperation__Equal extends DataCubeQueryFilterOper
   }
 
   buildConditionSnapshot(expression: V1_AppliedFunction) {
-    // TODO: @akphi - implement this for roundtrip testing
+    /** TODO: @datacube roundtrip */
     // export const buildPostFilterConditionState = (
     //   postFilterState: QueryBuilderPostFilterState,
     //   expression: FunctionExpression,

package/src/stores/dataCube/core/filter/DataCubeQueryFilterOperation__EqualCaseInsensitive.tsx

@@ -18,15 +18,16 @@ import { type V1_AppliedFunction } from '@finos/legend-graph';
 import {
   DataCubeQueryFilterOperation,
   generateDefaultFilterConditionPrimitiveTypeValue,
-  ofType,
 } from './DataCubeQueryFilterOperation.js';
 import type {
   DataCubeQuerySnapshotColumn,
   DataCubeQuerySnapshotFilterCondition,
 } from '../DataCubeQuerySnapshot.js';
 import {
+  DataCubeColumnDataType,
   DataCubeFunction,
   DataCubeQueryFilterOperator,
+  ofDataType,
   type DataCubeOperationValue,
 } from '../DataCubeQueryEngine.js';
 import {
@@ -56,12 +57,12 @@ export class DataCubeQueryFilterOperation__EqualCaseInsensitive extends DataCube
   }
 
   isCompatibleWithColumn(column: DataCubeQuerySnapshotColumn) {
-    return ofType(column.type, ['string']);
+    return ofDataType(column.type, [DataCubeColumnDataType.TEXT]);
   }
 
   isCompatibleWithValue(value: DataCubeOperationValue) {
     return (
-      ofType(value.type, ['string']) &&
+      ofDataType(value.type, [DataCubeColumnDataType.TEXT]) &&
       value.value !== undefined &&
       !Array.isArray(value.value)
     );
@@ -75,7 +76,7 @@ export class DataCubeQueryFilterOperation__EqualCaseInsensitive extends DataCube
   }
 
   buildConditionSnapshot(expression: V1_AppliedFunction) {
-    // TODO: @akphi - implement this for roundtrip testing
+    /** TODO: @datacube roundtrip */
     return undefined;
   }
 

package/src/stores/dataCube/core/filter/DataCubeQueryFilterOperation__EqualCaseInsensitiveColumn.tsx

@@ -15,18 +15,17 @@
  */
 
 import { type V1_AppliedFunction } from '@finos/legend-graph';
-import {
-  DataCubeQueryFilterOperation,
-  ofType,
-} from './DataCubeQueryFilterOperation.js';
+import { DataCubeQueryFilterOperation } from './DataCubeQueryFilterOperation.js';
 import type {
   DataCubeQuerySnapshotColumn,
   DataCubeQuerySnapshotFilterCondition,
 } from '../DataCubeQuerySnapshot.js';
 import {
+  DataCubeColumnDataType,
   DataCubeFunction,
   DataCubeOperationAdvancedValueType,
   DataCubeQueryFilterOperator,
+  ofDataType,
   type DataCubeOperationValue,
 } from '../DataCubeQueryEngine.js';
 import {
@@ -56,7 +55,7 @@ export class DataCubeQueryFilterOperation__EqualCaseInsensitiveColumn extends Da
   }
 
   isCompatibleWithColumn(column: DataCubeQuerySnapshotColumn) {
-    return ofType(column.type, ['string']);
+    return ofDataType(column.type, [DataCubeColumnDataType.TEXT]);
   }
 
   isCompatibleWithValue(value: DataCubeOperationValue) {
@@ -75,7 +74,7 @@ export class DataCubeQueryFilterOperation__EqualCaseInsensitiveColumn extends Da
   }
 
   buildConditionSnapshot(expression: V1_AppliedFunction) {
-    // TODO: @akphi - implement this for roundtrip testing
+    /** TODO: @datacube roundtrip */
     return undefined;
   }
 

package/src/stores/dataCube/core/filter/DataCubeQueryFilterOperation__EqualColumn.tsx

@@ -15,18 +15,17 @@
  */
 
 import { type V1_AppliedFunction } from '@finos/legend-graph';
-import {
-  DataCubeQueryFilterOperation,
-  ofType,
-} from './DataCubeQueryFilterOperation.js';
+import { DataCubeQueryFilterOperation } from './DataCubeQueryFilterOperation.js';
 import type {
   DataCubeQuerySnapshotColumn,
   DataCubeQuerySnapshotFilterCondition,
 } from '../DataCubeQuerySnapshot.js';
 import {
+  DataCubeColumnDataType,
   DataCubeFunction,
   DataCubeOperationAdvancedValueType,
   DataCubeQueryFilterOperator,
+  ofDataType,
   type DataCubeOperationValue,
 } from '../DataCubeQueryEngine.js';
 import {
@@ -56,7 +55,12 @@ export class DataCubeQueryFilterOperation__EqualColumn extends DataCubeQueryFilt
   }
 
   isCompatibleWithColumn(column: DataCubeQuerySnapshotColumn) {
-    return ofType(column.type, ['string', 'number', 'date']);
+    return ofDataType(column.type, [
+      DataCubeColumnDataType.TEXT,
+      DataCubeColumnDataType.NUMBER,
+      DataCubeColumnDataType.DATE,
+      DataCubeColumnDataType.TIME,
+    ]);
   }
 
   isCompatibleWithValue(value: DataCubeOperationValue) {
@@ -75,7 +79,7 @@ export class DataCubeQueryFilterOperation__EqualColumn extends DataCubeQueryFilt
   }
 
   buildConditionSnapshot(expression: V1_AppliedFunction) {
-    // TODO: @akphi - implement this for roundtrip testing
+    /** TODO: @datacube roundtrip */
     return undefined;
   }
 

package/src/stores/dataCube/core/filter/DataCubeQueryFilterOperation__GreaterThan.tsx

@@ -18,15 +18,16 @@ import { type V1_AppliedFunction } from '@finos/legend-graph';
 import {
   DataCubeQueryFilterOperation,
   generateDefaultFilterConditionPrimitiveTypeValue,
-  ofType,
 } from './DataCubeQueryFilterOperation.js';
 import type {
   DataCubeQuerySnapshotColumn,
   DataCubeQuerySnapshotFilterCondition,
 } from '../DataCubeQuerySnapshot.js';
 import {
+  DataCubeColumnDataType,
   DataCubeFunction,
   DataCubeQueryFilterOperator,
+  ofDataType,
   type DataCubeOperationValue,
 } from '../DataCubeQueryEngine.js';
 import {
@@ -55,12 +56,20 @@ export class DataCubeQueryFilterOperation__GreaterThan extends DataCubeQueryFilt
   }
 
   isCompatibleWithColumn(column: DataCubeQuerySnapshotColumn) {
-    return ofType(column.type, ['number', 'date']);
+    return ofDataType(column.type, [
+      DataCubeColumnDataType.NUMBER,
+      DataCubeColumnDataType.DATE,
+      DataCubeColumnDataType.TIME,
+    ]);
   }
 
   isCompatibleWithValue(value: DataCubeOperationValue) {
     return (
-      ofType(value.type, ['number', 'date']) &&
+      ofDataType(value.type, [
+        DataCubeColumnDataType.NUMBER,
+        DataCubeColumnDataType.DATE,
+        DataCubeColumnDataType.TIME,
+      ]) &&
       value.value !== undefined &&
       !Array.isArray(value.value)
     );
@@ -74,7 +83,7 @@ export class DataCubeQueryFilterOperation__GreaterThan extends DataCubeQueryFilt
   }
 
   buildConditionSnapshot(expression: V1_AppliedFunction) {
-    // TODO: @akphi - implement this for roundtrip testing
+    /** TODO: @datacube roundtrip */
     return undefined;
   }
 

package/src/stores/dataCube/core/filter/DataCubeQueryFilterOperation__GreaterThanColumn.tsx

@@ -15,18 +15,17 @@
  */
 
 import { type V1_AppliedFunction } from '@finos/legend-graph';
-import {
-  DataCubeQueryFilterOperation,
-  ofType,
-} from './DataCubeQueryFilterOperation.js';
+import { DataCubeQueryFilterOperation } from './DataCubeQueryFilterOperation.js';
 import type {
   DataCubeQuerySnapshotColumn,
   DataCubeQuerySnapshotFilterCondition,
 } from '../DataCubeQuerySnapshot.js';
 import {
+  DataCubeColumnDataType,
   DataCubeFunction,
   DataCubeOperationAdvancedValueType,
   DataCubeQueryFilterOperator,
+  ofDataType,
   type DataCubeOperationValue,
 } from '../DataCubeQueryEngine.js';
 import {
@@ -56,7 +55,11 @@ export class DataCubeQueryFilterOperation__GreaterThanColumn extends DataCubeQue
   }
 
   isCompatibleWithColumn(column: DataCubeQuerySnapshotColumn) {
-    return ofType(column.type, ['string', 'number', 'date']);
+    return ofDataType(column.type, [
+      DataCubeColumnDataType.NUMBER,
+      DataCubeColumnDataType.DATE,
+      DataCubeColumnDataType.TIME,
+    ]);
   }
 
   isCompatibleWithValue(value: DataCubeOperationValue) {
@@ -75,7 +78,7 @@ export class DataCubeQueryFilterOperation__GreaterThanColumn extends DataCubeQue
   }
 
   buildConditionSnapshot(expression: V1_AppliedFunction) {
-    // TODO: @akphi - implement this for roundtrip testing
+    /** TODO: @datacube roundtrip */
     return undefined;
   }
 

package/src/stores/dataCube/core/filter/DataCubeQueryFilterOperation__GreaterThanOrEqual.tsx

@@ -18,15 +18,16 @@ import { type V1_AppliedFunction } from '@finos/legend-graph';
 import {
   DataCubeQueryFilterOperation,
   generateDefaultFilterConditionPrimitiveTypeValue,
-  ofType,
 } from './DataCubeQueryFilterOperation.js';
 import type {
   DataCubeQuerySnapshotColumn,
   DataCubeQuerySnapshotFilterCondition,
 } from '../DataCubeQuerySnapshot.js';
 import {
+  DataCubeColumnDataType,
   DataCubeFunction,
   DataCubeQueryFilterOperator,
+  ofDataType,
   type DataCubeOperationValue,
 } from '../DataCubeQueryEngine.js';
 import {
@@ -55,12 +56,20 @@ export class DataCubeQueryFilterOperation__GreaterThanOrEqual extends DataCubeQu
   }
 
   isCompatibleWithColumn(column: DataCubeQuerySnapshotColumn) {
-    return ofType(column.type, ['number']);
+    return ofDataType(column.type, [
+      DataCubeColumnDataType.NUMBER,
+      DataCubeColumnDataType.DATE,
+      DataCubeColumnDataType.TIME,
+    ]);
   }
 
   isCompatibleWithValue(value: DataCubeOperationValue) {
     return (
-      ofType(value.type, ['number']) &&
+      ofDataType(value.type, [
+        DataCubeColumnDataType.NUMBER,
+        DataCubeColumnDataType.DATE,
+        DataCubeColumnDataType.TIME,
+      ]) &&
       value.value !== undefined &&
       !Array.isArray(value.value)
     );
@@ -74,7 +83,7 @@ export class DataCubeQueryFilterOperation__GreaterThanOrEqual extends DataCubeQu
   }
 
   buildConditionSnapshot(expression: V1_AppliedFunction) {
-    // TODO: @akphi - implement this for roundtrip testing
+    /** TODO: @datacube roundtrip */
     return undefined;
   }
 

package/src/stores/dataCube/core/filter/DataCubeQueryFilterOperation__GreaterThanOrEqualColumn.tsx

@@ -15,18 +15,17 @@
  */
 
 import { type V1_AppliedFunction } from '@finos/legend-graph';
-import {
-  DataCubeQueryFilterOperation,
-  ofType,
-} from './DataCubeQueryFilterOperation.js';
+import { DataCubeQueryFilterOperation } from './DataCubeQueryFilterOperation.js';
 import type {
   DataCubeQuerySnapshotColumn,
   DataCubeQuerySnapshotFilterCondition,
 } from '../DataCubeQuerySnapshot.js';
 import {
+  DataCubeColumnDataType,
   DataCubeFunction,
   DataCubeOperationAdvancedValueType,
   DataCubeQueryFilterOperator,
+  ofDataType,
   type DataCubeOperationValue,
 } from '../DataCubeQueryEngine.js';
 import {
@@ -56,7 +55,11 @@ export class DataCubeQueryFilterOperation__GreaterThanOrEqualColumn extends Data
   }
 
   isCompatibleWithColumn(column: DataCubeQuerySnapshotColumn) {
-    return ofType(column.type, ['string', 'number', 'date']);
+    return ofDataType(column.type, [
+      DataCubeColumnDataType.NUMBER,
+      DataCubeColumnDataType.DATE,
+      DataCubeColumnDataType.TIME,
+    ]);
   }
 
   isCompatibleWithValue(value: DataCubeOperationValue) {
@@ -75,7 +78,7 @@ export class DataCubeQueryFilterOperation__GreaterThanOrEqualColumn extends Data
   }
 
   buildConditionSnapshot(expression: V1_AppliedFunction) {
-    // TODO: @akphi - implement this for roundtrip testing
+    /** TODO: @datacube roundtrip */
     return undefined;
   }