@finos/legend-application-repl 0.0.36 → 0.0.37

package/src/stores/REPLStore.tsx

@@ -0,0 +1,145 @@
+/**
+ * Copyright (c) 2020-present, Goldman Sachs
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import type { LegendREPLApplicationStore } from './LegendREPLBaseStore.js';
+import { REPLServerClient } from '../server/REPLServerClient.js';
+import {
+  ActionState,
+  assertErrorThrown,
+  LogEvent,
+  NetworkClient,
+} from '@finos/legend-shared';
+import { makeObservable, observable } from 'mobx';
+import { DataCubeState } from './dataCube/DataCubeState.js';
+import { DataCubeEngine } from './dataCube/DataCubeEngine.js';
+import { LicenseManager } from '@ag-grid-enterprise/core';
+import { ActionAlertType, APPLICATION_EVENT } from '@finos/legend-application';
+import {
+  DEFAULT_ALERT_WINDOW_CONFIG,
+  LayoutConfiguration,
+  LayoutManagerState,
+  SingletonModeDisplayState,
+  WindowState,
+} from './LayoutManagerState.js';
+import { ErrorAlert } from '../components/repl/Alert.js';
+import { DocumentationPanel } from '../components/repl/DocumentationPanel.js';
+import { SettingsPanel } from '../components/repl/SettingsPanel.js';
+
+export class REPLStore {
+  readonly application: LegendREPLApplicationStore;
+  readonly client: REPLServerClient;
+  readonly layout: LayoutManagerState;
+  readonly initState = ActionState.create();
+  readonly settingsDisplay: SingletonModeDisplayState;
+  readonly documentationDisplay: SingletonModeDisplayState;
+
+  dataCubeEngine!: DataCubeEngine;
+
+  // TODO: when we support multi-view, we would need to support multiple states
+  dataCube!: DataCubeState;
+
+  constructor(application: LegendREPLApplicationStore) {
+    makeObservable(this, {
+      dataCube: observable,
+    });
+
+    this.application = application;
+    this.client = new REPLServerClient(
+      new NetworkClient({
+        baseUrl: this.application.config.useDynamicREPLServer
+          ? window.location.origin +
+            this.application.config.baseAddress.replace('/repl/', '')
+          : this.application.config.replUrl,
+      }),
+    );
+    this.layout = new LayoutManagerState(this.application);
+    this.dataCubeEngine = new DataCubeEngine(this);
+    this.dataCube = new DataCubeState(this);
+    this.settingsDisplay = new SingletonModeDisplayState(
+      this.layout,
+      'Settings',
+      () => <SettingsPanel />,
+    );
+    this.settingsDisplay.configuration.window = {
+      x: -50,
+      y: 50,
+      width: 600,
+      height: 400,
+      minWidth: 300,
+      minHeight: 200,
+      center: false,
+    };
+    this.documentationDisplay = new SingletonModeDisplayState(
+      this.layout,
+      'Documentation',
+      () => <DocumentationPanel />,
+    );
+    this.documentationDisplay.configuration.window = {
+      x: -50,
+      y: -50,
+      width: 400,
+      height: 400,
+      minWidth: 300,
+      minHeight: 200,
+      center: false,
+    };
+  }
+
+  notifyError(error: Error, message: string, text?: string | undefined): void {
+    this.application.notificationService.notifyError(error);
+    const window = new WindowState(
+      new LayoutConfiguration('Error', () => (
+        <ErrorAlert message={message} text={text} />
+      )),
+    );
+    window.configuration.window = DEFAULT_ALERT_WINDOW_CONFIG;
+    this.layout.newWindow(window);
+  }
+
+  async initialize(): Promise<void> {
+    if (!this.initState.isInInitialState) {
+      // eslint-disable-next-line no-process-env
+      if (process.env.NODE_ENV === 'production') {
+        this.application.notificationService.notifyIllegalState(
+          'REPL store is re-initialized',
+        );
+      } else {
+        this.application.logService.debug(
+          LogEvent.create(APPLICATION_EVENT.DEBUG),
+          'REPL store is re-initialized',
+        );
+      }
+      return;
+    }
+    this.initState.inProgress();
+
+    try {
+      const info = await this.dataCubeEngine.getInfrastructureInfo();
+      if (info.gridClientLicense) {
+        LicenseManager.setLicenseKey(info.gridClientLicense);
+      }
+      this.initState.pass();
+    } catch (error: unknown) {
+      assertErrorThrown(error);
+      this.application.alertService.setActionAlertInfo({
+        message: `Initialization failure: ${error.message}`,
+        type: ActionAlertType.ERROR,
+        actions: [],
+      });
+      this.initState.fail();
+    }
+  }
+}

package/src/stores/dataCube/{DataCubeInfrastructure.ts → DataCubeEngine.ts}

@@ -26,22 +26,70 @@ import {
 import type { REPLServerClient } from '../../server/REPLServerClient.js';
 import {
   DataCubeGetBaseQueryResult,
+  type DataCubeInfrastructureInfo,
   type CompletionItem,
-} from '../../server/models/DataCubeEngineModels.js';
+} from '../../server/REPLEngine.js';
 import { guaranteeType } from '@finos/legend-shared';
 import type { LegendREPLApplicationStore } from '../LegendREPLBaseStore.js';
 import type { REPLStore } from '../REPLStore.js';
 import { action, makeObservable, observable } from 'mobx';
 
-class DataCubeEngine {
+export const DEFAULT_ENABLE_DEBUG_MODE = false;
+export const DEFAULT_GRID_CLIENT_ROW_BUFFER = 50;
+export const DEFAULT_GRID_CLIENT_PURGE_CLOSED_ROW_NODES = false;
+
+export class DataCubeEngine {
+  readonly repl: REPLStore;
+  readonly application: LegendREPLApplicationStore;
   private readonly client: REPLServerClient;
 
-  constructor(client: REPLServerClient) {
-    this.client = client;
+  enableDebugMode = DEFAULT_ENABLE_DEBUG_MODE;
+  gridClientRowBuffer = DEFAULT_GRID_CLIENT_ROW_BUFFER;
+  gridClientPurgeClosedRowNodes = false;
+
+  constructor(repl: REPLStore) {
+    makeObservable(this, {
+      enableDebugMode: observable,
+      setEnableDebugMode: action,
+
+      gridClientRowBuffer: observable,
+      setGridClientRowBuffer: action,
+
+      gridClientPurgeClosedRowNodes: observable,
+      setGridClientPurgeClosedRowNodes: action,
+    });
+
+    this.repl = repl;
+    this.application = repl.application;
+    this.client = repl.client;
+  }
+
+  setEnableDebugMode(enableDebugMode: boolean): void {
+    this.enableDebugMode = enableDebugMode;
+    this.applyChanges();
+  }
+
+  setGridClientRowBuffer(rowBuffer: number): void {
+    this.gridClientRowBuffer = rowBuffer;
+    this.applyChanges();
+  }
+
+  setGridClientPurgeClosedRowNodes(purgeClosedRowNodes: boolean): void {
+    this.gridClientPurgeClosedRowNodes = purgeClosedRowNodes;
+    this.applyChanges();
+  }
+
+  private applyChanges(): void {
+    // When we support multi-view (i.e. multiple instances of DataCubes) we would need to traverse
+    // through and update the configurations of all of their grid clients
+    this.repl.dataCube.grid.client.updateGridOptions({
+      rowBuffer: this.gridClientRowBuffer,
+      purgeClosedRowNodes: this.gridClientPurgeClosedRowNodes,
+    });
   }
 
-  async getGridClientLicenseKey(): Promise<string> {
-    return this.client.getGridClientLicenseKey();
+  async getInfrastructureInfo(): Promise<DataCubeInfrastructureInfo> {
+    return this.client.getInfrastructureInfo();
   }
 
   async getQueryTypeahead(
@@ -70,49 +118,21 @@ class DataCubeEngine {
     );
   }
 
-  async executeQuery(query: V1_Lambda): Promise<TDSExecutionResult> {
+  async executeQuery(
+    query: V1_Lambda,
+  ): Promise<{ result: TDSExecutionResult; executedSQL: string }> {
     const result = await this.client.executeQuery({
       query: V1_serializeValueSpecification(query, []),
+      debug: this.enableDebugMode,
     });
-    return guaranteeType(
-      V1_buildExecutionResult(
-        V1_serializeExecutionResult(JSON.parse(result.result)),
+    return {
+      result: guaranteeType(
+        V1_buildExecutionResult(
+          V1_serializeExecutionResult(JSON.parse(result.result)),
+        ),
+        TDSExecutionResult,
       ),
-      TDSExecutionResult,
-    );
-  }
-}
-
-/**
- * Infrastructure for data cube, can be shared across multiple data cube states
- */
-export class DataCubeInfrastructure {
-  readonly replStore: REPLStore;
-  readonly application: LegendREPLApplicationStore;
-  readonly engine: DataCubeEngine;
-
-  gridClientRowBuffer = 50;
-  enableDebugMode = false;
-
-  constructor(replStore: REPLStore) {
-    makeObservable(this, {
-      gridClientRowBuffer: observable,
-      setGridClientRowBuffer: action,
-
-      enableDebugMode: observable,
-      setEnableDebugMode: action,
-    });
-
-    this.replStore = replStore;
-    this.application = replStore.applicationStore;
-    this.engine = new DataCubeEngine(replStore.client);
-  }
-
-  setGridClientRowBuffer(rowBuffer: number): void {
-    this.gridClientRowBuffer = rowBuffer;
-  }
-
-  setEnableDebugMode(enableDebugMode: boolean): void {
-    this.enableDebugMode = enableDebugMode;
+      executedSQL: result.executedSQL,
+    };
   }
 }

package/src/stores/dataCube/DataCubeState.ts

@@ -23,7 +23,8 @@ import type { LegendREPLApplicationStore } from '../LegendREPLBaseStore.js';
 import { DataCubeCoreState } from './core/DataCubeCoreState.js';
 import { validateAndBuildQuerySnapshot } from './core/DataCubeQuerySnapshotBuilder.js';
 import { action, makeObservable, observable } from 'mobx';
-import type { DataCubeInfrastructure } from './DataCubeInfrastructure.js';
+import type { DataCubeEngine } from './DataCubeEngine.js';
+import { ActionAlertType } from '@finos/legend-application';
 
 export class DataCubeTask {
   uuid = uuid();
@@ -41,9 +42,9 @@ export class DataCubeTask {
 }
 
 export class DataCubeState {
-  readonly replStore: REPLStore;
+  readonly repl: REPLStore;
   readonly application: LegendREPLApplicationStore;
-  readonly infrastructure: DataCubeInfrastructure;
+  readonly engine: DataCubeEngine;
   readonly snapshotManager: DataCubeQuerySnapshotManager;
 
   readonly core: DataCubeCoreState;
@@ -52,16 +53,16 @@ export class DataCubeState {
 
   readonly runningTasks = new Map<string, DataCubeTask>();
 
-  constructor(replStore: REPLStore) {
+  constructor(repl: REPLStore) {
     makeObservable(this, {
       runningTasks: observable,
       newTask: action,
       endTask: action,
     });
 
-    this.replStore = replStore;
-    this.application = replStore.applicationStore;
-    this.infrastructure = replStore.dataCubeInfrastructure;
+    this.repl = repl;
+    this.application = repl.application;
+    this.engine = repl.dataCubeEngine;
 
     // NOTE: snapshot manager must be instantiated before subscribers
     this.snapshotManager = new DataCubeQuerySnapshotManager(this);
@@ -93,7 +94,7 @@ export class DataCubeState {
           },
         ),
       );
-      const result = await this.infrastructure.engine.getBaseQuery();
+      const result = await this.engine.getBaseQuery();
       const initialSnapshot = validateAndBuildQuerySnapshot(
         result.partialQuery,
         result.sourceQuery,
@@ -103,7 +104,11 @@ export class DataCubeState {
       this.snapshotManager.broadcastSnapshot(initialSnapshot);
     } catch (error: unknown) {
       assertErrorThrown(error);
-      this.application.notificationService.notifyError(error);
+      this.repl.application.alertService.setActionAlertInfo({
+        message: `Initialization failure: ${error.message}`,
+        type: ActionAlertType.ERROR,
+        actions: [],
+      });
     } finally {
       this.endTask(task);
     }

package/src/stores/dataCube/core/DataCubeCoreState.ts

@@ -18,7 +18,7 @@ import { action, makeObservable, observable } from 'mobx';
 import type { DataCubeState } from '../DataCubeState.js';
 import { DataCubeQuerySnapshotSubscriber } from './DataCubeQuerySnapshotSubscriber.js';
 import type { DataCubeQuerySnapshot } from './DataCubeQuerySnapshot.js';
-import type { DataCubeQuery } from '../../../server/models/DataCubeQuery.js';
+import type { DataCubeQuery } from '../../../server/DataCubeQuery.js';
 import { formatDate } from '@finos/legend-shared';
 import { DEFAULT_REPORT_NAME } from './DataCubeQueryEngine.js';
 

package/src/stores/dataCube/core/DataCubeQueryEngine.ts

@@ -245,15 +245,14 @@ export function getDataType(type: string): DataCubeColumnDataType {
 export const DEFAULT_URL_LABEL_QUERY_PARAM = 'dataCube.linkLabel';
 
 export const DEFAULT_GRID_LINE_COLOR = TailwindCSSPalette.neutral[200];
-export const DEFAULT_ROW_HIGHLIGHT_BACKGROUND_COLOR =
-  TailwindCSSPalette.sky[100];
+export const DEFAULT_ROW_HIGHLIGHT_BACKGROUND_COLOR = '#d7e0eb';
 
 export const DEFAULT_COLUMN_WIDTH = 300;
 export const DEFAULT_COLUMN_MIN_WIDTH = 50;
 export const DEFAULT_COLUMN_MAX_WIDTH = undefined;
 
 export const DEFAULT_FONT_FAMILY = DataCubeFont.ROBOTO;
-export const DEFAULT_FONT_SIZE = 12;
+export const DEFAULT_FONT_SIZE = 11;
 export const DEFAULT_FONT_BOLD = false;
 export const DEFAULT_FONT_ITALIC = false;
 export const DEFAULT_FONT_CASE = undefined;

package/src/stores/dataCube/core/DataCubeQuerySnapshotBuilder.ts

@@ -33,7 +33,7 @@ import {
   matchFunctionName,
   type V1_ValueSpecification,
 } from '@finos/legend-graph';
-import type { DataCubeQuery } from '../../../server/models/DataCubeQuery.js';
+import type { DataCubeQuery } from '../../../server/DataCubeQuery.js';
 import {
   DataCubeQuerySnapshot,
   type DataCubeQuerySnapshotColumn,

package/src/stores/dataCube/core/DataCubeQuerySnapshotManager.ts

@@ -24,7 +24,7 @@ import {
   assertErrorThrown,
   guaranteeNonNullable,
 } from '@finos/legend-shared';
-import type { DataCubeQuery } from '../../../server/models/DataCubeQuery.js';
+import type { DataCubeQuery } from '../../../server/DataCubeQuery.js';
 
 // TODO: set a stack depth when we implement undo/redo
 // const DATA_CUBE_MAX_SNAPSHOT_COUNT = 100;

package/src/stores/dataCube/core/DataCubeQuerySnapshotSubscriber.ts

@@ -14,6 +14,7 @@
  * limitations under the License.
  */
 
+import { deepDiff } from '@finos/legend-shared';
 import type { LegendREPLApplicationStore } from '../../LegendREPLBaseStore.js';
 import type { DataCubeState } from '../DataCubeState.js';
 import type { DataCubeQuerySnapshot } from './DataCubeQuerySnapshot.js';
@@ -42,6 +43,15 @@ export abstract class DataCubeQuerySnapshotSubscriber {
   }
 
   publishSnapshot(snapshot: DataCubeQuerySnapshot): void {
+    if (this.dataCube.engine.enableDebugMode) {
+      this.application.debugProcess(
+        `New Snapshot`,
+        '\nSnapshot',
+        snapshot,
+        '\nDiff',
+        deepDiff(snapshot, this.latestSnapshot ?? {}),
+      );
+    }
     this.latestSnapshot = snapshot;
     this.dataCube.snapshotManager.broadcastSnapshot(snapshot);
   }

package/src/stores/dataCube/editor/DataCubeEditorCodePanelState.ts

@@ -106,7 +106,7 @@ export class DataCubeEditorCodePanelState {
     try {
       this.queryEditorState.setParserError(undefined);
       yield flowResult(
-        this.dataCube.replStore.client.parseQuery({
+        this.dataCube.repl.client.parseQuery({
           code: `|${this.queryEditorState.query}`,
         }),
       );

package/src/stores/dataCube/editor/{DataCubeEditorState.ts → DataCubeEditorState.tsx}

@@ -20,15 +20,16 @@ import { DataCubeEditorSortsPanelState } from './DataCubeEditorSortsPanelState.j
 import { DataCubeEditorCodePanelState } from './DataCubeEditorCodePanelState.js';
 import { DataCubeQuerySnapshotSubscriber } from '../core/DataCubeQuerySnapshotSubscriber.js';
 import { type DataCubeQuerySnapshot } from '../core/DataCubeQuerySnapshot.js';
-import { guaranteeNonNullable, uuid } from '@finos/legend-shared';
+import { guaranteeNonNullable } from '@finos/legend-shared';
 import { DataCubeEditorGeneralPropertiesPanelState } from './DataCubeEditorGeneralPropertiesPanelState.js';
 import { DataCubeEditorColumnPropertiesPanelState } from './DataCubeEditorColumnPropertiesPanelState.js';
-import type { REPLWindowConfig } from '../../../components/REPLWindow.js';
 import { DataCubeEditorColumnsPanelState } from './DataCubeEditorColumnsPanelState.js';
 import { DataCubeConfiguration } from '../core/DataCubeConfiguration.js';
 import { DataCubeEditorVerticalPivotsPanelState } from './DataCubeEditorVerticalPivotsPanelState.js';
+import { SingletonModeDisplayState } from '../../LayoutManagerState.js';
+import { DataCubeEditor } from '../../../components/dataCube/editor/DataCubeEditor.js';
 
-export enum DATA_CUBE_EDITOR_TAB {
+export enum DataCubeEditorTab {
   GENERAL_PROPERTIES = 'General Properties',
   COLUMN_PROPERTIES = 'Column Properties',
   FILTER = 'Filter',
@@ -41,6 +42,7 @@ export enum DATA_CUBE_EDITOR_TAB {
 }
 
 export class DataCubeEditorState extends DataCubeQuerySnapshotSubscriber {
+  readonly display: SingletonModeDisplayState;
   readonly generalProperties: DataCubeEditorGeneralPropertiesPanelState;
   readonly columnProperties: DataCubeEditorColumnPropertiesPanelState;
   readonly columns: DataCubeEditorColumnsPanelState;
@@ -48,14 +50,7 @@ export class DataCubeEditorState extends DataCubeQuerySnapshotSubscriber {
   readonly sorts: DataCubeEditorSortsPanelState;
   readonly code: DataCubeEditorCodePanelState;
 
-  readonly window: REPLWindowConfig = {
-    uuid: uuid(),
-    title: 'Properties',
-    center: true,
-  };
-
-  isPanelOpen = false;
-  currentTab = DATA_CUBE_EDITOR_TAB.GENERAL_PROPERTIES;
+  currentTab = DataCubeEditorTab.GENERAL_PROPERTIES;
 
   constructor(dataCube: DataCubeState) {
     super(dataCube);
@@ -65,12 +60,13 @@ export class DataCubeEditorState extends DataCubeQuerySnapshotSubscriber {
 
       currentTab: observable,
       setCurrentTab: action,
-
-      isPanelOpen: observable,
-      openPanel: action,
-      closePanel: action,
     });
 
+    this.display = new SingletonModeDisplayState(
+      this.dataCube.repl.layout,
+      'Properties',
+      () => <DataCubeEditor />,
+    );
     this.generalProperties = new DataCubeEditorGeneralPropertiesPanelState(
       this,
     );
@@ -81,15 +77,7 @@ export class DataCubeEditorState extends DataCubeQuerySnapshotSubscriber {
     this.code = new DataCubeEditorCodePanelState(this);
   }
 
-  openPanel(): void {
-    this.isPanelOpen = true;
-  }
-
-  closePanel(): void {
-    this.isPanelOpen = false;
-  }
-
-  setCurrentTab(val: DATA_CUBE_EDITOR_TAB): void {
+  setCurrentTab(val: DataCubeEditorTab): void {
     this.currentTab = val;
   }
 

package/src/stores/dataCube/grid/DataCubeGridClientEngine.ts

@@ -48,7 +48,7 @@ export enum DataCubeGridClientExportFormat {
   PDF = 'PDF',
 }
 
-export enum INTERNAL__GRID_CLIENT_UTILITY_CSS_CLASS_NAME {
+export enum INTERNAL__GridClientUtilityCssClassName {
   ROOT = 'data-cube-grid.ag-theme-balham',
   HIGHLIGHT_ROW = 'data-cube-grid__utility--highlight-row',
   SHOW_VERTICAL_GRID_LINES = 'data-cube-grid__utility--show-vertical-grid-lines',
@@ -68,29 +68,29 @@ export enum INTERNAL__GRID_CLIENT_UTILITY_CSS_CLASS_NAME {
   BACKGROUND_COLOR_PREFIX = 'data-cube-grid__utility--background-color-',
 }
 export const generateFontFamilyUtilityClassName = (fontFamily: string) =>
-  `${INTERNAL__GRID_CLIENT_UTILITY_CSS_CLASS_NAME.FONT_FAMILY_PREFIX}${fontFamily.replaceAll(' ', '-')}`;
+  `${INTERNAL__GridClientUtilityCssClassName.FONT_FAMILY_PREFIX}${fontFamily.replaceAll(' ', '-')}`;
 export const generateFontSizeUtilityClassName = (fontSize: number) =>
-  `${INTERNAL__GRID_CLIENT_UTILITY_CSS_CLASS_NAME.FONT_SIZE_PREFIX}${fontSize}`;
+  `${INTERNAL__GridClientUtilityCssClassName.FONT_SIZE_PREFIX}${fontSize}`;
 export const generateFontUnderlineUtilityClassName = (
   variant: string | undefined,
 ) =>
-  `${INTERNAL__GRID_CLIENT_UTILITY_CSS_CLASS_NAME.FONT_UNDERLINE_PREFIX}${variant ?? 'none'}`;
+  `${INTERNAL__GridClientUtilityCssClassName.FONT_UNDERLINE_PREFIX}${variant ?? 'none'}`;
 export const generateFontCaseUtilityClassName = (
   fontCase: string | undefined,
 ) =>
-  `${INTERNAL__GRID_CLIENT_UTILITY_CSS_CLASS_NAME.FONT_CASE_PREFIX}${fontCase ?? 'none'}`;
+  `${INTERNAL__GridClientUtilityCssClassName.FONT_CASE_PREFIX}${fontCase ?? 'none'}`;
 export const generateTextAlignUtilityClassName = (alignment: string) =>
-  `${INTERNAL__GRID_CLIENT_UTILITY_CSS_CLASS_NAME.TEXT_ALIGN_PREFIX}${alignment}`;
+  `${INTERNAL__GridClientUtilityCssClassName.TEXT_ALIGN_PREFIX}${alignment}`;
 export const generateTextColorUtilityClassName = (
   color: string,
   key: DataCubeConfigurationColorKey,
 ) =>
-  `${INTERNAL__GRID_CLIENT_UTILITY_CSS_CLASS_NAME.TEXT_COLOR_PREFIX}${key}-${color.substring(1)}`;
+  `${INTERNAL__GridClientUtilityCssClassName.TEXT_COLOR_PREFIX}${key}-${color.substring(1)}`;
 export const generateBackgroundColorUtilityClassName = (
   color: string,
   key: DataCubeConfigurationColorKey,
 ) =>
-  `${INTERNAL__GRID_CLIENT_UTILITY_CSS_CLASS_NAME.BACKGROUND_COLOR_PREFIX}${key}-${color.substring(1)}`;
+  `${INTERNAL__GridClientUtilityCssClassName.BACKGROUND_COLOR_PREFIX}${key}-${color.substring(1)}`;
 
 export const INTERNAL__GRID_CLIENT_SIDE_BAR_WIDTH = 200;
 export const INTERNAL__GRID_CLIENT_COLUMN_MIN_WIDTH = 50;
@@ -224,9 +224,16 @@ export class DataCubeGridClientServerSideDataSource
       });
       const lambda = new V1_Lambda();
       lambda.body.push(executableQuery);
-      const result =
-        await this.grid.dataCube.infrastructure.engine.executeQuery(lambda);
-      const rowData = TDStoRowData(result.result);
+      const result = await this.grid.dataCube.engine.executeQuery(lambda);
+      const rowData = TDStoRowData(result.result.result);
+      if (this.grid.dataCube.engine.enableDebugMode) {
+        this.grid.dataCube.application.debugProcess(
+          `Execution`,
+          `\nConfig: pagination=${this.grid.isPaginationEnabled}`,
+          `\nStats: ${rowData.length} rows, ${result.result.result.columns.length} columns`,
+          `\nSQL: ${result.executedSQL}`,
+        );
+      }
       if (this.grid.isPaginationEnabled) {
         params.success({ rowData });
         // Only update row count when loading the top-level drilldown data
@@ -251,7 +258,11 @@ export class DataCubeGridClientServerSideDataSource
       }
     } catch (error) {
       assertErrorThrown(error);
-      this.grid.dataCube.application.notificationService.notifyError(error);
+      this.grid.dataCube.repl.notifyError(
+        error,
+        `Data fetch failure: ${error.message}`,
+        error.stack,
+      );
       params.fail();
     } finally {
       this.grid.dataCube.endTask(task);

package/src/stores/dataCube/grid/DataCubeGridClientExportEngine.ts

@@ -158,12 +158,15 @@ export class DataCubeGridClientExportEngine {
 
     downloadFileUsingDataURI(
       `${fileName}.eml`,
-      `${EMAIL_CONTENT}--${EMAIL_MIXED_BOUNDARY}\n` +
+      // NOTE: empty lines before email content can cause some mail client to not
+      // recognize the email content, e.g. Outlook
+      `${EMAIL_CONTENT.trimStart()}--${EMAIL_MIXED_BOUNDARY}\n` +
         `Content-Type: ${contentType}; name="${fileNameWithExtension}"\n` +
         `Content-Transfer-Encoding: base64\n` +
         `Content-Disposition: attachment; filename="${fileNameWithExtension}"\n\n` +
         `${attachment}\n\n` +
         `--${EMAIL_MIXED_BOUNDARY}--`,
+      // This MIME type here might not matter
       ContentType.MESSAGE_RFC822,
     );
   }

package/src/stores/dataCube/grid/DataCubeGridConfigurationBuilder.tsx

@@ -37,7 +37,7 @@ import {
   GridClientAggregateOperation,
   GridClientSortDirection,
   INTERNAL__GRID_CLIENT_COLUMN_MIN_WIDTH,
-  INTERNAL__GRID_CLIENT_UTILITY_CSS_CLASS_NAME,
+  INTERNAL__GridClientUtilityCssClassName,
   generateFontFamilyUtilityClassName,
   generateFontSizeUtilityClassName,
   generateFontUnderlineUtilityClassName,
@@ -301,10 +301,9 @@ function _displaySpec(columnData: ColumnData) {
     cellClassRules: {
       [generateFontFamilyUtilityClassName(fontFamily)]: () => true,
       [generateFontSizeUtilityClassName(fontSize)]: () => true,
-      [INTERNAL__GRID_CLIENT_UTILITY_CSS_CLASS_NAME.FONT_BOLD]: () => fontBold,
-      [INTERNAL__GRID_CLIENT_UTILITY_CSS_CLASS_NAME.FONT_ITALIC]: () =>
-        fontItalic,
-      [INTERNAL__GRID_CLIENT_UTILITY_CSS_CLASS_NAME.FONT_STRIKETHROUGH]: () =>
+      [INTERNAL__GridClientUtilityCssClassName.FONT_BOLD]: () => fontBold,
+      [INTERNAL__GridClientUtilityCssClassName.FONT_ITALIC]: () => fontItalic,
+      [INTERNAL__GridClientUtilityCssClassName.FONT_STRIKETHROUGH]: () =>
         fontStrikethrough,
       [generateFontUnderlineUtilityClassName(fontUnderline)]: () =>
         Boolean(fontUnderline),
@@ -346,7 +345,7 @@ function _displaySpec(columnData: ColumnData) {
       ) => params.node.failedLoad,
       [generateBackgroundColorUtilityClassName(errorBackgroundColor, 'error')]:
         (params) => params.node.failedLoad,
-      [INTERNAL__GRID_CLIENT_UTILITY_CSS_CLASS_NAME.BLUR]: () => column.blur,
+      [INTERNAL__GridClientUtilityCssClassName.BLUR]: () => column.blur,
     },
     cellRenderer: cellRenderer,
     pinned:
@@ -449,6 +448,7 @@ export function generateBaseGridOptions(dataCube: DataCubeState): GridOptions {
     groupDisplayType: 'custom', // keeps the column set stable even when row grouping is used
     suppressRowGroupHidesColumns: true, // keeps the column set stable even when row grouping is used
     suppressAggFuncInHeader: true, //  keeps the columns stable when aggregation is used
+    // purgeClosedRowNodes: true, // remove closed row nodes from the cache to allow reloading failed rows? - or should we have declarative action to retry?
     getChildCount: (data) =>
       data[INTERNAL__GRID_CLIENT_ROW_GROUPING_COUNT_AGG_COLUMN_ID],
     // -------------------------------------- PIVOT --------------------------------------
@@ -510,7 +510,7 @@ export function generateBaseGridOptions(dataCube: DataCubeState): GridOptions {
     tooltipShowDelay: INTERNAL__GRID_CLIENT_TOOLTIP_SHOW_DELAY,
     tooltipInteraction: true,
     // -------------------------------------- COLUMN MOVING --------------------------------------
-    // suppressDragLeaveHidesColumns: true,
+    suppressDragLeaveHidesColumns: true, // disable this since it's quite easy to accidentally hide columns while moving
     // -------------------------------------- SERVER SIDE ROW MODEL --------------------------------------
     suppressScrollOnNewData: true,
     suppressServerSideFullWidthLoadingRow: true, // make sure each column has its own loading indicator instead of the whole row
@@ -537,7 +537,7 @@ export function generateBaseGridOptions(dataCube: DataCubeState): GridOptions {
       ],
       position: 'right',
     },
-    // allowDragFromColumnsToolPanel: true,
+    allowDragFromColumnsToolPanel: true,
     // -------------------------------------- PERFORMANCE --------------------------------------
     animateRows: false, // improve performance
     suppressColumnMoveAnimation: true, // improve performance
@@ -560,9 +560,7 @@ export function generateGridOptionsFromSnapshot(
      */
     rowClassRules: configuration.alternateRows
       ? {
-          [INTERNAL__GRID_CLIENT_UTILITY_CSS_CLASS_NAME.HIGHLIGHT_ROW]: (
-            params,
-          ) =>
+          [INTERNAL__GridClientUtilityCssClassName.HIGHLIGHT_ROW]: (params) =>
             params.rowIndex % (configuration.alternateRowsCount * 2) >=
             configuration.alternateRowsCount,
         }