@finos/legend-application-query 13.8.53 → 13.8.54

package/src/components/QueryEditor.tsx

@@ -99,6 +99,7 @@ import {
   HttpStatus,
   isValidUrl,
   NetworkClientError,
+  StopWatch,
 } from '@finos/legend-shared';
 import { DSL_DATA_SPACE_LEGEND_QUERY_DOCUMENTATION_KEY } from '../__lib__/DSL_DataSpace_LegendQueryDocumentation.js';
 import { LegendQueryInfo } from './LegendQueryAppInfo.js';
@@ -188,22 +189,33 @@ const CreateQueryDialog = observer(() => {
     if (!aiSuggester || !editorStore.queryBuilderState || !legendAIUrl) {
       return;
     }
+    const sourceInfo = editorStore.getSourceInfo();
     LegendQueryAgentChatTelemetryHelper.logEvent_QueryAISuggestLaunched(
       applicationStore.telemetryService,
+      { sourceInfo },
     );
     setIsSuggestingWithAI(true);
     setAISuggestion(undefined);
+    const stopWatch = new StopWatch();
     try {
       const request = await buildAISuggestionRequest(
         editorStore.queryBuilderState,
       );
       const suggestion = await aiSuggester(request, legendAIUrl);
       setAISuggestion(suggestion);
+      LegendQueryAgentChatTelemetryHelper.logEvent_QueryAISuggestSucceeded(
+        applicationStore.telemetryService,
+        { sourceInfo, durationMs: stopWatch.elapsed },
+      );
     } catch (error) {
       assertErrorThrown(error);
       LegendQueryAgentChatTelemetryHelper.logEvent_QueryAISuggestFailure(
         applicationStore.telemetryService,
-        error.message,
+        {
+          sourceInfo,
+          durationMs: stopWatch.elapsed,
+          errorMessage: error.message,
+        },
       );
       if (
         error instanceof NetworkClientError &&
@@ -228,6 +240,7 @@ const CreateQueryDialog = observer(() => {
     }
     LegendQueryAgentChatTelemetryHelper.logEvent_QueryAISuggestApplied(
       applicationStore.telemetryService,
+      { sourceInfo: editorStore.getSourceInfo() },
     );
     createQueryState.setQueryName(aiSuggestion.title);
     createQueryState.setQueryDescription(aiSuggestion.description);
@@ -236,6 +249,7 @@ const CreateQueryDialog = observer(() => {
   const discardAISuggestion = (): void => {
     LegendQueryAgentChatTelemetryHelper.logEvent_QueryAISuggestDiscarded(
       applicationStore.telemetryService,
+      { sourceInfo: editorStore.getSourceInfo() },
     );
     setAISuggestion(undefined);
   };
@@ -510,8 +524,14 @@ const RenameQueryDialog = observer(
       ) {
         return;
       }
+      const sourceInfo = existingEditorStore.getSourceInfo();
+      LegendQueryAgentChatTelemetryHelper.logEvent_QueryAISuggestLaunched(
+        applicationStore.telemetryService,
+        { sourceInfo },
+      );
       setIsSuggestingWithAI(true);
       setAISuggestion(undefined);
+      const stopWatch = new StopWatch();
       try {
         const request = await buildAISuggestionRequest(
           existingEditorStore.queryBuilderState,
@@ -519,11 +539,19 @@ const RenameQueryDialog = observer(
         );
         const suggestion = await aiSuggester(request, legendAIUrl);
         setAISuggestion(suggestion);
+        LegendQueryAgentChatTelemetryHelper.logEvent_QueryAISuggestSucceeded(
+          applicationStore.telemetryService,
+          { sourceInfo, durationMs: stopWatch.elapsed },
+        );
       } catch (error) {
         assertErrorThrown(error);
         LegendQueryAgentChatTelemetryHelper.logEvent_QueryAISuggestFailure(
           applicationStore.telemetryService,
-          error.message,
+          {
+            sourceInfo,
+            durationMs: stopWatch.elapsed,
+            errorMessage: error.message,
+          },
         );
         if (
           error instanceof NetworkClientError &&

package/src/components/data-space/DataSpaceInfo.tsx

@@ -34,8 +34,8 @@ import {
   DataSpaceSupportEmail,
 } from '@finos/legend-extension-dsl-data-space/graph';
 import {
+  EXTERNAL_APPLICATION_NAVIGATION__generateMarketplaceDataspaceViewUrl,
   EXTERNAL_APPLICATION_NAVIGATION__generateStudioSDLCProjectViewUrl,
-  EXTERNAL_APPLICATION_NAVIGATION__generateTaxonomyDataspaceViewUrl,
 } from '../../__lib__/LegendQueryNavigation.js';
 import { flowResult } from 'mobx';
 import { assertErrorThrown, guaranteeType } from '@finos/legend-shared';
@@ -134,14 +134,14 @@ export const QueryEditorDataspaceInfoModal = observer(
     const storePath =
       connection?.store?.value.path ?? dataSpaceMedata?.storePath;
 
-    const openInTaxonomy = (): void => {
+    const openInMarketplace = (): void => {
       if (
         projectInfo &&
-        editorStore.applicationStore.config.taxonomyApplicationUrl
+        editorStore.applicationStore.config.marketplaceApplicationUrl
       ) {
         editorStore.applicationStore.navigationService.navigator.visitAddress(
-          EXTERNAL_APPLICATION_NAVIGATION__generateTaxonomyDataspaceViewUrl(
-            editorStore.applicationStore.config.taxonomyApplicationUrl,
+          EXTERNAL_APPLICATION_NAVIGATION__generateMarketplaceDataspaceViewUrl(
+            editorStore.applicationStore.config.marketplaceApplicationUrl,
             projectInfo.groupId,
             projectInfo.artifactId,
             projectInfo.versionId,
@@ -176,11 +176,11 @@ export const QueryEditorDataspaceInfoModal = observer(
               title="Close"
               disabled={
                 !(
-                  editorStore.applicationStore.config.taxonomyApplicationUrl &&
-                  projectInfo
+                  editorStore.applicationStore.config
+                    .marketplaceApplicationUrl && projectInfo
                 )
               }
-              onClick={openInTaxonomy}
+              onClick={openInMarketplace}
             >
               Open Data Space
             </button>

package/src/components/data-space/DataSpaceQuerySetup.tsx

@@ -38,6 +38,7 @@ import type {
 } from '../../stores/data-space/DataProductSelectorState.js';
 import { flowResult } from 'mobx';
 import { DepotEntityWithOrigin } from '@finos/legend-storage';
+import { LegendQueryTelemetryHelper } from '../../__lib__/LegendQueryTelemetryHelper.js';
 
 // Custom format function to handle both DataSpace and DataProduct options
 const formatDataSpaceOrProductOptionLabel = (
@@ -90,8 +91,32 @@ const DataProductQuerySetupSetupPanelContent = observer(
       queryBuilderState.queryAgentChatState?.abort();
       const value = option?.value;
       if (value instanceof ResolvedDataSpaceEntityWithOrigin) {
+        LegendQueryTelemetryHelper.logEvent_ChangeDataSpace(
+          applicationStore.telemetryService,
+          {
+            sourceInfo: queryBuilderState.sourceInfo,
+            to: {
+              groupId: value.origin?.groupId,
+              artifactId: value.origin?.artifactId,
+              versionId: value.origin?.versionId,
+              path: value.path,
+            },
+          },
+        );
         queryBuilderState.changeHandlers.onDataSpaceChange(value);
       } else if (value instanceof DepotEntityWithOrigin) {
+        LegendQueryTelemetryHelper.logEvent_ChangeDataProduct(
+          applicationStore.telemetryService,
+          {
+            sourceInfo: queryBuilderState.sourceInfo,
+            to: {
+              groupId: value.origin?.groupId,
+              artifactId: value.origin?.artifactId,
+              versionId: value.origin?.versionId,
+              path: value.path,
+            },
+          },
+        );
         queryBuilderState.changeHandlers.onDataProductChange(value);
       }
     };

package/src/components/data-space/LegendQueryDataSpaceQueryBuilder.tsx

@@ -65,6 +65,7 @@ import { LakehouseRuntimeConfigModal } from '../shared/LakehouseRuntimeConfigMod
 import type { DataProductWithLegacyOption } from '../../stores/data-space/DataProductSelectorState.js';
 import { formatDataProductOrSpaceOptionLabel } from '../shared/LegendQueryDataProductOptionLabel.js';
 import type { LegendQueryDataSpaceQueryBuilderState } from '../../stores/data-space/query-builder/LegendQueryDataSpaceQueryBuilderState.js';
+import { LegendQueryTelemetryHelper } from '../../__lib__/LegendQueryTelemetryHelper.js';
 
 const resolveExecutionContextRuntimes = (
   queryBuilderState: LegendQueryDataSpaceQueryBuilderState,
@@ -117,11 +118,35 @@ const LegendQueryDataSpaceQueryBuilderSetupPanelContent = observer(
       const value = option.value;
       if (value instanceof ResolvedDataSpaceEntityWithOrigin) {
         queryBuilderState.queryAgentChatState?.abort();
+        LegendQueryTelemetryHelper.logEvent_ChangeDataSpace(
+          applicationStore.telemetryService,
+          {
+            sourceInfo: queryBuilderState.sourceInfo,
+            to: {
+              groupId: value.origin?.groupId,
+              artifactId: value.origin?.artifactId,
+              versionId: value.origin?.versionId,
+              path: value.path,
+            },
+          },
+        );
         queryBuilderState
           .onDataSpaceChange(value)
           .catch(queryBuilderState.applicationStore.alertUnhandledError);
       } else if (value instanceof DepotEntityWithOrigin) {
         queryBuilderState.queryAgentChatState?.abort();
+        LegendQueryTelemetryHelper.logEvent_ChangeDataProduct(
+          applicationStore.telemetryService,
+          {
+            sourceInfo: queryBuilderState.sourceInfo,
+            to: {
+              groupId: value.origin?.groupId,
+              artifactId: value.origin?.artifactId,
+              versionId: value.origin?.versionId,
+              path: value.path,
+            },
+          },
+        );
         queryBuilderState.onDataProductChange(value);
       }
     };

package/src/stores/QueryEditorStore.ts

@@ -630,6 +630,7 @@ export abstract class QueryEditorStore {
           clientConfig: {
             baseUrl: this.applicationStore.config.engineServerUrl,
             queryBaseUrl: this.applicationStore.config.engineQueryServerUrl,
+            queryClientName: this.applicationStore.config.engineQueryClientName,
             enableCompression: true,
             useCookieAuthOnly:
               this.applicationStore.config.engineUseCookieAuthOnly,
@@ -641,10 +642,22 @@ export abstract class QueryEditorStore {
       );
 
       yield this.setUpEditorState();
-      yield flowResult(this.buildGraph());
-      this.queryBuilderState = (yield this.initializeQueryBuilderState(
-        stopWatch,
-      )) as QueryBuilderState;
+      try {
+        yield flowResult(this.buildGraph());
+      } catch (error) {
+        assertErrorThrown(error);
+        this.logBuildGraphFailure(error);
+        throw error;
+      }
+      try {
+        this.queryBuilderState = (yield this.initializeQueryBuilderState(
+          stopWatch,
+        )) as QueryBuilderState;
+      } catch (error) {
+        assertErrorThrown(error);
+        this.logInitializeQueryBuilderStateFailure(error);
+        throw error;
+      }
       this.queryLoaderState.initialize(this.queryBuilderState);
       this.initState.pass();
       // the canonical "a query builder is loaded" signal, emitted for every
@@ -755,6 +768,33 @@ export abstract class QueryEditorStore {
     );
   }
 
+  /**
+   * Failure counterpart of {@link logBuildGraphMetrics}. Fires when the graph
+   * build stage of `initialize()` throws. Base emits with only the error
+   * dimensions — {@link ExistingQueryEditorStore} overrides to attach the
+   * loaded query's identity, mirroring how its success override attaches
+   * identity too.
+   */
+  logBuildGraphFailure(error: Error): void {
+    LegendQueryTelemetryHelper.logEvent_GraphInitializationFailed(
+      this.applicationStore.telemetryService,
+      buildTelemetryErrorFields(error),
+    );
+  }
+
+  /**
+   * Failure hook for the query builder state initialization stage of
+   * `initialize()`. Default is a no-op: creator routes already report a
+   * failure here through `INITIALIZE_QUERY_CREATOR__FAILURE`, so emitting a
+   * second event would double-count. {@link ExistingQueryEditorStore}
+   * overrides this to emit `VIEW_QUERY__FAILURE`, the counterpart of the
+   * `VIEW_QUERY__SUCCESS` its `initializeQueryBuilderState` fires on the
+   * happy path.
+   */
+  logInitializeQueryBuilderStateFailure(_error: Error): void {
+    // no-op by default; overrides on saved-query stores emit failure telemetry
+  }
+
   *buildFullGraph(): GeneratorFn<void> {
     const stopWatch = new StopWatch();
 
@@ -2088,6 +2128,32 @@ export class ExistingQueryEditorStore extends QueryEditorStore {
     );
   }
 
+  override logBuildGraphFailure(error: Error): void {
+    // attach whatever identity is already known — `_lightQuery` is only
+    // populated once the query resolves, which may not have happened yet, so
+    // the route id is the only guaranteed field
+    const currentQuery = this._lightQuery;
+    LegendQueryTelemetryHelper.logEvent_GraphInitializationFailed(
+      this.applicationStore.telemetryService,
+      {
+        ...buildTelemetryErrorFields(error),
+        ...(currentQuery ? buildQueryIdentity(currentQuery) : {}),
+      },
+    );
+  }
+
+  override logInitializeQueryBuilderStateFailure(error: Error): void {
+    const currentQuery = this._lightQuery;
+    LegendQueryTelemetryHelper.logEvent_ViewQueryFailed(
+      this.applicationStore.telemetryService,
+      {
+        queryId: this.queryId,
+        ...(currentQuery ? buildQueryIdentity(currentQuery) : {}),
+        ...buildTelemetryErrorFields(error),
+      },
+    );
+  }
+
   override getOpenedFrom(): QUERY_BUILDER_OPENED_FROM {
     return QUERY_BUILDER_OPENED_FROM.QUERY_SAVED;
   }
@@ -2620,11 +2686,27 @@ export class ExistingQueryEditorStore extends QueryEditorStore {
       }
     }
 
-    queryBuilderState.initializeWithQuery(
-      existingQueryLambda,
-      defaultParameters,
-      query.gridConfig,
-    );
+    try {
+      queryBuilderState.initializeWithQuery(
+        existingQueryLambda,
+        defaultParameters,
+        query.gridConfig,
+      );
+    } catch (error) {
+      assertErrorThrown(error);
+      // pair with `INITIALIZE_QUERY_STATE__SUCCESS` below — this is the tight
+      // boundary that success wraps, so failure is reported here rather than
+      // in the outer catch (which owns `VIEW_QUERY__FAILURE`)
+      LegendQueryTelemetryHelper.logEvent_InitializeQueryStateFailed(
+        this.applicationStore.telemetryService,
+        {
+          queryId: this.queryId,
+          ...buildQueryIdentity(query),
+          ...buildTelemetryErrorFields(error),
+        },
+      );
+      throw error;
+    }
     initailizeQueryStateReport.timings =
       this.applicationStore.timeService.finalizeTimingsRecord(
         initailizeQueryStateStopWatch,

package/src/stores/QueryProductionizerSetupStore.ts

@@ -26,6 +26,7 @@ import { EXTERNAL_APPLICATION_NAVIGATION__generateStudioProductionizeQueryUrl }
 import { BaseQuerySetupStore } from './QuerySetupStore.js';
 import { LegendQueryUserDataHelper } from '../__lib__/LegendQueryUserDataHelper.js';
 import { buildQueryLoaderLifecycleTelemetryHandlers } from '../__lib__/LegendQueryLifecycleTelemetry.js';
+import { LegendQueryTelemetryHelper } from '../__lib__/LegendQueryTelemetryHelper.js';
 import { quantifyList } from '@finos/legend-shared';
 
 export class QueryProductionizerSetupStore extends BaseQuerySetupStore {
@@ -96,6 +97,21 @@ export class QueryProductionizerSetupStore extends BaseQuerySetupStore {
         prompt: 'Please do not close the application',
         showLoading: true,
       });
+      // emitted at the actual handoff to studio — the setup landing action
+      // that lands us on this route is upstream and may be abandoned before
+      // the user picks a query, so emitting here counts real launches only
+      LegendQueryTelemetryHelper.logEvent_ProductionizeQueryLaunched(
+        this.applicationStore.telemetryService,
+        {
+          query: {
+            id: selectedQuery.id,
+            name: selectedQuery.name,
+            groupId: selectedQuery.groupId,
+            artifactId: selectedQuery.artifactId,
+            versionId: selectedQuery.versionId,
+          },
+        },
+      );
       this.applicationStore.navigationService.navigator.goToAddress(
         EXTERNAL_APPLICATION_NAVIGATION__generateStudioProductionizeQueryUrl(
           matchingSDLCEntry.url,

package/src/stores/QuerySetupStore.ts

@@ -80,6 +80,7 @@ export abstract class BaseQuerySetupStore {
           clientConfig: {
             baseUrl: this.applicationStore.config.engineServerUrl,
             queryBaseUrl: this.applicationStore.config.engineQueryServerUrl,
+            queryClientName: this.applicationStore.config.engineQueryClientName,
             enableCompression: true,
             useCookieAuthOnly:
               this.applicationStore.config.engineUseCookieAuthOnly,

package/src/stores/__test-utils__/LegendQueryApplicationTestUtils.ts

@@ -30,9 +30,6 @@ const TEST_DATA__appConfig = {
     url: 'https://testStudioUrl',
     instances: [],
   },
-  taxonomy: {
-    url: 'https://testTaxonomyUrl',
-  },
 };
 
 export const TEST__getTestLegendQueryApplicationConfig = (

package/src/stores/data-cube/ExistingQueryDataCubeViewer.ts

@@ -71,6 +71,7 @@ export class ExistingQueryDataCubeEditorStore {
           clientConfig: {
             baseUrl: this.applicationStore.config.engineServerUrl,
             queryBaseUrl: this.applicationStore.config.engineQueryServerUrl,
+            queryClientName: this.applicationStore.config.engineQueryClientName,
             enableCompression: true,
           },
         },

package/src/stores/data-space/DataSpaceQueryBuilderHelper.ts

@@ -22,6 +22,7 @@ import { EXTERNAL_APPLICATION_NAVIGATION__generateStudioSDLCProjectViewUrl } fro
 import type { LegendQueryApplicationStore } from '../LegendQueryBaseStore.js';
 import { parseProjectIdentifier } from '@finos/legend-storage';
 import { EXTERNAL_APPLICATION_NAVIGATION__generateStudioProjectViewUrl } from '@finos/legend-application';
+import { LegendQueryTelemetryHelper } from '../../__lib__/LegendQueryTelemetryHelper.js';
 
 export const createViewProjectHandler =
   (applicationStore: LegendQueryApplicationStore) =>
@@ -30,7 +31,10 @@ export const createViewProjectHandler =
     artifactId: string,
     versionId: string,
     entityPath: string | undefined,
-  ): void =>
+  ): void => {
+    LegendQueryTelemetryHelper.logEvent_QueryViewProjectLaunched(
+      applicationStore.telemetryService,
+    );
     applicationStore.navigationService.navigator.visitAddress(
       EXTERNAL_APPLICATION_NAVIGATION__generateStudioProjectViewUrl(
         applicationStore.config.studioApplicationUrl,
@@ -40,6 +44,7 @@ export const createViewProjectHandler =
         entityPath,
       ),
     );
+  };
 
 export const createViewSDLCProjectHandler =
   (