@finos/legend-application-query 13.6.0 → 13.6.1

package/src/components/__test-utils__/QueryEditorComponentTestUtils.tsx

@@ -44,6 +44,11 @@ import {
 import { LegendQueryFrameworkProvider } from '../LegendQueryFrameworkProvider.js';
 import { TEST__BrowserEnvironmentProvider } from '@finos/legend-application/test';
 import { Core_LegendQueryApplicationPlugin } from '../Core_LegendQueryApplicationPlugin.js';
+import { Route, Routes } from '@finos/legend-application/browser';
+import {
+  generateExistingQueryEditorRoute,
+  LEGEND_QUERY_ROUTE_PATTERN,
+} from '../../__lib__/LegendQueryNavigation.js';
 
 const TEST_QUERY_ID = 'test-query-id';
 export const TEST_QUERY_NAME = 'MyTestQuery';
@@ -170,9 +175,16 @@ export const TEST__setUpQueryEditor = async (
 
   const renderResult = render(
     <ApplicationStoreProvider store={MOCK__editorStore.applicationStore}>
-      <TEST__BrowserEnvironmentProvider>
+      <TEST__BrowserEnvironmentProvider
+        initialEntries={[generateExistingQueryEditorRoute(lightQuery.id)]}
+      >
         <LegendQueryFrameworkProvider>
-          <ExistingQueryEditor />
+          <Routes>
+            <Route
+              path={LEGEND_QUERY_ROUTE_PATTERN.EDIT_EXISTING_QUERY}
+              element={<ExistingQueryEditor />}
+            />
+          </Routes>
         </LegendQueryFrameworkProvider>
       </TEST__BrowserEnvironmentProvider>
     </ApplicationStoreProvider>,

package/src/components/data-cube/ExistingQueryDataCubeViewer.tsx

@@ -29,6 +29,7 @@ import { useEffect } from 'react';
 import { flowResult } from 'mobx';
 import { DataCube, DataCubeProvider } from '@finos/legend-data-cube';
 import { QueryBuilderDataCubeApplicationEngine } from '@finos/legend-query-builder';
+import { guaranteeNonNullable } from '@finos/legend-shared';
 
 export const DataCubeWrapper = observer(() => {
   const applicationStore = useApplicationStore();
@@ -44,6 +45,7 @@ export const DataCubeWrapper = observer(() => {
   const _appEngine = new QueryBuilderDataCubeApplicationEngine(
     applicationStore,
   );
+
   return (
     <DataCubeProvider application={_appEngine} engine={store.engine}>
       <DataCube />
@@ -53,7 +55,10 @@ export const DataCubeWrapper = observer(() => {
 
 export const ExistingQueryDataCubeViewer = observer(() => {
   const params = useParams<ExistingQueryEditorPathParams>();
-  const queryId = params[LEGEND_QUERY_ROUTE_PATTERN_TOKEN.QUERY_ID];
+  const queryId = guaranteeNonNullable(
+    params[LEGEND_QUERY_ROUTE_PATTERN_TOKEN.QUERY_ID],
+  );
+
   return (
     <ExistingQueryDataCubeEditorStoreProvider queryId={queryId}>
       <DataCubeWrapper />

package/src/components/data-space/DataSpaceQueryCreator.tsx

@@ -88,14 +88,12 @@ const DataSpaceQueryCreatorStoreProvider: React.FC<{
 
 export const DataSpaceQueryCreator = observer(() => {
   const applicationStore = useApplicationStore();
-  const parameters = useParams<DataSpaceQueryCreatorPathParams | undefined>();
-  const gav = parameters?.[DATA_SPACE_QUERY_CREATOR_ROUTE_PATTERN_TOKEN.GAV];
+  const parameters = useParams<DataSpaceQueryCreatorPathParams>();
+  const gav = parameters[DATA_SPACE_QUERY_CREATOR_ROUTE_PATTERN_TOKEN.GAV];
   const dataSpacePath =
-    parameters?.[DATA_SPACE_QUERY_CREATOR_ROUTE_PATTERN_TOKEN.DATA_SPACE_PATH];
+    parameters[DATA_SPACE_QUERY_CREATOR_ROUTE_PATTERN_TOKEN.DATA_SPACE_PATH];
   const executionContext =
-    parameters?.[
-      DATA_SPACE_QUERY_CREATOR_ROUTE_PATTERN_TOKEN.EXECUTION_CONTEXT
-    ];
+    parameters[DATA_SPACE_QUERY_CREATOR_ROUTE_PATTERN_TOKEN.EXECUTION_CONTEXT];
   const runtimePath =
     applicationStore.navigationService.navigator.getCurrentLocationParameterValue(
       DATA_SPACE_QUERY_CREATOR_QUERY_PARAM_TOKEN.RUNTIME_PATH,

package/src/components/data-space/DataSpaceQuerySetup.tsx

@@ -82,7 +82,7 @@ const DataSpaceQuerySetupSetupPanelContent = observer(
             </label>
             <CustomSelectorInput
               inputId="query-builder__setup__data-space-selector"
-              ref={dataSpaceSearchRef}
+              inputRef={dataSpaceSearchRef}
               className="panel__content__form__section__dropdown query-builder__setup__config-group__item__selector"
               options={dataSpaceOptions}
               isLoading={queryBuilderState.loadDataSpacesState.isInProgress}

package/src/components/data-space/DataSpaceTemplateQueryCreator.tsx

@@ -28,6 +28,7 @@ import {
   type DataSpaceTemplateQueryCreatorPathParams,
 } from '../../__lib__/DSL_DataSpace_LegendQueryNavigation.js';
 import { QueryEditor } from '../QueryEditor.js';
+import { guaranteeNonNullable } from '@finos/legend-shared';
 
 const DataSpaceTemplateQueryCreatorStoreProvider: React.FC<{
   children: React.ReactNode;
@@ -59,16 +60,19 @@ const DataSpaceTemplateQueryCreatorStoreProvider: React.FC<{
 
 export const DataSpaceTemplateQueryCreator = observer(() => {
   const parameters = useParams<DataSpaceTemplateQueryCreatorPathParams>();
-  const gav =
-    parameters[DATA_SPACE_TEMPLATE_QUERY_CREATOR_ROUTE_PATTERN_TOKEN.GAV];
-  const dataSpacePath =
+  const gav = guaranteeNonNullable(
+    parameters[DATA_SPACE_TEMPLATE_QUERY_CREATOR_ROUTE_PATTERN_TOKEN.GAV],
+  );
+  const dataSpacePath = guaranteeNonNullable(
     parameters[
       DATA_SPACE_TEMPLATE_QUERY_CREATOR_ROUTE_PATTERN_TOKEN.DATA_SPACE_PATH
-    ];
-  const templateQueryId =
+    ],
+  );
+  const templateQueryId = guaranteeNonNullable(
     parameters[
       DATA_SPACE_TEMPLATE_QUERY_CREATOR_ROUTE_PATTERN_TOKEN.TEMPLATE_QUERY_ID
-    ];
+    ],
+  );
 
   return (
     <DataSpaceTemplateQueryCreatorStoreProvider