@finos/legend-application-marketplace 0.2.26 → 0.2.28

package/src/stores/LegendMarketplaceBaseStore.ts

@@ -211,6 +211,7 @@ export class LegendMarketplaceBaseStore {
     );
     this.engineServerClient = this.remoteEngine.getEngineServerClient();
     this.engineServerClient.setTracerService(applicationStore.tracerService);
+    this.engineServerClient.setZipkinUrl(applicationStore.config.zipkinUrl);
 
     // User search
     if (this.pluginManager.getUserPlugins().length > 0) {

package/src/stores/ai/LegendMarketplaceAIChatStore.ts

@@ -25,7 +25,6 @@ import {
 import {
   type GeneratorFn,
   type PlainObject,
-  ActionState,
   assertErrorThrown,
   guaranteeNonNullable,
 } from '@finos/legend-shared';
@@ -196,8 +195,6 @@ export class LegendMarketplaceAIChatStore {
   }[] = [];
   selectedDataProductId: string | undefined = undefined;
 
-  readonly searchState = ActionState.create();
-
   constructor(baseStore: LegendMarketplaceBaseStore) {
     makeObservable(this, {
       stage: observable,
@@ -751,6 +748,7 @@ export class LegendMarketplaceAIChatStore {
     this.messages = [...this.messages, ...createMessagePair(trimmed)];
 
     const setMessages = this.createMessageSetter();
+    const startTime = Date.now();
 
     try {
       if (this.selectedProductCoordinates) {
@@ -823,7 +821,7 @@ export class LegendMarketplaceAIChatStore {
       finishWithThinkingError(
         setMessages,
         error.message,
-        Date.now(),
+        startTime,
         classifyError(error),
       );
       this.stage = MarketplaceAIChatStage.IDLE;
@@ -1046,6 +1044,7 @@ export class LegendMarketplaceAIChatStore {
     this.messages = [...this.messages, ...createMessagePair(trimmed)];
 
     const setMessages = this.createMessageSetter();
+    const startTime = Date.now();
 
     try {
       this.stage = MarketplaceAIChatStage.QUERYING;
@@ -1060,7 +1059,7 @@ export class LegendMarketplaceAIChatStore {
       finishWithThinkingError(
         setMessages,
         error.message,
-        Date.now(),
+        startTime,
         classifyError(error),
       );
     } finally {
@@ -1453,7 +1452,8 @@ export class LegendMarketplaceAIChatStore {
         ? this.buildContextPromise(question, metadata, setMessages)
         : Promise.resolve();
 
-    const fastIntent = classifyQuestionIntentFast(question, true);
+    const entityNames = [metadata.name, ...services.map((s) => s.title)];
+    const fastIntent = classifyQuestionIntentFast(question, true, entityNames);
 
     // ── Pure METADATA: fast classifier is confident, no data signals ──
     if (
@@ -1783,6 +1783,7 @@ export class LegendMarketplaceAIChatStore {
     if (!prompt) {
       return undefined;
     }
+    const correctionStart = Date.now();
     try {
       const raw = await plugin.callLLM(prompt, config);
       const trimmed = cleanLlmSqlResponse(raw);
@@ -1797,7 +1798,7 @@ export class LegendMarketplaceAIChatStore {
         config,
       );
       if (retryResult.rows.length > 0) {
-        const sqlGenTime = elapsedSeconds(Date.now(), 2);
+        const sqlGenTime = elapsedSeconds(correctionStart, 2);
         completeThinkingSteps(setMessages);
         updateLastAssistant(setMessages, () => ({
           sql: trimmed,
@@ -1806,8 +1807,12 @@ export class LegendMarketplaceAIChatStore {
         }));
         return { sql: trimmed, result: retryResult };
       }
-    } catch {
-      /* empty */
+    } catch (correctionError) {
+      assertErrorThrown(correctionError);
+      addThinkingStep(
+        setMessages,
+        `Filter correction failed: ${correctionError.message.slice(0, 120)}`,
+      );
     }
     return undefined;
   }

package/src/stores/lakehouse/LegendMarketplaceProductViewerStore.ts

@@ -62,6 +62,7 @@ import {
 import { buildGraphForDataProduct } from '../../utils/LakehouseUtils.js';
 import {
   type Entity,
+  type ProjectGAVCoordinates,
   type StoredFileGeneration,
   parseGAVCoordinates,
   parseProjectIdentifier,
@@ -70,6 +71,7 @@ import { deserialize } from 'serializr';
 import {
   EXTERNAL_APPLICATION_NAVIGATION__generateDataProductModelQueryUrl,
   EXTERNAL_APPLICATION_NAVIGATION__generateDataProductSampleQueryUrl,
+  EXTERNAL_APPLICATION_NAVIGATION__generateIngestQueryUrl,
   EXTERNAL_APPLICATION_NAVIGATION__generateDataSpaceQueryEditorUrl,
   EXTERNAL_APPLICATION_NAVIGATION__generateStudioSDLCProjectViewUrl,
   generateLakehouseDataProductPath,
@@ -423,6 +425,25 @@ export class LegendMarketplaceProductViewerStore {
                 );
               }
             : undefined,
+          openIngestQuery: projectGAV
+            ? (
+                gav: ProjectGAVCoordinates,
+                ingestDefinitionPath: string,
+                dataSet: string,
+              ): void => {
+                this.marketplaceBaseStore.applicationStore.navigationService.navigator.visitAddress(
+                  EXTERNAL_APPLICATION_NAVIGATION__generateIngestQueryUrl(
+                    this.marketplaceBaseStore.applicationStore.config
+                      .queryApplicationUrl,
+                    gav.groupId,
+                    gav.artifactId,
+                    gav.versionId,
+                    ingestDefinitionPath,
+                    dataSet,
+                  ),
+                );
+              }
+            : undefined,
         },
         this.marketplaceBaseStore.registryServerClient,
       );
@@ -662,6 +683,23 @@ export class LegendMarketplaceProductViewerStore {
                     ),
                   );
                 },
+                openIngestQuery: (
+                  _gav: ProjectGAVCoordinates,
+                  ingestDefinitionPath: string,
+                  dataSet: string,
+                ): void => {
+                  this.marketplaceBaseStore.applicationStore.navigationService.navigator.visitAddress(
+                    EXTERNAL_APPLICATION_NAVIGATION__generateIngestQueryUrl(
+                      this.marketplaceBaseStore.applicationStore.config
+                        .queryApplicationUrl,
+                      _gav.groupId,
+                      _gav.artifactId,
+                      _gav.versionId,
+                      ingestDefinitionPath,
+                      dataSet,
+                    ),
+                  );
+                },
               },
               this.marketplaceBaseStore.registryServerClient,
             );