@fincity/kirun-js 3.2.0 → 3.2.2

package/.claude/settings.local.json

@@ -0,0 +1,8 @@
+{
+  "permissions": {
+    "allow": [
+      "Bash(npm test:*)",
+      "Bash(mvn test:*)"
+    ]
+  }
+}

package/__tests__/engine/runtime/expression/ExpressionEvaluationTest.ts

@@ -596,6 +596,58 @@ test('ternary expression with displayValue equality check', () => {
     expect(ev.evaluate(MapUtil.of(ttv.getPrefix(), ttv))).toBe('11');
 });
 
+class StoreTokenValueExtractor extends TokenValueExtractor {
+    private store: any;
+
+    constructor(store: any) {
+        super();
+        this.store = store;
+    }
+
+    protected getValueInternal(token: string): any {
+        return this.retrieveElementFrom(token, token.split('.'), 1, this.store);
+    }
+    public getPrefix(): string {
+        return 'Store.';
+    }
+    public getStore(): any {
+        return this.store;
+    }
+}
+
+test('String vs Number equality with nested expression substitution', () => {
+    // Setup store with string "413" and number 413
+    let stv = new StoreTokenValueExtractor({ strNumber: '413', number: 413 });
+    let valuesMap: Map<string, TokenValueExtractor> = MapUtil.of(stv.getPrefix(), stv);
+
+    // Direct comparison: Store.strNumber = Store.number should return false
+    // because "413" (string) != 413 (number) - different types
+    let ev = new ExpressionEvaluator('Store.strNumber = Store.number');
+    expect(ev.evaluate(valuesMap)).toBe(false);
+
+    // Nested expression substitution: {{Store.strNumber}} = Store.number should return true
+    // because {{Store.strNumber}} is replaced with "413" making the expression "413 = Store.number"
+    // which evaluates to 413 = 413 (both numbers) and returns true
+    ev = new ExpressionEvaluator('{{Store.strNumber}} = Store.number');
+    expect(ev.evaluate(valuesMap)).toBe(true);
+
+    // Additional test: verify the string value directly
+    ev = new ExpressionEvaluator('Store.strNumber');
+    expect(ev.evaluate(valuesMap)).toBe('413');
+
+    // Additional test: verify the number value directly
+    ev = new ExpressionEvaluator('Store.number');
+    expect(ev.evaluate(valuesMap)).toBe(413);
+
+    // Additional test: string to string comparison should return true
+    ev = new ExpressionEvaluator("Store.strNumber = '413'");
+    expect(ev.evaluate(valuesMap)).toBe(true);
+
+    // Additional test: number to number comparison should return true
+    ev = new ExpressionEvaluator('Store.number = 413');
+    expect(ev.evaluate(valuesMap)).toBe(true);
+});
+
 test('unary minus operator', () => {
     // Simple negative number
     let ev = new ExpressionEvaluator('-5');

package/__tests__/engine/runtime/expression/ExpressionParsingTest.ts

@@ -602,7 +602,7 @@ describe('Original Expression Parsing Tests', () => {
         expect(ev.evaluate(valuesMapWithValue)).toBe('Application : My Application Title');
 
         // Store with value null - should return location.expression
-        
+        // Note: expression value includes quotes so it becomes a valid string literal when substituted
         const storeValueNull = new TestTokenValueExtractor('Store.', {
             urlDetails: { pageName: 'home' },
             pageDefinition: {
@@ -611,7 +611,7 @@ describe('Original Expression Parsing Tests', () => {
                         title: {
                             name: {
                                 value: null,
-                                location: { expression: 'Expression Fallback Title' },
+                                location: { expression: "'Expression Fallback Title'" },
                             },
                         },
                     },
@@ -632,7 +632,7 @@ describe('Original Expression Parsing Tests', () => {
                     properties: {
                         title: {
                             name: {
-                                location: { expression: 'Expression Fallback Title' },
+                                location: { expression: "'Expression Fallback Title'" },
                             },
                         },
                     },

package/__tests__/engine/runtime/expression/tokenextractor/ObjectValueSetterExtractorTest.ts

@@ -55,3 +55,31 @@ test('ObjectValueSetterExtractor Test', async () => {
     extractor.setValue('Store.plain', 'plainString', false, false);
     expect(extractor.getValue('Store.plain')).toStrictEqual('plainString');
 });
+
+test('ObjectValueSetterExtractor - set empty object then set nested property with numeric key', async () => {
+    let store = {};
+
+    let extractor: ObjectValueSetterExtractor = new ObjectValueSetterExtractor(store, 'Store');
+
+    extractor.setValue('Store.x', {});
+    expect(extractor.getValue('Store.x')).toMatchObject({});
+
+    extractor.setValue('Store.x.1', 'kiran');
+    expect(extractor.getValue('Store.x.1')).toBe('kiran');
+    expect(extractor.getValue('Store.x')).toMatchObject({ '1': 'kiran' });
+});
+
+test('ObjectValueSetterExtractor - set empty array then set element with numeric index', async () => {
+    let store = {};
+
+    let extractor: ObjectValueSetterExtractor = new ObjectValueSetterExtractor(store, 'Store');
+
+    extractor.setValue('Store.arr', []);
+    expect(extractor.getValue('Store.arr')).toMatchObject([]);
+
+    extractor.setValue('Store.arr.1', 'value');
+    expect(extractor.getValue('Store.arr.1')).toBe('value');
+    const arr = extractor.getValue('Store.arr');
+    expect(arr.length).toBe(2);
+    expect(arr[1]).toBe('value');
+});