@financial-times/o-autocomplete 1.9.1 → 1.9.2

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## [1.9.2](https://github.com/Financial-Times/origami/compare/o-autocomplete-v1.9.1...o-autocomplete-v1.9.2) (2024-04-12)
+
+
+### Bug Fixes
+
+* Update financial-times/accessible-autocomplete ([#1524](https://github.com/Financial-Times/origami/issues/1524)) ([8bcd024](https://github.com/Financial-Times/origami/commit/8bcd02402f3fa50e35756d3eb2a22b10435d634b))
+
 ## [1.9.1](https://github.com/Financial-Times/origami/compare/o-autocomplete-v1.9.0...o-autocomplete-v1.9.1) (2023-10-27)
 
 

package/README.md

@@ -98,7 +98,7 @@ Or pass an element to initialise a specific `o-autocomplete` instance:
 
 ```js
 import oAutocomplete from 'o-autocomplete';
-const oAutocompleteElement = document.getElementById('#my-o-autocomplete-element');
+const oAutocompleteElement = document.getElementById('my-o-autocomplete-element');
 new oAutocomplete(oAutocompleteElement);
 ```
 ### dynamic suggestions function
@@ -123,7 +123,7 @@ async function customSuggestions(query, populateOptions) {
 	populateOptions(suggestions);
 }
 
-const oAutocompleteElement = document.getElementById('#my-o-autocomplete-element');
+const oAutocompleteElement = document.getElementById('my-o-autocomplete-element');
 new oAutocomplete(oAutocompleteElement, {
     source: customSuggestions
 });
@@ -176,7 +176,7 @@ function mapOptionToSuggestedValue(option) {
 	return option.suggestionText;
 }
 
-const oAutocompleteElement = document.getElementById('#my-o-autocomplete-element');
+const oAutocompleteElement = document.getElementById('my-o-autocomplete-element');
 new oAutocomplete(oAutocompleteElement, {
     mapOptionToSuggestedValue,
     source: customSuggestions,
@@ -221,7 +221,7 @@ function onConfirm(option) {
     console.log('You selected option: ', option);
 }
 
-const oAutocompleteElement = document.getElementById('#my-o-autocomplete-element');
+const oAutocompleteElement = document.getElementById('my-o-autocomplete-element');
 new oAutocomplete(oAutocompleteElement, {
     onConfirm
     mapOptionToSuggestedValue,
@@ -260,7 +260,7 @@ function suggestionTemplate(option) {
 	`;
 }
 
-const oAutocompleteElement = document.getElementById('#my-o-autocomplete-element');
+const oAutocompleteElement = document.getElementById('my-o-autocomplete-element');
 new oAutocomplete(oAutocompleteElement, {
     suggestionTemplate,
     source: customSuggestions,
@@ -305,7 +305,7 @@ function onConfirm(option) {
     console.log('You selected option: ', option);
 }
 
-const oAutocompleteElement = document.getElementById('#my-o-autocomplete-element');
+const oAutocompleteElement = document.getElementById('my-o-autocomplete-element');
 new oAutocomplete(oAutocompleteElement, {
     onConfirm
     mapOptionToSuggestedValue,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@financial-times/o-autocomplete",
-  "version": "1.9.1",
+  "version": "1.9.2",
   "description": "An origami component for autocomplete inputs",
   "keywords": [
     "autocomplete",
@@ -47,7 +47,7 @@
     "@financial-times/o-utils": "^2.1.0"
   },
   "dependencies": {
-    "@financial-times/accessible-autocomplete": "^2.1.2"
+    "@financial-times/accessible-autocomplete": "^3.0.0"
   },
   "private": false
 }

package/src/js/autocomplete.js

@@ -1,10 +1,12 @@
 // We use our own fork of accessible-autocomplete because the main package is not being actively maintained and has bugs which we needed to fix
 // There is a changelog for the fixes we've added -- https://github.com/Financial-Times/accessible-autocomplete/blob/master/CHANGELOG.md#210---2021-05-24
 // Below are the pull-requests to accessible-autocomplete which would fix the bugs:
-// https://github.com/alphagov/accessible-autocomplete/pull/497
 // https://github.com/alphagov/accessible-autocomplete/pull/491
-// https://github.com/alphagov/accessible-autocomplete/pull/496
 // If the above pull-requests are merged and published, then we can stop using our fork
+// though switching to alphagov/accessible-autocomplete will require that consumers
+// applying `aria-labelledby` to the `ul` element
+// via the `ariaLabelledBy` option (https://github.com/Financial-Times/accessible-autocomplete/pull/6)
+// instead do so via the `menuAttributes` option (https://github.com/alphagov/accessible-autocomplete/pull/591)
 import accessibleAutocomplete from '@financial-times/accessible-autocomplete';
 
 /**