@financial-times/n-conversion-forms 43.0.2 → 44.0.0

package/.toolkitstate/ci.json

@@ -1,7 +1,7 @@
 {
   "branch": "",
   "repo": "n-conversion-forms",
-  "version": "43bf193e6c5bb6ea45b708559bbbb5f8c4a72d5f",
-  "tag": "v43.0.2",
-  "buildNumber": "16560"
+  "version": "b7c24384296a50d4148dd0954b3f2f84bfd72e46",
+  "tag": "v44.0.0",
+  "buildNumber": "16605"
 }

package/components/payment-term.jsx

@@ -14,8 +14,6 @@ export function PaymentTerm({
 	optionsInARow = false,
 	billingCountry = '',
 	isTermedSubscriptionTermType = false,
-	isTrialOfferAsNonTrialOverride = false,
-	labelOverride = '', // this is a temporary hack for the February 2024 campaign
 }) {
 	/**
 	 * Compute monthly price for given term name
@@ -271,16 +269,6 @@ export function PaymentTerm({
 			const showTrialCopyInTitle =
 				option.isTrial && !isPrintOrBundle && !isDigitalEdition;
 
-			// https://financialtimes.atlassian.net/browse/ACQ-2592
-			// We need to have one specific trial offer to have terms displayed as non-trial.
-			// The offer is a trial offer and should use trial mechanics but should show as non-trial.
-			// There is nothing in the offer payload to identify when this should happen, we need to rely on the offer id.
-			// This is a TEMPORARY hack and will be removed once the campaign is over.
-			// A ticket as been raised already to deal with the clean up: https://financialtimes.atlassian.net/browse/ACQ-2593.
-			if (isTrialOfferAsNonTrialOverride && labelOverride) {
-				return labelOverride;
-			}
-
 			const title =
 				option.name && nameMap[option.name] ? nameMap[option.name].title : '';
 
@@ -427,5 +415,4 @@ PaymentTerm.propTypes = {
 	largePrice: PropTypes.bool,
 	optionsInARow: PropTypes.bool,
 	billingCountry: PropTypes.string,
-	isTrialOfferAsNonTrialOverride: PropTypes.bool,
 };

package/components/payment-term.spec.js

@@ -194,7 +194,7 @@ describe('PaymentTerm', () => {
 				);
 			});
 		});
-		describe('getDisplayName trial', () => {
+		describe('getDisplayName', () => {
 			const trialOptions = {
 				...baseOptions,
 				isTrial: true,
@@ -206,19 +206,6 @@ describe('PaymentTerm', () => {
 					/^Trial: Premium Digital - Monthly .*$/
 				);
 			});
-			it('handles trial to non-trial payment term display name', () => {
-				const options = [trialOptions];
-				const wrapper = shallow(
-					<PaymentTerm
-						options={options}
-						labelOverride={'some term label'}
-						isTrialOfferAsNonTrialOverride={true}
-					/>
-				);
-				expect(wrapper.find('.ncf__payment-term__label').text()).toMatch(
-					/^some term label.*$/
-				);
-			});
 			it('renders using displayName if available', () => {
 				const options = [
 					{

package/components/payment-term.stories.js

@@ -144,38 +144,3 @@ RenewOffers.args = {
 	],
 	optionsInARow: true,
 };
-
-// https://financialtimes.atlassian.net/browse/ACQ-2592
-// We need to have one specific trial offer to have terms displayed as non-trial.
-// The offer is a trial offer and should use trial mechanics but should show as non-trial.
-// There is nothing in the offer payload to identify when this should happen, we need to rely on the offer id.
-// This is a TEMPORARY hack and will be removed once the campaign is over.
-// A ticket as been raised already to deal with the clean up: https://financialtimes.atlassian.net/browse/ACQ-2593.
-export const PaymentTermLabelOverride = (args) => (
-	<div className="ncf">
-		<Fieldset>
-			<PaymentTerm {...args} />
-		</Fieldset>
-	</div>
-);
-
-PaymentTermLabelOverride.args = {
-	isTrialOfferAsNonTrialOverride: true,
-	labelOverride: 'some fancy payment term',
-	options: [
-		{
-			name: '6 monthly',
-			isTrial: false,
-			discount: '',
-			selected: false,
-			price: '$229.00',
-			trialPrice: '$0.00',
-			trialDuration: '',
-			monthlyPrice: '0',
-			amount: '229.00',
-			trialAmount: null,
-			value: 'P6M',
-			currency: 'USD',
-		},
-	],
-};

package/dist/payment-term.jsx

@@ -32,11 +32,7 @@ function PaymentTerm(_ref) {
     _ref$billingCountry = _ref.billingCountry,
     billingCountry = _ref$billingCountry === void 0 ? '' : _ref$billingCountry,
     _ref$isTermedSubscrip = _ref.isTermedSubscriptionTermType,
-    isTermedSubscriptionTermType = _ref$isTermedSubscrip === void 0 ? false : _ref$isTermedSubscrip,
-    _ref$isTrialOfferAsNo = _ref.isTrialOfferAsNonTrialOverride,
-    isTrialOfferAsNonTrialOverride = _ref$isTrialOfferAsNo === void 0 ? false : _ref$isTrialOfferAsNo,
-    _ref$labelOverride = _ref.labelOverride,
-    labelOverride = _ref$labelOverride === void 0 ? '' : _ref$labelOverride;
+    isTermedSubscriptionTermType = _ref$isTermedSubscrip === void 0 ? false : _ref$isTermedSubscrip;
   /**
    * Compute monthly price for given term name
    * @param {number} amount price in number format
@@ -214,16 +210,6 @@ function PaymentTerm(_ref) {
     };
     var getTermDisplayName = function getTermDisplayName() {
       var showTrialCopyInTitle = option.isTrial && !isPrintOrBundle && !isDigitalEdition;
-
-      // https://financialtimes.atlassian.net/browse/ACQ-2592
-      // We need to have one specific trial offer to have terms displayed as non-trial.
-      // The offer is a trial offer and should use trial mechanics but should show as non-trial.
-      // There is nothing in the offer payload to identify when this should happen, we need to rely on the offer id.
-      // This is a TEMPORARY hack and will be removed once the campaign is over.
-      // A ticket as been raised already to deal with the clean up: https://financialtimes.atlassian.net/browse/ACQ-2593.
-      if (isTrialOfferAsNonTrialOverride && labelOverride) {
-        return labelOverride;
-      }
       var title = option.name && nameMap[option.name] ? nameMap[option.name].title : '';
       var termDisplayName = '';
       if (showTrialCopyInTitle) {
@@ -315,6 +301,5 @@ PaymentTerm.propTypes = {
   showLegal: _propTypes["default"].bool,
   largePrice: _propTypes["default"].bool,
   optionsInARow: _propTypes["default"].bool,
-  billingCountry: _propTypes["default"].string,
-  isTrialOfferAsNonTrialOverride: _propTypes["default"].bool
+  billingCountry: _propTypes["default"].string
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@financial-times/n-conversion-forms",
-  "version": "43.0.2",
+  "version": "44.0.0",
   "description": "Containing jsx components and styles for forms included on Accounts and Acquisition apps (next-signup, next-profile, next-retention, etc).",
   "main": "./dist/index.js",
   "scripts": {