@financial-times/n-conversion-forms 28.8.0 → 28.9.0

package/components/payment-term.jsx

@@ -406,6 +406,7 @@ PaymentTerm.propTypes = {
 			subTitle: PropTypes.string,
 			bestOffer: PropTypes.bool,
 			chargeOnText: PropTypes.string,
+			fulfilmentOption: PropTypes.string,
 		})
 	),
 	isFixedTermOffer: PropTypes.bool,

package/dist/payment-term.js

@@ -288,7 +288,8 @@ PaymentTerm.propTypes = {
     title: _propTypes["default"].string,
     subTitle: _propTypes["default"].string,
     bestOffer: _propTypes["default"].bool,
-    chargeOnText: _propTypes["default"].string
+    chargeOnText: _propTypes["default"].string,
+    fulfilmentOption: _propTypes["default"].string
   })),
   isFixedTermOffer: _propTypes["default"].bool,
   offerDisplayName: _propTypes["default"].string,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@financial-times/n-conversion-forms",
-  "version": "28.8.0",
+  "version": "28.9.0",
   "description": "Containing jsx components and styles for forms included on Accounts and Acqusition apps (next-signup, next-profile, next-retention, etc).",
   "main": "dist/index.js",
   "scripts": {

package/utils/payment-term.js

@@ -104,8 +104,9 @@ class PaymentTerm {
 	}
 
 	/**
-	 * Update the payment term options
-	 * @param {Array} options Array of objects contain terms information
+	 * Updates the payment term options.
+	 * @param {Object} options - indexed Object about Array of objects containing terms information. E.g.: { P1Y: {...}, P3M: {...}}
+	 * @throws Will throw an error if a payment term update is not found for a given value.
 	 */
 	updateOptions(options) {
 		const terms = this.$paymentTerm.querySelectorAll(ITEM_CLASS);
@@ -115,7 +116,7 @@ class PaymentTerm {
 			const price = term.querySelector(PRICE_CLASS);
 			const trialPrice = term.querySelector(TRIAL_PRICE_CLASS);
 			const monthlyPrice = term.querySelector(MONTHLY_PRICE_CLASS);
-			const update = options.find((option) => option.value === value);
+			const update = options[value];
 
 			if (!update) {
 				throw new Error(`Payment term update not found for "${value}"`);

package/utils/payment-term.spec.js

@@ -94,7 +94,7 @@ describe('PaymentTerm', () => {
 
 			it('throws an error if not all terms have an update', () => {
 				expect(() => {
-					paymentTerm.updateOptions([]);
+					paymentTerm.updateOptions({});
 				}).toThrow();
 			});
 
@@ -105,12 +105,12 @@ describe('PaymentTerm', () => {
 						? priceStub
 						: elementStub;
 				});
-				paymentTerm.updateOptions([
-					{
+				paymentTerm.updateOptions({
+					test: {
 						value: 'test',
 						price: '£1.01',
 					},
-				]);
+				});
 				expect(priceStub.innerHTML).toEqual('£1.01');
 			});
 
@@ -121,12 +121,12 @@ describe('PaymentTerm', () => {
 						? trialPriceStub
 						: elementStub;
 				});
-				paymentTerm.updateOptions([
-					{
+				paymentTerm.updateOptions({
+					test: {
 						value: 'test',
 						trialPrice: '£1.01',
 					},
-				]);
+				});
 				expect(trialPriceStub.innerHTML).toEqual('£1.01');
 			});
 
@@ -137,31 +137,31 @@ describe('PaymentTerm', () => {
 						? monthlyPriceStub
 						: elementStub;
 				});
-				paymentTerm.updateOptions([
-					{
+				paymentTerm.updateOptions({
+					test: {
 						value: 'test',
 						monthlyPrice: '£1.01',
 					},
-				]);
+				});
 				expect(monthlyPriceStub.innerHTML).toEqual('£1.01');
 			});
 
 			describe('updating base amount', () => {
-				const updatedOptions = [
-					{
+				const updatedOptions = {
+					test: {
 						value: 'test',
 						monthlyPrice: '£1.01',
 						amount: 500,
 						trialAmount: 1,
 					},
-				];
+				};
 
 				beforeEach(() => {
 					elementStub.querySelector.mockReturnValue(elementStub);
 				});
 
 				it('replaces the base amount with the correct updated trial amount', () => {
-					updatedOptions[0].isTrial = true;
+					updatedOptions.test.isTrial = true;
 					paymentTerm.updateOptions(updatedOptions);
 					expect(elementStub.setAttribute).toHaveBeenCalledWith(
 						'data-base-amount',
@@ -170,7 +170,7 @@ describe('PaymentTerm', () => {
 				});
 
 				it('replaces the base amount with the correct updated amount', () => {
-					updatedOptions[0].isTrial = false;
+					updatedOptions.test.isTrial = false;
 					paymentTerm.updateOptions(updatedOptions);
 					expect(elementStub.setAttribute).toHaveBeenCalledWith(
 						'data-base-amount',