@financial-times/dotcom-server-handlebars 9.0.0-beta.9 → 9.0.2

package/package.json

@@ -1,9 +1,9 @@
 {
   "name": "@financial-times/dotcom-server-handlebars",
-  "version": "9.0.0-beta.9",
+  "version": "9.0.2",
   "description": "",
   "main": "dist/node/index.js",
-  "types": "src/index.ts",
+  "types": "dist/node/index.d.ts",
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1",
     "clean": "npm run clean:dist && npm run clean:node_modules",
@@ -22,9 +22,7 @@
     "dateformat": "^3.0.3",
     "glob": "^7.1.3",
     "handlebars": "^4.3.1",
-    "mixin-deep": "^2.0.0",
-    "react": "^16.12.0",
-    "react-dom": "^16.12.0"
+    "mixin-deep": "^2.0.0"
   },
   "engines": {
     "node": "16.x || 18.x",
@@ -45,5 +43,9 @@
   },
   "devDependencies": {
     "check-engine": "^1.10.1"
+  },
+  "peerDependencies": {
+    "react": "17.x || 18.x",
+    "react-dom": "17.x || 18.x"
   }
 }

package/src/__test__/HandlebarsRenderer.spec.ts

@@ -80,20 +80,21 @@ describe('dotcom-server-handlebars/src/PageKitHandlebars', () => {
   })
 
   describe('.renderView()', () => {
-    it('can render a template and fire a callback with the result', () => {
-      return new Promise((done) => {
-        const templateContext = { title: 'Hello World', aside: 'Lorem ipsum' }
+    it('can render a template and fire a callback with the result', async () => {
+      const spy = jest.fn()
+      const templateContext = { title: 'Hello World', aside: 'Lorem ipsum' }
+      await instance.renderView(view, templateContext, spy)
 
-        instance.renderView(view, templateContext, (error, result) => {
-          expect(error).toBeNull()
+      const callbackParameters = spy.mock.calls[0]
+      const [callbackError, callbackSuccess] = callbackParameters
 
-          expect(result).toContain('<h1>Hello World</h1>')
-          expect(result).toContain('<aside>Lorem ipsum</aside>')
-          expect(result).toMatch(/<main>.+<\/main>/s)
+      expect(spy).toHaveBeenCalledTimes(1)
 
-          done()
-        })
-      })
+      expect(callbackError).toBeNull()
+
+      expect(callbackSuccess).toContain('<h1>Hello World</h1>')
+      expect(callbackSuccess).toContain('<aside>Lorem ipsum</aside>')
+      expect(callbackSuccess).toContain('<main>')
     })
   })
 })

package/src/helpers/renderReactComponent.ts

@@ -30,5 +30,6 @@ export default function renderReactComponent({ hash }) {
 
   const props = { ...this, ...hash }
 
+  // @ts-ignore
   return ReactDOMServer.renderToStaticMarkup(React.createElement(Component, props))
 }

package/src/helpers/slice.ts

@@ -10,6 +10,10 @@ export default function slice(...args) {
   const offset = parseInt(options.hash.offset, 10) || 0
   const limit = parseInt(options.hash.limit, 10) || 1
 
+  if (!args[0]) {
+    return ''
+  }
+
   const slicedItems = Array.from(args[0]).slice(offset, offset + limit)
 
   let contents = ''