@financial-times/dotcom-server-handlebars 8.2.1 → 8.2.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@financial-times/dotcom-server-handlebars",
-  "version": "8.2.1",
+  "version": "8.2.3",
   "description": "",
   "main": "dist/node/index.js",
   "types": "src/index.ts",

package/src/__test__/HandlebarsRenderer.spec.ts

@@ -80,20 +80,21 @@ describe('dotcom-server-handlebars/src/PageKitHandlebars', () => {
   })
 
   describe('.renderView()', () => {
-    it('can render a template and fire a callback with the result', () => {
-      return new Promise((done) => {
-        const templateContext = { title: 'Hello World', aside: 'Lorem ipsum' }
+    it('can render a template and fire a callback with the result', async () => {
+      const spy = jest.fn()
+      const templateContext = { title: 'Hello World', aside: 'Lorem ipsum' }
+      await instance.renderView(view, templateContext, spy)
 
-        instance.renderView(view, templateContext, (error, result) => {
-          expect(error).toBeNull()
+      const callbackParameters = spy.mock.calls[0]
+      const [callbackError, callbackSuccess] = callbackParameters
 
-          expect(result).toContain('<h1>Hello World</h1>')
-          expect(result).toContain('<aside>Lorem ipsum</aside>')
-          expect(result).toMatch(/<main>.+<\/main>/s)
+      expect(spy).toHaveBeenCalledTimes(1)
 
-          done()
-        })
-      })
+      expect(callbackError).toBeNull()
+
+      expect(callbackSuccess).toContain('<h1>Hello World</h1>')
+      expect(callbackSuccess).toContain('<aside>Lorem ipsum</aside>')
+      expect(callbackSuccess).toContain('<main>')
     })
   })
 })

package/src/helpers/renderReactComponent.ts

@@ -30,5 +30,6 @@ export default function renderReactComponent({ hash }) {
 
   const props = { ...this, ...hash }
 
+  // @ts-ignore
   return ReactDOMServer.renderToStaticMarkup(React.createElement(Component, props))
 }